fix(browser): Update build-artifacts tests to match actual env.ts implementation

The tests were expecting import.meta.env code that was intentionally removed
from the source to avoid CJS syntax errors. Updated tests to verify:
- Neither CJS nor ESM builds contain import.meta.env in code
- Both builds use process.env for env var access
- Both builds use globalThis for bundler-injected values

Author: BYK

packages/browser/test/build-artifacts.test.ts

@@ -2,9 +2,9 @@
  * Tests to verify build artifacts are correctly formatted for their module type.
  *
  * These tests verify that:
- * - CJS builds don't contain import.meta (would cause syntax errors)
- * - ESM builds DO contain import.meta.env checks
- * - Empty strings are filtered by resolveSpotlightOptions
+ * - Both CJS and ESM builds contain the getEnvValue function
+ * - Both builds use process.env for environment variable access
+ * - Neither build contains import.meta (we intentionally don't use it to avoid CJS errors)
  */
 
 import * as fs from 'fs';
@@ -14,7 +14,7 @@ import { describe, expect, it } from 'vitest';
 const REPO_ROOT = path.resolve(__dirname, '../../..');
 const BROWSER_BUILD = path.join(REPO_ROOT, 'packages/browser/build/npm');
 
-describe('Build Artifacts - CJS vs ESM', () => {
+describe('Build Artifacts - env.ts', () => {
   describe('CJS builds', () => {
     it('env.js CJS build does NOT contain import.meta syntax', () => {
       const cjsDevPath = path.join(BROWSER_BUILD, 'cjs/dev/utils/env.js');
@@ -59,44 +59,45 @@ describe('Build Artifacts - CJS vs ESM', () => {
   });
 
   describe('ESM builds', () => {
-    it('env.js ESM build DOES contain import.meta.env check', () => {
+    it('env.js ESM build also does NOT contain import.meta syntax', () => {
+      // We intentionally don't use import.meta.env because it would require
+      // a rollup plugin to strip it from CJS builds, and we want consistent
+      // behavior across both module formats.
       const esmDevPath = path.join(BROWSER_BUILD, 'esm/dev/utils/env.js');
       const esmProdPath = path.join(BROWSER_BUILD, 'esm/prod/utils/env.js');
 
       if (fs.existsSync(esmDevPath)) {
         const content = fs.readFileSync(esmDevPath, 'utf-8');
 
-        // SHOULD contain import.meta checks
-        expect(content).toContain('import.meta');
-        expect(content).toContain('import.meta.env');
+        // Filter out comments
+        const lines = content
+          .split('\n')
+          .filter(line => !line.trim().startsWith('//') && !line.trim().startsWith('*'));
+        const codeOnly = lines.join('\n');
+
+        // Should NOT contain import.meta in actual code
+        expect(codeOnly).not.toContain('import.meta.env');
       }
 
       if (fs.existsSync(esmProdPath)) {
         const content = fs.readFileSync(esmProdPath, 'utf-8');
 
-        expect(content).toContain('import.meta');
-        expect(content).toContain('import.meta.env');
-      }
-    });
-
-    it('env.js ESM build contains rollup markers for ESM-only code', () => {
-      const esmDevPath = path.join(BROWSER_BUILD, 'esm/dev/utils/env.js');
-
-      if (fs.existsSync(esmDevPath)) {
-        const content = fs.readFileSync(esmDevPath, 'utf-8');
+        const lines = content
+          .split('\n')
+          .filter(line => !line.trim().startsWith('//') && !line.trim().startsWith('*'));
+        const codeOnly = lines.join('\n');
 
-        // SHOULD contain the rollup markers (they're kept in output as comments)
-        expect(content).toContain('rollup-esm-only');
+        expect(codeOnly).not.toContain('import.meta.env');
       }
     });
 
-    it('env.js ESM build contains process.env check as well', () => {
+    it('env.js ESM build contains process.env check', () => {
       const esmDevPath = path.join(BROWSER_BUILD, 'esm/dev/utils/env.js');
 
       if (fs.existsSync(esmDevPath)) {
         const content = fs.readFileSync(esmDevPath, 'utf-8');
 
-        // SHOULD contain process.env check too (for compatibility)
+        // SHOULD contain process.env check
         expect(content).toContain('process.env');
       }
     });
@@ -117,5 +118,20 @@ describe('Build Artifacts - CJS vs ESM', () => {
         expect(content).toContain('getEnvValue');
       }
     });
+
+    it('contain globalThis check for bundler-injected values', () => {
+      const cjsPath = path.join(BROWSER_BUILD, 'cjs/dev/utils/env.js');
+      const esmPath = path.join(BROWSER_BUILD, 'esm/dev/utils/env.js');
+
+      if (fs.existsSync(cjsPath)) {
+        const content = fs.readFileSync(cjsPath, 'utf-8');
+        expect(content).toContain('globalThis');
+      }
+
+      if (fs.existsSync(esmPath)) {
+        const content = fs.readFileSync(esmPath, 'utf-8');
+        expect(content).toContain('globalThis');
+      }
+    });
   });
 });