Skip to content

Commit bf9efbb

Browse files
committed
fixup! chore(node-core): Add nodeVersion.js in sideEffect array
1 parent 88545dd commit bf9efbb

9 files changed

Lines changed: 18 additions & 20 deletions

File tree

packages/node-core/package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,5 @@
138138
"volta": {
139139
"extends": "../../package.json"
140140
},
141-
"sideEffects": [
142-
"**/nodeVersion.js"
143-
]
141+
"sideEffects": false
144142
}

packages/node-core/src/common-exports.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export { getSentryRelease, defaultStackParser } from './sdk/api';
3434
export { createGetModuleFromFilename } from './utils/module';
3535
export { addOriginToSpan } from './utils/addOriginToSpan';
3636
export { initializeEsmLoader } from './sdk/esmLoader';
37-
export { isCjs } from './utils/detection';
37+
export { isCjs } from './utils/isCjs';
3838
export { createMissingInstrumentationContext } from './utils/createMissingInstrumentationContext';
3939
export { makeNodeTransport, type NodeTransportOptions } from './transports';
4040
export type { HTTPModuleRequestIncomingMessage } from './transports/http-module';

packages/node-core/src/integrations/modules.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { existsSync, readFileSync } from 'node:fs';
22
import { dirname, join } from 'node:path';
33
import { GLOBAL_OBJ, type IntegrationFn } from '@sentry/core';
4-
import { isCjs } from '../utils/detection';
4+
import { isCjs } from '../utils/isCjs';
55

66
type ModuleInfo = Record<string, string>;
77

packages/node-core/src/light/sdk.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ import { systemErrorIntegration } from '../integrations/systemError';
2828
import { defaultStackParser, getSentryRelease } from '../sdk/api';
2929
import { makeNodeTransport } from '../transports';
3030
import type { NodeClientOptions, NodeOptions } from '../types';
31-
import { isCjs } from '../utils/detection';
31+
import { isCjs } from '../utils/isCjs';
3232
import { getSpotlightConfig } from '../utils/spotlight';
3333
import { setAsyncLocalStorageAsyncContextStrategy } from './asyncLocalStorageStrategy';
3434
import { LightNodeClient } from './client';

packages/node-core/src/sdk/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ import { consoleIntegration } from '../integrations/console';
3737
import { systemErrorIntegration } from '../integrations/systemError';
3838
import { makeNodeTransport } from '../transports';
3939
import type { NodeClientOptions, NodeOptions } from '../types';
40-
import { isCjs } from '../utils/detection';
40+
import { isCjs } from '../utils/isCjs';
4141
import { getSpotlightConfig } from '../utils/spotlight';
4242
import { defaultStackParser, getSentryRelease } from './api';
4343
import { NodeClient } from './client';

packages/node-core/src/utils/createMissingInstrumentationContext.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import type { MissingInstrumentationContext } from '@sentry/core';
2-
import { isCjs } from './detection';
2+
import { isCjs } from './isCjs';
33

44
export const createMissingInstrumentationContext = (pkg: string): MissingInstrumentationContext => ({
55
package: pkg,

packages/node-core/src/utils/detection.ts

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,6 @@
11
import { consoleSandbox } from '@sentry/core';
22
import { NODE_MAJOR, NODE_MINOR } from '../nodeVersion';
3-
4-
/** Detect CommonJS. */
5-
export function isCjs(): boolean {
6-
/*! rollup-include-cjs-only */
7-
return true;
8-
/*! rollup-include-cjs-only-end */
9-
10-
/*! rollup-include-esm-only */
11-
return false;
12-
/*! rollup-include-esm-only-end */
13-
}
3+
import { isCjs } from './isCjs';
144

155
let hasWarnedAboutNodeVersion: boolean | undefined;
166

packages/node-core/src/utils/ensureIsWrapped.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010
} from '@sentry/core';
1111
import type { NodeClient } from '../sdk/client';
1212
import { createMissingInstrumentationContext } from './createMissingInstrumentationContext';
13-
import { isCjs } from './detection';
13+
import { isCjs } from './isCjs';
1414

1515
/**
1616
* Checks and warns if a framework isn't wrapped by opentelemetry.
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
/** Detect CommonJS. */
2+
export function isCjs(): boolean {
3+
/*! rollup-include-cjs-only */
4+
return true;
5+
/*! rollup-include-cjs-only-end */
6+
7+
/*! rollup-include-esm-only */
8+
return false;
9+
/*! rollup-include-esm-only-end */
10+
}

0 commit comments

Comments
 (0)