Skip to content

Commit c448386

Browse files
committed
Revert
1 parent 805f8dc commit c448386

File tree

3 files changed

+12
-27
lines changed

3 files changed

+12
-27
lines changed

packages/core/src/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ export { addAutoIpAddressToSession } from './utils/ipAddress';
7474
export { addAutoIpAddressToUser } from './utils/ipAddress';
7575
export {
7676
convertSpanLinksForEnvelope,
77-
spanToTraceparentHeader,
7877
spanToTraceHeader,
7978
spanToJSON,
8079
spanIsSampled,
@@ -90,7 +89,7 @@ export {
9089
export { _setSpanForScope as _INTERNAL_setSpanForScope } from './utils/spanOnScope';
9190
export { parseSampleRate } from './utils/parseSampleRate';
9291
export { applySdkMetadata } from './utils/sdkMetadata';
93-
export { getTraceData, scopeToTraceparentHeader } from './utils/traceData';
92+
export { getTraceData } from './utils/traceData';
9493
export { getTraceMetaTags } from './utils/meta';
9594
export { debounce } from './utils/debounce';
9695
export {
@@ -270,6 +269,7 @@ export {
270269
generateSentryTraceHeader,
271270
propagationContextFromHeaders,
272271
shouldContinueTrace,
272+
generateTraceparentHeader,
273273
} from './utils/tracing';
274274
export { getSDKSource, isBrowserBundle } from './utils/env';
275275
export type { SdkSource } from './utils/env';

packages/core/src/utils/traceData.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,7 @@ function scopeToTraceHeader(scope: Scope): string {
7272
return generateSentryTraceHeader(traceId, propagationSpanId, sampled);
7373
}
7474

75-
/**
76-
* Get a traceparent header value for the given scope.
77-
*/
78-
export function scopeToTraceparentHeader(scope: Scope): string {
75+
function scopeToTraceparentHeader(scope: Scope): string {
7976
const { traceId, sampled, propagationSpanId } = scope.getPropagationContext();
8077
return generateTraceparentHeader(traceId, propagationSpanId, sampled);
8178
}

packages/opentelemetry/src/utils/getTraceData.ts

Lines changed: 9 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -3,36 +3,28 @@ import type { Client, Scope, SerializedTraceData, Span } from '@sentry/core';
33
import {
44
dynamicSamplingContextToSentryBaggageHeader,
55
generateSentryTraceHeader,
6+
generateTraceparentHeader,
67
getCapturedScopesOnSpan,
7-
scopeToTraceparentHeader,
8-
spanToTraceparentHeader,
98
} from '@sentry/core';
109
import { getInjectionData } from '../propagator';
11-
import { getContextFromScope, getScopesFromContext } from './contextData';
10+
import { getContextFromScope } from './contextData';
1211

1312
/**
1413
* Otel-specific implementation of `getTraceData`.
1514
* @see `@sentry/core` version of `getTraceData` for more information
1615
*/
17-
export function getTraceData(options: { span?: Span; scope?: Scope; client?: Client; propagateTraceparent?: boolean } = {}): SerializedTraceData {
18-
const { client, propagateTraceparent } = options;
19-
let { span, scope } = options;
20-
16+
export function getTraceData({
17+
span,
18+
scope,
19+
client,
20+
propagateTraceparent,
21+
}: { span?: Span; scope?: Scope; client?: Client; propagateTraceparent?: boolean } = {}): SerializedTraceData {
2122
let ctx = (scope && getContextFromScope(scope)) ?? api.context.active();
2223

2324
if (span) {
2425
const { scope } = getCapturedScopesOnSpan(span);
2526
// fall back to current context if for whatever reason we can't find the one of the span
2627
ctx = (scope && getContextFromScope(scope)) || api.trace.setSpan(api.context.active(), span);
27-
} else {
28-
span = api.trace.getSpan(ctx);
29-
}
30-
31-
if (!scope) {
32-
const scopes = getScopesFromContext(ctx);
33-
if (scopes) {
34-
scope = scopes.scope;
35-
}
3628
}
3729

3830
const { traceId, spanId, sampled, dynamicSamplingContext } = getInjectionData(ctx, { scope, client });
@@ -43,11 +35,7 @@ export function getTraceData(options: { span?: Span; scope?: Scope; client?: Cli
4335
};
4436

4537
if (propagateTraceparent) {
46-
if (span) {
47-
traceData.traceparent = spanToTraceparentHeader(span);
48-
} else if (scope) {
49-
traceData.traceparent = scopeToTraceparentHeader(scope);
50-
}
38+
traceData.traceparent = generateTraceparentHeader(traceId, spanId, sampled);
5139
}
5240

5341
return traceData;

0 commit comments

Comments
 (0)