fix: Dont filter captured messages when they have no stacktraces (#1549)

Author: kamilogorek

packages/browser/src/integrations/inboundfilters.ts

@@ -83,7 +83,7 @@ export class InboundFilters implements Integration {
       return false;
     }
     const url = this.getEventFilterUrl(event);
-    return this.blacklistUrls.some(pattern => this.isMatchingPattern(url, pattern));
+    return !url ? false : this.blacklistUrls.some(pattern => this.isMatchingPattern(url, pattern));
   }
 
   /** JSDoc */
@@ -93,7 +93,7 @@ export class InboundFilters implements Integration {
       return true;
     }
     const url = this.getEventFilterUrl(event);
-    return this.whitelistUrls.some(pattern => this.isMatchingPattern(url, pattern));
+    return !url ? true : this.whitelistUrls.some(pattern => this.isMatchingPattern(url, pattern));
   }
 
   /** JSDoc */
@@ -140,7 +140,7 @@ export class InboundFilters implements Integration {
   }
 
   /** JSDoc */
-  private getEventFilterUrl(event: SentryEvent): string {
+  private getEventFilterUrl(event: SentryEvent): string | null {
     const evt = event as any;
 
     try {
@@ -149,11 +149,11 @@ export class InboundFilters implements Integration {
       } else if (evt.exception) {
         return evt.exception.values[0].stacktrace.frames[0].filename;
       } else {
-        return '';
+        return null;
       }
     } catch (oO) {
       logger.error(`Cannot extract url for event ${getEventDescription(event)}`);
-      return '';
+      return null;
     }
   }
 }

packages/browser/test/integrations/inboundfilters.test.ts

@@ -160,6 +160,7 @@ describe('InboundFilters', () => {
 
   describe('blacklistUrls/whitelistUrls', () => {
     const messageEvent = {
+      message: 'wat',
       stacktrace: {
         frames: [
           {
@@ -195,6 +196,23 @@ describe('InboundFilters', () => {
       expect(inboundFilters.isWhitelistedUrl(messageEvent)).equal(true);
     });
 
+    it('should not filter captured messages with no stacktraces', () => {
+      inboundFilters.install({
+        blacklistUrls: ['https://awesome-analytics.io'],
+        whitelistUrls: ['https://awesome-analytics.io'],
+      });
+      expect(
+        inboundFilters.isBlacklistedUrl({
+          message: 'any',
+        }),
+      ).equal(false);
+      expect(
+        inboundFilters.isWhitelistedUrl({
+          message: 'any',
+        }),
+      ).equal(true);
+    });
+
     it('should filter captured exception based on its stack trace using string filter', () => {
       inboundFilters.install({
         blacklistUrls: ['https://awesome-analytics.io'],
@@ -231,7 +249,7 @@ describe('InboundFilters', () => {
       expect(inboundFilters.isWhitelistedUrl(exceptionEvent)).equal(true);
     });
 
-    it('should not fail with malformed event event and default to false', () => {
+    it('should not fail with malformed event event and default to false for isBlacklistedUrl and true for isWhitelistedUrl', () => {
       const malformedEvent = {
         stacktrace: {
           frames: undefined,
@@ -242,7 +260,7 @@ describe('InboundFilters', () => {
         whitelistUrls: ['https://awesome-analytics.io'],
       });
       expect(inboundFilters.isBlacklistedUrl(malformedEvent)).equal(false);
-      expect(inboundFilters.isWhitelistedUrl(malformedEvent)).equal(false);
+      expect(inboundFilters.isWhitelistedUrl(malformedEvent)).equal(true);
     });
   });
 });