Skip to content

Commit f16915a

Browse files
committed
fix(e2e): use vite dev server for realistic Spotlight testing
Switch from vite build+preview to vite dev server because: - Spotlight is designed for development mode - Dev server automatically uses 'development' exports from SDK - More realistic test of how users would use Spotlight Changes: - test:build now only runs install (no build needed for dev server) - playwright starts 'pnpm dev' instead of 'pnpm preview' - Removed resolve.conditions hack (dev server handles this)
1 parent 90eca4e commit f16915a

File tree

3 files changed

+4
-9
lines changed

3 files changed

+4
-9
lines changed

dev-packages/e2e-tests/test-applications/browser-webworker-vite/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@
44
"version": "0.0.0",
55
"type": "module",
66
"scripts": {
7-
"dev": "vite",
7+
"dev": "vite --port 3030",
88
"build": "rm -rf dist && tsc && vite build",
99
"preview": "vite preview --port 3030",
1010
"test": "playwright test",
11-
"test:build": "pnpm install && pnpm build",
11+
"test:build": "pnpm install",
1212
"test:assert": "pnpm test"
1313
},
1414
"devDependencies": {

dev-packages/e2e-tests/test-applications/browser-webworker-vite/playwright.config.mjs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
import { getPlaywrightConfig } from '@sentry-internal/test-utils';
22

33
const config = getPlaywrightConfig({
4-
startCommand: `pnpm preview`,
4+
// Use vite dev server to test development-mode behavior (e.g., Spotlight auto-enablement)
5+
startCommand: `pnpm dev`,
56
eventProxyFile: 'start-event-proxy.mjs',
67
eventProxyPort: 3031,
78
port: 3030,

dev-packages/e2e-tests/test-applications/browser-webworker-vite/vite.config.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,6 @@ export default defineConfig({
1313
},
1414
},
1515

16-
// Use development exports from @sentry/* packages to include Spotlight auto-enablement code
17-
// The SDK has conditional exports: "development" includes Spotlight, "production" strips it
18-
resolve: {
19-
conditions: ['development', 'module', 'browser', 'import'],
20-
},
21-
2216
plugins: [
2317
sentryVitePlugin({
2418
org: process.env.E2E_TEST_SENTRY_ORG_SLUG,

0 commit comments

Comments
 (0)