fix(integrations): asyncio: continuation trace transactions #6634
constantiniustest-integrations-tasks.yml
on: pull_request
Matrix: Tasks
All Tasks tests passed
3s
Annotations
1 error and 30 warnings
|
Hardcoded transaction name 'downstream' loses coroutine-specific tracing context:
sentry_sdk/integrations/asyncio.py#L77
The new code uses a hardcoded `name="downstream"` instead of `name=get_name(coro)` which previously captured the actual coroutine function name (e.g., 'foo', 'bar'). This eliminates meaningful trace identification - all async tasks will now appear as 'downstream' rather than their actual function names, making debugging and performance analysis significantly harder.
|
|
Origin attribute not set on new transactions, breaking trace origin tracking:
sentry_sdk/integrations/asyncio.py#L76
The original code set `origin=AsyncioIntegration.origin` (which equals 'auto.function.asyncio') on spans. The new transaction creation doesn't pass an origin, so it will default to 'manual'. This breaks the test at test_asyncio.py:395 which expects `event["spans"][0]["origin"] == "auto.function.asyncio"` and loses the ability to identify spans created by the asyncio integration.
|
|
Changed conditional skips span creation when task_spans=True but no active span exists:
sentry_sdk/integrations/asyncio.py#L75
The condition changed from `if task_spans` to `if task_spans and in_span`. This means when `task_spans=True` but there's no current active span (`in_span=False`), no transaction/span will be created at all. Previously, a span would still be created in this case. This is a behavioral change that could result in missing traces for orphaned async tasks.
|
|
Tasks (3.11, ubuntu-22.04)
❌ Patch coverage check failed: 0.00% < target 80%
|
|
Tasks (3.6, ubuntu-22.04)
❌ Patch coverage check failed: 0.00% < target 80%
|
|
Tasks (3.6, ubuntu-22.04)
Failed to upload coverage artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Tasks (3.6, ubuntu-22.04)
Failed to upload test artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Tasks (3.8, ubuntu-22.04)
❌ Patch coverage check failed: 0.00% < target 80%
|
|
Tasks (3.8, ubuntu-22.04)
Failed to upload coverage artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Tasks (3.8, ubuntu-22.04)
Failed to upload test artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Tasks (3.7, ubuntu-22.04)
❌ Patch coverage check failed: 0.00% < target 80%
|
|
Tasks (3.7, ubuntu-22.04)
Failed to upload coverage artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Tasks (3.7, ubuntu-22.04)
Failed to upload test artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Tasks (3.9, ubuntu-22.04)
❌ Patch coverage check failed: 0.00% < target 80%
|
|
Tasks (3.9, ubuntu-22.04)
Failed to upload coverage artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Tasks (3.9, ubuntu-22.04)
Failed to upload test artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Tasks (3.14t, ubuntu-22.04)
❌ Patch coverage check failed: 0.00% < target 80%
|
|
Tasks (3.14t, ubuntu-22.04)
Failed to upload coverage artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Tasks (3.14t, ubuntu-22.04)
Failed to upload test artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Tasks (3.14, ubuntu-22.04)
❌ Patch coverage check failed: 0.00% < target 80%
|
|
Tasks (3.14, ubuntu-22.04)
Failed to upload coverage artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Tasks (3.14, ubuntu-22.04)
Failed to upload test artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Tasks (3.10, ubuntu-22.04)
❌ Patch coverage check failed: 0.00% < target 80%
|
|
Tasks (3.10, ubuntu-22.04)
Failed to upload coverage artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Tasks (3.10, ubuntu-22.04)
Failed to upload test artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Tasks (3.12, ubuntu-22.04)
❌ Patch coverage check failed: 0.00% < target 80%
|
|
Tasks (3.12, ubuntu-22.04)
Failed to upload coverage artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Tasks (3.12, ubuntu-22.04)
Failed to upload test artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Tasks (3.13, ubuntu-22.04)
❌ Patch coverage check failed: 0.00% < target 80%
|
|
Tasks (3.13, ubuntu-22.04)
Failed to upload coverage artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
|
Tasks (3.13, ubuntu-22.04)
Failed to upload test artifact: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
codecov-coverage-results-constantinius-fix-asyncio-transaction-as-continuation-trace-test-tasks
|
105 KB |
sha256:1b5061bd8b5b10a1645b22d2c4b530f131b095e5e6c20cfa113412352f05dcc1
|
|
|
codecov-test-results-constantinius-fix-asyncio-transaction-as-continuation-trace-test-tasks
|
231 Bytes |
sha256:8dc38a22edc3bf37fd8ebf510832f9c16639ea5d39d9f93eb66216cb50a3aadb
|
|