tests: add test for wsgi middleware handling in flask

Author: untitaker

sentry_sdk/integrations/flask.py

@@ -29,14 +29,14 @@ def install(self, client):
         appcontext_tearing_down.connect(_pop_appctx)
         got_request_exception.connect(_capture_exception)
 
-        old_app = Flask.wsgi_app
+        old_app = Flask.__call__
 
         def sentry_patched_wsgi_app(self, environ, start_response):
             return run_wsgi_app(
                 lambda *a, **kw: old_app(self, *a, **kw), environ, start_response
             )
 
-        Flask.wsgi_app = sentry_patched_wsgi_app
+        Flask.__call__ = sentry_patched_wsgi_app
 
 
 def _push_appctx(*args, **kwargs):

tests/integrations/flask/test_flask.py

@@ -321,7 +321,8 @@ def index():
     assert event["level"] == "error"
 
 
-def test_no_errors_without_request(app):
+def test_no_errors_without_request(app, sentry_init):
+    sentry_init(integrations=[flask_sentry.FlaskIntegration()])
     with app.app_context():
         capture_exception(ValueError())
 
@@ -340,3 +341,23 @@ def foo():
         app.cli.main(
             args=["foo"], prog_name="myapp", obj=ScriptInfo(create_app=lambda _: app)
         )
+
+
+def test_wsgi_level_error_is_caught(app, capture_exceptions, sentry_init):
+    sentry_init(integrations=[flask_sentry.FlaskIntegration()])
+
+    def wsgi_app(environ, start_response):
+        1 / 0
+
+    app.wsgi_app = wsgi_app
+
+    client = app.test_client()
+
+    exceptions = capture_exceptions()
+
+    with pytest.raises(ZeroDivisionError) as exc:
+        client.get("/")
+
+    error, = exceptions
+
+    assert error is exc.value