feat(profiling): Enable profiling on all transactions (#1797)

Up to now, we've only been profiling WSGI + ASGI transactions. This change will enable profiling for all transactions.

Author: Zylphrex

sentry_sdk/hub.py

@@ -8,6 +8,7 @@
 from sentry_sdk.consts import INSTRUMENTER
 from sentry_sdk.scope import Scope
 from sentry_sdk.client import Client
+from sentry_sdk.profiler import Profile
 from sentry_sdk.tracing import NoOpSpan, Span, Transaction
 from sentry_sdk.session import Session
 from sentry_sdk.utils import (
@@ -548,6 +549,9 @@ def start_transaction(
         sampling_context.update(custom_sampling_context)
         transaction._set_initial_sampling_decision(sampling_context=sampling_context)
 
+        profile = Profile(transaction, hub=self)
+        profile._set_initial_sampling_decision(sampling_context=sampling_context)
+
         # we don't bother to keep spans if we already know we're not going to
         # send the transaction
         if transaction.sampled:

sentry_sdk/integrations/asgi.py

@@ -14,7 +14,6 @@
 from sentry_sdk.hub import Hub, _should_send_default_pii
 from sentry_sdk.integrations._wsgi_common import _filter_headers
 from sentry_sdk.integrations.modules import _get_installed_modules
-from sentry_sdk.profiler import start_profiling
 from sentry_sdk.sessions import auto_session_tracking
 from sentry_sdk.tracing import (
     SOURCE_FOR_STYLE,
@@ -176,7 +175,7 @@ async def _run_app(self, scope, callback):
 
                     with hub.start_transaction(
                         transaction, custom_sampling_context={"asgi_scope": scope}
-                    ), start_profiling(transaction, hub):
+                    ):
                         # XXX: Would be cool to have correct span status, but we
                         # would have to wrap send(). That is a bit hard to do with
                         # the current abstraction over ASGI 2/3.

sentry_sdk/integrations/django/asgi.py

@@ -7,7 +7,6 @@
 """
 
 import asyncio
-import threading
 
 from sentry_sdk import Hub, _functools
 from sentry_sdk._types import MYPY
@@ -92,7 +91,7 @@ async def sentry_wrapped_callback(request, *args, **kwargs):
 
         with hub.configure_scope() as sentry_scope:
             if sentry_scope.profile is not None:
-                sentry_scope.profile.active_thread_id = threading.current_thread().ident
+                sentry_scope.profile.update_active_thread_id()
 
             with hub.start_span(
                 op=OP.VIEW_RENDER, description=request.resolver_match.view_name

sentry_sdk/integrations/django/views.py

@@ -1,5 +1,3 @@
-import threading
-
 from sentry_sdk.consts import OP
 from sentry_sdk.hub import Hub
 from sentry_sdk._types import MYPY
@@ -79,7 +77,7 @@ def sentry_wrapped_callback(request, *args, **kwargs):
             # set the active thread id to the handler thread for sync views
             # this isn't necessary for async views since that runs on main
             if sentry_scope.profile is not None:
-                sentry_scope.profile.active_thread_id = threading.current_thread().ident
+                sentry_scope.profile.update_active_thread_id()
 
             with hub.start_span(
                 op=OP.VIEW_RENDER, description=request.resolver_match.view_name

sentry_sdk/integrations/fastapi.py

@@ -1,5 +1,4 @@
 import asyncio
-import threading
 
 from sentry_sdk._types import MYPY
 from sentry_sdk.hub import Hub, _should_send_default_pii
@@ -78,9 +77,7 @@ def _sentry_call(*args, **kwargs):
                 hub = Hub.current
                 with hub.configure_scope() as sentry_scope:
                     if sentry_scope.profile is not None:
-                        sentry_scope.profile.active_thread_id = (
-                            threading.current_thread().ident
-                        )
+                        sentry_scope.profile.update_active_thread_id()
                     return old_call(*args, **kwargs)
 
             dependant.call = _sentry_call

sentry_sdk/integrations/starlette.py

@@ -2,7 +2,6 @@
 
 import asyncio
 import functools
-import threading
 
 from sentry_sdk._compat import iteritems
 from sentry_sdk._types import MYPY
@@ -413,9 +412,7 @@ def _sentry_sync_func(*args, **kwargs):
 
                 with hub.configure_scope() as sentry_scope:
                     if sentry_scope.profile is not None:
-                        sentry_scope.profile.active_thread_id = (
-                            threading.current_thread().ident
-                        )
+                        sentry_scope.profile.update_active_thread_id()
 
                     request = args[0]
 

sentry_sdk/integrations/wsgi.py

@@ -12,7 +12,6 @@
 from sentry_sdk.tracing import Transaction, TRANSACTION_SOURCE_ROUTE
 from sentry_sdk.sessions import auto_session_tracking
 from sentry_sdk.integrations._wsgi_common import _filter_headers
-from sentry_sdk.profiler import start_profiling
 
 from sentry_sdk._types import MYPY
 
@@ -132,7 +131,7 @@ def __call__(self, environ, start_response):
 
                     with hub.start_transaction(
                         transaction, custom_sampling_context={"wsgi_environ": environ}
-                    ), start_profiling(transaction, hub):
+                    ):
                         try:
                             rv = self.app(
                                 environ,