fix(django): Set transaction lazily in event processor

Fix crash when app returns a 404 response

See #19

Author: untitaker

sentry_sdk/integrations/django.py

@@ -8,7 +8,7 @@
 except ImportError:
     from django.core.urlresolvers import resolve
 
-from sentry_sdk import get_current_hub, configure_scope, capture_exception
+from sentry_sdk import get_current_hub, capture_exception
 from sentry_sdk.hub import _internal_exceptions, _should_send_default_pii
 from ._wsgi import RequestExtractor, get_client_ip
 from . import Integration
@@ -45,10 +45,10 @@ def sentry_patched_get_response(self, request):
                     lambda: make_event_processor(request)
                 )
 
-                with configure_scope() as scope:
-                    scope.transaction = resolve(request.path).func.__name__
-
-                return old_get_response(self, request)
+                try:
+                    return old_get_response(self, request)
+                except Exception:
+                    capture_exception()
 
         BaseHandler.get_response = sentry_patched_get_response
 
@@ -58,6 +58,10 @@ def _make_event_processor(self, request):
         client_options = get_current_hub().client.options
 
         def processor(event):
+            if "transaction" not in event:
+                with _internal_exceptions():
+                    event["transaction"] = resolve(request.path).func.__name__
+
             with _internal_exceptions():
                 DjangoRequestExtractor(request).extract_into_event(
                     event, client_options

tests/integrations/django/myapp/settings.py

@@ -56,13 +56,7 @@ def process_request(self, request):
         if "middleware-exc" in request.path:
             1 / 0
 
-        with sentry_sdk.configure_scope() as scope:
-            assert scope._data["transaction"] is not None
-
     def process_response(self, request, response):
-        with sentry_sdk.configure_scope() as scope:
-            assert scope._data["transaction"] is not None
-
         return response
 
 

tests/integrations/django/myapp/urls.py

@@ -23,9 +23,8 @@
 from . import views
 
 urlpatterns = [
-    path("self-check", views.self_check, name="self_check"),
     path("view-exc", views.view_exc, name="view_exc"),
-    path("middleware-exc", views.self_check, name="middleware_exc"),
+    path("middleware-exc", views.message, name="middleware_exc"),
     path("message", views.message, name="message"),
     path("mylogin", views.mylogin, name="mylogin"),
 ]

tests/integrations/django/myapp/views.py

@@ -5,12 +5,6 @@
 import sentry_sdk
 
 
-def self_check(request):
-    with sentry_sdk.configure_scope() as scope:
-        assert scope._data["transaction"] == "self_check"
-    return HttpResponse("ok")
-
-
 def view_exc(request):
     1 / 0
 

tests/integrations/django/test_basic.py

@@ -19,11 +19,6 @@ def client(monkeypatch_test_transport):
     return Client()
 
 
-def test_scope_working(client):
-    response = client.get(reverse("self_check"))
-    assert response.status_code == 200
-
-
 def test_view_exceptions(client, capture_exceptions):
     exceptions = capture_exceptions()
     with pytest.raises(ZeroDivisionError) as exc:
@@ -46,6 +41,7 @@ def test_request_captured(client, capture_events):
     assert response.content == b"ok"
 
     event, = events
+    assert event["transaction"] == "message"
     assert event["request"] == {
         "cookies": {},
         "env": {