Skip to content

Commit 4eaa6d1

Browse files
authored
stories: fix type loader signature and safety (#104307)
Fixes the type loader signature and uses optional chaining to avoid attempting to access documentation values when the type loader is not enabled.
1 parent a82d6c3 commit 4eaa6d1

File tree

18 files changed

+34
-35
lines changed

18 files changed

+34
-35
lines changed

static/app/components/charts/chartWidgetLoader.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {CodeBlock} from 'sentry/components/core/code';
55
import * as Storybook from 'sentry/stories';
66

77
export default Storybook.story('ChartWidgetLoader', (story, APIReference) => {
8-
APIReference(documentation.props.ChartWidgetLoader);
8+
APIReference(documentation.props?.ChartWidgetLoader);
99

1010
story('Getting Started', () => {
1111
return (

static/app/components/core/button/button.mdx

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,18 +37,18 @@ import ButtonDocumentation from '!!type-loader!@sentry/scraps/button';
3737

3838
export const documentation = {
3939
exports: {
40-
module: ButtonDocumentation.exports.module,
40+
module: ButtonDocumentation.exports?.module,
4141
exports: {
4242
// Button has some exports that we don't want to document, strip them out until they are removed
4343
...Object.fromEntries(
44-
Object.entries(ButtonDocumentation.exports.exports).filter(
44+
Object.entries(ButtonDocumentation?.exports?.exports ?? {}).filter(
4545
([key]) => key !== 'StyledButton' && key !== 'ButtonBar'
4646
)
4747
),
4848
},
4949
},
5050
props: {
51-
...ButtonDocumentation.props,
51+
...ButtonDocumentation?.props,
5252
},
5353
};
5454

@@ -63,19 +63,17 @@ To create a basic button, wrap text in a `<Button>` and pass an `onClick` callba
6363
Buttons come in a few different styles: `muted` (default), `primary`, `warning`, `danger`, `transparent` and `link`.
6464

6565
<Storybook.Demo>
66-
<Button priority="muted">Muted (default)</Button>
66+
<Button priority="default">Default (default)</Button>
6767
<Button priority="primary">Primary</Button>
68-
<Button priority="warning">Warning</Button>
6968
<Button priority="danger">Danger</Button>
7069
<Button priority="transparent">Transparent</Button>
7170
<div style={{alignSelf: 'center'}}>
7271
<Button priority="link">Link</Button>
7372
</div>
7473
</Storybook.Demo>
7574
```jsx
76-
<Button priority="muted">Muted (default)</Button>
75+
<Button priority="default">Default (default)</Button>
7776
<Button priority="primary">Primary</Button>
78-
<Button priority="warning">Warning</Button>
7977
<Button priority="danger">Danger</Button>
8078
<Button priority="transparent">Transparent</Button>
8179
<Button priority="link">Link</Button>

static/app/components/core/button/buttonBar.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {ButtonBar} from 'sentry/components/core/button/buttonBar';
66
import * as Storybook from 'sentry/stories';
77

88
export default Storybook.story('ButtonBar', (story, APIReference) => {
9-
APIReference(documentation.props.ButtonBar);
9+
APIReference(documentation.props?.ButtonBar);
1010

1111
story('Default', () => {
1212
const [active, setActive] = useState('One');

static/app/components/core/input/input.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import * as Storybook from 'sentry/stories';
88
import {space} from 'sentry/styles/space';
99

1010
export default Storybook.story('Input', (story, APIReference) => {
11-
APIReference(documentation.props.Input);
11+
APIReference(documentation.props?.Input);
1212

1313
story('Sizes', () => {
1414
return (

static/app/components/core/input/inputGroup.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {space} from 'sentry/styles/space';
1010
import {InputGroup} from './inputGroup';
1111

1212
export default Storybook.story('InputGroup', (story, APIReference) => {
13-
APIReference(documentation.props.InputGroup);
13+
APIReference(documentation.props?.InputGroup);
1414

1515
story('Default', () => {
1616
return (

static/app/components/core/input/numberDragInput.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {NumberDragInput} from 'sentry/components/core/input/numberDragInput';
66
import * as Storybook from 'sentry/stories';
77

88
export default Storybook.story('NumberDragInput', (story, APIReference) => {
9-
APIReference(documentation.props.NumberDragInput);
9+
APIReference(documentation.props?.NumberDragInput);
1010

1111
story('Default', () => {
1212
const [horizontalValue, setHorizontalValue] = useState(10);

static/app/components/core/input/numberInput.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import * as Storybook from 'sentry/stories';
66
import {NumberInput} from './numberInput';
77

88
export default Storybook.story('NumberInput', (story, APIReference) => {
9-
APIReference(documentation.props.NumberInput);
9+
APIReference(documentation.props?.NumberInput);
1010

1111
story('Default', () => {
1212
return (

static/app/components/core/menuListItem/menuListItem.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import * as Storybook from 'sentry/stories';
66
import {space} from 'sentry/styles/space';
77

88
export default Storybook.story('MenuListItem', (story, APIReference) => {
9-
APIReference(documentation.props.MenuListItem);
9+
APIReference(documentation.props?.MenuListItem);
1010

1111
story('focused', () => {
1212
return <SizeVariants isFocused />;

static/app/components/core/radio/radio.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import * as Storybook from 'sentry/stories';
77
import {space} from 'sentry/styles/space';
88

99
export default Storybook.story('Radio', (story, APIReference) => {
10-
APIReference(documentation.props.Radio);
10+
APIReference(documentation.props?.Radio);
1111

1212
story('Default', () => {
1313
return (

static/app/components/core/select/select.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {IconGraphBar} from 'sentry/icons/iconGraphBar';
66
import * as Storybook from 'sentry/stories';
77

88
export default Storybook.story('Select', (story, APIReference) => {
9-
APIReference(documentation.props.Select);
9+
APIReference(documentation.props?.Select);
1010

1111
story('Sizes', () => {
1212
return (

0 commit comments

Comments
 (0)