Skip to content

Commit 75edeed

Browse files
authored
chore(aci): set event_id when creating open period (#104558)
This is necessary to link open periods and events in the UI.
1 parent 0e97dc4 commit 75edeed

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

src/sentry/event_manager.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1600,7 +1600,7 @@ def _create_group(
16001600
logger.exception("Error after unsticking project counter")
16011601
raise
16021602

1603-
create_open_period(group=group, start_time=group.first_seen)
1603+
create_open_period(group=group, start_time=group.first_seen, event_id=event.event_id)
16041604

16051605
return group
16061606

@@ -1812,7 +1812,7 @@ def _handle_regression(group: Group, event: BaseEvent, release: Release | None)
18121812
kick_off_status_syncs.apply_async(
18131813
kwargs={"project_id": group.project_id, "group_id": group.id}
18141814
)
1815-
create_open_period(group, activity.datetime)
1815+
create_open_period(group, activity.datetime, event.event_id)
18161816

18171817
return is_regression
18181818

src/sentry/models/groupopenperiod.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ def get_open_periods_for_group(
184184
return group_open_periods[:limit]
185185

186186

187-
def create_open_period(group: Group, start_time: datetime) -> None:
187+
def create_open_period(group: Group, start_time: datetime, event_id: str | None = None) -> None:
188188
# no-op if the group does not create open periods
189189
if not should_create_open_periods(group.type):
190190
return None
@@ -209,6 +209,7 @@ def create_open_period(group: Group, start_time: datetime) -> None:
209209
date_started=start_time,
210210
date_ended=None,
211211
resolution_activity=None,
212+
event_id=event_id,
212213
)
213214

214215
# If we care about this group's activity, create activity entry

tests/sentry/event_manager/test_event_manager.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -441,9 +441,11 @@ def test_unresolves_group(
441441
open_period = open_periods[0]
442442
assert open_period.date_started == regression_activity.datetime
443443
assert open_period.date_ended is None
444+
assert open_period.event_id == event2.event_id
444445
open_period = open_periods[1]
445446
assert open_period.date_started == group.first_seen
446447
assert open_period.date_ended == resolved_at
448+
assert open_period.event_id == event.event_id
447449

448450
@mock.patch("sentry.signals.issue_unresolved.send_robust")
449451
def test_unresolves_group_without_open_period(self, send_robust: mock.MagicMock) -> None:
@@ -4088,7 +4090,7 @@ def test_removed_boost_not_added_again_if_limit_is_exceeded(self) -> None:
40884090
class TestSaveGroupHashAndGroup(TransactionTestCase):
40894091
def test_simple(self) -> None:
40904092
perf_data = load_data("transaction-n-plus-one", timestamp=before_now(minutes=10))
4091-
perf_data["event_id"] = str(uuid.uuid4())
4093+
perf_data["event_id"] = "a" * 32
40924094
event = _get_event_instance(perf_data, project_id=self.project.id)
40934095
group_hash = "some_group"
40944096
group, created, _ = save_grouphash_and_group(self.project, event, group_hash)

0 commit comments

Comments
 (0)