update naming

Author: nora-shap

src/sentry/seer/sentry_data_models.py

@@ -30,7 +30,7 @@ class TraceData(BaseModel):
     spans: list[Span]
 
 
-class EvidenceTraceData(BaseModel):
+class TraceMetadata(BaseModel):
     trace_id: str
     transaction_name: str
 

src/sentry/tasks/llm_issue_detection/detection.py

@@ -17,6 +17,7 @@
 from sentry.models.project import Project
 from sentry.net.http import connection_from_url
 from sentry.seer.models import SeerApiError
+from sentry.seer.sentry_data_models import TraceMetadata
 from sentry.seer.signed_seer_api import make_signed_seer_api_request
 from sentry.tasks.base import instrumented_task
 from sentry.tasks.llm_issue_detection.trace_data import (
@@ -58,6 +59,12 @@ class IssueDetectionResponse(BaseModel):
     issues: list[DetectedIssue]
 
 
+class IssueDetectionRequest(BaseModel):
+    traces: list[TraceMetadata]
+    organization_id: int
+    project_id: int
+
+
 class LLMIssueDetectionError(SeerApiError):
     def __init__(
         self,
@@ -233,11 +240,12 @@ def detect_llm_issues_for_project(project_id: int) -> None:
     # Shuffle to randomize order
     random.shuffle(evidence_traces)
 
-    seer_request = {
-        "telemetry": [{**trace.dict(), "kind": "trace"} for trace in evidence_traces],
-        "organization_id": organization_id,
-        "project_id": project_id,
-    }
+    seer_request = IssueDetectionRequest(
+        traces=evidence_traces,
+        organization_id=organization_id,
+        project_id=project_id,
+    )
+
     response = make_signed_seer_api_request(
         connection_pool=seer_issue_detection_connection_pool,
         path=SEER_ANALYZE_ISSUE_ENDPOINT_PATH,

src/sentry/tasks/llm_issue_detection/trace_data.py

@@ -9,7 +9,7 @@
 from sentry.search.eap.types import SearchResolverConfig
 from sentry.search.events.types import SnubaParams
 from sentry.seer.explorer.utils import normalize_description
-from sentry.seer.sentry_data_models import EvidenceTraceData
+from sentry.seer.sentry_data_models import TraceMetadata
 from sentry.snuba.referrer import Referrer
 from sentry.snuba.spans_rpc import Spans
 
@@ -23,7 +23,7 @@ def get_project_top_transaction_traces_for_llm_detection(
     project_id: int,
     limit: int,
     start_time_delta_minutes: int,
-) -> list[EvidenceTraceData]:
+) -> list[TraceMetadata]:
     """
     Get top transactions by total time spent, return one semi-randomly chosen trace per transaction.
     """
@@ -67,7 +67,7 @@ def _build_snuba_params(start: datetime) -> SnubaParams:
         sampling_mode="NORMAL",
     )
 
-    evidence_traces = []
+    trace_metadata = []
     seen_names = set()
 
     for row in transactions_result.get("data", []):
@@ -101,12 +101,12 @@ def _build_snuba_params(start: datetime) -> SnubaParams:
         if not trace_id:
             continue
 
-        evidence_traces.append(
-            EvidenceTraceData(
+        trace_metadata.append(
+            TraceMetadata(
                 trace_id=trace_id,
                 transaction_name=normalized_name,
             )
         )
         seen_names.add(normalized_name)
 
-    return evidence_traces
+    return trace_metadata

tests/sentry/tasks/test_llm_issue_detection.py

@@ -241,13 +241,11 @@ def test_detect_llm_issues_full_flow(
         request_body = json.loads(seer_call_kwargs["body"].decode("utf-8"))
         assert request_body["project_id"] == self.project.id
         assert request_body["organization_id"] == self.project.organization_id
-        assert len(request_body["telemetry"]) == 2
-        assert request_body["telemetry"][0]["kind"] == "trace"
-        assert request_body["telemetry"][0]["trace_id"] == "trace_id_1"
-        assert request_body["telemetry"][0]["transaction_name"] == "POST /some/thing"
-        assert request_body["telemetry"][1]["kind"] == "trace"
-        assert request_body["telemetry"][1]["trace_id"] == "trace_id_2"
-        assert request_body["telemetry"][1]["transaction_name"] == "GET /another/"
+        assert len(request_body["traces"]) == 2
+        assert request_body["traces"][0]["trace_id"] == "trace_id_1"
+        assert request_body["traces"][0]["transaction_name"] == "POST /some/thing"
+        assert request_body["traces"][1]["trace_id"] == "trace_id_2"
+        assert request_body["traces"][1]["transaction_name"] == "GET /another/"
 
         assert mock_produce_occurrence.call_count == 2