Skip to content

Commit ccb61aa

Browse files
authored
Modified: Mapping of colours in theme.tsx (#104572)
## Problem I actually made a design fault when I assigned the same colours for chonk 400 colours as well as the regular 400 colours. The reason is that I forgot they are used for separate things. Chonk 400 colors are used for backgrounds, while regular 400's are used for graphical elements. The problem showed itself in Replay Details because they heavily depend on the 400 scale for their breadcrumb items. ## Solution I've modified the colour mapping in theme.tsx to make it look more appropriate. ### Light Before <img width="2880" height="1802" alt="CleanShot 2025-12-09 at 12 13 10@2x" src="https://github.com/user-attachments/assets/aae9cfe6-4a75-4b8c-9f61-ed89a5d899d7" /> <img width="2880" height="1803" alt="CleanShot 2025-12-09 at 12 20 51@2x" src="https://github.com/user-attachments/assets/3b8b1982-8e11-42a3-9539-ecad734914df" /> ### Light After <img width="2880" height="1801" alt="CleanShot 2025-12-09 at 12 12 54@2x" src="https://github.com/user-attachments/assets/53da997d-ee3f-42de-a6f4-d24cfe4cf85d" /> <img width="2880" height="1802" alt="CleanShot 2025-12-09 at 12 17 15@2x" src="https://github.com/user-attachments/assets/71e54f2f-1d88-41cc-a0ca-c7673f99cdea" /> ### Dark Before <img width="2880" height="1801" alt="CleanShot 2025-12-09 at 12 13 59@2x" src="https://github.com/user-attachments/assets/3e54517e-3a75-48a1-8afb-bf87987f8f6a" /> <img width="2880" height="1801" alt="CleanShot 2025-12-09 at 12 21 06@2x" src="https://github.com/user-attachments/assets/56539025-33c7-4997-930c-15227f317875" /> ### Dark After <img width="2880" height="1801" alt="CleanShot 2025-12-09 at 12 13 56@2x" src="https://github.com/user-attachments/assets/45db253a-4029-4107-b8e5-050a9ec0b0c2" /> <img width="2880" height="1801" alt="CleanShot 2025-12-09 at 12 17 37@2x" src="https://github.com/user-attachments/assets/d6a3009a-8b93-4a2c-ae2f-fd5eed7ce4cd" />
1 parent cd96185 commit ccb61aa

File tree

1 file changed

+66
-66
lines changed

1 file changed

+66
-66
lines changed

static/app/utils/theme/theme.tsx

Lines changed: 66 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -1197,49 +1197,49 @@ const lightColors = {
11971197
gray600: color.neutral.light.opaque1200, // ⚠ link.muted.hover only
11981198
gray500: color.neutral.light.opaque1100, // content.secondary, link.muted.default
11991199
gray400: color.neutral.light.opaque1000, // graphics.muted
1200-
gray300: color.neutral.light.transparent300,
1201-
gray200: color.neutral.light.transparent200,
1202-
gray100: color.neutral.light.transparent100,
1200+
gray300: color.neutral.light.transparent400,
1201+
gray200: color.neutral.light.transparent300,
1202+
gray100: color.neutral.light.transparent200,
12031203

1204-
blue700: color.blue.light.opaque1400, // ⚠ link.accent.active only
1205-
blue600: color.blue.light.opaque1300, // ⚠ link.accent.hover only
1206-
blue500: color.blue.light.opaque1200, // content.accent, link.accent.default
1204+
blue700: color.blue.light.opaque1300, // ⚠ link.accent.active only
1205+
blue600: color.blue.light.opaque1200, // ⚠ link.accent.hover only
1206+
blue500: color.blue.light.opaque1100, // content.accent, link.accent.default
12071207
blue400: color.blue.light.opaque1000, // graphics.muted, border.accent
1208-
blue300: color.blue.light.transparent300,
1209-
blue200: color.blue.light.transparent200,
1210-
blue100: color.blue.light.transparent100,
1208+
blue300: color.blue.light.transparent400,
1209+
blue200: color.blue.light.transparent300,
1210+
blue100: color.blue.light.transparent200,
12111211

12121212
pink700: color.pink.light.opaque1300, // ⚠ link.promotion.active only
12131213
pink600: color.pink.light.opaque1200, // ⚠ link.promotion.hover only
12141214
pink500: color.pink.light.opaque1100, // content.promotion, link.promotion.default
12151215
pink400: color.pink.light.opaque1000, // graphics.promotion, border.promotion
1216-
pink300: color.pink.light.transparent300,
1217-
pink200: color.pink.light.transparent200,
1218-
pink100: color.pink.light.transparent100,
1216+
pink300: color.pink.light.transparent400,
1217+
pink200: color.pink.light.transparent300,
1218+
pink100: color.pink.light.transparent200,
12191219

12201220
red700: color.red.light.opaque1300, // ⚠ link.danger.active only
12211221
red600: color.red.light.opaque1200, // ⚠ link.danger.hover only
12221222
red500: color.red.light.opaque1100, // ⚠ content.danger, link.danger.default
12231223
red400: color.red.light.opaque1000, // graphics.danger, border.danger
1224-
red300: color.red.light.transparent300,
1225-
red200: color.red.light.transparent200,
1226-
red100: color.red.light.transparent100,
1224+
red300: color.red.light.transparent400,
1225+
red200: color.red.light.transparent300,
1226+
red100: color.red.light.transparent200,
12271227

12281228
yellow700: color.yellow.light.opaque1300, // ⚠ link.warning.active only
12291229
yellow600: color.yellow.light.opaque1200, // ⚠ link.warning.hover only
12301230
yellow500: color.yellow.light.opaque1100, // content.warning, link.warning.default
1231-
yellow400: color.yellow.light.opaque600, // graphics.warning, border.warning
1232-
yellow300: color.yellow.light.transparent300,
1233-
yellow200: color.yellow.light.transparent200,
1234-
yellow100: color.yellow.light.transparent100,
1231+
yellow400: color.yellow.light.opaque800, // graphics.warning, border.warning
1232+
yellow300: color.yellow.light.transparent400,
1233+
yellow200: color.yellow.light.transparent300,
1234+
yellow100: color.yellow.light.transparent200,
12351235

12361236
green700: color.green.light.opaque1300, // ⚠ link.success.active only
12371237
green600: color.green.light.opaque1200, // ⚠ link.success.hover only
12381238
green500: color.green.light.opaque1100, // content.success, link.success.default
1239-
green400: color.green.light.opaque800, // graphics.success, border.success
1240-
green300: color.green.light.transparent300,
1241-
green200: color.green.light.transparent200,
1242-
green100: color.green.light.transparent100,
1239+
green400: color.green.light.opaque1000, // graphics.success, border.success
1240+
green300: color.green.light.transparent400,
1241+
green200: color.green.light.transparent300,
1242+
green100: color.green.light.transparent200,
12431243

12441244
// Currently used for avatars, badges, booleans, buttons, checkboxes, radio buttons
12451245
chonk: {
@@ -1261,54 +1261,54 @@ const darkColors: Colors = {
12611261
surface200: color.neutral.dark.opaque200, // border.muted
12621262
surface100: color.neutral.dark.opaque100, // border.primary
12631263

1264-
gray800: color.neutral.dark.opaque1600, // content.primary
1265-
gray700: color.neutral.dark.opaque1300, // ⚠ link.muted.active only
1266-
gray600: color.neutral.dark.opaque1200, // ⚠ link.muted.hover only
1267-
gray500: color.neutral.dark.opaque1100, // content.secondary, link.muted.default
1268-
gray400: color.neutral.dark.opaque900, // // graphics.muted
1269-
gray300: color.neutral.dark.transparent800,
1270-
gray200: color.neutral.dark.transparent600,
1271-
gray100: color.neutral.dark.transparent400,
1272-
1273-
blue700: color.blue.dark.opaque1200, // ⚠ link.accent.active only
1274-
blue600: color.blue.dark.opaque1100, // ⚠ link.accent.hover only
1275-
blue500: color.blue.dark.opaque1000, // content.accent, link.accent.default
1276-
blue400: color.blue.dark.opaque900, // // graphics.accent, border.accent
1277-
blue300: color.blue.dark.transparent300,
1278-
blue200: color.blue.dark.transparent200,
1279-
blue100: color.blue.dark.transparent100,
1280-
1281-
pink700: color.pink.dark.opaque1300, // ⚠ link.promotion.active only
1282-
pink600: color.pink.dark.opaque1200, // ⚠ link.promotion.hover only
1283-
pink500: color.pink.dark.opaque1100, // content.promotion, link.promotion.default
1284-
pink400: color.pink.dark.opaque1000, // // graphics.promotion, border.promotion
1285-
pink300: color.pink.dark.transparent300,
1286-
pink200: color.pink.dark.transparent200,
1287-
pink100: color.pink.dark.transparent100,
1288-
1289-
red700: color.red.dark.opaque1200, // ⚠ link.danger.active only
1290-
red600: color.red.dark.opaque1100, // ⚠ link.danger.hover only
1291-
red500: color.red.dark.opaque1000, // content.danger, link.danger.default
1292-
red400: color.red.dark.opaque900, // // graphics.danger, border.danger
1293-
red300: color.red.dark.transparent300,
1294-
red200: color.red.dark.transparent200,
1295-
red100: color.red.dark.transparent100,
1264+
gray800: color.neutral.dark.opaque1500, // content.primary
1265+
gray700: color.neutral.dark.opaque1400, // ⚠ link.muted.active only
1266+
gray600: color.neutral.dark.opaque1300, // ⚠ link.muted.hover only
1267+
gray500: color.neutral.dark.opaque1200, // content.secondary, link.muted.default
1268+
gray400: color.neutral.dark.opaque1100, // // graphics.muted
1269+
gray300: color.neutral.dark.transparent400,
1270+
gray200: color.neutral.dark.transparent300,
1271+
gray100: color.neutral.dark.transparent200,
1272+
1273+
blue700: color.blue.dark.opaque1400, // ⚠ link.accent.active only
1274+
blue600: color.blue.dark.opaque1300, // ⚠ link.accent.hover only
1275+
blue500: color.blue.dark.opaque1200, // content.accent, link.accent.default
1276+
blue400: color.blue.dark.opaque1100, // // graphics.accent, border.accent
1277+
blue300: color.blue.dark.transparent600,
1278+
blue200: color.blue.dark.transparent500,
1279+
blue100: color.blue.dark.transparent400,
1280+
1281+
pink700: color.pink.dark.opaque1400, // ⚠ link.promotion.active only
1282+
pink600: color.pink.dark.opaque1300, // ⚠ link.promotion.hover only
1283+
pink500: color.pink.dark.opaque1200, // content.promotion, link.promotion.default
1284+
pink400: color.pink.dark.opaque1100, // // graphics.promotion, border.promotion
1285+
pink300: color.pink.dark.transparent400,
1286+
pink200: color.pink.dark.transparent300,
1287+
pink100: color.pink.dark.transparent200,
1288+
1289+
red700: color.red.dark.opaque1400, // ⚠ link.danger.active only
1290+
red600: color.red.dark.opaque1300, // ⚠ link.danger.hover only
1291+
red500: color.red.dark.opaque1200, // content.danger, link.danger.default
1292+
red400: color.red.dark.opaque1100, // // graphics.danger, border.danger
1293+
red300: color.red.dark.transparent400,
1294+
red200: color.red.dark.transparent300,
1295+
red100: color.red.dark.transparent200,
12961296

12971297
yellow700: color.yellow.dark.opaque1500, // ⚠ link.warning.active only
12981298
yellow600: color.yellow.dark.opaque1400, // ⚠ link.warning.hover only
12991299
yellow500: color.yellow.dark.opaque1300, // content.warning, link.warning.default
13001300
yellow400: color.yellow.dark.opaque1200, // graphics.warning, border.warning
1301-
yellow300: color.yellow.dark.transparent300,
1302-
yellow200: color.yellow.dark.transparent200,
1303-
yellow100: color.yellow.dark.transparent100,
1304-
1305-
green700: color.green.dark.opaque1400, // ⚠ link.success.active only
1306-
green600: color.green.dark.opaque1300, // ⚠ link.success.hover only
1307-
green500: color.green.dark.opaque1200, // content.success, link.success.default
1308-
green400: color.green.dark.opaque1100, // graphics.success, border.success
1309-
green300: color.green.dark.transparent600,
1310-
green200: color.green.dark.transparent500,
1311-
green100: color.green.dark.transparent400,
1301+
yellow300: color.yellow.dark.transparent400,
1302+
yellow200: color.yellow.dark.transparent300,
1303+
yellow100: color.yellow.dark.transparent200,
1304+
1305+
green700: color.green.dark.opaque1500, // ⚠ link.success.active only
1306+
green600: color.green.dark.opaque1400, // ⚠ link.success.hover only
1307+
green500: color.green.dark.opaque1300, // content.success, link.success.default
1308+
green400: color.green.dark.opaque1200, // graphics.success, border.success
1309+
green300: color.green.dark.transparent400,
1310+
green200: color.green.dark.transparent300,
1311+
green100: color.green.dark.transparent200,
13121312

13131313
// Currently used for avatars, badges, booleans, buttons, checkboxes, radio buttons
13141314
chonk: {

0 commit comments

Comments
 (0)