feat(trace-tree-node): Mitigating error node type guards usage #104501
+20
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
…k/trace-tree-node-error-guards-usage
Abdkhan14
commented
Dec 9, 2025
| true | ||
| ); | ||
| const startTimestamp = 'start_timestamp' in event ? event.start_timestamp : undefined; | ||
| // TODO Abdullah Khan: Clean this up once getRepresentativeTraceEvent is moved to the TraceTree class |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| 'timestamp' in event | ||
| ? event.timestamp | ||
| : 'event_timestamp' in event && typeof event.event_timestamp === 'number' | ||
| ? event.event_timestamp |
Contributor
There was a problem hiding this comment.
Bug: Wrong property name causes missing duration for EAP events
The code checks for event_timestamp but this property doesn't exist on any TraceTree.TraceEvent type. For EAPSpan and UptimeCheck events, the end time is stored in end_timestamp, not event_timestamp. This causes the duration calculation to fail for these event types, returning '\u2014' instead of the actual duration. The condition should check for 'end_timestamp' in event rather than 'event_timestamp' in event.
gggritso
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.