From 23e6b71d7f5b08b65ce833f50704242d63f92576 Mon Sep 17 00:00:00 2001 From: David Cramer Date: Sun, 22 Feb 2026 11:03:51 -0800 Subject: [PATCH] ref: Combine multiple reduce operations into single pass Warden finding code-simplifier-154faa58 Severity: medium Co-Authored-By: Warden --- src/action/checks/manager.ts | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/src/action/checks/manager.ts b/src/action/checks/manager.ts index c9b1aed8..ede19c5d 100644 --- a/src/action/checks/manager.ts +++ b/src/action/checks/manager.ts @@ -43,13 +43,22 @@ export function aggregateUsage(reports: SkillReport[]): UsageStats | undefined { const reportsWithUsage = reports.filter((r) => r.usage); if (reportsWithUsage.length === 0) return undefined; - return { - inputTokens: reportsWithUsage.reduce((sum, r) => sum + (r.usage?.inputTokens ?? 0), 0), - outputTokens: reportsWithUsage.reduce((sum, r) => sum + (r.usage?.outputTokens ?? 0), 0), - cacheReadInputTokens: reportsWithUsage.reduce((sum, r) => sum + (r.usage?.cacheReadInputTokens ?? 0), 0), - cacheCreationInputTokens: reportsWithUsage.reduce((sum, r) => sum + (r.usage?.cacheCreationInputTokens ?? 0), 0), - costUSD: reportsWithUsage.reduce((sum, r) => sum + (r.usage?.costUSD ?? 0), 0), + const seed: UsageStats = { + inputTokens: 0, + outputTokens: 0, + cacheReadInputTokens: 0, + cacheCreationInputTokens: 0, + costUSD: 0, }; + + return reportsWithUsage.reduce((acc, r) => { + acc.inputTokens += r.usage?.inputTokens ?? 0; + acc.outputTokens += r.usage?.outputTokens ?? 0; + acc.cacheReadInputTokens = (acc.cacheReadInputTokens ?? 0) + (r.usage?.cacheReadInputTokens ?? 0); + acc.cacheCreationInputTokens = (acc.cacheCreationInputTokens ?? 0) + (r.usage?.cacheCreationInputTokens ?? 0); + acc.costUSD += r.usage?.costUSD ?? 0; + return acc; + }, seed); } /**