Skip to content

Commit dada4c8

Browse files
authored
model-conversion : remove max diff check in compare-logits [no ci] (#17954)
This commit removes the maximum difference check from the compare-logits.py which would stop early if the difference between the logits exceeded a threshold. The motivation for removing this is that it can be useful to be able to get the complete log for debugging/reporting purposes.
1 parent b8ee22c commit dada4c8

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

examples/model-conversion/scripts/causal/compare-logits.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@ def quick_logits_check(pytorch_file, llamacpp_file):
3232
print(f"Top 10 llama.cpp logits: {llamacpp_logits[llamacpp_top10]}")
3333
print(f"Max absolute difference: {max_diff:.4f}")
3434

35-
if max_diff > 1.0:
36-
print(f"❌ NOK: Large differences detected - max diff: {max_diff:.4f}")
37-
return False
38-
3935
return True
4036

4137
def main():

0 commit comments

Comments
 (0)