fix: observer command (#123)

* fix(observer): resolve -c flag conflict and crash

- Remove -c short flag from --cookie option on ps:observer
  to fix conflict with -c for --ssh_cmd (Click silently
  took the last -c definition, making --cookie unreachable)
- Add missing `auth` import in observer.py that caused a
  NameError crash on 401 responses
- Fix sanitize_respone to handle multi-line Erlang/OTP
  warnings by extracting only the last non-empty line
  before stripping quotes

* chore: bump version

Author: gigatim

gigalixir/__init__.py

@@ -1094,7 +1094,7 @@ def google_signup(ctx):
 
 @cli.command(name='ps:observer')
 @click.option('-a', '--app_name', envvar="GIGALIXIR_APP")
-@click.option('-c', '--cookie')
+@click.option('--cookie')
 @click.option('-o', '--ssh_opts', default="", help='Command-line options to pass to ssh.')
 @click.option('-c', '--ssh_cmd', default="ssh", help='Which ssh command to use.')
 @click.pass_context

gigalixir/observer.py

@@ -9,6 +9,7 @@
 import subprocess
 import time
 from .shell import cast, call
+from . import auth
 from . import app as gigalixir_app
 from six.moves.urllib.parse import quote
 
@@ -141,6 +142,11 @@ def ensure_port_free(port):
         pass
 
 def sanitize_respone(text):
+    # The output may contain multi-line warnings (e.g. Erlang/OTP version
+    # notices). The actual value is always the last non-empty line.
+    lines = [line for line in text.strip().splitlines() if line.strip()]
+    if lines:
+        text = lines[-1].strip()
     match = re.match(r"^(~c\"|')(.+)[\"']$", text)
     if match:
         return match.groups()[1]

setup.py

@@ -5,7 +5,7 @@
     url='https://github.com/gigalixir/gigalixir-cli',
     author='Tim Knight',
     author_email='tim@gigalixir.com',
-    version='1.16.0',
+    version='1.16.1',
     packages=find_packages(),
     include_package_data=True,
     install_requires=[