fix: allow daemon errors in corruption-scenario tests

Three missing_attribution tests (H6d, H7a, H18) intentionally create corrupt
checkpoint data to document failure modes. In daemon mode, the daemon reports
errors when processing these, causing wait_for_daemon_completion_sessions to
panic before the test can check the outcome. Add allow_daemon_errors flag to
TestRepo so these tests can indicate that daemon errors are expected.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: jwiegley

tests/integration/missing_attribution.rs

@@ -783,6 +783,7 @@ fn test_h6d_ai_checkpoint_wrong_file_path() {
     );
     fs::write(cp_dir.join("checkpoints.jsonl"), &checkpoint_json).unwrap();
 
+    repo.set_allow_daemon_errors(true);
     let result = repo.stage_all_and_commit("add ai code");
 
     match result {
@@ -862,6 +863,7 @@ fn test_h7a_truncated_jsonl_poisons_all_checkpoints() {
     let checkpoints = format!("{}\n{}\n", valid_checkpoint, corrupt_line);
     fs::write(cp_dir.join("checkpoints.jsonl"), &checkpoints).unwrap();
 
+    repo.set_allow_daemon_errors(true);
     let result = repo.stage_all_and_commit("add ai code");
 
     // The corrupt line causes read_all_checkpoints() to fail with Err.
@@ -1643,6 +1645,7 @@ fn test_h18_append_checkpoint_on_corrupt_jsonl_overwrites_valid_data() {
     // The corrupt JSONL may cause post-commit to fail entirely (no note written),
     // or the note may be written but with file_a's AI data lost. Either outcome
     // confirms the data-loss bug in append_checkpoint.
+    repo.set_allow_daemon_errors(true);
     let result = repo.stage_all_and_commit("commit both");
 
     match result {

tests/integration/repos/test_repo.rs

@@ -20,7 +20,7 @@ use std::fs;
 use std::io::Read;
 use std::path::{Path, PathBuf};
 use std::process::{Child, Command, Stdio};
-use std::sync::atomic::{AtomicUsize, Ordering};
+use std::sync::atomic::{AtomicBool, AtomicUsize, Ordering};
 use std::sync::{Arc, Mutex, OnceLock};
 use std::thread;
 use std::time::{Duration, Instant};
@@ -747,6 +747,7 @@ pub struct TestRepo {
     /// Base repo's test DB path for cleanup.
     _base_test_db_path: Option<PathBuf>,
     daemon_family_key: OnceLock<String>,
+    allow_daemon_errors: AtomicBool,
 }
 
 #[allow(dead_code)]
@@ -1014,6 +1015,7 @@ impl TestRepo {
             _base_repo_path: Some(base_path),
             _base_test_db_path: Some(base_test_db_path),
             daemon_family_key: OnceLock::new(),
+            allow_daemon_errors: AtomicBool::new(false),
         };
 
         repo.apply_default_config_patch();
@@ -1051,6 +1053,7 @@ impl TestRepo {
             _base_repo_path: None,
             _base_test_db_path: None,
             daemon_family_key: OnceLock::new(),
+            allow_daemon_errors: AtomicBool::new(false),
         };
 
         repo.apply_default_config_patch();
@@ -1133,6 +1136,7 @@ impl TestRepo {
             _base_repo_path: Some(main_path),
             _base_test_db_path: None,
             daemon_family_key: OnceLock::new(),
+            allow_daemon_errors: AtomicBool::new(false),
         };
 
         repo.apply_default_config_patch();
@@ -1177,6 +1181,7 @@ impl TestRepo {
             _base_repo_path: None,
             _base_test_db_path: None,
             daemon_family_key: OnceLock::new(),
+            allow_daemon_errors: AtomicBool::new(false),
         };
 
         let mut repo = repo;
@@ -1235,6 +1240,7 @@ impl TestRepo {
             _base_repo_path: None,
             _base_test_db_path: None,
             daemon_family_key: OnceLock::new(),
+            allow_daemon_errors: AtomicBool::new(false),
         };
 
         // Ensure the upstream default branch is named "main" for consistency across Git versions
@@ -1278,6 +1284,7 @@ impl TestRepo {
             _base_repo_path: None,
             _base_test_db_path: None,
             daemon_family_key: OnceLock::new(),
+            allow_daemon_errors: AtomicBool::new(false),
         };
 
         // Ensure the default branch is named "main" for consistency across Git versions
@@ -1334,6 +1341,7 @@ impl TestRepo {
             _base_repo_path: None,
             _base_test_db_path: None,
             daemon_family_key: OnceLock::new(),
+            allow_daemon_errors: AtomicBool::new(false),
         };
 
         repo.apply_default_config_patch();
@@ -1346,6 +1354,10 @@ impl TestRepo {
         self.feature_flags = feature_flags;
     }
 
+    pub fn set_allow_daemon_errors(&self, allow: bool) {
+        self.allow_daemon_errors.store(allow, Ordering::Relaxed);
+    }
+
     pub(crate) fn daemon_control_socket_path(&self) -> PathBuf {
         self.daemon_process
             .as_ref()
@@ -1525,6 +1537,10 @@ impl TestRepo {
                     continue;
                 }
                 if entry.status == "error" {
+                    if self.allow_daemon_errors.load(Ordering::Relaxed) {
+                        completed.insert(session);
+                        continue;
+                    }
                     panic!(
                         "daemon completion log reported an error for family {} session {}: {}",
                         family_key,