Skip to content
This repository was archived by the owner on Jun 8, 2023. It is now read-only.

Commit 4da137a

Browse files
committed
Merge pull request #153 from github/xcode-7
Build under Xcode 7
2 parents 6981c5b + 7d304e4 commit 4da137a

File tree

7 files changed

+30
-10
lines changed

7 files changed

+30
-10
lines changed

Rebel.xcodeproj/project.pbxproj

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -506,8 +506,9 @@
506506
D09AE4D515C5F45200ECAD10 /* Project object */ = {
507507
isa = PBXProject;
508508
attributes = {
509+
LastSwiftUpdateCheck = 0700;
509510
LastTestingUpgradeCheck = 0510;
510-
LastUpgradeCheck = 0620;
511+
LastUpgradeCheck = 0700;
511512
ORGANIZATIONNAME = GitHub;
512513
};
513514
buildConfigurationList = D09AE4D815C5F45200ECAD10 /* Build configuration list for PBXProject "Rebel" */;
@@ -610,6 +611,7 @@
610611
isa = XCBuildConfiguration;
611612
baseConfigurationReference = D08BB2DE15CB307200CC9868 /* Profile.xcconfig */;
612613
buildSettings = {
614+
GCC_NO_COMMON_BLOCKS = YES;
613615
MACOSX_DEPLOYMENT_TARGET = 10.8;
614616
};
615617
name = Profile;
@@ -622,6 +624,7 @@
622624
DYLIB_CURRENT_VERSION = 1;
623625
FRAMEWORK_VERSION = A;
624626
INFOPLIST_FILE = "Rebel/Rebel-Info.plist";
627+
PRODUCT_BUNDLE_IDENTIFIER = "com.github.${PRODUCT_NAME:rfc1034identifier}";
625628
WRAPPER_EXTENSION = framework;
626629
};
627630
name = Profile;
@@ -638,6 +641,7 @@
638641
INFOPLIST_FILE = "RebelTests/RebelTests-Info.plist";
639642
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/../Frameworks @loader_path/../Frameworks";
640643
MACOSX_DEPLOYMENT_TARGET = 10.9;
644+
PRODUCT_BUNDLE_IDENTIFIER = "com.github.${PRODUCT_NAME:rfc1034identifier}";
641645
PRODUCT_NAME = "$(TARGET_NAME)";
642646
};
643647
name = Profile;
@@ -646,6 +650,8 @@
646650
isa = XCBuildConfiguration;
647651
baseConfigurationReference = D08BB2DD15CB307200CC9868 /* Debug.xcconfig */;
648652
buildSettings = {
653+
ENABLE_TESTABILITY = YES;
654+
GCC_NO_COMMON_BLOCKS = YES;
649655
MACOSX_DEPLOYMENT_TARGET = 10.8;
650656
ONLY_ACTIVE_ARCH = YES;
651657
};
@@ -655,6 +661,7 @@
655661
isa = XCBuildConfiguration;
656662
baseConfigurationReference = D08BB2DF15CB307200CC9868 /* Release.xcconfig */;
657663
buildSettings = {
664+
GCC_NO_COMMON_BLOCKS = YES;
658665
MACOSX_DEPLOYMENT_TARGET = 10.8;
659666
};
660667
name = Release;
@@ -667,6 +674,7 @@
667674
DYLIB_CURRENT_VERSION = 1;
668675
FRAMEWORK_VERSION = A;
669676
INFOPLIST_FILE = "Rebel/Rebel-Info.plist";
677+
PRODUCT_BUNDLE_IDENTIFIER = "com.github.${PRODUCT_NAME:rfc1034identifier}";
670678
WRAPPER_EXTENSION = framework;
671679
};
672680
name = Debug;
@@ -679,6 +687,7 @@
679687
DYLIB_CURRENT_VERSION = 1;
680688
FRAMEWORK_VERSION = A;
681689
INFOPLIST_FILE = "Rebel/Rebel-Info.plist";
690+
PRODUCT_BUNDLE_IDENTIFIER = "com.github.${PRODUCT_NAME:rfc1034identifier}";
682691
WRAPPER_EXTENSION = framework;
683692
};
684693
name = Release;
@@ -695,6 +704,7 @@
695704
INFOPLIST_FILE = "RebelTests/RebelTests-Info.plist";
696705
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/../Frameworks @loader_path/../Frameworks";
697706
MACOSX_DEPLOYMENT_TARGET = 10.9;
707+
PRODUCT_BUNDLE_IDENTIFIER = "com.github.${PRODUCT_NAME:rfc1034identifier}";
698708
PRODUCT_NAME = "$(TARGET_NAME)";
699709
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
700710
};
@@ -712,6 +722,7 @@
712722
INFOPLIST_FILE = "RebelTests/RebelTests-Info.plist";
713723
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/../Frameworks @loader_path/../Frameworks";
714724
MACOSX_DEPLOYMENT_TARGET = 10.9;
725+
PRODUCT_BUNDLE_IDENTIFIER = "com.github.${PRODUCT_NAME:rfc1034identifier}";
715726
PRODUCT_NAME = "$(TARGET_NAME)";
716727
};
717728
name = Release;

Rebel.xcodeproj/xcshareddata/xcschemes/Rebel.xcscheme

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "0620"
3+
LastUpgradeVersion = "0700"
44
version = "2.0">
55
<BuildAction
66
parallelizeBuildables = "YES"
@@ -37,10 +37,10 @@
3737
</BuildActionEntries>
3838
</BuildAction>
3939
<TestAction
40+
buildConfiguration = "Debug"
4041
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
4142
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
42-
shouldUseLaunchSchemeArgsEnv = "YES"
43-
buildConfiguration = "Debug">
43+
shouldUseLaunchSchemeArgsEnv = "YES">
4444
<Testables>
4545
<TestableReference
4646
skipped = "NO">
@@ -62,16 +62,19 @@
6262
ReferencedContainer = "container:Rebel.xcodeproj">
6363
</BuildableReference>
6464
</MacroExpansion>
65+
<AdditionalOptions>
66+
</AdditionalOptions>
6567
</TestAction>
6668
<LaunchAction
69+
buildConfiguration = "Debug"
6770
selectedDebuggerIdentifier = ""
6871
selectedLauncherIdentifier = "Xcode.IDEFoundation.Launcher.PosixSpawn"
6972
launchStyle = "0"
7073
useCustomWorkingDirectory = "NO"
71-
buildConfiguration = "Debug"
7274
ignoresPersistentStateOnLaunch = "NO"
7375
debugDocumentVersioning = "YES"
7476
debugXPCServices = "NO"
77+
debugServiceExtension = "internal"
7578
allowLocationSimulation = "YES">
7679
<MacroExpansion>
7780
<BuildableReference
@@ -86,10 +89,10 @@
8689
</AdditionalOptions>
8790
</LaunchAction>
8891
<ProfileAction
92+
buildConfiguration = "Profile"
8993
shouldUseLaunchSchemeArgsEnv = "YES"
9094
savedToolIdentifier = ""
9195
useCustomWorkingDirectory = "NO"
92-
buildConfiguration = "Profile"
9396
debugDocumentVersioning = "YES">
9497
<MacroExpansion>
9598
<BuildableReference

Rebel/RBLHTMLView.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
// Copyright (c) 2013 GitHub. All rights reserved.
77
//
88

9-
#import <WebKit/WebKit.h>
9+
@import WebKit;
1010

1111
// A view for displaying HTML-styled text.
1212
@interface RBLHTMLView : WebView

Rebel/RBLHTMLView.m

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,12 @@
88

99
#import "RBLHTMLView.h"
1010

11+
// These protocols are informal on 10.10, but required on 10.11. 😞
12+
#ifdef MAC_OS_X_VERSION_10_11
13+
@interface RBLHTMLView () <WebPolicyDelegate, WebUIDelegate>
14+
@end
15+
#endif
16+
1117
@implementation RBLHTMLView
1218

1319
#pragma mark Lifecycle

Rebel/RBLSlidingContainerView.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ - (void)setContentView:(NSView *)contentView direction:(RBLSlidingContainerViewS
9595
[self addConstraints:self.verticalContainerConstraints];
9696
[self addConstraints:self.horizontalContainerConstraints];
9797

98-
self.animations = nil;
98+
self.animations = @{};
9999

100100
if (completionBlock != nil) completionBlock();
101101
};

Rebel/Rebel-Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<key>CFBundleIconFile</key>
1010
<string></string>
1111
<key>CFBundleIdentifier</key>
12-
<string>com.github.${PRODUCT_NAME:rfc1034identifier}</string>
12+
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
1313
<key>CFBundleInfoDictionaryVersion</key>
1414
<string>6.0</string>
1515
<key>CFBundleName</key>

RebelTests/RebelTests-Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<key>CFBundleExecutable</key>
88
<string>${EXECUTABLE_NAME}</string>
99
<key>CFBundleIdentifier</key>
10-
<string>com.github.${PRODUCT_NAME:rfc1034identifier}</string>
10+
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
1111
<key>CFBundleInfoDictionaryVersion</key>
1212
<string>6.0</string>
1313
<key>CFBundlePackageType</key>

0 commit comments

Comments
 (0)