Skip to content

Commit 40f80a8

Browse files
committed
Rename type to better match generic intention
1 parent b222c3a commit 40f80a8

2 files changed

Lines changed: 11 additions & 9 deletions

File tree

lib/entry-points.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/cli/output-cache.ts

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,10 @@ type CommandCacheKeyOutputMap = {
2020
[CommandCacheKey.Version]: VersionInfo;
2121
};
2222

23-
/** The persisted version together with the CLI path it was obtained from. */
24-
interface PersistedVersionInfo<K extends CommandCacheKey> {
23+
/**
24+
* The type of the command cache that is persisted to disk.
25+
*/
26+
interface CommandCacheRecord<K extends CommandCacheKey> {
2527
cmd: string;
2628
entries: Map<K, CommandCacheKeyOutputMap[K]>;
2729
}
@@ -107,7 +109,7 @@ export function getCachedCodeQlVersion(
107109
return undefined;
108110
}
109111
if (
110-
!isPersistedVersionInfo(persisted) ||
112+
!isCommandCacheRecord(persisted) ||
111113
(cmd !== undefined && persisted.cmd !== cmd)
112114
) {
113115
return undefined;
@@ -137,14 +139,14 @@ function isVersionInfo(x: unknown): x is VersionInfo {
137139
}
138140

139141
/**
140-
* Determines whether a value is a `PersistedVersionInfo` object.
142+
* Determines whether a value is a `CommandCacheRecord` object.
141143
* @param x The value to test
142144
*/
143-
function isPersistedVersionInfo(
145+
function isCommandCacheRecord(
144146
x: unknown,
145-
): x is PersistedVersionInfo<CommandCacheKey.Version> {
147+
): x is CommandCacheRecord<CommandCacheKey.Version> {
146148
const candidate = x as Partial<
147-
PersistedVersionInfo<CommandCacheKey.Version>
149+
CommandCacheRecord<CommandCacheKey.Version>
148150
> | null;
149151
return (
150152
typeof candidate === "object" &&

0 commit comments

Comments
 (0)