Rule 7.0.2: Address review feedback

Author: lcartey

cpp/misra/src/rules/RULE-7-0-2/NoImplicitBoolConversion.ql

@@ -43,7 +43,6 @@ predicate isBitFieldOfSizeOne(Expr expr) {
 
 predicate isPointerType(Type t) {
   t.getUnspecifiedType() instanceof PointerType or
-  t.getUnspecifiedType() instanceof ArrayType or
   t.getUnspecifiedType() instanceof PointerToMemberType
 }
 
@@ -59,12 +58,15 @@ where
       // Exception 2: Contextual conversion from pointer
       not (
         isPointerType(conv.getExpr().getType()) and
-        isInContextualBoolContext(conv.getExpr())
+        // Checks if the unconverted expression for this conversion is in a contextual bool context
+        // This handles the cases where we have multiple stacked conversions, e.g. when converting
+        // an array to a pointer, then the pointer to bool
+        isInContextualBoolContext(conv.getUnconverted())
       ) and
-      // Exception 3: Bit-field of size 1
-      not isBitFieldOfSizeOne(conv.getExpr()) and
-      // Exception 4: While condition declaration
-      not isInWhileConditionDeclaration(conv.getExpr()) and
+      // Exception 3: Unconverted expression is a bit-field of size 1
+      not isBitFieldOfSizeOne(conv.getUnconverted()) and
+      // Exception 4: Unconverted expression is in a while condition declaration
+      not isInWhileConditionDeclaration(conv.getUnconverted()) and
       reason = "Conversion from '" + conv.getExpr().getType().toString() + "' to 'bool'"
     )
     or

cpp/misra/test/rules/RULE-7-0-2/NoImplicitBoolConversion.expected

@@ -21,8 +21,6 @@
 | test.cpp:182:7:182:8 | (bool)... | Conversion from 'float' to 'bool'. |
 | test.cpp:184:7:184:8 | (bool)... | Conversion from 'double' to 'bool'. |
 | test.cpp:186:7:186:8 | (bool)... | Conversion from 'long double' to 'bool'. |
-| test.cpp:195:7:195:8 | (bool)... | Conversion from 'int32_t *' to 'bool'. |
-| test.cpp:197:7:197:8 | (bool)... | Conversion from 'int32_t *' to 'bool'. |
 | test.cpp:199:13:199:14 | (bool)... | Conversion from 'int32_t *' to 'bool'. |
 | test.cpp:211:13:211:14 | (bool)... | Conversion from '..:: *' to 'bool'. |
 | test.cpp:212:13:212:14 | (bool)... | Conversion from '..:: *' to 'bool'. |

cpp/misra/test/rules/RULE-7-0-2/test.cpp

@@ -192,9 +192,9 @@ void test_floating_point_conversion() {
 void test_array_conversion() {
   std::int32_t l1[5] = {1, 2, 3, 4, 5};
 
-  if (l1) { // NON_COMPLIANT
+  if (l1) { // COMPLIANT
   }
-  if (g8) { // NON_COMPLIANT
+  if (g8) { // COMPLIANT
   }
   bool l2 = l1;              // NON_COMPLIANT
   bool l3 = (l1 != nullptr); // COMPLIANT