Merge pull request #20844 from Eliav2/20823-globalVarRef-document-defaultView

javascript: Add support for `document.defaultView` in global variable references

Author: asgerf

javascript/ql/lib/change-notes/2025-11-19-default-view.md

@@ -0,0 +1,5 @@
+---
+category: minorAnalysis
+---
+
+- JavaScript `DataFlow::globalVarRef` now recognizes `document.defaultView` as an alias of `window`, allowing flows such as `document.defaultView.history.pushState(...)` to be modeled and found by queries relying on `globalVarRef("history")`.

javascript/ql/lib/semmle/javascript/dataflow/Nodes.qll

@@ -393,6 +393,9 @@ DataFlow::SourceNode globalObjectRef() {
   // DOM
   result = globalVariable("window")
   or
+  // DOM alias via `document.defaultView`
+  result = globalVariable("document").getAPropertyRead("defaultView")
+  or
   // Node.js
   result = globalVariable("global")
   or

javascript/ql/test/library-tests/Nodes/globalObjectRef.expected

@@ -5,9 +5,12 @@
 | tst2.js:8:1:8:6 | global |
 | tst3.js:1:1:1:0 | this |
 | tst3.js:3:9:3:19 | goog.global |
+| tst4.js:1:1:1:0 | this |
+| tst4.js:1:1:1:38 | require ... ultView |
 | tst.js:1:1:1:0 | this |
 | tst.js:1:1:1:6 | window |
 | tst.js:3:1:3:6 | window |
 | tst.js:4:1:4:6 | window |
 | tst.js:5:1:5:4 | self |
 | tst.js:6:1:6:10 | globalThis |
+| tst.js:7:1:7:20 | document.defaultView |

javascript/ql/test/library-tests/Nodes/globalVarRef.expected

@@ -1,15 +1,19 @@
 | Object | tst2.js:8:1:8:13 | global.Object |
 | String | tst2.js:9:1:9:11 | this.String |
 | document | tst2.js:2:1:2:26 | require ... ument") |
+| document | tst4.js:1:1:1:26 | require ... ument") |
 | document | tst.js:3:1:3:15 | window.document |
 | document | tst.js:5:1:5:13 | self.document |
 | document | tst.js:6:1:6:19 | globalThis.document |
+| document | tst.js:7:1:7:8 | document |
 | foo | tst3.js:4:1:4:5 | w.foo |
 | global | tst2.js:7:1:7:6 | global |
 | global | tst2.js:8:1:8:6 | global |
 | globalThis | tst.js:6:1:6:10 | globalThis |
 | goog | tst3.js:1:1:1:4 | goog |
 | goog | tst3.js:3:9:3:12 | goog |
+| history | tst4.js:1:1:1:46 | require ... history |
+| history | tst.js:7:1:7:28 | documen ... history |
 | self | tst.js:5:1:5:4 | self |
 | setTimeout | tst2.js:5:1:5:12 | g.setTimeout |
 | window | tst2.js:3:1:3:24 | require ... indow") |

javascript/ql/test/library-tests/Nodes/tst.js

@@ -4,3 +4,4 @@ window.document;
 window.window.document;
 self.document;
 globalThis.document;
+document.defaultView.history;

javascript/ql/test/library-tests/Nodes/tst4.js

@@ -0,0 +1 @@
+require("global/document").defaultView.history;