Merge pull request #960 from hvitved/csharp/cache-get-arg

calumgrant · web-flow · commit 1386af46c1b8 · 2019-02-22T12:39:55.000Z
C#: Cache `Call::getArgumentForParameter()`
diff --git a/csharp/ql/src/semmle/code/csharp/exprs/Call.qll b/csharp/ql/src/semmle/code/csharp/exprs/Call.qll
@@ -76,7 +76,7 @@ class Call extends DotNet::Call, Expr, @call {
    * }
    * ```
    */
-  pragma[nomagic]
+  cached
   override Expr getArgumentForParameter(DotNet::Parameter p) {
     getTarget().getAParameter() = p and
     (

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ class Call extends DotNet::Call, Expr, @call {`
`76`	`76`	`* }`
`77`	`77`	* ```
`78`	`78`	`*/`
`79`		`- pragma[nomagic]`
	`79`	`+ cached`
`80`	`80`	`override Expr getArgumentForParameter(DotNet::Parameter p) {`
`81`	`81`	`getTarget().getAParameter() = p and`
`82`	`82`	`(`