C#: Now that SummarizedCallableDefaultClears content has been removed, we need to explicitly say that fields are cleared.

Author: michaelnebel

csharp/ql/test/library-tests/dataflow/external-models/steps.expected

@@ -20,5 +20,5 @@ summarySetterStep
 | Steps.cs:34:37:34:37 | 0 | Steps.cs:34:13:34:16 | [post] this access | Steps.cs:63:13:63:20 | property Property |
 | Steps.cs:38:36:38:36 | 0 | Steps.cs:38:13:38:16 | [post] this access | file://:0:0:0:0 | element |
 clearsContent
-| Steps.cs:61:14:61:28 | StepFieldSetter | Steps.cs:57:13:57:17 | field Field | this |
-| Steps.cs:67:14:67:31 | StepPropertySetter | Steps.cs:63:13:63:20 | property Property | this |
+| Steps.cs:61:14:61:28 | StepFieldSetter | file://:0:0:0:0 | element | this |
+| Steps.cs:67:14:67:31 | StepPropertySetter | file://:0:0:0:0 | element | this |

csharp/ql/test/library-tests/dataflow/external-models/steps.ql

@@ -5,7 +5,7 @@ import semmle.code.csharp.dataflow.FlowSummary
 import semmle.code.csharp.dataflow.internal.FlowSummaryImpl as FlowSummaryImpl
 import CsvValidation
 
-class SummaryModelTest extends SummaryModelCsv {
+private class SummaryModelTest extends SummaryModelCsv {
   override predicate row(string row) {
     row =
       [
@@ -28,6 +28,18 @@ class SummaryModelTest extends SummaryModelCsv {
   }
 }
 
+private class SummarizedCallableClear extends SummarizedCallable {
+  SummarizedCallableClear() {
+    this.getName() = ["StepPropertySetter", "StepFieldSetter"] and
+    this.getFile().getBaseName() = "Steps.cs"
+  }
+
+  override predicate clearsContent(ParameterPosition pos, DataFlow::ContentSet content) {
+    pos.isThisParameter() and
+    content instanceof DataFlow::ElementContent
+  }
+}
+
 query predicate summaryThroughStep(
   DataFlow::Node node1, DataFlow::Node node2, boolean preservesValue
 ) {