Skip to content

Commit 47ab307

Browse files
committed
C++: Respond to review comments.
1 parent eb6b085 commit 47ab307

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2086,12 +2086,13 @@ predicate localExprFlow(Expr e1, Expr e2) {
20862086
*
20872087
* This is possible in _almost_ all cases, but there are cases where it is
20882088
* not possible to map between a field in the uninstantiated template to a
2089-
* field in the instantiated template. This problem appears to be only in the
2090-
* case of a local class definition. So this abstract class has two
2091-
* implementations: a non-local case (where we can represent a canonical field
2092-
* as the field declaration from an uninstantiated class template or a non-
2093-
* templated class), and a local case (where we simply use the field from the
2094-
* instantiated class).
2089+
* field in the instantiated template. This happens in the case of local class
2090+
* definitions (because the local class is not the template that constructs
2091+
* the instantiation - it is the enclosing function). So this abstract class
2092+
* has two implementations: a non-local case (where we can represent a
2093+
* canonical field as the field declaration from an uninstantiated class
2094+
* template or a non-templated class), and a local case (where we simply use
2095+
* the field from the instantiated class).
20952096
*/
20962097
abstract private class CanonicalField extends Field {
20972098
/** Gets a field represented by this canonical field. */

0 commit comments

Comments
 (0)