Centralize malformed-frontmatter skip in metadata_for

Co-authored-by: ahpook <56753+ahpook@users.noreply.github.com>

Author: Copilot

test/collections_test.rb

@@ -26,8 +26,6 @@
         end
 
         it "has valid items" do
-          skip "malformed YAML frontmatter" if frontmatter_malformed?(collections_dir, collection)
-
           invalid_slugs = []
 
           items_for_collection(collection).each do |item|
@@ -40,8 +38,6 @@
         end
 
         it "has valid number of items" do
-          skip "malformed YAML frontmatter" if frontmatter_malformed?(collections_dir, collection)
-
           items = items_for_collection(collection)
           assert (1...MAX_COLLECTION_ITEMS_LENGTH + 1).cover?(items.length),
                  "must have no more than #{MAX_COLLECTION_ITEMS_LENGTH} items " \
@@ -80,8 +76,6 @@
         end
 
         it "has expected metadata in Jekyll front matter" do
-          skip "malformed YAML frontmatter" if frontmatter_malformed?(collections_dir, collection)
-
           metadata = metadata_for(collections_dir, collection)
           refute_empty metadata, "expected some metadata for collection"
 

test/test_helper.rb

@@ -252,20 +252,12 @@ def metadata_for(dir, name)
   begin
     YAML.safe_load(frontmatter)
   rescue Psych::SyntaxError
-    nil
+    # Malformed frontmatter is reported by the dedicated YAML syntax test.
+    # Skip metadata-dependent tests here so that syntax test is the sole failure.
+    skip "malformed YAML frontmatter in #{File.join(dir, name, 'index.md')}"
   end
 end
 
-def frontmatter_malformed?(dir, name)
-  frontmatter = frontmatter_for(dir, name)
-  return false unless frontmatter
-
-  YAML.safe_load(frontmatter)
-  false
-rescue Psych::SyntaxError
-  true
-end
-
 def yaml_syntax_error_for(dir, name)
   frontmatter = frontmatter_for(dir, name)
   return unless frontmatter

test/topics_test.rb

@@ -275,8 +275,6 @@
       end
 
       it "has expected metadata in Jekyll front matter" do
-        skip "malformed YAML frontmatter" if frontmatter_malformed?(topics_dir, topic)
-
         metadata = metadata_for(topics_dir, topic)
         refute_empty metadata, "expected some metadata for topic"