[repository-quality] Repository Quality Improvement Report — Remote Fetch API Context Gap

[github-actions[bot]]

🎯 Repository Quality Improvement Report — Remote Fetch API Context Gap

Analysis Date: 2026-07-02
Focus Area: Remote Fetch API Context Gap — Public parser functions strip caller context
Strategy Type: Custom
Custom Area: Yes — caller context is silently discarded by 8 public wrappers in pkg/parser/remote_fetch.go

Executive Summary

pkg/parser/remote_fetch.go exposes 8 public functions with no context.Context parameter. All 8 delegate to private implementations that do accept context, but 7 auth-fallback sites hard-code context.Background() instead of threading the caller's context.

Nine callers in pkg/cli/ already hold a cobra cmd.Context() but cannot pass it — so Ctrl-C does not cancel in-flight HTTP requests. The fix is to add ctx context.Context to the 8 public APIs, propagate through the private chain, replace the 7 context.Background() fallback sites, update CLI callers, and add a linter to prevent regression.

Full Analysis

Public APIs with no context (pkg/parser/remote_fetch.go)

DownloadFileFromGitHub              line 876
DownloadFileFromGitHubForHost       line 885
ResolveRefToSHAForHost              line 893
ListWorkflowFiles                   line 1030
ListWorkflowFilesForHost            line 1036
ListDirAllFilesForHost              line 1095
ListDirAllFilesRecursivelyForHost   line 1208
ListDirSubdirsForHost               line 1354

context.Background() hard-coded in fallback paths

remote_fetch.go:535   resolveRefToSHAViaPublicAPI(context.Background(), ...)
remote_fetch.go:906   downloadFileViaGit(context.Background(), ...)
remote_fetch.go:926   downloadFileViaGit(context.Background(), ...)
remote_fetch.go:930   downloadFileViaPublicAPI(context.Background(), ...)
remote_fetch.go:1070  listWorkflowFilesViaPublicAPI(context.Background(), ...)
remote_fetch.go:1124  listDirAllFilesViaPublicAPI(context.Background(), ...)
remote_fetch.go:1383  listDirSubdirsViaPublicAPI(context.Background(), ...)

CLI callers that cannot propagate context

pkg/cli/dispatch.go:82,378,384
pkg/cli/includes.go:68,107,365
pkg/cli/resources.go:185
pkg/cli/list_workflows_command.go:266
pkg/cli/add_package_manifest.go:881,886,891,896

Metrics:

Metric	Value	Status
Public APIs with no context	8	❌
context.Background() fallback sites	7	❌
CLI callers that cannot pass context	9	⚠️
Private functions that accept context	8	✅

---

🤖 Tasks for Copilot Agent

NOTE TO PLANNER AGENT: Split the following tasks into individual work items.

Task 1: Add context.Context to 8 public parser APIs

Priority: High | Effort: Medium
Code Region: pkg/parser/remote_fetch.go

Add ctx context.Context as the first parameter to DownloadFileFromGitHub, DownloadFileFromGitHubForHost, ResolveRefToSHAForHost, ListWorkflowFiles, ListWorkflowFilesForHost, ListDirAllFilesForHost, ListDirAllFilesRecursivelyForHost, ListDirSubdirsForHost. Thread ctx into private implementations (downloadFileFromGitHubWithDepth, listWorkflowFilesForHost, etc.) and replace the 7 context.Background() fallback sites with the incoming ctx.

Acceptance Criteria:

• All 8 public functions accept ctx context.Context as first param
• 7 context.Background() fallback sites replaced with caller ctx
• go build ./... and go test ./pkg/parser/... pass

---

Task 2: Update CLI callers to pass cmd.Context()

Priority: High | Effort: Medium
Code Region: pkg/cli/dispatch.go, pkg/cli/includes.go, pkg/cli/resources.go, pkg/cli/list_workflows_command.go, pkg/cli/add_package_manifest.go

After Task 1, update all 9 call sites in pkg/cli/ to pass the cobra command context. Update fileDownloadFn type in dispatch.go to include ctx context.Context as first param. Thread ctx from cobra RunE handlers into helper functions.

Acceptance Criteria:

• All 9 CLI call sites pass a real context (not context.Background())
• fileDownloadFn type updated in dispatch.go
• go build ./... and go test ./pkg/cli/... pass

---

Task 3: Fix remaining context.Background() in CLI helpers

Priority: Medium | Effort: Small
Code Region: pkg/cli/copilot_agents.go, pkg/cli/resources.go, pkg/cli/includes.go

buildAgenticWorkflowsSkillContent() (copilot_agents.go:222) calls listAgenticWorkflowsMarkdownFiles(context.Background()). resources.go:82 and includes.go:140 call getRepoDefaultBranch(context.Background(), ...). Thread the cobra context from the upstream RunE callers into these helpers.

Acceptance Criteria:

• buildAgenticWorkflowsSkillContent accepts and uses ctx
• resources.go:82 and includes.go:140 use caller ctx for getRepoDefaultBranch
• go build ./... and go test ./pkg/cli/... pass

---

Task 4: Add httpbgctx linter to flag http.NewRequestWithContext(context.Background(), ...)

Priority: Medium | Effort: Small
Code Region: pkg/linters/

Create pkg/linters/httpbgctx/ analyzer that flags http.NewRequestWithContext(context.Background(), ...) in non-test production code. Register in pkg/linters/linters.go and spec_test.go. Add testdata golden file.

Acceptance Criteria:

• Analyzer reports the 7 pre-fix sites in remote_fetch.go
• After Tasks 1-3 apply, zero findings
• testdata golden-file test passes
• Registered in linters.go and spec_test.go

---

📈 Success Metrics

• context.Background() in auth-fallback paths: 7 → 0
• Public parser APIs accepting context: 0/8 → 8/8
• CLI callers passing real context: 0/9 → 9/9
• Linter coverage for http.NewRequestWithContext(context.Background()): 0 → 1

Next Steps

1. Task 1 → Task 2 (sequential; Task 2 depends on Task 1 API change)
2. Task 3 + Task 4 in parallel after Task 1+2 land
3. Re-evaluate in 2 weeks

References: §28593277510

Generated by ⚡ Repository Quality Improvement Agent · 100.5 AIC · ⌖ 9.09 AIC · ⊞ 6.7K · ◷

• expires on Jul 3, 2026, 5:32 AM UTC-08:00

[github-actions[bot]]

This discussion has been marked as outdated by Repository Quality Improvement Agent.

A newer discussion is available at Discussion #43206.