-
Notifications
You must be signed in to change notification settings - Fork 317
Description
Step Name Alignment Issue
Found in: 167 compiler-generated .lock.yml files (all workflows with threat detection enabled)
Summary
A recent mass recompile replaced the step name "Parse threat detection results" with "Parse and conclude threat detection" across all workflows. The new name uses a compound verb and verb pattern that is unusual in this codebase and contains an ambiguous second verb.
Issue Identified
[Medium Priority] Compound Verb Pattern and Ambiguous "conclude"
Current step name (compiler-generated, 167 files):
"Parse and conclude threat detection"
Step definition context:
name: Parse and conclude threat detection
id: detection_conclusion
uses: actions/github-script@...
# calls parse_threat_detection_results.cjs
# sets detection_conclusion outputIssues:
-
Compound verb inconsistency — Established naming patterns use a single imperative verb. The only other
verb and verbstep is"Build and push Docker image (amd64)", which describes a well-known Docker compound operation."parse and conclude"is less idiomatic. -
Ambiguous "conclude" — In English,
"conclude"can mean either draw a conclusion from (intended meaning) or finish/end (common meaning). A reader could interpret this as "finish the threat detection process" rather than "derive a threat detection verdict". -
Script name divergence — The underlying script is
parse_threat_detection_results.cjs, reinforcing that "parse" is the primary action. The conclusion-setting is an output of parsing, not a separate action that needs a dedicated verb.
Suggested improvements:
| Option | Name | Notes |
|---|---|---|
| A | Parse threat detection results |
Restores previous name; matches script name; single verb |
| B | Evaluate threat detection results |
Single comprehensive verb implying analysis + verdict |
| C | Assess threat detection results |
Alternative single verb; concise |
Recommended: Option A — Parse threat detection results — restores the previous, simpler name that accurately describes what the step does and matches the underlying script name.
Agentic Task Description
To fix this step name:
- Locate the compiler template that generates this step — search for
"Parse and conclude threat detection"in the compiler source or action templates under.github/actions/ - Update the template to use
"Parse threat detection results"(or chosen alternative) - Recompile all workflows — run
gh aw compile --allto regenerate the 167 affected.lock.ymlfiles - Verify the step name is updated consistently across all compiled files
Related Files
- Compiler template: search
.github/actions/for threat detection step generation - Affected compiled workflows: all 167 lock files with
threat-detectionjobs - Project glossary:
docs/src/content/docs/reference/glossary.md(Threat Detection section) - Naming patterns: single imperative verb convention
Priority
This issue is Medium Priority — the step works correctly, but the name violates the single-verb naming convention and contains ambiguous language that could confuse contributors.
AI generated by Step Name Alignment for daily maintenance
Generated by Step Name Alignment · ◷
- expires on Mar 29, 2026, 7:37 PM UTC