remove get_check_runs gate

Author: kerobbi

pkg/github/pullrequests.go

@@ -152,7 +152,7 @@ Possible options:
 				result, err := GetIssueComments(ctx, client, deps, owner, repo, pullNumber, pagination)
 				return attachIFC(result), nil, err
 			case "get_check_runs":
-				result, err := GetPullRequestCheckRuns(ctx, client, deps, owner, repo, pullNumber, pagination)
+				result, err := GetPullRequestCheckRuns(ctx, client, owner, repo, pullNumber, pagination)
 				return attachIFC(result), nil, err
 			default:
 				return utils.NewToolResultError(fmt.Sprintf("unknown method: %s", method)), nil, nil
@@ -315,7 +315,7 @@ func GetPullRequestStatus(ctx context.Context, client *github.Client, owner, rep
 	return utils.NewToolResultText(string(r)), nil
 }
 
-func GetPullRequestCheckRuns(ctx context.Context, client *github.Client, deps ToolDependencies, owner, repo string, pullNumber int, pagination PaginationParams) (*mcp.CallToolResult, error) {
+func GetPullRequestCheckRuns(ctx context.Context, client *github.Client, owner, repo string, pullNumber int, pagination PaginationParams) (*mcp.CallToolResult, error) {
 	// First get the PR to get the head SHA
 	pr, resp, err := client.PullRequests.Get(ctx, owner, repo, pullNumber)
 	if err != nil {
@@ -335,16 +335,6 @@ func GetPullRequestCheckRuns(ctx context.Context, client *github.Client, deps To
 		return ghErrors.NewGitHubAPIStatusErrorResponse(ctx, "failed to get pull request", resp, body), nil
 	}
 
-	if deps.GetFlags(ctx).LockdownMode {
-		cache, err := deps.GetRepoAccessCache(ctx)
-		if err != nil {
-			return nil, fmt.Errorf("failed to get repo access cache: %w", err)
-		}
-		if restricted, err := authorLockdownResult(ctx, cache, owner, repo, pr.GetUser().GetLogin(), lockdownPullRequestRestrictedMessage); restricted != nil || err != nil {
-			return restricted, err
-		}
-	}
-
 	// Get check runs for the head SHA
 	opts := &github.ListCheckRunsOptions{
 		ListOptions: github.ListOptions{

pkg/github/pullrequests_test.go

@@ -1772,8 +1772,6 @@ func Test_GetPullRequestCheckRuns(t *testing.T) {
 		expectError       bool
 		expectedCheckRuns *github.ListCheckRunsResults
 		expectedErrMsg    string
-		lockdownEnabled   bool
-		restPermission    string
 	}{
 		{
 			name: "successful check runs fetch",
@@ -1825,64 +1823,17 @@ func Test_GetPullRequestCheckRuns(t *testing.T) {
 			expectError:    true,
 			expectedErrMsg: "failed to get check runs",
 		},
-		{
-			name: "lockdown enabled - author lacks push access",
-			mockedClient: MockHTTPClientWithHandlers(map[string]http.HandlerFunc{
-				GetReposPullsByOwnerByRepoByPullNumber: mockResponse(t, http.StatusOK, &github.PullRequest{
-					Number: github.Ptr(42),
-					Head:   &github.PullRequestBranch{SHA: github.Ptr("abcd1234")},
-					User:   &github.User{Login: github.Ptr("reader")},
-				}),
-			}),
-			requestArgs: map[string]any{
-				"method":     "get_check_runs",
-				"owner":      "owner",
-				"repo":       "repo",
-				"pullNumber": float64(42),
-			},
-			lockdownEnabled: true,
-			restPermission:  "read",
-			expectError:     true,
-			expectedErrMsg:  "access to pull request is restricted by lockdown mode",
-		},
-		{
-			name: "lockdown enabled - author has push access",
-			mockedClient: MockHTTPClientWithHandlers(map[string]http.HandlerFunc{
-				GetReposPullsByOwnerByRepoByPullNumber: mockResponse(t, http.StatusOK, &github.PullRequest{
-					Number: github.Ptr(42),
-					Head:   &github.PullRequestBranch{SHA: github.Ptr("abcd1234")},
-					User:   &github.User{Login: github.Ptr("writer")},
-				}),
-				GetReposCommitsCheckRunsByOwnerByRepoByRef: mockResponse(t, http.StatusOK, mockCheckRuns),
-			}),
-			requestArgs: map[string]any{
-				"method":     "get_check_runs",
-				"owner":      "owner",
-				"repo":       "repo",
-				"pullNumber": float64(42),
-			},
-			lockdownEnabled:   true,
-			restPermission:    "write",
-			expectError:       false,
-			expectedCheckRuns: mockCheckRuns,
-		},
 	}
 
 	for _, tc := range tests {
 		t.Run(tc.name, func(t *testing.T) {
 			// Setup client with mock
 			client := mustNewGHClient(t, tc.mockedClient)
 			serverTool := PullRequestRead(translations.NullTranslationHelper)
-
-			var restClient *github.Client
-			if tc.lockdownEnabled {
-				restClient = mockRESTPermissionServer(t, tc.restPermission, nil)
-			}
-
 			deps := BaseDeps{
 				Client:          client,
-				RepoAccessCache: stubRepoAccessCache(restClient, 5*time.Minute),
-				Flags:           stubFeatureFlags(map[string]bool{"lockdown-mode": tc.lockdownEnabled}),
+				RepoAccessCache: stubRepoAccessCache(nil, 5*time.Minute),
+				Flags:           stubFeatureFlags(map[string]bool{"lockdown-mode": false}),
 			}
 			handler := serverTool.Handler(deps)