redo changes

Author: mattdholloway

.github/pull_request_template.md

@@ -1,44 +1,11 @@
 <!--
-Copilot: Fill all sections. Prefer short, concrete answers.
-If a checkbox is selected, add a brief explanation.
--->
-
-## Summary
-<!-- In 1–2 sentences: what does this PR do? -->
-
-## Why
-<!-- Why is this change needed? Link issues or discussions. -->
-Fixes #
-
-## What changed
-<!-- Bullet list of concrete changes. -->
-- 
-- 
-
-## MCP impact
-<!-- Select one or more. If selected, add 1–2 sentences. -->
-- [ ] No tool or API changes
-- [ ] Tool schema or behavior changed
-- [ ] New tool added
+    Thank you for contributing to GitHub MCP Server!
+    Please reference an existing issue: `Closes #NUMBER`
 
-## Prompts tested (tool changes only)
-<!-- If you changed or added tools, list example prompts you tested. -->
-<!-- Include prompts that trigger the tool and describe the use case. -->
-<!-- Example: "List all open issues in the repo assigned to me" -->
-- 
-
-## Security / limits
-<!-- Select if relevant. Add a short note if checked. -->
-- [ ] No security or limits impact
-- [ ] Auth / permissions considered
-- [ ] Data exposure, filtering, or token/size limits considered
-
-## Lint & tests
-<!-- Check what you ran. If not run, explain briefly. -->
-- [ ] Linted locally with `./script/lint`
-- [ ] Tested locally with `./script/test`
-
-## Docs
+    Screenshots or videos of changed behavior is incredibly helpful and always appreciated.
+    Consider addressing the following:
+    - Tradeoffs: List tradeoffs you made to take on or pay down tech debt.
+    - Alternatives: Describe alternative approaches you considered and why you discarded them.
+-->
 
-- [ ] Not needed
-- [ ] Updated (README / docs / examples)
+Closes:

.github/workflows/docker-publish.yml

@@ -87,7 +87,7 @@ jobs:
             type=raw,value=latest,enable=${{ github.ref_type == 'tag' && startsWith(github.ref, 'refs/tags/v') && !contains(github.ref, '-') }}
 
       - name: Go Build Cache for Docker
-        uses: actions/cache@v5
+        uses: actions/cache@v4
         with:
           path: go-build-cache
           key: ${{ runner.os }}-go-build-cache-${{ hashFiles('**/go.sum') }}

CONTRIBUTING.md

@@ -39,7 +39,6 @@ These are one time installations required to be able to test your changes locall
     - Run linter: `script/lint`
     - Update snapshots and run tests: `UPDATE_TOOLSNAPS=true go test ./...`
     - Update readme documentation: `script/generate-docs`
-    - If renaming a tool, add a deprecation alias (see [Tool Renaming Guide](docs/tool-renaming.md))
 6. Push to your fork and [submit a pull request][pr] targeting the `main` branch
 7. Pat yourself on the back and wait for your pull request to be reviewed and merged.
 

README.md

@@ -991,7 +991,7 @@ The following sets of tools are available:
      2. get_diff - Get the diff of a pull request.
      3. get_status - Get status of a head commit in a pull request. This reflects status of builds and checks.
      4. get_files - Get the list of files changed in a pull request. Use with pagination parameters to control the number of results returned.
-     5. get_review_comments - Get review threads on a pull request. Each thread contains logically grouped review comments made on the same code location during pull request reviews. Returns threads with metadata (isResolved, isOutdated, isCollapsed) and their associated comments. Use cursor-based pagination (perPage, after) to control results.
+     5. get_review_comments - Get the review comments on a pull request. They are comments made on a portion of the unified diff during a pull request review. Use with pagination parameters to control the number of results returned.
      6. get_reviews - Get the reviews on a pull request. When asked for review comments, use get_review_comments method.
      7. get_comments - Get comments on a pull request. Use this if user doesn't specifically want review comments. Use with pagination parameters to control the number of results returned.
      (string, required)
@@ -1061,7 +1061,7 @@ The following sets of tools are available:
   - `owner`: Repository owner (username or organization) (string, required)
   - `path`: Path where to create/update the file (string, required)
   - `repo`: Repository name (string, required)
-  - `sha`: The blob SHA of the file being replaced. (string, optional)
+  - `sha`: Required if updating an existing file. The blob SHA of the file being replaced. (string, optional)
 
 - **create_repository** - Create repository
   - `autoInit`: Initialize with README (boolean, optional)
@@ -1092,7 +1092,7 @@ The following sets of tools are available:
 
 - **get_file_contents** - Get file or directory contents
   - `owner`: Repository owner (username or organization) (string, required)
-  - `path`: Path to file/directory (string, optional)
+  - `path`: Path to file/directory (directories must end with a slash '/') (string, optional)
   - `ref`: Accepts optional git refs such as `refs/tags/{tag}`, `refs/heads/{branch}` or `refs/pull/{pr_number}/head` (string, optional)
   - `repo`: Repository name (string, required)
   - `sha`: Accepts optional commit SHA. If specified, it will be used instead of ref (string, optional)

cmd/github-mcp-server/generate_docs.go

@@ -8,7 +8,7 @@ import (
 	"strings"
 
 	"github.com/github/github-mcp-server/pkg/github"
-	"github.com/github/github-mcp-server/pkg/inventory"
+	"github.com/github/github-mcp-server/pkg/registry"
 	"github.com/github/github-mcp-server/pkg/translations"
 	"github.com/google/jsonschema-go/jsonschema"
 	"github.com/modelcontextprotocol/go-sdk/mcp"
@@ -50,8 +50,8 @@ func generateReadmeDocs(readmePath string) error {
 	// Create translation helper
 	t, _ := translations.TranslationHelper()
 
-	// Build inventory - stateless, no dependencies needed for doc generation
-	r := github.NewInventory(t).Build()
+	// Build registry - stateless, no dependencies needed for doc generation
+	r := github.NewRegistry(t).Build()
 
 	// Generate toolsets documentation
 	toolsetsDoc := generateToolsetsDoc(r)
@@ -104,7 +104,7 @@ func generateRemoteServerDocs(docsPath string) error {
 	return os.WriteFile(docsPath, []byte(updatedContent), 0600) //#nosec G306
 }
 
-func generateToolsetsDoc(i *inventory.Inventory) string {
+func generateToolsetsDoc(r *registry.Registry) string {
 	var buf strings.Builder
 
 	// Add table header and separator
@@ -116,14 +116,14 @@ func generateToolsetsDoc(i *inventory.Inventory) string {
 
 	// AvailableToolsets() returns toolsets that have tools, sorted by ID
 	// Exclude context (custom description above) and dynamic (internal only)
-	for _, ts := range i.AvailableToolsets("context", "dynamic") {
+	for _, ts := range r.AvailableToolsets("context", "dynamic") {
 		fmt.Fprintf(&buf, "| `%s` | %s |\n", ts.ID, ts.Description)
 	}
 
 	return strings.TrimSuffix(buf.String(), "\n")
 }
 
-func generateToolsDoc(r *inventory.Inventory) string {
+func generateToolsDoc(r *registry.Registry) string {
 	// AllTools() returns tools sorted by toolset ID then tool name.
 	// We iterate once, grouping by toolset as we encounter them.
 	tools := r.AllTools()
@@ -133,7 +133,7 @@ func generateToolsDoc(r *inventory.Inventory) string {
 
 	var buf strings.Builder
 	var toolBuf strings.Builder
-	var currentToolsetID inventory.ToolsetID
+	var currentToolsetID registry.ToolsetID
 	firstSection := true
 
 	writeSection := func() {
@@ -299,8 +299,8 @@ func generateRemoteToolsetsDoc() string {
 	// Create translation helper
 	t, _ := translations.TranslationHelper()
 
-	// Build inventory - stateless
-	r := github.NewInventory(t).Build()
+	// Build registry - stateless
+	r := github.NewRegistry(t).Build()
 
 	// Generate table header
 	buf.WriteString("| Name           | Description                                      | API URL                                               | 1-Click Install (VS Code)                                                                                                                                                                                                 | Read-only Link                                                                                                 | 1-Click Read-only Install (VS Code)                                                                                                                                                                                                 |\n")

cmd/github-mcp-server/main.go

@@ -54,14 +54,18 @@ var (
 
 			// Parse tools (similar to toolsets)
 			var enabledTools []string
-			if err := viper.UnmarshalKey("tools", &enabledTools); err != nil {
-				return fmt.Errorf("failed to unmarshal tools: %w", err)
+			if viper.IsSet("tools") {
+				if err := viper.UnmarshalKey("tools", &enabledTools); err != nil {
+					return fmt.Errorf("failed to unmarshal tools: %w", err)
+				}
 			}
 
 			// Parse enabled features (similar to toolsets)
 			var enabledFeatures []string
-			if err := viper.UnmarshalKey("features", &enabledFeatures); err != nil {
-				return fmt.Errorf("failed to unmarshal features: %w", err)
+			if viper.IsSet("features") {
+				if err := viper.UnmarshalKey("features", &enabledFeatures); err != nil {
+					return fmt.Errorf("failed to unmarshal features: %w", err)
+				}
 			}
 
 			ttl := viper.GetDuration("repo-access-cache-ttl")

docs/installation-guides/README.md

@@ -4,7 +4,6 @@ This directory contains detailed installation instructions for the GitHub MCP Se
 
 ## Installation Guides by Host Application
 - **[GitHub Copilot in other IDEs](install-other-copilot-ides.md)** - Installation for JetBrains, Visual Studio, Eclipse, and Xcode with GitHub Copilot
-- **[Antigravity](install-antigravity.md)** - Installation for Google Antigravity IDE
 - **[Claude Applications](install-claude.md)** - Installation guide for Claude Web, Claude Desktop and Claude Code CLI
 - **[Cursor](install-cursor.md)** - Installation guide for Cursor IDE
 - **[Google Gemini CLI](install-gemini-cli.md)** - Installation guide for Google Gemini CLI