fix: remove unused icon parameter from writeToolDoc

- Remove unused 'icon' parameter from writeToolDoc function signature
- Fix whitespace inconsistency in octicons_test.go
- Fixes lint failure: unused-parameter revive error

Author: SamMorrowDrums

cmd/github-mcp-server/generate_docs.go

@@ -190,7 +190,7 @@ func generateToolsDoc(r *inventory.Inventory) string {
 			currentToolsetID = tool.Toolset.ID
 			currentToolsetIcon = tool.Toolset.Icon
 		}
-		writeToolDoc(&toolBuf, tool.Tool, tool.Toolset.Icon)
+		writeToolDoc(&toolBuf, tool.Tool)
 		toolBuf.WriteString("\n\n")
 	}
 
@@ -224,7 +224,7 @@ func formatToolsetName(name string) string {
 	}
 }
 
-func writeToolDoc(buf *strings.Builder, tool mcp.Tool, icon string) {
+func writeToolDoc(buf *strings.Builder, tool mcp.Tool) {
 	// Tool name (no icon - section header already has the toolset icon)
 	fmt.Fprintf(buf, "- **%s** - %s\n", tool.Name, tool.Annotations.Title)
 

pkg/octicons/octicons_test.go

@@ -104,9 +104,9 @@ func TestThemeConstants(t *testing.T) {
 }
 
 func TestEmbeddedIconsExist(t *testing.T) {
-        // Test that all required icons from required_icons.txt are properly embedded
-        // This is the single source of truth for which icons should be available
-        expectedIcons := RequiredIcons()
+	// Test that all required icons from required_icons.txt are properly embedded
+	// This is the single source of truth for which icons should be available
+	expectedIcons := RequiredIcons()
 	for _, icon := range expectedIcons {
 		t.Run(icon, func(t *testing.T) {
 			lightURI := DataURI(icon, ThemeLight)