review: use UserWarning instead of DeprecationWarning

DeprecationWarning is suppressed by default in Python, so users relying
on the old SPECKIT_ALLOW_ALL_TOOLS env var would never see the
deprecation notice during normal CLI runs. Switch to UserWarning which
is always shown. Update test to also assert the warning category.

Author: mnriem

src/specify_cli/integrations/copilot/__init__.py

@@ -36,7 +36,7 @@ def _allow_all() -> bool:
         warnings.warn(
             "SPECKIT_ALLOW_ALL_TOOLS is deprecated; "
             "use SPECKIT_COPILOT_ALLOW_ALL_TOOLS instead.",
-            DeprecationWarning,
+            UserWarning,
             stacklevel=2,
         )
         return old_var != "0"

tests/test_workflows.py

@@ -396,7 +396,11 @@ def test_copilot_deprecated_env_var_still_honoured(self, monkeypatch):
             warnings.simplefilter("always")
             args = impl.build_exec_args("do stuff")
         assert "--yolo" not in args
-        assert any("SPECKIT_ALLOW_ALL_TOOLS is deprecated" in str(x.message) for x in w)
+        assert any(
+            "SPECKIT_ALLOW_ALL_TOOLS is deprecated" in str(x.message)
+            and issubclass(x.category, UserWarning)
+            for x in w
+        )
 
     def test_copilot_new_env_var_takes_precedence(self, monkeypatch):
         monkeypatch.setenv("SPECKIT_COPILOT_ALLOW_ALL_TOOLS", "1")