Gate validates string options, prompt uses resolved integration, loop normalizes max_iterations

Author: mnriem

src/specify_cli/workflows/engine.py

@@ -615,7 +615,9 @@ def _execute_steps(
                 if step_type in ("while", "do-while"):
                     from .expressions import evaluate_condition
 
-                    max_iters = step_config.get("max_iterations", 10)
+                    max_iters = step_config.get("max_iterations")
+                    if not isinstance(max_iters, int) or max_iters < 1:
+                        max_iters = 10
                     condition = step_config.get("condition", False)
                     for _loop_iter in range(max_iters - 1):
                         if not evaluate_condition(condition, context):

src/specify_cli/workflows/steps/gate/__init__.py

@@ -97,9 +97,13 @@ def validate(self, config: dict[str, Any]) -> list[str]:
                 f"Gate step {config.get('id', '?')!r} is missing 'message' field."
             )
         options = config.get("options", ["approve", "reject"])
-        if not isinstance(options, list):
+        if not isinstance(options, list) or not options:
             errors.append(
-                f"Gate step {config.get('id', '?')!r}: 'options' must be a list."
+                f"Gate step {config.get('id', '?')!r}: 'options' must be a non-empty list."
+            )
+        elif not all(isinstance(o, str) for o in options):
+            errors.append(
+                f"Gate step {config.get('id', '?')!r}: all options must be strings."
             )
         on_reject = config.get("on_reject", "abort")
         if on_reject not in ("abort", "skip", "retry"):

src/specify_cli/workflows/steps/prompt/__init__.py

@@ -89,7 +89,7 @@ def execute(self, config: dict[str, Any], context: StepContext) -> StepResult:
                 output=output,
                 error=(
                     f"Cannot dispatch prompt: "
-                    f"integration {config.get('integration') or context.default_integration!r} "
+                    f"integration {integration!r} "
                     f"CLI not found or not installed."
                 ),
             )