fix(kimi): reject symlinked target dir during legacy skills migration

When the migration destination already exists, guard against a symlinked
(or non-directory) target_dir before comparing SKILL.md bytes, so the
comparison never follows a link outside the project root. Also skip a
missing/non-file target SKILL.md explicitly.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: meymchen

src/specify_cli/integrations/kimi/__init__.py

@@ -276,23 +276,25 @@ def _migrate_legacy_kimi_skills_dir(
             continue
 
         # Target exists — only remove legacy if SKILL.md is identical.
-        # Skip when the target SKILL.md is a symlink so the byte comparison
-        # never follows it outside the project. (legacy_skill is already
-        # guaranteed to be a real file by the guard above.)
+        # Skip when the target dir or its SKILL.md is a symlink (or the dir is
+        # not a real directory) so the byte comparison never follows a link
+        # outside the project. (legacy_skill is already guaranteed to be a real
+        # file by the guard above.)
+        if target_dir.is_symlink() or not target_dir.is_dir():
+            continue
         target_skill = target_dir / "SKILL.md"
-        if target_skill.is_symlink():
+        if target_skill.is_symlink() or not target_skill.is_file():
             continue
-        if target_skill.is_file():
-            try:
-                if target_skill.read_bytes() == legacy_skill.read_bytes():
-                    has_extra = any(
-                        child.name != "SKILL.md" for child in legacy_dir.iterdir()
-                    )
-                    if not has_extra:
-                        shutil.rmtree(legacy_dir)
-                        removed_count += 1
-            except OSError:
-                pass
+        try:
+            if target_skill.read_bytes() == legacy_skill.read_bytes():
+                has_extra = any(
+                    child.name != "SKILL.md" for child in legacy_dir.iterdir()
+                )
+                if not has_extra:
+                    shutil.rmtree(legacy_dir)
+                    removed_count += 1
+        except OSError:
+            pass
 
     # Remove the legacy skills directory if it is now empty.
     try:

tests/integrations/test_integration_kimi.py

@@ -8,6 +8,7 @@
 from specify_cli.integrations.kimi import (
     _migrate_legacy_kimi_context_file,
     _migrate_legacy_kimi_dotted_skills,
+    _migrate_legacy_kimi_skills_dir,
 )
 from specify_cli.integrations.manifest import IntegrationManifest
 
@@ -492,6 +493,35 @@ def test_setup_rejects_symlinked_destination_before_writing(self, tmp_path):
         # Nothing was written into the unintended `./skills` location.
         assert not (project / "skills").exists()
 
+    def test_migrate_skips_symlinked_target_dir(self, tmp_path):
+        # The destination `.kimi-code/skills/speckit-foo` already exists but is
+        # a symlink to a directory outside the project. Migration compares
+        # SKILL.md bytes to decide whether to drop the legacy copy; it must not
+        # follow the symlinked target dir to read SKILL.md from outside.
+        outside = tmp_path / "outside"
+        outside.mkdir()
+        (outside / "SKILL.md").write_text("# shared\n")
+
+        project = tmp_path / "project"
+        legacy = project / ".kimi" / "skills" / "speckit-foo"
+        legacy.mkdir(parents=True)
+        # Identical bytes: without the symlink guard the legacy dir would be
+        # removed after following the link out of the project.
+        (legacy / "SKILL.md").write_text("# shared\n")
+
+        target = project / ".kimi-code" / "skills" / "speckit-foo"
+        target.parent.mkdir(parents=True)
+        _symlink_or_skip(target, outside, target_is_directory=True)
+
+        _migrate_legacy_kimi_skills_dir(
+            project / ".kimi" / "skills", project / ".kimi-code" / "skills"
+        )
+
+        # Legacy copy is preserved (migration refused to follow the symlink),
+        # and the outside target is untouched.
+        assert (legacy / "SKILL.md").exists()
+        assert (outside / "SKILL.md").exists()
+
     def test_context_migration_does_not_write_through_symlinked_agents_md(
         self, tmp_path
     ):