provide same creds to hooks call as to push

Author: extrawurst

asyncgit/src/sync/hooks.rs

@@ -48,6 +48,7 @@ pub fn advertised_remote_refs(
 	repo_path: &RepoPath,
 	remote: Option<&str>,
 	url: &str,
+	basic_credential: Option<crate::sync::cred::BasicAuthCredential>,
 ) -> Result<HashMap<String, Oid>> {
 	let repo = repo(repo_path)?;
 	let mut remote_handle = if let Some(name) = remote {
@@ -56,7 +57,7 @@ pub fn advertised_remote_refs(
 		repo.remote_anonymous(url)?
 	};
 
-	let callbacks = Callbacks::new(None, None);
+	let callbacks = Callbacks::new(None, basic_credential);
 	let conn = remote_handle.connect_auth(
 		Direction::Push,
 		Some(callbacks.callbacks()),
@@ -146,6 +147,7 @@ pub fn hooks_pre_push(
 	remote: Option<&str>,
 	url: &str,
 	push: &PrePushTarget<'_>,
+	basic_credential: Option<crate::sync::cred::BasicAuthCredential>,
 ) -> Result<HookResult> {
 	scope_time!("hooks_pre_push");
 
@@ -158,7 +160,12 @@ pub fn hooks_pre_push(
 		return Ok(HookResult::Ok);
 	}
 
-	let advertised = advertised_remote_refs(repo_path, remote, url)?;
+	let advertised = advertised_remote_refs(
+		repo_path,
+		remote,
+		url,
+		basic_credential,
+	)?;
 	let updates = match push {
 		PrePushTarget::Branch { branch, delete } => {
 			let remote_ref = branch_push_destination_ref(

asyncgit/src/sync/mod.rs

@@ -68,7 +68,7 @@ pub use git2::BranchType;
 pub use hooks::{
 	advertised_remote_refs, hooks_commit_msg, hooks_post_commit,
 	hooks_pre_commit, hooks_pre_push, hooks_prepare_commit_msg,
-	HookResult, PrePushRef, PrePushTarget, PrepareCommitMsgSource,
+	HookResult, PrePushTarget, PrepareCommitMsgSource,
 };
 pub use hunks::{reset_hunk, stage_hunk, unstage_hunk};
 pub use ignore::add_to_ignore;

src/popups/push.rs

@@ -171,6 +171,7 @@ impl PushPopup {
 				branch: &self.branch,
 				delete: self.modifier.delete(),
 			},
+			cred.clone(),
 		)? {
 			log::error!("pre-push hook failed: {e}");
 			self.queue.push(InternalEvent::ShowErrorMsg(format!(

src/popups/push_tags.rs

@@ -110,6 +110,7 @@ impl PushTagsPopup {
 			Some(&remote),
 			&remote_url,
 			&asyncgit::sync::PrePushTarget::Tags,
+			cred.clone(),
 		)? {
 			log::error!("pre-push hook failed: {e}");
 			self.queue.push(InternalEvent::ShowErrorMsg(format!(