Skip to content

Conversation

@AdrienClairembault
Copy link
Contributor

@AdrienClairembault AdrienClairembault commented Dec 3, 2025

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.

Description

The helpdesk use some kind of fuzzy matching to find items:

image_paste6210464

Here it matched "Server" to "Service" and considered it to be a valid search result.

However, this system is IMO not good enough as it returns results that are too different (even a simple case like the screenshot above can be confusing, see the internal support for more examples).

This is because it rely on the levenstein php function, which is not the most powerful tool for this. Maybe we should use a dedicated PHP package that contains a stronger algorithm.

For now I propose to disable it, it is far from an important feature and most users probably don't even know it exist.
We'll redo it later when we have more time.

References

Internal support ticket: !40767 !40844

@trasher

This comment was marked as outdated.

Copy link
Member

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this proposal would improve the user experience. Indeed, of all the colleagues I have had since I started developing, at least a good third had problems with spelling and/or conjugation. A fuzzy match can help a lot in this case, as it will propose matching terms even when they are misspelled.

@cedric-anne cedric-anne requested a review from orthagh December 4, 2025 14:35
@cconard96
Copy link
Contributor

I am not sure this proposal would improve the user experience. Indeed, of all the colleagues I have had since I started developing, at least a good third had problems with spelling and/or conjugation.

I agree. The fuzzy search is a net-positive. If it isn't done already, sorting by score so the most relevant results are higher in the list would reduce the issue of "too different" results being returned.

@AdrienClairembault
Copy link
Contributor Author

The idea was to disable it for now as I don't think the current implementation is good enough and rewrite it later (because I am overloaded with subjects on my end so not much time for this :/).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants