Disable fuzzy matcher for helpdesk searches #22204
Open
+38
−35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
The helpdesk use some kind of fuzzy matching to find items:
Here it matched "Server" to "Service" and considered it to be a valid search result.
However, this system is IMO not good enough as it returns results that are too different (even a simple case like the screenshot above can be confusing, see the internal support for more examples).
This is because it rely on the levenstein php function, which is not the most powerful tool for this. Maybe we should use a dedicated PHP package that contains a stronger algorithm.
For now I propose to disable it, it is far from an important feature and most users probably don't even know it exist.
We'll redo it later when we have more time.
References
Internal support ticket: !40767 !40844