-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Labels
cleanupPRs that don't add new functionality but clean or improve the codebasePRs that don't add new functionality but clean or improve the codebase
Description
Nice catch!
rust-lang/futures-rs#1691 has a proposal on how this could be worked around (by wrapping the actual BoxFuture in a struct and marking it must_use).
I'd be in favour of using such a type in our codebase wherever we return BoxFuture as these bugs can be really nasty to find (not caught by unit tests) and I really like the rust compiler warnings in these cases.
Metadata
Metadata
Assignees
Labels
cleanupPRs that don't add new functionality but clean or improve the codebasePRs that don't add new functionality but clean or improve the codebase