add error log for unsupported charset

wxiaoguang · wxiaoguang · commit b294923e5f21 · 2025-12-13T19:47:05.000+08:00
diff --git a/modules/charset/charset.go b/modules/charset/charset.go
@@ -74,7 +74,7 @@ func ToUTF8(content []byte, opts ConvertOpts) []byte {
 
 	encoding, _ := charset.Lookup(charsetLabel)
 	if encoding == nil {
-		setting.PanicInDevOrTesting("unknown detected charset %q, it shouldn't happen", charsetLabel)
+		setting.PanicInDevOrTesting("unsupported detected charset %q, it shouldn't happen", charsetLabel)
 		return content
 	}
 
diff --git a/modules/setting/setting.go b/modules/setting/setting.go
@@ -240,4 +240,5 @@ func PanicInDevOrTesting(msg string, a ...any) {
 	if !IsProd || IsInTesting {
 		panic(fmt.Sprintf(msg, a...))
 	}
+	log.Error(msg, a...)
 }

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ func ToUTF8(content []byte, opts ConvertOpts) []byte {`
`74`	`74`
`75`	`75`	`encoding, _ := charset.Lookup(charsetLabel)`
`76`	`76`	`if encoding == nil {`
`77`		`- setting.PanicInDevOrTesting("unknown detected charset %q, it shouldn't happen", charsetLabel)`
	`77`	`+ setting.PanicInDevOrTesting("unsupported detected charset %q, it shouldn't happen", charsetLabel)`
`78`	`78`	`return content`
`79`	`79`	`}`
`80`	`80`
Original file line number	Diff line number	Diff line change
`@@ -240,4 +240,5 @@ func PanicInDevOrTesting(msg string, a ...any) {`
`240`	`240`	`if !IsProd \|\| IsInTesting {`
`241`	`241`	`panic(fmt.Sprintf(msg, a...))`
`242`	`242`	`}`
	`243`	`+ log.Error(msg, a...)`
`243`	`244`	`}`