temp

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>

Author: fredbi

pointer.go

@@ -28,13 +28,13 @@ var (
 // JSONPointable is an interface for structs to implement when they need to customize the
 // json pointer process
 type JSONPointable interface {
-	JSONLookup(string) (any, error)
+	JSONLookup(key string) (any, error)
 }
 
 // JSONSetable is an interface for structs to implement when they need to customize the
 // json pointer process
 type JSONSetable interface {
-	JSONSet(string, any) error
+	JSONSet(key string, value any) error
 }
 
 // Pointer is a representation of a json pointer
@@ -185,7 +185,6 @@ func (p *Pointer) set(node, data any, nameProvider *jsonname.NameProvider) error
 		decodedToken := Unescape(token)
 
 		if isLastToken {
-
 			return setSingleImpl(node, data, decodedToken, nameProvider)
 		}
 
@@ -198,10 +197,15 @@ func (p *Pointer) set(node, data any, nameProvider *jsonname.NameProvider) error
 		kind := rValue.Kind()
 
 		if rValue.Type().Implements(jsonPointableType) {
-			r, err := node.(JSONPointable).JSONLookup(decodedToken)
+			pointable, ok := node.(JSONPointable)
+			if !ok {
+				panic(fmt.Errorf("internal error: expected a JSONPointable but got %T: %w", node, ErrPointer))
+			}
+			r, err := pointable.JSONLookup(decodedToken)
 			if err != nil {
 				return err
 			}
+
 			fld := reflect.ValueOf(r)
 			if fld.CanAddr() && fld.Kind() != reflect.Interface && fld.Kind() != reflect.Map && fld.Kind() != reflect.Slice && fld.Kind() != reflect.Pointer {
 				node = fld.Addr().Interface()
@@ -353,7 +357,12 @@ func setSingleImpl(node, data any, decodedToken string, nameProvider *jsonname.N
 	}
 
 	if rValue.Type().Implements(jsonSetableType) {
-		return node.(JSONSetable).JSONSet(decodedToken, data)
+		setable, ok := node.(JSONSetable)
+		if !ok {
+			panic(fmt.Errorf("internal error: expected a JSONPointable but got %T: %w", node, ErrPointer))
+		}
+
+		return setable.JSONSet(decodedToken, data)
 	}
 
 	switch rValue.Kind() { //nolint:exhaustive

pointer_test.go

@@ -6,6 +6,7 @@ package jsonpointer
 import (
 	"encoding/json"
 	"fmt"
+	"os"
 	"strconv"
 	"testing"
 
@@ -31,7 +32,11 @@ const (
 }`
 )
 
-var testDocumentJSON any
+var (
+	testDocumentJSON  any
+	testStructJSONDoc testStructJSON
+	testStructJSONPtr *testStructJSON
+)
 
 type testStructJSON struct {
 	Foo []string `json:"foo"`
@@ -48,18 +53,26 @@ type testStructJSON struct {
 
 type aliasedMap map[string]any
 
-var testStructJSONDoc testStructJSON
-var testStructJSONPtr *testStructJSON
+func TestMain(m *testing.M) {
+	// initializations to run tests in this package
+	if err := initTestDocument(); err != nil {
+		panic(err)
+	}
+
+	os.Exit(m.Run())
+}
 
-func init() {
+func initTestDocument() error {
 	if err := json.Unmarshal([]byte(TestDocumentString), &testDocumentJSON); err != nil {
-		panic(err)
+		return err
 	}
 	if err := json.Unmarshal([]byte(TestDocumentString), &testStructJSONDoc); err != nil {
-		panic(err)
+		return err
 	}
 
 	testStructJSONPtr = &testStructJSONDoc
+
+	return nil
 }
 
 func TestEscaping(t *testing.T) {
@@ -83,19 +96,24 @@ func TestFullDocument(t *testing.T) {
 	p, err := New(in)
 	require.NoErrorf(t, err, "New(%v) error %v", in, err)
 
-	result, _, err := p.Get(testDocumentJSON)
-	require.NoErrorf(t, err, "Get(%v) error %v", in, err)
+	t.Run("should resolve doc", func(t *testing.T) {
+		result, _, err := p.Get(testDocumentJSON)
+		require.NoErrorf(t, err, "Get(%v) error %v", in, err)
 
-	asMap, ok := result.(map[string]any)
-	require.True(t, ok)
-	require.Lenf(t, asMap, TestDocumentNBItems, "Get(%v) = %v, expect full document", in, result)
+		asMap, ok := result.(map[string]any)
+		require.True(t, ok)
+
+		require.Lenf(t, asMap, TestDocumentNBItems, "Get(%v) = %v, expect full document", in, result)
+	})
 
-	result, _, err = p.get(testDocumentJSON, nil)
-	require.NoErrorf(t, err, "Get(%v) error %v", in, err)
+	t.Run("should resolve doc, with nil name provider", func(t *testing.T) {
+		result, _, err := p.get(testDocumentJSON, nil)
+		require.NoErrorf(t, err, "Get(%v) error %v", in, err)
 
-	asMap, ok = result.(map[string]any)
-	require.True(t, ok)
-	require.Lenf(t, asMap, TestDocumentNBItems, "Get(%v) = %v, expect full document", in, result)
+		asMap, ok := result.(map[string]any)
+		require.True(t, ok)
+		require.Lenf(t, asMap, TestDocumentNBItems, "Get(%v) = %v, expect full document", in, result)
+	})
 }
 
 func TestDecodedTokens(t *testing.T) {
@@ -227,7 +245,10 @@ func TestGetNode(t *testing.T) {
 	require.NoError(t, err)
 	assert.Len(t, result, TestNodeObjNBItems)
 
-	result, _, err = p.Get(aliasedMap(testDocumentJSON.(map[string]any)))
+	asMap, ok := testDocumentJSON.(map[string]any)
+	require.True(t, ok)
+
+	result, _, err = p.Get(aliasedMap(asMap))
 	require.NoError(t, err)
 	assert.Len(t, result, TestNodeObjNBItems)
 
@@ -301,9 +322,19 @@ func TestOtherThings(t *testing.T) {
 
 	p, err = New("/foo/1")
 	require.NoError(t, err)
-	expected := "hello"
-	bbb := testDocumentJSON.(map[string]any)["foo"]
-	bbb.([]any)[1] = "hello"
+
+	const expected = "hello"
+
+	asMap, ok := testDocumentJSON.(map[string]any)
+	require.True(t, ok)
+
+	bbb, ok := asMap["foo"]
+	require.True(t, ok)
+
+	asArray, ok := bbb.([]any)
+	require.True(t, ok)
+
+	asArray[1] = expected
 
 	v, _, err := p.Get(testDocumentJSON)
 	require.NoError(t, err)
@@ -513,7 +544,9 @@ func TestSetNode(t *testing.T) {
 		chNodeVI := changedNode["c"]
 
 		require.IsType(t, 0, chNodeVI)
-		changedNodeValue := chNodeVI.(int)
+		changedNodeValue, ok := chNodeVI.(int)
+		require.True(t, ok)
+
 		require.Equal(t, 999, changedNodeValue)
 		assert.Len(t, sliceNode, 1)
 	})