[gopls-release-branch.0.6] all: merge master into gopls-release-branch.0.6

fe37c9e all: replace all usages of os/exec with golang.org/x/sys/execabs
a46736d internal/lsp/source: handle possible nil pointer in rename check
e0d2015 gopls/doc: rewrite troubleshooting.md
d78b04b gopls/doc: clean up and slightly reorganize documentation
1bdb73f gopls/doc: move contents of golang/go#36899 to documentation
f964368 gopls/internal/regtest: fix synchronization for TestUseGoplsMod
8b4aab6 gopls/doc/vscode.md: update vscode setting example

Change-Id: Iec71457cdff70ef15b77cf4193a0006f5ca47c01

Author: stamblerre

cmd/auth/authtest/authtest.go

@@ -18,13 +18,13 @@ import (
 	"bytes"
 	"flag"
 	"fmt"
+	exec "golang.org/x/sys/execabs"
 	"io"
 	"log"
 	"net/http"
 	"net/textproto"
 	"net/url"
 	"os"
-	"os/exec"
 	"path/filepath"
 	"strings"
 )

cmd/auth/gitauth/gitauth.go

@@ -16,11 +16,11 @@ package main
 import (
 	"bytes"
 	"fmt"
+	exec "golang.org/x/sys/execabs"
 	"log"
 	"net/http"
 	"net/url"
 	"os"
-	"os/exec"
 	"path/filepath"
 	"strings"
 )

cmd/compilebench/main.go

@@ -82,10 +82,10 @@ import (
 	"encoding/json"
 	"flag"
 	"fmt"
+	exec "golang.org/x/sys/execabs"
 	"io/ioutil"
 	"log"
 	"os"
-	"os/exec"
 	"path/filepath"
 	"regexp"
 	"strconv"

cmd/cover/html.go

@@ -8,12 +8,12 @@ import (
 	"bufio"
 	"bytes"
 	"fmt"
+	exec "golang.org/x/sys/execabs"
 	"html/template"
 	"io"
 	"io/ioutil"
 	"math"
 	"os"
-	"os/exec"
 	"path/filepath"
 	"runtime"
 

cmd/eg/eg.go

@@ -14,8 +14,8 @@ import (
 	"go/format"
 	"go/parser"
 	"go/token"
+	exec "golang.org/x/sys/execabs"
 	"os"
-	"os/exec"
 	"strings"
 
 	"golang.org/x/tools/go/buildutil"

cmd/fiximports/main.go

@@ -79,11 +79,11 @@ import (
 	"go/format"
 	"go/parser"
 	"go/token"
+	exec "golang.org/x/sys/execabs"
 	"io"
 	"io/ioutil"
 	"log"
 	"os"
-	"os/exec"
 	"path"
 	"path/filepath"
 	"sort"

cmd/getgo/main.go

@@ -13,8 +13,8 @@ import (
 	"errors"
 	"flag"
 	"fmt"
+	exec "golang.org/x/sys/execabs"
 	"os"
-	"os/exec"
 	"strings"
 )
 

cmd/getgo/system.go

@@ -9,7 +9,7 @@ package main
 import (
 	"bytes"
 	"context"
-	"os/exec"
+	exec "golang.org/x/sys/execabs"
 	"runtime"
 	"strings"
 )

cmd/go-contrib-init/contrib.go

@@ -13,10 +13,10 @@ import (
 	"flag"
 	"fmt"
 	"go/build"
+	exec "golang.org/x/sys/execabs"
 	"io/ioutil"
 	"log"
 	"os"
-	"os/exec"
 	"path/filepath"
 	"regexp"
 	"runtime"

cmd/godoc/goroot.go

@@ -5,8 +5,8 @@
 package main
 
 import (
+	exec "golang.org/x/sys/execabs"
 	"os"
-	"os/exec"
 	"path/filepath"
 	"runtime"
 	"strings"