Add new filen linter

Author: DanilXO

.golangci.next.reference.yml

@@ -39,6 +39,7 @@ linters:
     - forbidigo
     - forcetypeassert
     - funlen
+    - filen
     - gci
     - ginkgolinter
     - gocheckcompilerdirectives
@@ -155,6 +156,7 @@ linters:
     - forbidigo
     - forcetypeassert
     - funlen
+    - filen
     - gci
     - ginkgolinter
     - gocheckcompilerdirectives
@@ -577,6 +579,17 @@ linters-settings:
     # Default false
     ignore-comments: true
 
+  filen:
+    # Min number of lines in a file setting
+    # Default: 5
+    min-lines-num: 5
+    # Max number of lines in a file setting
+    # Default: 5
+    max-lines-num: 500
+    # Ignore comments when counting lines.
+    # Default false
+    ignore-comments: false
+
   gci:
     # Section configuration to compare against.
     # Section names are case-insensitive and may contain parameters in ().

.golangci.yml

@@ -25,6 +25,7 @@ linters:
     - errcheck
     - errorlint
     - funlen
+    - filen
     - gocheckcompilerdirectives
     - gochecknoinits
     - gochecknoinits
@@ -76,6 +77,10 @@ linters-settings:
   funlen:
     lines: -1 # the number of lines (code + empty lines) is not a right metric and leads to code without empty line or one-liner.
     statements: 50
+  filen:
+    min-lines-num: 5
+    max-lines-num: 500
+    ignore-comments: false
   goconst:
     min-len: 2
     min-occurrences: 3

go.mod

@@ -1,6 +1,6 @@
 module github.com/golangci/golangci-lint
 
-go 1.22.1
+go 1.23.2
 
 require (
 	4d63.com/gocheckcompilerdirectives v1.2.1
@@ -12,6 +12,7 @@ require (
 	github.com/Antonboom/testifylint v1.5.0
 	github.com/BurntSushi/toml v1.4.1-0.20240526193622-a339e1f7089c
 	github.com/Crocmagnon/fatcontext v0.5.2
+	github.com/DanilXO/filen v0.0.2
 	github.com/Djarvur/go-err113 v0.0.0-20210108212216-aea10b59be24
 	github.com/GaijinEntertainment/go-exhaustruct/v3 v3.3.0
 	github.com/OpenPeeDeeP/depguard/v2 v2.2.0

go.sum

@@ -197,6 +197,11 @@ var defaultLintersSettings = LintersSettings{
 		ErrorVariableNames:               []string{"err"},
 		ForceExclusiveShortDeclarations:  false,
 	},
+	Filen: FilenSettings{
+		MinLinesNum:    5,
+		MaxLinesNum:    500,
+		IgnoreComments: false,
+	},
 }
 
 type LintersSettings struct {
@@ -282,6 +287,7 @@ type LintersSettings struct {
 	Whitespace      WhitespaceSettings
 	Wrapcheck       WrapcheckSettings
 	WSL             WSLSettings
+	Filen           FilenSettings
 
 	Custom map[string]CustomLinterSettings
 }
@@ -1013,6 +1019,12 @@ type WSLSettings struct {
 	ForceExclusiveShortDeclarations  bool     `mapstructure:"force-short-decl-cuddling"`
 }
 
+type FilenSettings struct {
+	MaxLinesNum    int  `mapstructure:"min-lines-num"`
+	MinLinesNum    int  `mapstructure:"max-lines-num"`
+	IgnoreComments bool `mapstructure:"ignore-comments"`
+}
+
 // CustomLinterSettings encapsulates the meta-data of a private linter.
 type CustomLinterSettings struct {
 	// Type plugin type.

pkg/config/linters_settings.go

@@ -0,0 +1,23 @@
+package filen
+
+import (
+	"github.com/DanilXO/filen/pgk/filen"
+	"github.com/golangci/golangci-lint/pkg/config"
+	"github.com/golangci/golangci-lint/pkg/goanalysis"
+	"golang.org/x/tools/go/analysis"
+)
+
+func New(settings *config.FilenSettings) *goanalysis.Linter {
+	a := filen.NewAnalyzer(&filen.Runner{
+		MaxLinesNum:    settings.MaxLinesNum,
+		MinLinesNum:    settings.MinLinesNum,
+		IgnoreComments: settings.IgnoreComments,
+	})
+
+	return goanalysis.NewLinter(
+		a.Name,
+		a.Doc,
+		[]*analysis.Analyzer{a},
+		nil,
+	).WithLoadMode(goanalysis.LoadModeTypesInfo)
+}

pkg/golinters/filen/filen.go

@@ -0,0 +1,10 @@
+package filen
+
+import (
+	"github.com/golangci/golangci-lint/test/testshared/integration"
+	"testing"
+)
+
+func TestFromTestdata(t *testing.T) {
+	integration.RunTestdata(t)
+}

pkg/golinters/filen/filen_test.go

@@ -0,0 +1,32 @@
+// Package samples - is the code for functional tests
+package samples
+
+// foo - is test function
+func foo() string {
+	return "bar"
+}
+
+// foo1 - is test function
+func foo1() string {
+	return "bar1"
+}
+
+// foo2 - is test function
+func foo2() string {
+	return "bar2"
+}
+
+// foo3 - is test function
+func foo3() string {
+	return "bar3"
+}
+
+// foo4 - is test function
+func foo4() string {
+	return "bar4"
+}
+
+// foo5 - is test function
+func foo5() string {
+	return "bar5"
+}

pkg/golinters/filen/testdata/filen.go

@@ -28,6 +28,7 @@ import (
 	"github.com/golangci/golangci-lint/pkg/golinters/exhaustruct"
 	"github.com/golangci/golangci-lint/pkg/golinters/exportloopref"
 	"github.com/golangci/golangci-lint/pkg/golinters/fatcontext"
+	"github.com/golangci/golangci-lint/pkg/golinters/filen"
 	"github.com/golangci/golangci-lint/pkg/golinters/forbidigo"
 	"github.com/golangci/golangci-lint/pkg/golinters/forcetypeassert"
 	"github.com/golangci/golangci-lint/pkg/golinters/funlen"
@@ -853,5 +854,11 @@ func (LinterBuilder) Build(cfg *config.Config) ([]*linter.Config, error) {
 			WithPresets(linter.PresetStyle).
 			WithAutoFix().
 			WithURL("https://github.com/golangci/golangci-lint/tree/master/pkg/golinters/nolintlint/internal"),
+
+		linter.NewConfig(filen.New(&cfg.LintersSettings.Filen)).
+			WithSince("v1.62.0").
+			WithPresets(linter.PresetComplexity).
+			WithLoadForGoAnalysis().
+			WithURL("https://github.com/DanilXO/filen"),
 	}, nil
 }