Rename things + docs

Author: Androbin

app/actions.py

@@ -213,21 +213,21 @@ def bookmarkRemove(self):
     upperRow, _, lowerRow, _ = self.startAndEnd()
     return self.bookmarkRemoveFrom(upperRow, lowerRow)
 
-  def bookmarkRemoveFrom(self, upperRow, lowerRow):
+  def bookmarkRemoveFrom(self, startRow, endRow):
     """
     Removes bookmarks in the given line interval.
 
     Args:
-      upperRow: The upper line limit, inclusive.
-      lowerRow: The lower line limit, inclusive.
+      startRow: The start of the line interval, inclusive.
+      endRow: The end of the line interval, inclusive.
 
     Returns:
       (boolean) Whether any bookmarks were removed.
     """
-    if upperRow > lowerRow:
+    if startRow > endRow:
       return False
     rangeList = self.bookmarks
-    needle = app.bookmark.Bookmark(upperRow, lowerRow)
+    needle = app.bookmark.Bookmark(startRow, endRow)
     # Find the left-hand index.
     begin = bisect.bisect_left(rangeList, needle)
     if begin and needle.begin <= rangeList[begin - 1].end:
@@ -253,33 +253,33 @@ def bookmarkRemoveFrom(self, upperRow, lowerRow):
     self.bookmarks = rangeList[:begin] + rangeList[index:]
     return True
 
-  def bookmarkMove(self, upper, delta):
+  def bookmarkMove(self, startRow, delta):
     """
     Moves bookmarks up and down.
     Called after changes to line numbers.
 
     Args:
-      upper (int): The upper limit on current bookmark positions.
+      startRow (int): The upper limit on the bookmarks boundaries to move.
       delta (int): The number of rows to move.
 
     Returns:
       None.
     """
-    begin = max(bisect.bisect_left(self.bookmarks, ((upper, upper),)) - 1, 0)
+    begin = max(bisect.bisect_left(self.bookmarks, ((startRow, startRow),)) - 1, 0)
 
     # TODO(Androbin, aaxu): defer changes outside the screen
     for index in range(begin, len(self.bookmarks)):
       bookmark = self.bookmarks[index]
       markRange, data = bookmark
 
-      if markRange[0] > upper:
+      if markRange[0] > startRow:
         markRange = (markRange[0] + delta, markRange[1] + delta)
-      elif markRange[1] >= upper:
+      elif markRange[1] >= startRow:
         markRange = (markRange[0], markRange[1] + delta)
 
       for key in ['cursor', 'marker', 'pen']:
         value = data[key]
-        if value[0] >= upper:
+        if value[0] >= startRow:
           data[key] = (value[0] + delta, value[1])
 
       bookmark = (markRange, data)