From 86041e0c27fb221b45633cf9ee7097f0df413978 Mon Sep 17 00:00:00 2001 From: Carlos Date: Wed, 25 Mar 2026 23:46:32 +0000 Subject: [PATCH] Fix browser tests by importing the shared tests instead of exporting Previously we called 'export' to append main() into the test file. Dart Test package 1.29.0 now disallows this pattern. TIL that the test package is released separate from the main Dart binary! Fixes #195 --- browser_library_test/package-lock.json | 2 +- browser_library_test/test/esbuild_import_test.dart | 6 +++++- browser_library_test/test/esbuild_require_test.dart | 6 +++++- browser_library_test/test/jspm_test.dart | 6 +++++- browser_library_test/test/rollup_import_test.dart | 6 +++++- browser_library_test/test/rollup_require_test.dart | 6 +++++- browser_library_test/test/vite_test.dart | 6 +++++- browser_library_test/test/webpack_import_test.dart | 6 +++++- browser_library_test/test/webpack_require_test.dart | 6 +++++- 9 files changed, 41 insertions(+), 9 deletions(-) diff --git a/browser_library_test/package-lock.json b/browser_library_test/package-lock.json index ace8df5..66467cf 100644 --- a/browser_library_test/package-lock.json +++ b/browser_library_test/package-lock.json @@ -25,7 +25,7 @@ }, "build/npm": { "name": "cli-pkg-test", - "version": "0.0.1", + "version": "0.0.0", "dev": true, "dependencies": { "immutable": "^4.2.0", diff --git a/browser_library_test/test/esbuild_import_test.dart b/browser_library_test/test/esbuild_import_test.dart index 0b6b55a..81449e9 100644 --- a/browser_library_test/test/esbuild_import_test.dart +++ b/browser_library_test/test/esbuild_import_test.dart @@ -17,4 +17,8 @@ library; import 'package:test/test.dart'; -export 'browser_test_shared.dart'; +import 'browser_test_shared.dart' as shared_browser_tests; + +void main() { + shared_browser_tests.main(); +} diff --git a/browser_library_test/test/esbuild_require_test.dart b/browser_library_test/test/esbuild_require_test.dart index 0b6b55a..81449e9 100644 --- a/browser_library_test/test/esbuild_require_test.dart +++ b/browser_library_test/test/esbuild_require_test.dart @@ -17,4 +17,8 @@ library; import 'package:test/test.dart'; -export 'browser_test_shared.dart'; +import 'browser_test_shared.dart' as shared_browser_tests; + +void main() { + shared_browser_tests.main(); +} diff --git a/browser_library_test/test/jspm_test.dart b/browser_library_test/test/jspm_test.dart index c637222..8feb656 100644 --- a/browser_library_test/test/jspm_test.dart +++ b/browser_library_test/test/jspm_test.dart @@ -17,4 +17,8 @@ library; import 'package:test/test.dart'; -export 'browser_test_shared.dart'; +import 'browser_test_shared.dart' as shared_browser_tests; + +void main() { + shared_browser_tests.main(); +} diff --git a/browser_library_test/test/rollup_import_test.dart b/browser_library_test/test/rollup_import_test.dart index 0b6b55a..81449e9 100644 --- a/browser_library_test/test/rollup_import_test.dart +++ b/browser_library_test/test/rollup_import_test.dart @@ -17,4 +17,8 @@ library; import 'package:test/test.dart'; -export 'browser_test_shared.dart'; +import 'browser_test_shared.dart' as shared_browser_tests; + +void main() { + shared_browser_tests.main(); +} diff --git a/browser_library_test/test/rollup_require_test.dart b/browser_library_test/test/rollup_require_test.dart index 0b6b55a..81449e9 100644 --- a/browser_library_test/test/rollup_require_test.dart +++ b/browser_library_test/test/rollup_require_test.dart @@ -17,4 +17,8 @@ library; import 'package:test/test.dart'; -export 'browser_test_shared.dart'; +import 'browser_test_shared.dart' as shared_browser_tests; + +void main() { + shared_browser_tests.main(); +} diff --git a/browser_library_test/test/vite_test.dart b/browser_library_test/test/vite_test.dart index c637222..8feb656 100644 --- a/browser_library_test/test/vite_test.dart +++ b/browser_library_test/test/vite_test.dart @@ -17,4 +17,8 @@ library; import 'package:test/test.dart'; -export 'browser_test_shared.dart'; +import 'browser_test_shared.dart' as shared_browser_tests; + +void main() { + shared_browser_tests.main(); +} diff --git a/browser_library_test/test/webpack_import_test.dart b/browser_library_test/test/webpack_import_test.dart index 0b6b55a..81449e9 100644 --- a/browser_library_test/test/webpack_import_test.dart +++ b/browser_library_test/test/webpack_import_test.dart @@ -17,4 +17,8 @@ library; import 'package:test/test.dart'; -export 'browser_test_shared.dart'; +import 'browser_test_shared.dart' as shared_browser_tests; + +void main() { + shared_browser_tests.main(); +} diff --git a/browser_library_test/test/webpack_require_test.dart b/browser_library_test/test/webpack_require_test.dart index 0b6b55a..81449e9 100644 --- a/browser_library_test/test/webpack_require_test.dart +++ b/browser_library_test/test/webpack_require_test.dart @@ -17,4 +17,8 @@ library; import 'package:test/test.dart'; -export 'browser_test_shared.dart'; +import 'browser_test_shared.dart' as shared_browser_tests; + +void main() { + shared_browser_tests.main(); +}