Skip to content

Commit dda48d0

Browse files
brackendawsonbrackendawson
authored
Revert "Remove graduated GitHub v3 API preview header (#1636)" (#2301)
This reverts commit 76c3c3d.
1 parent 77b2d75 commit dda48d0

File tree

3 files changed

+36
-11
lines changed

3 files changed

+36
-11
lines changed

‎github/checks.go‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,8 @@ func (s *ChecksService) GetCheckRun(ctx context.Context, owner, repo string, che
106106
return nil, nil, err
107107
}
108108

109+
req.Header.Set("Accept", mediaTypeCheckRunsPreview)
110+
109111
checkRun := new(CheckRun)
110112
resp, err := s.client.Do(ctx, req, checkRun)
111113
if err != nil {
@@ -125,6 +127,8 @@ func (s *ChecksService) GetCheckSuite(ctx context.Context, owner, repo string, c
125127
return nil, nil, err
126128
}
127129

130+
req.Header.Set("Accept", mediaTypeCheckRunsPreview)
131+
128132
checkSuite := new(CheckSuite)
129133
resp, err := s.client.Do(ctx, req, checkSuite)
130134
if err != nil {
@@ -165,6 +169,8 @@ func (s *ChecksService) CreateCheckRun(ctx context.Context, owner, repo string,
165169
return nil, nil, err
166170
}
167171

172+
req.Header.Set("Accept", mediaTypeCheckRunsPreview)
173+
168174
checkRun := new(CheckRun)
169175
resp, err := s.client.Do(ctx, req, checkRun)
170176
if err != nil {
@@ -196,6 +202,8 @@ func (s *ChecksService) UpdateCheckRun(ctx context.Context, owner, repo string,
196202
return nil, nil, err
197203
}
198204

205+
req.Header.Set("Accept", mediaTypeCheckRunsPreview)
206+
199207
checkRun := new(CheckRun)
200208
resp, err := s.client.Do(ctx, req, checkRun)
201209
if err != nil {
@@ -220,6 +228,8 @@ func (s *ChecksService) ListCheckRunAnnotations(ctx context.Context, owner, repo
220228
return nil, nil, err
221229
}
222230

231+
req.Header.Set("Accept", mediaTypeCheckRunsPreview)
232+
223233
var checkRunAnnotations []*CheckRunAnnotation
224234
resp, err := s.client.Do(ctx, req, &checkRunAnnotations)
225235
if err != nil {
@@ -260,6 +270,8 @@ func (s *ChecksService) ListCheckRunsForRef(ctx context.Context, owner, repo, re
260270
return nil, nil, err
261271
}
262272

273+
req.Header.Set("Accept", mediaTypeCheckRunsPreview)
274+
263275
var checkRunResults *ListCheckRunsResults
264276
resp, err := s.client.Do(ctx, req, &checkRunResults)
265277
if err != nil {
@@ -284,6 +296,8 @@ func (s *ChecksService) ListCheckRunsCheckSuite(ctx context.Context, owner, repo
284296
return nil, nil, err
285297
}
286298

299+
req.Header.Set("Accept", mediaTypeCheckRunsPreview)
300+
287301
var checkRunResults *ListCheckRunsResults
288302
resp, err := s.client.Do(ctx, req, &checkRunResults)
289303
if err != nil {
@@ -322,6 +336,8 @@ func (s *ChecksService) ListCheckSuitesForRef(ctx context.Context, owner, repo,
322336
return nil, nil, err
323337
}
324338

339+
req.Header.Set("Accept", mediaTypeCheckRunsPreview)
340+
325341
var checkSuiteResults *ListCheckSuiteResults
326342
resp, err := s.client.Do(ctx, req, &checkSuiteResults)
327343
if err != nil {
@@ -363,6 +379,8 @@ func (s *ChecksService) SetCheckSuitePreferences(ctx context.Context, owner, rep
363379
return nil, nil, err
364380
}
365381

382+
req.Header.Set("Accept", mediaTypeCheckRunsPreview)
383+
366384
var checkSuitePrefResults *CheckSuitePreferenceResults
367385
resp, err := s.client.Do(ctx, req, &checkSuitePrefResults)
368386
if err != nil {
@@ -388,6 +406,8 @@ func (s *ChecksService) CreateCheckSuite(ctx context.Context, owner, repo string
388406
return nil, nil, err
389407
}
390408

409+
req.Header.Set("Accept", mediaTypeCheckRunsPreview)
410+
391411
checkSuite := new(CheckSuite)
392412
resp, err := s.client.Do(ctx, req, checkSuite)
393413
if err != nil {
@@ -408,6 +428,8 @@ func (s *ChecksService) ReRequestCheckSuite(ctx context.Context, owner, repo str
408428
return nil, err
409429
}
410430

431+
req.Header.Set("Accept", mediaTypeCheckRunsPreview)
432+
411433
resp, err := s.client.Do(ctx, req, nil)
412434
return resp, err
413435
}

‎github/checks_test.go‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ func TestChecksService_GetCheckRun(t *testing.T) {
2121

2222
mux.HandleFunc("/repos/o/r/check-runs/1", func(w http.ResponseWriter, r *http.Request) {
2323
testMethod(t, r, "GET")
24-
24+
testHeader(t, r, "Accept", mediaTypeCheckRunsPreview)
2525
fmt.Fprint(w, `{
2626
"id": 1,
2727
"name":"testCheckRun",
@@ -71,7 +71,7 @@ func TestChecksService_GetCheckSuite(t *testing.T) {
7171

7272
mux.HandleFunc("/repos/o/r/check-suites/1", func(w http.ResponseWriter, r *http.Request) {
7373
testMethod(t, r, "GET")
74-
74+
testHeader(t, r, "Accept", mediaTypeCheckRunsPreview)
7575
fmt.Fprint(w, `{
7676
"id": 1,
7777
"head_branch":"master",
@@ -120,7 +120,7 @@ func TestChecksService_CreateCheckRun(t *testing.T) {
120120

121121
mux.HandleFunc("/repos/o/r/check-runs", func(w http.ResponseWriter, r *http.Request) {
122122
testMethod(t, r, "POST")
123-
123+
testHeader(t, r, "Accept", mediaTypeCheckRunsPreview)
124124
fmt.Fprint(w, `{
125125
"id": 1,
126126
"name":"testCreateCheckRun",
@@ -187,7 +187,7 @@ func TestChecksService_ListCheckRunAnnotations(t *testing.T) {
187187

188188
mux.HandleFunc("/repos/o/r/check-runs/1/annotations", func(w http.ResponseWriter, r *http.Request) {
189189
testMethod(t, r, "GET")
190-
190+
testHeader(t, r, "Accept", mediaTypeCheckRunsPreview)
191191
testFormValues(t, r, values{
192192
"page": "1",
193193
})
@@ -247,7 +247,7 @@ func TestChecksService_UpdateCheckRun(t *testing.T) {
247247

248248
mux.HandleFunc("/repos/o/r/check-runs/1", func(w http.ResponseWriter, r *http.Request) {
249249
testMethod(t, r, "PATCH")
250-
250+
testHeader(t, r, "Accept", mediaTypeCheckRunsPreview)
251251
fmt.Fprint(w, `{
252252
"id": 1,
253253
"name":"testUpdateCheckRun",
@@ -313,7 +313,7 @@ func TestChecksService_ListCheckRunsForRef(t *testing.T) {
313313

314314
mux.HandleFunc("/repos/o/r/commits/master/check-runs", func(w http.ResponseWriter, r *http.Request) {
315315
testMethod(t, r, "GET")
316-
316+
testHeader(t, r, "Accept", mediaTypeCheckRunsPreview)
317317
testFormValues(t, r, values{
318318
"check_name": "testing",
319319
"page": "1",
@@ -385,7 +385,7 @@ func TestChecksService_ListCheckRunsCheckSuite(t *testing.T) {
385385

386386
mux.HandleFunc("/repos/o/r/check-suites/1/check-runs", func(w http.ResponseWriter, r *http.Request) {
387387
testMethod(t, r, "GET")
388-
388+
testHeader(t, r, "Accept", mediaTypeCheckRunsPreview)
389389
testFormValues(t, r, values{
390390
"check_name": "testing",
391391
"page": "1",
@@ -452,7 +452,7 @@ func TestChecksService_ListCheckSuiteForRef(t *testing.T) {
452452

453453
mux.HandleFunc("/repos/o/r/commits/master/check-suites", func(w http.ResponseWriter, r *http.Request) {
454454
testMethod(t, r, "GET")
455-
455+
testHeader(t, r, "Accept", mediaTypeCheckRunsPreview)
456456
testFormValues(t, r, values{
457457
"check_name": "testing",
458458
"page": "1",
@@ -518,7 +518,7 @@ func TestChecksService_SetCheckSuitePreferences(t *testing.T) {
518518

519519
mux.HandleFunc("/repos/o/r/check-suites/preferences", func(w http.ResponseWriter, r *http.Request) {
520520
testMethod(t, r, "PATCH")
521-
521+
testHeader(t, r, "Accept", mediaTypeCheckRunsPreview)
522522
testBody(t, r, `{"auto_trigger_checks":[{"app_id":2,"setting":false}]}`+"\n")
523523
fmt.Fprint(w, `{"preferences":{"auto_trigger_checks":[{"app_id": 2,"setting": false}]}}`)
524524
})
@@ -565,7 +565,7 @@ func TestChecksService_CreateCheckSuite(t *testing.T) {
565565

566566
mux.HandleFunc("/repos/o/r/check-suites", func(w http.ResponseWriter, r *http.Request) {
567567
testMethod(t, r, "POST")
568-
568+
testHeader(t, r, "Accept", mediaTypeCheckRunsPreview)
569569
fmt.Fprint(w, `{
570570
"id": 2,
571571
"head_branch":"master",
@@ -621,7 +621,7 @@ func TestChecksService_ReRequestCheckSuite(t *testing.T) {
621621

622622
mux.HandleFunc("/repos/o/r/check-suites/1/rerequest", func(w http.ResponseWriter, r *http.Request) {
623623
testMethod(t, r, "POST")
624-
624+
testHeader(t, r, "Accept", mediaTypeCheckRunsPreview)
625625
w.WriteHeader(http.StatusCreated)
626626
})
627627
ctx := context.Background()

‎github/github.go‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,9 @@ const (
100100
// https://developer.github.com/changes/2018-03-16-protected-branches-required-approving-reviews/
101101
mediaTypeRequiredApprovingReviewsPreview = "application/vnd.github.luke-cage-preview+json"
102102

103+
// https://developer.github.com/changes/2018-05-07-new-checks-api-public-beta/
104+
mediaTypeCheckRunsPreview = "application/vnd.github.antiope-preview+json"
105+
103106
// https://developer.github.com/enterprise/2.13/v3/repos/pre_receive_hooks/
104107
mediaTypePreReceiveHooksPreview = "application/vnd.github.eye-scream-preview"
105108

0 commit comments

Comments
 (0)