-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat!: Implement Enterprise SCIM - Provision Groups & Users #3852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3852 +/- ##
==========================================
- Coverage 92.46% 92.37% -0.10%
==========================================
Files 199 199
Lines 14240 14330 +90
==========================================
+ Hits 13167 13237 +70
- Misses 884 894 +10
- Partials 189 199 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @elminster-aom!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear - @zyfy29
Fix typo on the `CIMEnterpriseGroupAttributes` struct documentation. Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
BREAKING CHANGE:
SCIMEnterpriseDisplayReference.Refis now of type*string.Related with #3813
From REST API endpoints for Enterprise SCIM docs, implements:
Provision a SCIM enterprise group, POST /scim/v2/enterprises/{enterprise}/Groups
Provision a SCIM enterprise user, POST /scim/v2/enterprises/{enterprise}/Users
Breaking API change
When provisioning Groups, the
SCIMEnterpriseDisplayReference.Refis optional for provisioning actions so it changed to pointer.