Skip to content

Conversation

@elminster-aom
Copy link
Contributor

@elminster-aom elminster-aom commented Dec 4, 2025

BREAKING CHANGE: SCIMEnterpriseDisplayReference.Ref is now of type *string.

Related with #3813

From REST API endpoints for Enterprise SCIM docs, implements:

Breaking API change

When provisioning Groups, the SCIMEnterpriseDisplayReference.Ref is optional for provisioning actions so it changed to pointer.

@elminster-aom elminster-aom mentioned this pull request Dec 4, 2025
12 tasks
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.37%. Comparing base (841abae) to head (cd6b534).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3852      +/-   ##
==========================================
- Coverage   92.46%   92.37%   -0.10%     
==========================================
  Files         199      199              
  Lines       14240    14330      +90     
==========================================
+ Hits        13167    13237      +70     
- Misses        884      894      +10     
- Partials      189      199      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elminster-aom elminster-aom marked this pull request as ready for review December 4, 2025 13:09
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Dec 4, 2025
@gmlewis gmlewis changed the title Implement Enterprise SCIM - Provision Groups & Users feat!: Implement Enterprise SCIM - Provision Groups & Users Dec 4, 2025
@gmlewis gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Dec 4, 2025
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @elminster-aom!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @zyfy29

Fix typo on the `CIMEnterpriseGroupAttributes` struct documentation.

Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). NeedsReview PR is awaiting a review before merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants