From ff6973360302a991e76f749fbff678221583ce9e Mon Sep 17 00:00:00 2001 From: Glenn Lewis <6598971+gmlewis@users.noreply.github.com> Date: Tue, 17 Mar 2026 15:14:12 -0400 Subject: [PATCH 1/2] chore: Remove unncessary use of `new` and `&SomeStruct{}` Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com> --- github/actions_artifacts.go | 12 +-- github/actions_cache.go | 20 ++-- github/actions_hosted_runners.go | 38 +++---- github/actions_oidc.go | 4 +- github/actions_permissions_enterprise.go | 44 ++++---- github/actions_permissions_enterprise_test.go | 28 ++--- github/actions_permissions_orgs.go | 48 ++++----- github/actions_permissions_orgs_test.go | 28 ++--- github/actions_runner_groups.go | 18 ++-- github/actions_runners.go | 36 +++---- github/actions_runners_test.go | 8 +- github/actions_secrets.go | 14 +-- github/actions_variables.go | 10 +- github/actions_workflow_jobs.go | 8 +- github/actions_workflow_runs.go | 16 +-- github/actions_workflow_runs_test.go | 4 +- github/actions_workflows.go | 10 +- github/activity.go | 4 +- github/activity_notifications.go | 12 +-- github/activity_notifications_test.go | 4 +- github/activity_watching.go | 8 +- github/activity_watching_test.go | 4 +- github/admin.go | 8 +- github/admin_orgs.go | 8 +- github/admin_orgs_test.go | 12 +-- github/admin_stats.go | 4 +- github/admin_test.go | 8 +- github/admin_users.go | 4 +- github/admin_users_test.go | 4 +- github/apps.go | 20 ++-- github/apps_hooks.go | 6 +- github/apps_hooks_deliveries.go | 8 +- github/apps_installation.go | 5 +- github/apps_manifest.go | 4 +- github/apps_test.go | 8 +- github/authorizations.go | 12 +-- github/billing.go | 36 +++---- github/checks.go | 20 ++-- github/classroom.go | 8 +- github/code_scanning.go | 36 +++---- github/code_scanning_test.go | 4 +- github/codesofconduct.go | 4 +- github/copilot.go | 12 +-- github/copilot_test.go | 24 ++--- github/dependabot_alerts.go | 8 +- github/dependabot_secrets.go | 14 +-- github/enterprise_actions_hosted_runners.go | 38 +++---- github/enterprise_actions_runner_groups.go | 18 ++-- github/enterprise_actions_runners.go | 14 +-- github/enterprise_actions_runners_test.go | 4 +- github/enterprise_billing_cost_centers.go | 28 ++--- .../enterprise_code_security_and_analysis.go | 4 +- ...erprise_code_security_and_analysis_test.go | 4 +- ...rprise_codesecurity_configurations_test.go | 4 +- github/enterprise_licenses.go | 4 +- github/enterprise_manage_ghes.go | 12 +-- github/enterprise_manage_ghes_config.go | 20 ++-- github/enterprise_manage_ghes_config_test.go | 12 +-- ...enterprise_manage_ghes_maintenance_test.go | 4 +- github/enterprise_manage_ghes_ssh_test.go | 8 +- github/enterprise_network_configurations.go | 25 +++-- github/enterprise_scim.go | 40 +++---- github/event_types_test.go | 3 +- github/examples_test.go | 2 +- github/gists.go | 20 ++-- github/gists_comments.go | 12 +-- github/gists_comments_test.go | 8 +- github/gists_test.go | 8 +- github/git_blobs.go | 10 +- github/git_blobs_test.go | 4 +- github/git_commits.go | 8 +- github/git_commits_test.go | 8 +- github/git_refs.go | 12 +-- github/git_refs_test.go | 12 +-- github/git_tags.go | 8 +- github/git_tags_test.go | 4 +- github/git_trees.go | 8 +- github/github.go | 5 +- github/github_test.go | 68 ++++-------- github/gitignore.go | 4 +- github/interactions_orgs.go | 10 +- github/interactions_orgs_test.go | 4 +- github/interactions_repos.go | 10 +- github/interactions_repos_test.go | 4 +- github/issue_import.go | 16 +-- github/issue_import_test.go | 12 +-- github/issues.go | 16 +-- github/issues_assignees.go | 8 +- github/issues_comments.go | 12 +-- github/issues_comments_test.go | 8 +- github/issues_events.go | 4 +- github/issues_labels.go | 12 +-- github/issues_labels_test.go | 8 +- github/issues_milestones.go | 12 +-- github/issues_milestones_test.go | 8 +- github/issues_test.go | 10 +- github/licenses.go | 4 +- github/markdown.go | 4 +- github/markdown_test.go | 4 +- github/meta.go | 12 +-- github/migrations.go | 8 +- github/migrations_source_import.go | 20 ++-- github/migrations_source_import_test.go | 16 +-- github/migrations_user.go | 15 +-- github/orgs.go | 20 ++-- github/orgs_actions_allowed_test.go | 4 +- github/orgs_actions_permissions_test.go | 4 +- github/orgs_artifacts.go | 28 +++-- .../orgs_codesecurity_configurations_test.go | 4 +- github/orgs_custom_repository_roles.go | 20 ++-- github/orgs_hooks.go | 12 +-- github/orgs_hooks_configuration.go | 8 +- github/orgs_hooks_configuration_test.go | 4 +- github/orgs_hooks_deliveries.go | 8 +- github/orgs_hooks_test.go | 8 +- github/orgs_issue_types.go | 8 +- github/orgs_issue_types_test.go | 8 +- github/orgs_members.go | 8 +- github/orgs_members_test.go | 12 +-- github/orgs_network_configurations.go | 30 +++--- github/orgs_organization_roles.go | 20 ++-- github/orgs_personal_access_tokens_test.go | 4 +- github/orgs_test.go | 4 +- github/private_registries_test.go | 8 +- github/projects.go | 67 ++++++++---- github/pulls.go | 24 ++--- github/pulls_comments.go | 17 +-- github/pulls_comments_test.go | 12 +-- github/pulls_reviewers.go | 8 +- github/pulls_reviews.go | 20 ++-- github/pulls_reviews_test.go | 16 +-- github/pulls_test.go | 4 +- github/reactions.go | 28 ++--- github/repos.go | 100 +++++++++--------- github/repos_actions_access.go | 4 +- github/repos_actions_access_test.go | 4 +- github/repos_actions_allowed.go | 8 +- github/repos_actions_allowed_test.go | 4 +- github/repos_actions_permissions.go | 28 ++--- github/repos_actions_permissions_test.go | 20 ++-- github/repos_autolinks.go | 4 +- github/repos_autolinks_test.go | 4 +- github/repos_codeowners.go | 4 +- github/repos_collaborators.go | 8 +- github/repos_collaborators_test.go | 4 +- github/repos_comments.go | 13 +-- github/repos_comments_test.go | 8 +- github/repos_commits.go | 8 +- github/repos_community_health.go | 4 +- github/repos_contents.go | 16 +-- github/repos_deployment_protection_rules.go | 4 +- .../repos_deployment_protection_rules_test.go | 4 +- github/repos_deployments.go | 16 +-- github/repos_deployments_test.go | 8 +- github/repos_environments.go | 14 +-- github/repos_environments_test.go | 12 +-- github/repos_forks.go | 12 +-- github/repos_hooks.go | 15 +-- github/repos_hooks_configuration.go | 8 +- github/repos_hooks_configuration_test.go | 4 +- github/repos_hooks_deliveries.go | 8 +- github/repos_hooks_test.go | 8 +- github/repos_invitations.go | 4 +- github/repos_keys.go | 8 +- github/repos_keys_test.go | 4 +- github/repos_merging.go | 8 +- github/repos_merging_test.go | 8 +- github/repos_pages.go | 24 ++--- github/repos_pages_test.go | 20 ++-- github/repos_prereceive_hooks.go | 8 +- github/repos_prereceive_hooks_test.go | 4 +- github/repos_releases.go | 39 ++++--- github/repos_releases_test.go | 12 +-- github/repos_stats.go | 4 +- github/repos_statuses.go | 8 +- github/repos_statuses_test.go | 4 +- github/repos_tags.go | 4 +- github/repos_tags_test.go | 4 +- github/repos_test.go | 60 +++++------ github/repos_traffic.go | 4 +- github/scim.go | 10 +- github/search.go | 28 ++--- github/secret_scanning_test.go | 4 +- github/security_advisories.go | 12 +-- github/sub_issue.go | 12 +-- github/sub_issue_test.go | 12 +-- github/teams.go | 68 ++++++------ github/teams_discussion_comments.go | 24 ++--- github/teams_discussion_comments_test.go | 8 +- github/teams_discussions.go | 24 ++--- github/teams_discussions_test.go | 16 +-- github/teams_members.go | 16 +-- github/teams_members_test.go | 16 +-- github/teams_test.go | 36 +++---- github/users.go | 16 +-- github/users_administration_test.go | 4 +- github/users_emails_test.go | 2 +- github/users_gpg_keys.go | 8 +- github/users_keys.go | 8 +- github/users_keys_test.go | 4 +- github/users_ssh_signing_keys.go | 8 +- github/users_ssh_signing_keys_test.go | 4 +- github/users_test.go | 4 +- tools/gen-release-notes/main.go | 4 +- 204 files changed, 1355 insertions(+), 1327 deletions(-) diff --git a/github/actions_artifacts.go b/github/actions_artifacts.go index 4185a15037a..eede7828413 100644 --- a/github/actions_artifacts.go +++ b/github/actions_artifacts.go @@ -96,8 +96,8 @@ func (s *ActionsService) ListArtifacts(ctx context.Context, owner, repo string, return nil, nil, err } - artifactList := new(ArtifactList) - resp, err := s.client.Do(ctx, req, artifactList) + var artifactList *ArtifactList + resp, err := s.client.Do(ctx, req, &artifactList) if err != nil { return nil, resp, err } @@ -122,8 +122,8 @@ func (s *ActionsService) ListWorkflowRunArtifacts(ctx context.Context, owner, re return nil, nil, err } - artifactList := new(ArtifactList) - resp, err := s.client.Do(ctx, req, artifactList) + var artifactList *ArtifactList + resp, err := s.client.Do(ctx, req, &artifactList) if err != nil { return nil, resp, err } @@ -144,8 +144,8 @@ func (s *ActionsService) GetArtifact(ctx context.Context, owner, repo string, ar return nil, nil, err } - artifact := new(Artifact) - resp, err := s.client.Do(ctx, req, artifact) + var artifact *Artifact + resp, err := s.client.Do(ctx, req, &artifact) if err != nil { return nil, resp, err } diff --git a/github/actions_cache.go b/github/actions_cache.go index c883effb900..b53a7d5de82 100644 --- a/github/actions_cache.go +++ b/github/actions_cache.go @@ -92,8 +92,8 @@ func (s *ActionsService) ListCaches(ctx context.Context, owner, repo string, opt return nil, nil, err } - actionCacheList := new(ActionsCacheList) - resp, err := s.client.Do(ctx, req, actionCacheList) + var actionCacheList *ActionsCacheList + resp, err := s.client.Do(ctx, req, &actionCacheList) if err != nil { return nil, resp, err } @@ -160,8 +160,8 @@ func (s *ActionsService) GetCacheUsageForRepo(ctx context.Context, owner, repo s return nil, nil, err } - cacheUsage := new(ActionsCacheUsage) - res, err := s.client.Do(ctx, req, cacheUsage) + var cacheUsage *ActionsCacheUsage + res, err := s.client.Do(ctx, req, &cacheUsage) if err != nil { return nil, res, err } @@ -190,8 +190,8 @@ func (s *ActionsService) ListCacheUsageByRepoForOrg(ctx context.Context, org str return nil, nil, err } - cacheUsage := new(ActionsCacheUsageList) - res, err := s.client.Do(ctx, req, cacheUsage) + var cacheUsage *ActionsCacheUsageList + res, err := s.client.Do(ctx, req, &cacheUsage) if err != nil { return nil, res, err } @@ -215,8 +215,8 @@ func (s *ActionsService) GetTotalCacheUsageForOrg(ctx context.Context, org strin return nil, nil, err } - cacheUsage := new(TotalCacheUsage) - res, err := s.client.Do(ctx, req, cacheUsage) + var cacheUsage *TotalCacheUsage + res, err := s.client.Do(ctx, req, &cacheUsage) if err != nil { return nil, res, err } @@ -239,8 +239,8 @@ func (s *ActionsService) GetTotalCacheUsageForEnterprise(ctx context.Context, en return nil, nil, err } - cacheUsage := new(TotalCacheUsage) - res, err := s.client.Do(ctx, req, cacheUsage) + var cacheUsage *TotalCacheUsage + res, err := s.client.Do(ctx, req, &cacheUsage) if err != nil { return nil, res, err } diff --git a/github/actions_hosted_runners.go b/github/actions_hosted_runners.go index eb805393ff3..770748f34fc 100644 --- a/github/actions_hosted_runners.go +++ b/github/actions_hosted_runners.go @@ -73,7 +73,7 @@ func (s *ActionsService) ListHostedRunners(ctx context.Context, org string, opts return nil, nil, err } - runners := &HostedRunners{} + var runners *HostedRunners resp, err := s.client.Do(ctx, req, &runners) if err != nil { return nil, resp, err @@ -151,8 +151,8 @@ func (s *ActionsService) CreateHostedRunner(ctx context.Context, org string, req return nil, nil, err } - hostedRunner := new(HostedRunner) - resp, err := s.client.Do(ctx, req, hostedRunner) + var hostedRunner *HostedRunner + resp, err := s.client.Do(ctx, req, &hostedRunner) if err != nil { return nil, resp, err } @@ -187,8 +187,8 @@ func (s *ActionsService) GetHostedRunnerGitHubOwnedImages(ctx context.Context, o return nil, nil, err } - hostedRunnerImages := new(HostedRunnerImages) - resp, err := s.client.Do(ctx, req, hostedRunnerImages) + var hostedRunnerImages *HostedRunnerImages + resp, err := s.client.Do(ctx, req, &hostedRunnerImages) if err != nil { return nil, resp, err } @@ -208,8 +208,8 @@ func (s *ActionsService) GetHostedRunnerPartnerImages(ctx context.Context, org s return nil, nil, err } - hostedRunnerImages := new(HostedRunnerImages) - resp, err := s.client.Do(ctx, req, hostedRunnerImages) + var hostedRunnerImages *HostedRunnerImages + resp, err := s.client.Do(ctx, req, &hostedRunnerImages) if err != nil { return nil, resp, err } @@ -240,8 +240,8 @@ func (s *ActionsService) GetHostedRunnerLimits(ctx context.Context, org string) return nil, nil, err } - publicIPLimits := new(HostedRunnerPublicIPLimits) - resp, err := s.client.Do(ctx, req, publicIPLimits) + var publicIPLimits *HostedRunnerPublicIPLimits + resp, err := s.client.Do(ctx, req, &publicIPLimits) if err != nil { return nil, resp, err } @@ -267,8 +267,8 @@ func (s *ActionsService) GetHostedRunnerMachineSpecs(ctx context.Context, org st return nil, nil, err } - machineSpecs := new(HostedRunnerMachineSpecs) - resp, err := s.client.Do(ctx, req, machineSpecs) + var machineSpecs *HostedRunnerMachineSpecs + resp, err := s.client.Do(ctx, req, &machineSpecs) if err != nil { return nil, resp, err } @@ -294,8 +294,8 @@ func (s *ActionsService) GetHostedRunnerPlatforms(ctx context.Context, org strin return nil, nil, err } - platforms := new(HostedRunnerPlatforms) - resp, err := s.client.Do(ctx, req, platforms) + var platforms *HostedRunnerPlatforms + resp, err := s.client.Do(ctx, req, &platforms) if err != nil { return nil, resp, err } @@ -315,8 +315,8 @@ func (s *ActionsService) GetHostedRunner(ctx context.Context, org string, runner return nil, nil, err } - hostedRunner := new(HostedRunner) - resp, err := s.client.Do(ctx, req, hostedRunner) + var hostedRunner *HostedRunner + resp, err := s.client.Do(ctx, req, &hostedRunner) if err != nil { return nil, resp, err } @@ -336,8 +336,8 @@ func (s *ActionsService) UpdateHostedRunner(ctx context.Context, org string, run return nil, nil, err } - hostedRunner := new(HostedRunner) - resp, err := s.client.Do(ctx, req, hostedRunner) + var hostedRunner *HostedRunner + resp, err := s.client.Do(ctx, req, &hostedRunner) if err != nil { return nil, resp, err } @@ -357,8 +357,8 @@ func (s *ActionsService) DeleteHostedRunner(ctx context.Context, org string, run return nil, nil, err } - hostedRunner := new(HostedRunner) - resp, err := s.client.Do(ctx, req, hostedRunner) + var hostedRunner *HostedRunner + resp, err := s.client.Do(ctx, req, &hostedRunner) if err != nil { return nil, resp, err } diff --git a/github/actions_oidc.go b/github/actions_oidc.go index 596aa9d981e..7fe3acbdd9f 100644 --- a/github/actions_oidc.go +++ b/github/actions_oidc.go @@ -42,8 +42,8 @@ func (s *ActionsService) getOIDCSubjectClaimCustomTemplate(ctx context.Context, return nil, nil, err } - tmpl := new(OIDCSubjectClaimCustomTemplate) - resp, err := s.client.Do(ctx, req, tmpl) + var tmpl *OIDCSubjectClaimCustomTemplate + resp, err := s.client.Do(ctx, req, &tmpl) if err != nil { return nil, resp, err } diff --git a/github/actions_permissions_enterprise.go b/github/actions_permissions_enterprise.go index 326230d6490..18c0b7a4ca4 100644 --- a/github/actions_permissions_enterprise.go +++ b/github/actions_permissions_enterprise.go @@ -59,8 +59,8 @@ func (s *ActionsService) GetActionsPermissionsInEnterprise(ctx context.Context, return nil, nil, err } - permissions := new(ActionsPermissionsEnterprise) - resp, err := s.client.Do(ctx, req, permissions) + var permissions *ActionsPermissionsEnterprise + resp, err := s.client.Do(ctx, req, &permissions) if err != nil { return nil, resp, err } @@ -80,8 +80,8 @@ func (s *ActionsService) UpdateActionsPermissionsInEnterprise(ctx context.Contex return nil, nil, err } - p := new(ActionsPermissionsEnterprise) - resp, err := s.client.Do(ctx, req, p) + var p *ActionsPermissionsEnterprise + resp, err := s.client.Do(ctx, req, &p) if err != nil { return nil, resp, err } @@ -106,8 +106,8 @@ func (s *ActionsService) ListEnabledOrgsInEnterprise(ctx context.Context, owner return nil, nil, err } - orgs := &ActionsEnabledOnEnterpriseRepos{} - resp, err := s.client.Do(ctx, req, orgs) + var orgs *ActionsEnabledOnEnterpriseRepos + resp, err := s.client.Do(ctx, req, &orgs) if err != nil { return nil, resp, err } @@ -193,8 +193,8 @@ func (s *ActionsService) GetActionsAllowedInEnterprise(ctx context.Context, ente return nil, nil, err } - actionsAllowed := new(ActionsAllowed) - resp, err := s.client.Do(ctx, req, actionsAllowed) + var actionsAllowed *ActionsAllowed + resp, err := s.client.Do(ctx, req, &actionsAllowed) if err != nil { return nil, resp, err } @@ -214,8 +214,8 @@ func (s *ActionsService) UpdateActionsAllowedInEnterprise(ctx context.Context, e return nil, nil, err } - p := new(ActionsAllowed) - resp, err := s.client.Do(ctx, req, p) + var p *ActionsAllowed + resp, err := s.client.Do(ctx, req, &p) if err != nil { return nil, resp, err } @@ -236,8 +236,8 @@ func (s *ActionsService) GetDefaultWorkflowPermissionsInEnterprise(ctx context.C return nil, nil, err } - permissions := new(DefaultWorkflowPermissionEnterprise) - resp, err := s.client.Do(ctx, req, permissions) + var permissions *DefaultWorkflowPermissionEnterprise + resp, err := s.client.Do(ctx, req, &permissions) if err != nil { return nil, resp, err } @@ -257,8 +257,8 @@ func (s *ActionsService) UpdateDefaultWorkflowPermissionsInEnterprise(ctx contex return nil, nil, err } - p := new(DefaultWorkflowPermissionEnterprise) - resp, err := s.client.Do(ctx, req, p) + var p *DefaultWorkflowPermissionEnterprise + resp, err := s.client.Do(ctx, req, &p) if err != nil { return nil, resp, err } @@ -279,8 +279,8 @@ func (s *ActionsService) GetArtifactAndLogRetentionPeriodInEnterprise(ctx contex return nil, nil, err } - arp := new(ArtifactPeriod) - resp, err := s.client.Do(ctx, req, arp) + var arp *ArtifactPeriod + resp, err := s.client.Do(ctx, req, &arp) if err != nil { return nil, resp, err } @@ -315,8 +315,8 @@ func (s *ActionsService) GetSelfHostedRunnerPermissionsInEnterprise(ctx context. return nil, nil, err } - permissions := new(SelfHostRunnerPermissionsEnterprise) - resp, err := s.client.Do(ctx, req, permissions) + var permissions *SelfHostRunnerPermissionsEnterprise + resp, err := s.client.Do(ctx, req, &permissions) if err != nil { return nil, resp, err } @@ -352,8 +352,8 @@ func (s *ActionsService) GetPrivateRepoForkPRWorkflowSettingsInEnterprise(ctx co return nil, nil, err } - permissions := new(WorkflowsPermissions) - resp, err := s.client.Do(ctx, req, permissions) + var permissions *WorkflowsPermissions + resp, err := s.client.Do(ctx, req, &permissions) if err != nil { return nil, resp, err } @@ -389,8 +389,8 @@ func (s *ActionsService) GetEnterpriseForkPRContributorApprovalPermissions(ctx c return nil, nil, err } - policy := new(ContributorApprovalPermissions) - resp, err := s.client.Do(ctx, req, policy) + var policy *ContributorApprovalPermissions + resp, err := s.client.Do(ctx, req, &policy) if err != nil { return nil, resp, err } diff --git a/github/actions_permissions_enterprise_test.go b/github/actions_permissions_enterprise_test.go index 1b314817412..29d61242226 100644 --- a/github/actions_permissions_enterprise_test.go +++ b/github/actions_permissions_enterprise_test.go @@ -55,8 +55,8 @@ func TestActionsService_UpdateActionsPermissionsInEnterprise(t *testing.T) { input := &ActionsPermissionsEnterprise{EnabledOrganizations: Ptr("all"), AllowedActions: Ptr("selected")} mux.HandleFunc("/enterprises/e/actions/permissions", func(w http.ResponseWriter, r *http.Request) { - v := new(ActionsPermissionsEnterprise) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *ActionsPermissionsEnterprise + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { @@ -260,8 +260,8 @@ func TestActionsService_UpdateActionsAllowedInEnterprise(t *testing.T) { input := &ActionsAllowed{GithubOwnedAllowed: Ptr(true), VerifiedAllowed: Ptr(false), PatternsAllowed: []string{"a/b"}} mux.HandleFunc("/enterprises/e/actions/permissions/selected-actions", func(w http.ResponseWriter, r *http.Request) { - v := new(ActionsAllowed) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *ActionsAllowed + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { @@ -338,8 +338,8 @@ func TestActionsService_UpdateDefaultWorkflowPermissionsInEnterprise(t *testing. input := &DefaultWorkflowPermissionEnterprise{DefaultWorkflowPermissions: Ptr("read"), CanApprovePullRequestReviews: Ptr(true)} mux.HandleFunc("/enterprises/e/actions/permissions/workflow", func(w http.ResponseWriter, r *http.Request) { - v := new(DefaultWorkflowPermissionEnterprise) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *DefaultWorkflowPermissionEnterprise + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { @@ -420,8 +420,8 @@ func TestActionsService_UpdateArtifactAndLogRetentionPeriodInEnterprise(t *testi input := &ArtifactPeriodOpt{Days: Ptr(90)} mux.HandleFunc("/enterprises/e/actions/permissions/artifact-and-log-retention", func(w http.ResponseWriter, r *http.Request) { - v := new(ArtifactPeriodOpt) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *ArtifactPeriodOpt + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { @@ -492,8 +492,8 @@ func TestActionsService_UpdateSelfHostedRunnerPermissionsInEnterprise(t *testing input := &SelfHostRunnerPermissionsEnterprise{DisableSelfHostedRunnersForAllOrgs: Ptr(false)} mux.HandleFunc("/enterprises/e/actions/permissions/self-hosted-runners", func(w http.ResponseWriter, r *http.Request) { - v := new(SelfHostRunnerPermissionsEnterprise) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *SelfHostRunnerPermissionsEnterprise + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { @@ -573,8 +573,8 @@ func TestActionsService_UpdatePrivateRepoForkPRWorkflowSettingsInEnterprise(t *t } mux.HandleFunc("/enterprises/e/actions/permissions/fork-pr-workflows-private-repos", func(w http.ResponseWriter, r *http.Request) { - v := new(WorkflowsPermissionsOpt) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *WorkflowsPermissionsOpt + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { @@ -645,8 +645,8 @@ func TestActionsService_UpdateEnterpriseForkPRContributorApprovalPermissions(t * input := ContributorApprovalPermissions{ApprovalPolicy: "require_approval"} mux.HandleFunc("/enterprises/e/actions/permissions/fork-pr-contributor-approval", func(w http.ResponseWriter, r *http.Request) { - v := new(ContributorApprovalPermissions) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *ContributorApprovalPermissions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, &input) { diff --git a/github/actions_permissions_orgs.go b/github/actions_permissions_orgs.go index 626e3998303..6bd6c9f56d5 100644 --- a/github/actions_permissions_orgs.go +++ b/github/actions_permissions_orgs.go @@ -79,8 +79,8 @@ func (s *ActionsService) GetActionsPermissions(ctx context.Context, org string) return nil, nil, err } - permissions := new(ActionsPermissions) - resp, err := s.client.Do(ctx, req, permissions) + var permissions *ActionsPermissions + resp, err := s.client.Do(ctx, req, &permissions) if err != nil { return nil, resp, err } @@ -100,8 +100,8 @@ func (s *ActionsService) UpdateActionsPermissions(ctx context.Context, org strin return nil, nil, err } - p := new(ActionsPermissions) - resp, err := s.client.Do(ctx, req, p) + var p *ActionsPermissions + resp, err := s.client.Do(ctx, req, &p) if err != nil { return nil, resp, err } @@ -126,8 +126,8 @@ func (s *ActionsService) ListEnabledReposInOrg(ctx context.Context, owner string return nil, nil, err } - repos := &ActionsEnabledOnOrgRepos{} - resp, err := s.client.Do(ctx, req, repos) + var repos *ActionsEnabledOnOrgRepos + resp, err := s.client.Do(ctx, req, &repos) if err != nil { return nil, resp, err } @@ -213,8 +213,8 @@ func (s *ActionsService) GetActionsAllowed(ctx context.Context, org string) (*Ac return nil, nil, err } - actionsAllowed := new(ActionsAllowed) - resp, err := s.client.Do(ctx, req, actionsAllowed) + var actionsAllowed *ActionsAllowed + resp, err := s.client.Do(ctx, req, &actionsAllowed) if err != nil { return nil, resp, err } @@ -234,8 +234,8 @@ func (s *ActionsService) UpdateActionsAllowed(ctx context.Context, org string, a return nil, nil, err } - p := new(ActionsAllowed) - resp, err := s.client.Do(ctx, req, p) + var p *ActionsAllowed + resp, err := s.client.Do(ctx, req, &p) if err != nil { return nil, resp, err } @@ -256,8 +256,8 @@ func (s *ActionsService) GetDefaultWorkflowPermissionsInOrganization(ctx context return nil, nil, err } - permissions := new(DefaultWorkflowPermissionOrganization) - resp, err := s.client.Do(ctx, req, permissions) + var permissions *DefaultWorkflowPermissionOrganization + resp, err := s.client.Do(ctx, req, &permissions) if err != nil { return nil, resp, err } @@ -277,8 +277,8 @@ func (s *ActionsService) UpdateDefaultWorkflowPermissionsInOrganization(ctx cont return nil, nil, err } - p := new(DefaultWorkflowPermissionOrganization) - resp, err := s.client.Do(ctx, req, p) + var p *DefaultWorkflowPermissionOrganization + resp, err := s.client.Do(ctx, req, &p) if err != nil { return nil, resp, err } @@ -299,8 +299,8 @@ func (s *ActionsService) GetArtifactAndLogRetentionPeriodInOrganization(ctx cont return nil, nil, err } - arp := new(ArtifactPeriod) - resp, err := s.client.Do(ctx, req, arp) + var arp *ArtifactPeriod + resp, err := s.client.Do(ctx, req, &arp) if err != nil { return nil, resp, err } @@ -336,8 +336,8 @@ func (s *ActionsService) GetSelfHostedRunnersSettingsInOrganization(ctx context. return nil, nil, err } - settings := new(SelfHostedRunnersSettingsOrganization) - resp, err := s.client.Do(ctx, req, settings) + var settings *SelfHostedRunnersSettingsOrganization + resp, err := s.client.Do(ctx, req, &settings) if err != nil { return nil, resp, err } @@ -384,8 +384,8 @@ func (s *ActionsService) ListRepositoriesSelfHostedRunnersAllowedInOrganization( return nil, nil, err } - settings := new(SelfHostedRunnersAllowedRepos) - resp, err := s.client.Do(ctx, req, settings) + var settings *SelfHostedRunnersAllowedRepos + resp, err := s.client.Do(ctx, req, &settings) if err != nil { return nil, resp, err } @@ -461,8 +461,8 @@ func (s *ActionsService) GetPrivateRepoForkPRWorkflowSettingsInOrganization(ctx return nil, nil, err } - permissions := new(WorkflowsPermissions) - resp, err := s.client.Do(ctx, req, permissions) + var permissions *WorkflowsPermissions + resp, err := s.client.Do(ctx, req, &permissions) if err != nil { return nil, resp, err } @@ -498,8 +498,8 @@ func (s *ActionsService) GetOrganizationForkPRContributorApprovalPermissions(ctx return nil, nil, err } - policy := new(ContributorApprovalPermissions) - resp, err := s.client.Do(ctx, req, policy) + var policy *ContributorApprovalPermissions + resp, err := s.client.Do(ctx, req, &policy) if err != nil { return nil, resp, err } diff --git a/github/actions_permissions_orgs_test.go b/github/actions_permissions_orgs_test.go index c42405795df..c60c99f20e2 100644 --- a/github/actions_permissions_orgs_test.go +++ b/github/actions_permissions_orgs_test.go @@ -55,8 +55,8 @@ func TestActionsService_UpdateActionsPermissions(t *testing.T) { input := &ActionsPermissions{EnabledRepositories: Ptr("all"), AllowedActions: Ptr("selected"), SHAPinningRequired: Ptr(true)} mux.HandleFunc("/orgs/o/actions/permissions", func(w http.ResponseWriter, r *http.Request) { - v := new(ActionsPermissions) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *ActionsPermissions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { @@ -260,8 +260,8 @@ func TestActionsService_UpdateActionsAllowed(t *testing.T) { input := &ActionsAllowed{GithubOwnedAllowed: Ptr(true), VerifiedAllowed: Ptr(false), PatternsAllowed: []string{"a/b"}} mux.HandleFunc("/orgs/o/actions/permissions/selected-actions", func(w http.ResponseWriter, r *http.Request) { - v := new(ActionsAllowed) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *ActionsAllowed + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { @@ -380,8 +380,8 @@ func TestActionsService_UpdateDefaultWorkflowPermissionsInOrganization(t *testin input := &DefaultWorkflowPermissionOrganization{DefaultWorkflowPermissions: Ptr("read"), CanApprovePullRequestReviews: Ptr(true)} mux.HandleFunc("/orgs/o/actions/permissions/workflow", func(w http.ResponseWriter, r *http.Request) { - v := new(DefaultWorkflowPermissionOrganization) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *DefaultWorkflowPermissionOrganization + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { @@ -462,8 +462,8 @@ func TestActionsService_UpdateArtifactAndLogRetentionPeriodInOrganization(t *tes input := &ArtifactPeriodOpt{Days: Ptr(90)} mux.HandleFunc("/orgs/o/actions/permissions/artifact-and-log-retention", func(w http.ResponseWriter, r *http.Request) { - v := new(ArtifactPeriodOpt) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *ArtifactPeriodOpt + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { @@ -537,8 +537,8 @@ func TestActionsService_UpdateSelfHostedRunnersSettingsInOrganization(t *testing input := &SelfHostedRunnersSettingsOrganizationOpt{EnabledRepositories: Ptr("selected")} mux.HandleFunc("/orgs/o/actions/permissions/self-hosted-runners", func(w http.ResponseWriter, r *http.Request) { - v := new(SelfHostedRunnersSettingsOrganizationOpt) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *SelfHostedRunnersSettingsOrganizationOpt + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { @@ -745,8 +745,8 @@ func TestActionsService_UpdatePrivateRepoForkPRWorkflowSettingsInOrganization(t } mux.HandleFunc("/orgs/o/actions/permissions/fork-pr-workflows-private-repos", func(w http.ResponseWriter, r *http.Request) { - v := new(WorkflowsPermissionsOpt) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *WorkflowsPermissionsOpt + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { @@ -817,8 +817,8 @@ func TestActionsService_UpdateOrganizationForkPRContributorApprovalPermissions(t input := ContributorApprovalPermissions{ApprovalPolicy: "require_approval"} mux.HandleFunc("/orgs/o/actions/permissions/fork-pr-contributor-approval", func(w http.ResponseWriter, r *http.Request) { - v := new(ContributorApprovalPermissions) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *ContributorApprovalPermissions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, &input) { diff --git a/github/actions_runner_groups.go b/github/actions_runner_groups.go index 2d673b77f40..19f0e8b0c6d 100644 --- a/github/actions_runner_groups.go +++ b/github/actions_runner_groups.go @@ -100,7 +100,7 @@ func (s *ActionsService) ListOrganizationRunnerGroups(ctx context.Context, org s return nil, nil, err } - groups := &RunnerGroups{} + var groups *RunnerGroups resp, err := s.client.Do(ctx, req, &groups) if err != nil { return nil, resp, err @@ -121,8 +121,8 @@ func (s *ActionsService) GetOrganizationRunnerGroup(ctx context.Context, org str return nil, nil, err } - runnerGroup := new(RunnerGroup) - resp, err := s.client.Do(ctx, req, runnerGroup) + var runnerGroup *RunnerGroup + resp, err := s.client.Do(ctx, req, &runnerGroup) if err != nil { return nil, resp, err } @@ -158,8 +158,8 @@ func (s *ActionsService) CreateOrganizationRunnerGroup(ctx context.Context, org return nil, nil, err } - runnerGroup := new(RunnerGroup) - resp, err := s.client.Do(ctx, req, runnerGroup) + var runnerGroup *RunnerGroup + resp, err := s.client.Do(ctx, req, &runnerGroup) if err != nil { return nil, resp, err } @@ -179,8 +179,8 @@ func (s *ActionsService) UpdateOrganizationRunnerGroup(ctx context.Context, org return nil, nil, err } - runnerGroup := new(RunnerGroup) - resp, err := s.client.Do(ctx, req, runnerGroup) + var runnerGroup *RunnerGroup + resp, err := s.client.Do(ctx, req, &runnerGroup) if err != nil { return nil, resp, err } @@ -205,7 +205,7 @@ func (s *ActionsService) ListRepositoryAccessRunnerGroup(ctx context.Context, or return nil, nil, err } - repos := &ListRepositories{} + var repos *ListRepositories resp, err := s.client.Do(ctx, req, &repos) if err != nil { return nil, resp, err @@ -308,7 +308,7 @@ func (s *ActionsService) ListRunnerGroupRunners(ctx context.Context, org string, return nil, nil, err } - runners := &Runners{} + var runners *Runners resp, err := s.client.Do(ctx, req, &runners) if err != nil { return nil, resp, err diff --git a/github/actions_runners.go b/github/actions_runners.go index c4ae48232ec..dbe184fcb96 100644 --- a/github/actions_runners.go +++ b/github/actions_runners.go @@ -70,8 +70,8 @@ func (s *ActionsService) GenerateOrgJITConfig(ctx context.Context, org string, r return nil, nil, err } - jitConfig := new(JITRunnerConfig) - resp, err := s.client.Do(ctx, req, jitConfig) + var jitConfig *JITRunnerConfig + resp, err := s.client.Do(ctx, req, &jitConfig) if err != nil { return nil, resp, err } @@ -91,8 +91,8 @@ func (s *ActionsService) GenerateRepoJITConfig(ctx context.Context, owner, repo return nil, nil, err } - jitConfig := new(JITRunnerConfig) - resp, err := s.client.Do(ctx, req, jitConfig) + var jitConfig *JITRunnerConfig + resp, err := s.client.Do(ctx, req, &jitConfig) if err != nil { return nil, resp, err } @@ -119,8 +119,8 @@ func (s *ActionsService) CreateRegistrationToken(ctx context.Context, owner, rep return nil, nil, err } - registrationToken := new(RegistrationToken) - resp, err := s.client.Do(ctx, req, registrationToken) + var registrationToken *RegistrationToken + resp, err := s.client.Do(ctx, req, ®istrationToken) if err != nil { return nil, resp, err } @@ -174,7 +174,7 @@ func (s *ActionsService) ListRunners(ctx context.Context, owner, repo string, op return nil, nil, err } - runners := &Runners{} + var runners *Runners resp, err := s.client.Do(ctx, req, &runners) if err != nil { return nil, resp, err @@ -195,8 +195,8 @@ func (s *ActionsService) GetRunner(ctx context.Context, owner, repo string, runn return nil, nil, err } - runner := new(Runner) - resp, err := s.client.Do(ctx, req, runner) + var runner *Runner + resp, err := s.client.Do(ctx, req, &runner) if err != nil { return nil, resp, err } @@ -223,8 +223,8 @@ func (s *ActionsService) CreateRemoveToken(ctx context.Context, owner, repo stri return nil, nil, err } - removeToken := new(RemoveToken) - resp, err := s.client.Do(ctx, req, removeToken) + var removeToken *RemoveToken + resp, err := s.client.Do(ctx, req, &removeToken) if err != nil { return nil, resp, err } @@ -282,8 +282,8 @@ func (s *ActionsService) CreateOrganizationRegistrationToken(ctx context.Context return nil, nil, err } - registrationToken := new(RegistrationToken) - resp, err := s.client.Do(ctx, req, registrationToken) + var registrationToken *RegistrationToken + resp, err := s.client.Do(ctx, req, ®istrationToken) if err != nil { return nil, resp, err } @@ -308,7 +308,7 @@ func (s *ActionsService) ListOrganizationRunners(ctx context.Context, org string return nil, nil, err } - runners := &Runners{} + var runners *Runners resp, err := s.client.Do(ctx, req, &runners) if err != nil { return nil, resp, err @@ -329,8 +329,8 @@ func (s *ActionsService) GetOrganizationRunner(ctx context.Context, org string, return nil, nil, err } - runner := new(Runner) - resp, err := s.client.Do(ctx, req, runner) + var runner *Runner + resp, err := s.client.Do(ctx, req, &runner) if err != nil { return nil, resp, err } @@ -351,8 +351,8 @@ func (s *ActionsService) CreateOrganizationRemoveToken(ctx context.Context, org return nil, nil, err } - removeToken := new(RemoveToken) - resp, err := s.client.Do(ctx, req, removeToken) + var removeToken *RemoveToken + resp, err := s.client.Do(ctx, req, &removeToken) if err != nil { return nil, resp, err } diff --git a/github/actions_runners_test.go b/github/actions_runners_test.go index 323610fbe45..49ddca79145 100644 --- a/github/actions_runners_test.go +++ b/github/actions_runners_test.go @@ -63,8 +63,8 @@ func TestActionsService_GenerateOrgJITConfig(t *testing.T) { input := &GenerateJITConfigRequest{Name: "test", RunnerGroupID: 1, Labels: []string{"one", "two"}} mux.HandleFunc("/orgs/o/actions/runners/generate-jitconfig", func(w http.ResponseWriter, r *http.Request) { - v := new(GenerateJITConfigRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *GenerateJITConfigRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { @@ -107,8 +107,8 @@ func TestActionsService_GenerateRepoJITConfig(t *testing.T) { input := &GenerateJITConfigRequest{Name: "test", RunnerGroupID: 1, Labels: []string{"one", "two"}} mux.HandleFunc("/repos/o/r/actions/runners/generate-jitconfig", func(w http.ResponseWriter, r *http.Request) { - v := new(GenerateJITConfigRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *GenerateJITConfigRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { diff --git a/github/actions_secrets.go b/github/actions_secrets.go index f03d3fd191d..b9633da32da 100644 --- a/github/actions_secrets.go +++ b/github/actions_secrets.go @@ -54,8 +54,8 @@ func (s *ActionsService) getPublicKey(ctx context.Context, url string) (*PublicK return nil, nil, err } - pubKey := new(PublicKey) - resp, err := s.client.Do(ctx, req, pubKey) + var pubKey *PublicKey + resp, err := s.client.Do(ctx, req, &pubKey) if err != nil { return nil, resp, err } @@ -119,7 +119,7 @@ func (s *ActionsService) listSecrets(ctx context.Context, url string, opts *List return nil, nil, err } - secrets := new(Secrets) + var secrets *Secrets resp, err := s.client.Do(ctx, req, &secrets) if err != nil { return nil, resp, err @@ -177,8 +177,8 @@ func (s *ActionsService) getSecret(ctx context.Context, url string) (*Secret, *R return nil, nil, err } - secret := new(Secret) - resp, err := s.client.Do(ctx, req, secret) + var secret *Secret + resp, err := s.client.Do(ctx, req, &secret) if err != nil { return nil, resp, err } @@ -339,8 +339,8 @@ func (s *ActionsService) listSelectedReposForSecret(ctx context.Context, url str return nil, nil, err } - result := new(SelectedReposList) - resp, err := s.client.Do(ctx, req, result) + var result *SelectedReposList + resp, err := s.client.Do(ctx, req, &result) if err != nil { return nil, resp, err } diff --git a/github/actions_variables.go b/github/actions_variables.go index b192ba703ec..e6fe0126981 100644 --- a/github/actions_variables.go +++ b/github/actions_variables.go @@ -41,7 +41,7 @@ func (s *ActionsService) listVariables(ctx context.Context, url string, opts *Li return nil, nil, err } - variables := new(ActionsVariables) + var variables *ActionsVariables resp, err := s.client.Do(ctx, req, &variables) if err != nil { return nil, resp, err @@ -96,8 +96,8 @@ func (s *ActionsService) getVariable(ctx context.Context, url string) (*ActionsV return nil, nil, err } - variable := new(ActionsVariable) - resp, err := s.client.Do(ctx, req, variable) + var variable *ActionsVariable + resp, err := s.client.Do(ctx, req, &variable) if err != nil { return nil, resp, err } @@ -273,8 +273,8 @@ func (s *ActionsService) listSelectedReposForVariable(ctx context.Context, url s return nil, nil, err } - result := new(SelectedReposList) - resp, err := s.client.Do(ctx, req, result) + var result *SelectedReposList + resp, err := s.client.Do(ctx, req, &result) if err != nil { return nil, resp, err } diff --git a/github/actions_workflow_jobs.go b/github/actions_workflow_jobs.go index dabc809170a..10d68641bb8 100644 --- a/github/actions_workflow_jobs.go +++ b/github/actions_workflow_jobs.go @@ -85,7 +85,7 @@ func (s *ActionsService) ListWorkflowJobs(ctx context.Context, owner, repo strin return nil, nil, err } - jobs := new(Jobs) + var jobs *Jobs resp, err := s.client.Do(ctx, req, &jobs) if err != nil { return nil, resp, err @@ -111,7 +111,7 @@ func (s *ActionsService) ListWorkflowJobsAttempt(ctx context.Context, owner, rep return nil, nil, err } - jobs := new(Jobs) + var jobs *Jobs resp, err := s.client.Do(ctx, req, &jobs) if err != nil { return nil, resp, err @@ -133,8 +133,8 @@ func (s *ActionsService) GetWorkflowJobByID(ctx context.Context, owner, repo str return nil, nil, err } - job := new(WorkflowJob) - resp, err := s.client.Do(ctx, req, job) + var job *WorkflowJob + resp, err := s.client.Do(ctx, req, &job) if err != nil { return nil, resp, err } diff --git a/github/actions_workflow_runs.go b/github/actions_workflow_runs.go index 7b13a23ef40..3a0460d056a 100644 --- a/github/actions_workflow_runs.go +++ b/github/actions_workflow_runs.go @@ -149,7 +149,7 @@ func (s *ActionsService) listWorkflowRuns(ctx context.Context, endpoint string, return nil, nil, err } - runs := new(WorkflowRuns) + var runs *WorkflowRuns resp, err := s.client.Do(ctx, req, &runs) if err != nil { return nil, resp, err @@ -195,7 +195,7 @@ func (s *ActionsService) ListRepositoryWorkflowRuns(ctx context.Context, owner, return nil, nil, err } - runs := new(WorkflowRuns) + var runs *WorkflowRuns resp, err := s.client.Do(ctx, req, &runs) if err != nil { return nil, resp, err @@ -218,8 +218,8 @@ func (s *ActionsService) GetWorkflowRunByID(ctx context.Context, owner, repo str return nil, nil, err } - run := new(WorkflowRun) - resp, err := s.client.Do(ctx, req, run) + var run *WorkflowRun + resp, err := s.client.Do(ctx, req, &run) if err != nil { return nil, resp, err } @@ -245,8 +245,8 @@ func (s *ActionsService) GetWorkflowRunAttempt(ctx context.Context, owner, repo return nil, nil, err } - run := new(WorkflowRun) - resp, err := s.client.Do(ctx, req, run) + var run *WorkflowRun + resp, err := s.client.Do(ctx, req, &run) if err != nil { return nil, resp, err } @@ -473,8 +473,8 @@ func (s *ActionsService) GetWorkflowRunUsageByID(ctx context.Context, owner, rep return nil, nil, err } - workflowRunUsage := new(WorkflowRunUsage) - resp, err := s.client.Do(ctx, req, workflowRunUsage) + var workflowRunUsage *WorkflowRunUsage + resp, err := s.client.Do(ctx, req, &workflowRunUsage) if err != nil { return nil, resp, err } diff --git a/github/actions_workflow_runs_test.go b/github/actions_workflow_runs_test.go index d76712f39ca..2fdfa6ca519 100644 --- a/github/actions_workflow_runs_test.go +++ b/github/actions_workflow_runs_test.go @@ -1604,8 +1604,8 @@ func TestActionService_PendingDeployments(t *testing.T) { input := &PendingDeploymentsRequest{EnvironmentIDs: []int64{3, 4}, State: "approved", Comment: ""} mux.HandleFunc("/repos/o/r/actions/runs/399444496/pending_deployments", func(w http.ResponseWriter, r *http.Request) { - v := new(PendingDeploymentsRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *PendingDeploymentsRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { diff --git a/github/actions_workflows.go b/github/actions_workflows.go index 582949f4d8f..0b02548672f 100644 --- a/github/actions_workflows.go +++ b/github/actions_workflows.go @@ -114,7 +114,7 @@ func (s *ActionsService) ListWorkflows(ctx context.Context, owner, repo string, return nil, nil, err } - workflows := new(Workflows) + var workflows *Workflows resp, err := s.client.Do(ctx, req, &workflows) if err != nil { return nil, resp, err @@ -151,8 +151,8 @@ func (s *ActionsService) getWorkflow(ctx context.Context, url string) (*Workflow return nil, nil, err } - workflow := new(Workflow) - resp, err := s.client.Do(ctx, req, workflow) + var workflow *Workflow + resp, err := s.client.Do(ctx, req, &workflow) if err != nil { return nil, resp, err } @@ -188,8 +188,8 @@ func (s *ActionsService) getWorkflowUsage(ctx context.Context, url string) (*Wor return nil, nil, err } - workflowUsage := new(WorkflowUsage) - resp, err := s.client.Do(ctx, req, workflowUsage) + var workflowUsage *WorkflowUsage + resp, err := s.client.Do(ctx, req, &workflowUsage) if err != nil { return nil, resp, err } diff --git a/github/activity.go b/github/activity.go index edf8cc4397c..8b1c6a42150 100644 --- a/github/activity.go +++ b/github/activity.go @@ -67,8 +67,8 @@ func (s *ActivityService) ListFeeds(ctx context.Context) (*Feeds, *Response, err return nil, nil, err } - f := &Feeds{} - resp, err := s.client.Do(ctx, req, f) + var f *Feeds + resp, err := s.client.Do(ctx, req, &f) if err != nil { return nil, resp, err } diff --git a/github/activity_notifications.go b/github/activity_notifications.go index e126199052a..939e68bd1ea 100644 --- a/github/activity_notifications.go +++ b/github/activity_notifications.go @@ -155,8 +155,8 @@ func (s *ActivityService) GetThread(ctx context.Context, id string) (*Notificati return nil, nil, err } - notification := new(Notification) - resp, err := s.client.Do(ctx, req, notification) + var notification *Notification + resp, err := s.client.Do(ctx, req, ¬ification) if err != nil { return nil, resp, err } @@ -211,8 +211,8 @@ func (s *ActivityService) GetThreadSubscription(ctx context.Context, id string) return nil, nil, err } - sub := new(Subscription) - resp, err := s.client.Do(ctx, req, sub) + var sub *Subscription + resp, err := s.client.Do(ctx, req, &sub) if err != nil { return nil, resp, err } @@ -234,8 +234,8 @@ func (s *ActivityService) SetThreadSubscription(ctx context.Context, id string, return nil, nil, err } - sub := new(Subscription) - resp, err := s.client.Do(ctx, req, sub) + var sub *Subscription + resp, err := s.client.Do(ctx, req, &sub) if err != nil { return nil, resp, err } diff --git a/github/activity_notifications_test.go b/github/activity_notifications_test.go index 3483a927cf4..97011b8c822 100644 --- a/github/activity_notifications_test.go +++ b/github/activity_notifications_test.go @@ -313,8 +313,8 @@ func TestActivityService_SetThreadSubscription(t *testing.T) { input := &Subscription{Subscribed: Ptr(true)} mux.HandleFunc("/notifications/threads/1/subscription", func(w http.ResponseWriter, r *http.Request) { - v := new(Subscription) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *Subscription + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { diff --git a/github/activity_watching.go b/github/activity_watching.go index 8106d799cf1..b2e1400e4e6 100644 --- a/github/activity_watching.go +++ b/github/activity_watching.go @@ -101,8 +101,8 @@ func (s *ActivityService) GetRepositorySubscription(ctx context.Context, owner, return nil, nil, err } - sub := new(Subscription) - resp, err := s.client.Do(ctx, req, sub) + var sub *Subscription + resp, err := s.client.Do(ctx, req, &sub) if err != nil { // if it's just a 404, don't return that as an error _, err = parseBoolResponse(err) @@ -130,8 +130,8 @@ func (s *ActivityService) SetRepositorySubscription(ctx context.Context, owner, return nil, nil, err } - sub := new(Subscription) - resp, err := s.client.Do(ctx, req, sub) + var sub *Subscription + resp, err := s.client.Do(ctx, req, &sub) if err != nil { return nil, resp, err } diff --git a/github/activity_watching_test.go b/github/activity_watching_test.go index cf89366cd4d..8981cfdd8f0 100644 --- a/github/activity_watching_test.go +++ b/github/activity_watching_test.go @@ -194,8 +194,8 @@ func TestActivityService_SetRepositorySubscription(t *testing.T) { input := &Subscription{Subscribed: Ptr(true)} mux.HandleFunc("/repos/o/r/subscription", func(w http.ResponseWriter, r *http.Request) { - v := new(Subscription) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *Subscription + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { diff --git a/github/admin.go b/github/admin.go index 89b40ae2642..39bf91c86e1 100644 --- a/github/admin.go +++ b/github/admin.go @@ -92,8 +92,8 @@ func (s *AdminService) UpdateUserLDAPMapping(ctx context.Context, user string, m return nil, nil, err } - m := new(UserLDAPMapping) - resp, err := s.client.Do(ctx, req, m) + var m *UserLDAPMapping + resp, err := s.client.Do(ctx, req, &m) if err != nil { return nil, resp, err } @@ -113,8 +113,8 @@ func (s *AdminService) UpdateTeamLDAPMapping(ctx context.Context, team int64, ma return nil, nil, err } - m := new(TeamLDAPMapping) - resp, err := s.client.Do(ctx, req, m) + var m *TeamLDAPMapping + resp, err := s.client.Do(ctx, req, &m) if err != nil { return nil, resp, err } diff --git a/github/admin_orgs.go b/github/admin_orgs.go index b06c5b71fc6..2e24b2a1018 100644 --- a/github/admin_orgs.go +++ b/github/admin_orgs.go @@ -39,8 +39,8 @@ func (s *AdminService) CreateOrg(ctx context.Context, org *Organization, admin s return nil, nil, err } - o := new(Organization) - resp, err := s.client.Do(ctx, req, o) + var o *Organization + resp, err := s.client.Do(ctx, req, &o) if err != nil { return nil, resp, err } @@ -93,8 +93,8 @@ func (s *AdminService) RenameOrgByName(ctx context.Context, org, newName string) return nil, nil, err } - o := new(RenameOrgResponse) - resp, err := s.client.Do(ctx, req, o) + var o *RenameOrgResponse + resp, err := s.client.Do(ctx, req, &o) if err != nil { return nil, resp, err } diff --git a/github/admin_orgs_test.go b/github/admin_orgs_test.go index 14fc898afa0..e2d166895d1 100644 --- a/github/admin_orgs_test.go +++ b/github/admin_orgs_test.go @@ -23,8 +23,8 @@ func TestAdminOrgs_Create(t *testing.T) { } mux.HandleFunc("/admin/organizations", func(w http.ResponseWriter, r *http.Request) { - v := new(createOrgRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *createOrgRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") want := &createOrgRequest{Login: Ptr("github"), Admin: Ptr("ghAdmin")} @@ -65,8 +65,8 @@ func TestAdminOrgs_Rename(t *testing.T) { } mux.HandleFunc("/admin/organizations/o", func(w http.ResponseWriter, r *http.Request) { - v := new(renameOrgRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *renameOrgRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") want := &renameOrgRequest{Login: Ptr("the-new-octocats")} @@ -112,8 +112,8 @@ func TestAdminOrgs_RenameByName(t *testing.T) { client, mux, _ := setup(t) mux.HandleFunc("/admin/organizations/o", func(w http.ResponseWriter, r *http.Request) { - v := new(renameOrgRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *renameOrgRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") want := &renameOrgRequest{Login: Ptr("the-new-octocats")} diff --git a/github/admin_stats.go b/github/admin_stats.go index 17527e1fa36..51f04702608 100644 --- a/github/admin_stats.go +++ b/github/admin_stats.go @@ -162,8 +162,8 @@ func (s *AdminService) GetAdminStats(ctx context.Context) (*AdminStats, *Respons return nil, nil, err } - m := new(AdminStats) - resp, err := s.client.Do(ctx, req, m) + var m *AdminStats + resp, err := s.client.Do(ctx, req, &m) if err != nil { return nil, resp, err } diff --git a/github/admin_test.go b/github/admin_test.go index d167f1559bb..4756646ac2a 100644 --- a/github/admin_test.go +++ b/github/admin_test.go @@ -23,8 +23,8 @@ func TestAdminService_UpdateUserLDAPMapping(t *testing.T) { } mux.HandleFunc("/admin/ldap/users/u/mapping", func(w http.ResponseWriter, r *http.Request) { - v := new(UserLDAPMapping) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *UserLDAPMapping + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { @@ -71,8 +71,8 @@ func TestAdminService_UpdateTeamLDAPMapping(t *testing.T) { } mux.HandleFunc("/admin/ldap/teams/1/mapping", func(w http.ResponseWriter, r *http.Request) { - v := new(TeamLDAPMapping) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *TeamLDAPMapping + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { diff --git a/github/admin_users.go b/github/admin_users.go index 05f12317599..f9af3611e2d 100644 --- a/github/admin_users.go +++ b/github/admin_users.go @@ -106,8 +106,8 @@ func (s *AdminService) CreateUserImpersonation(ctx context.Context, username str return nil, nil, err } - a := new(UserAuthorization) - resp, err := s.client.Do(ctx, req, a) + var a *UserAuthorization + resp, err := s.client.Do(ctx, req, &a) if err != nil { return nil, resp, err } diff --git a/github/admin_users_test.go b/github/admin_users_test.go index fe3db01ecb2..a1a5a37500e 100644 --- a/github/admin_users_test.go +++ b/github/admin_users_test.go @@ -20,8 +20,8 @@ func TestAdminUsers_Create(t *testing.T) { client, mux, _ := setup(t) mux.HandleFunc("/admin/users", func(w http.ResponseWriter, r *http.Request) { - v := new(CreateUserRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *CreateUserRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") want := &CreateUserRequest{Login: "github", Email: Ptr("email@example.com"), Suspended: Ptr(false)} diff --git a/github/apps.go b/github/apps.go index 2de9ff6ddb6..f08a3b2a6ea 100644 --- a/github/apps.go +++ b/github/apps.go @@ -235,8 +235,8 @@ func (s *AppsService) Get(ctx context.Context, appSlug string) (*App, *Response, return nil, nil, err } - app := new(App) - resp, err := s.client.Do(ctx, req, app) + var app *App + resp, err := s.client.Do(ctx, req, &app) if err != nil { return nil, resp, err } @@ -391,8 +391,8 @@ func (s *AppsService) CreateInstallationToken(ctx context.Context, id int64, opt return nil, nil, err } - t := new(InstallationToken) - resp, err := s.client.Do(ctx, req, t) + var t *InstallationToken + resp, err := s.client.Do(ctx, req, &t) if err != nil { return nil, resp, err } @@ -415,8 +415,8 @@ func (s *AppsService) CreateInstallationTokenListRepos(ctx context.Context, id i return nil, nil, err } - t := new(InstallationToken) - resp, err := s.client.Do(ctx, req, t) + var t *InstallationToken + resp, err := s.client.Do(ctx, req, &t) if err != nil { return nil, resp, err } @@ -439,8 +439,8 @@ func (s *AppsService) CreateAttachment(ctx context.Context, contentReferenceID i req.Header.Set("Accept", mediaTypeContentAttachmentsPreview) - m := &Attachment{} - resp, err := s.client.Do(ctx, req, m) + var m *Attachment + resp, err := s.client.Do(ctx, req, &m) if err != nil { return nil, resp, err } @@ -490,8 +490,8 @@ func (s *AppsService) getInstallation(ctx context.Context, url string) (*Install return nil, nil, err } - i := new(Installation) - resp, err := s.client.Do(ctx, req, i) + var i *Installation + resp, err := s.client.Do(ctx, req, &i) if err != nil { return nil, resp, err } diff --git a/github/apps_hooks.go b/github/apps_hooks.go index 6046827ef06..cf372a48c0c 100644 --- a/github/apps_hooks.go +++ b/github/apps_hooks.go @@ -21,7 +21,7 @@ func (s *AppsService) GetHookConfig(ctx context.Context) (*HookConfig, *Response return nil, nil, err } - config := new(HookConfig) + var config *HookConfig resp, err := s.client.Do(ctx, req, &config) if err != nil { return nil, resp, err @@ -42,8 +42,8 @@ func (s *AppsService) UpdateHookConfig(ctx context.Context, config *HookConfig) return nil, nil, err } - c := new(HookConfig) - resp, err := s.client.Do(ctx, req, c) + var c *HookConfig + resp, err := s.client.Do(ctx, req, &c) if err != nil { return nil, resp, err } diff --git a/github/apps_hooks_deliveries.go b/github/apps_hooks_deliveries.go index 59800a0ae43..f677c1cabfc 100644 --- a/github/apps_hooks_deliveries.go +++ b/github/apps_hooks_deliveries.go @@ -47,8 +47,8 @@ func (s *AppsService) GetHookDelivery(ctx context.Context, deliveryID int64) (*H return nil, nil, err } - h := new(HookDelivery) - resp, err := s.client.Do(ctx, req, h) + var h *HookDelivery + resp, err := s.client.Do(ctx, req, &h) if err != nil { return nil, resp, err } @@ -68,8 +68,8 @@ func (s *AppsService) RedeliverHookDelivery(ctx context.Context, deliveryID int6 return nil, nil, err } - h := new(HookDelivery) - resp, err := s.client.Do(ctx, req, h) + var h *HookDelivery + resp, err := s.client.Do(ctx, req, &h) if err != nil { return nil, resp, err } diff --git a/github/apps_installation.go b/github/apps_installation.go index 57d6b4e76ed..b10d65efb34 100644 --- a/github/apps_installation.go +++ b/github/apps_installation.go @@ -33,7 +33,6 @@ func (s *AppsService) ListRepos(ctx context.Context, opts *ListOptions) (*ListRe } var r *ListRepositories - resp, err := s.client.Do(ctx, req, &r) if err != nil { return nil, resp, err @@ -81,8 +80,8 @@ func (s *AppsService) AddRepository(ctx context.Context, instID, repoID int64) ( return nil, nil, err } - r := new(Repository) - resp, err := s.client.Do(ctx, req, r) + var r *Repository + resp, err := s.client.Do(ctx, req, &r) if err != nil { return nil, resp, err } diff --git a/github/apps_manifest.go b/github/apps_manifest.go index fdd8d7b1e7a..edcb077488e 100644 --- a/github/apps_manifest.go +++ b/github/apps_manifest.go @@ -41,8 +41,8 @@ func (s *AppsService) CompleteAppManifest(ctx context.Context, code string) (*Ap return nil, nil, err } - cfg := new(AppConfig) - resp, err := s.client.Do(ctx, req, cfg) + var cfg *AppConfig + resp, err := s.client.Do(ctx, req, &cfg) if err != nil { return nil, resp, err } diff --git a/github/apps_test.go b/github/apps_test.go index 998806e18cd..b51c7729aa0 100644 --- a/github/apps_test.go +++ b/github/apps_test.go @@ -450,8 +450,8 @@ func TestAppsService_CreateInstallationTokenWithOptions(t *testing.T) { } mux.HandleFunc("/app/installations/1/access_tokens", func(w http.ResponseWriter, r *http.Request) { - v := new(InstallationTokenOptions) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *InstallationTokenOptions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) if !cmp.Equal(v, installationTokenOptions) { t.Errorf("request sent %+v, want %+v", v, installationTokenOptions) @@ -486,8 +486,8 @@ func TestAppsService_CreateInstallationTokenListReposWithOptions(t *testing.T) { } mux.HandleFunc("/app/installations/1/access_tokens", func(w http.ResponseWriter, r *http.Request) { - v := new(InstallationTokenListRepoOptions) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *InstallationTokenListRepoOptions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) if !cmp.Equal(v, installationTokenListRepoOptions) { t.Errorf("request sent %+v, want %+v", v, installationTokenListRepoOptions) diff --git a/github/authorizations.go b/github/authorizations.go index 24bbc4d3a69..cb1b62cc036 100644 --- a/github/authorizations.go +++ b/github/authorizations.go @@ -159,8 +159,8 @@ func (s *AuthorizationsService) Check(ctx context.Context, clientID, accessToken } req.Header.Set("Accept", mediaTypeOAuthAppPreview) - a := new(Authorization) - resp, err := s.client.Do(ctx, req, a) + var a *Authorization + resp, err := s.client.Do(ctx, req, &a) if err != nil { return nil, resp, err } @@ -194,8 +194,8 @@ func (s *AuthorizationsService) Reset(ctx context.Context, clientID, accessToken } req.Header.Set("Accept", mediaTypeOAuthAppPreview) - a := new(Authorization) - resp, err := s.client.Do(ctx, req, a) + var a *Authorization + resp, err := s.client.Do(ctx, req, &a) if err != nil { return nil, resp, err } @@ -267,8 +267,8 @@ func (s *AuthorizationsService) CreateImpersonation(ctx context.Context, usernam return nil, nil, err } - a := new(Authorization) - resp, err := s.client.Do(ctx, req, a) + var a *Authorization + resp, err := s.client.Do(ctx, req, &a) if err != nil { return nil, resp, err } diff --git a/github/billing.go b/github/billing.go index 29cccbaabed..2e22f613fe3 100644 --- a/github/billing.go +++ b/github/billing.go @@ -182,8 +182,8 @@ func (s *BillingService) GetOrganizationPackagesBilling(ctx context.Context, org return nil, nil, err } - result := new(PackagesBilling) - resp, err := s.client.Do(ctx, req, result) + var result *PackagesBilling + resp, err := s.client.Do(ctx, req, &result) if err != nil { return nil, resp, err } @@ -203,8 +203,8 @@ func (s *BillingService) GetOrganizationStorageBilling(ctx context.Context, org return nil, nil, err } - result := new(StorageBilling) - resp, err := s.client.Do(ctx, req, result) + var result *StorageBilling + resp, err := s.client.Do(ctx, req, &result) if err != nil { return nil, resp, err } @@ -229,8 +229,8 @@ func (s *BillingService) GetOrganizationAdvancedSecurityActiveCommitters(ctx con return nil, nil, err } - result := new(ActiveCommitters) - resp, err := s.client.Do(ctx, req, result) + var result *ActiveCommitters + resp, err := s.client.Do(ctx, req, &result) if err != nil { return nil, resp, err } @@ -249,8 +249,8 @@ func (s *BillingService) GetPackagesBilling(ctx context.Context, user string) (* return nil, nil, err } - packagesUserBilling := new(PackagesBilling) - resp, err := s.client.Do(ctx, req, packagesUserBilling) + var packagesUserBilling *PackagesBilling + resp, err := s.client.Do(ctx, req, &packagesUserBilling) if err != nil { return nil, resp, err } @@ -270,8 +270,8 @@ func (s *BillingService) GetStorageBilling(ctx context.Context, user string) (*S return nil, nil, err } - storageUserBilling := new(StorageBilling) - resp, err := s.client.Do(ctx, req, storageUserBilling) + var storageUserBilling *StorageBilling + resp, err := s.client.Do(ctx, req, &storageUserBilling) if err != nil { return nil, resp, err } @@ -298,8 +298,8 @@ func (s *BillingService) GetOrganizationUsageReport(ctx context.Context, org str return nil, nil, err } - usageReport := new(UsageReport) - resp, err := s.client.Do(ctx, req, usageReport) + var usageReport *UsageReport + resp, err := s.client.Do(ctx, req, &usageReport) if err != nil { return nil, resp, err } @@ -326,8 +326,8 @@ func (s *BillingService) GetUsageReport(ctx context.Context, user string, opts * return nil, nil, err } - usageReport := new(UsageReport) - resp, err := s.client.Do(ctx, req, usageReport) + var usageReport *UsageReport + resp, err := s.client.Do(ctx, req, &usageReport) if err != nil { return nil, resp, err } @@ -355,8 +355,8 @@ func (s *BillingService) GetOrganizationPremiumRequestUsageReport(ctx context.Co return nil, nil, err } - premiumRequestUsageReport := new(PremiumRequestUsageReport) - resp, err := s.client.Do(ctx, req, premiumRequestUsageReport) + var premiumRequestUsageReport *PremiumRequestUsageReport + resp, err := s.client.Do(ctx, req, &premiumRequestUsageReport) if err != nil { return nil, resp, err } @@ -384,8 +384,8 @@ func (s *BillingService) GetPremiumRequestUsageReport(ctx context.Context, user return nil, nil, err } - premiumRequestUsageReport := new(PremiumRequestUsageReport) - resp, err := s.client.Do(ctx, req, premiumRequestUsageReport) + var premiumRequestUsageReport *PremiumRequestUsageReport + resp, err := s.client.Do(ctx, req, &premiumRequestUsageReport) if err != nil { return nil, resp, err } diff --git a/github/checks.go b/github/checks.go index dcd661aa5e1..28c72d04b3f 100644 --- a/github/checks.go +++ b/github/checks.go @@ -113,8 +113,8 @@ func (s *ChecksService) GetCheckRun(ctx context.Context, owner, repo string, che req.Header.Set("Accept", mediaTypeCheckRunsPreview) - checkRun := new(CheckRun) - resp, err := s.client.Do(ctx, req, checkRun) + var checkRun *CheckRun + resp, err := s.client.Do(ctx, req, &checkRun) if err != nil { return nil, resp, err } @@ -136,8 +136,8 @@ func (s *ChecksService) GetCheckSuite(ctx context.Context, owner, repo string, c req.Header.Set("Accept", mediaTypeCheckRunsPreview) - checkSuite := new(CheckSuite) - resp, err := s.client.Do(ctx, req, checkSuite) + var checkSuite *CheckSuite + resp, err := s.client.Do(ctx, req, &checkSuite) if err != nil { return nil, resp, err } @@ -180,8 +180,8 @@ func (s *ChecksService) CreateCheckRun(ctx context.Context, owner, repo string, req.Header.Set("Accept", mediaTypeCheckRunsPreview) - checkRun := new(CheckRun) - resp, err := s.client.Do(ctx, req, checkRun) + var checkRun *CheckRun + resp, err := s.client.Do(ctx, req, &checkRun) if err != nil { return nil, resp, err } @@ -215,8 +215,8 @@ func (s *ChecksService) UpdateCheckRun(ctx context.Context, owner, repo string, req.Header.Set("Accept", mediaTypeCheckRunsPreview) - checkRun := new(CheckRun) - resp, err := s.client.Do(ctx, req, checkRun) + var checkRun *CheckRun + resp, err := s.client.Do(ctx, req, &checkRun) if err != nil { return nil, resp, err } @@ -453,8 +453,8 @@ func (s *ChecksService) CreateCheckSuite(ctx context.Context, owner, repo string req.Header.Set("Accept", mediaTypeCheckRunsPreview) - checkSuite := new(CheckSuite) - resp, err := s.client.Do(ctx, req, checkSuite) + var checkSuite *CheckSuite + resp, err := s.client.Do(ctx, req, &checkSuite) if err != nil { return nil, resp, err } diff --git a/github/classroom.go b/github/classroom.go index 47124dd4a0e..d9b84a9b62e 100644 --- a/github/classroom.go +++ b/github/classroom.go @@ -118,8 +118,8 @@ func (s *ClassroomService) GetAssignment(ctx context.Context, assignmentID int64 return nil, nil, err } - assignment := new(ClassroomAssignment) - resp, err := s.client.Do(ctx, req, assignment) + var assignment *ClassroomAssignment + resp, err := s.client.Do(ctx, req, &assignment) if err != nil { return nil, resp, err } @@ -141,8 +141,8 @@ func (s *ClassroomService) GetClassroom(ctx context.Context, classroomID int64) return nil, nil, err } - classroom := new(Classroom) - resp, err := s.client.Do(ctx, req, classroom) + var classroom *Classroom + resp, err := s.client.Do(ctx, req, &classroom) if err != nil { return nil, resp, err } diff --git a/github/code_scanning.go b/github/code_scanning.go index 982efc4597f..f5a1b94b619 100644 --- a/github/code_scanning.go +++ b/github/code_scanning.go @@ -318,8 +318,8 @@ func (s *CodeScanningService) GetAlert(ctx context.Context, owner, repo string, return nil, nil, err } - a := new(Alert) - resp, err := s.client.Do(ctx, req, a) + var a *Alert + resp, err := s.client.Do(ctx, req, &a) if err != nil { return nil, resp, err } @@ -345,8 +345,8 @@ func (s *CodeScanningService) UpdateAlert(ctx context.Context, owner, repo strin return nil, nil, err } - a := new(Alert) - resp, err := s.client.Do(ctx, req, a) + var a *Alert + resp, err := s.client.Do(ctx, req, &a) if err != nil { return nil, resp, err } @@ -410,8 +410,8 @@ func (s *CodeScanningService) UploadSarif(ctx context.Context, owner, repo strin if !errors.As(err, &acceptedError) { return nil, resp, err } - sarifID := new(SarifID) - decErr := json.Unmarshal(acceptedError.Raw, sarifID) + var sarifID *SarifID + decErr := json.Unmarshal(acceptedError.Raw, &sarifID) if decErr != nil { return nil, resp, decErr } @@ -444,8 +444,8 @@ func (s *CodeScanningService) GetSARIF(ctx context.Context, owner, repo, sarifID return nil, nil, err } - sarifUpload := new(SARIFUpload) - resp, err := s.client.Do(ctx, req, sarifUpload) + var sarifUpload *SARIFUpload + resp, err := s.client.Do(ctx, req, &sarifUpload) if err != nil { return nil, resp, err } @@ -501,8 +501,8 @@ func (s *CodeScanningService) GetAnalysis(ctx context.Context, owner, repo strin return nil, nil, err } - analysis := new(ScanningAnalysis) - resp, err := s.client.Do(ctx, req, analysis) + var analysis *ScanningAnalysis + resp, err := s.client.Do(ctx, req, &analysis) if err != nil { return nil, resp, err } @@ -536,8 +536,8 @@ func (s *CodeScanningService) DeleteAnalysis(ctx context.Context, owner, repo st return nil, nil, err } - deleteAnalysis := new(DeleteAnalysis) - resp, err := s.client.Do(ctx, req, deleteAnalysis) + var deleteAnalysis *DeleteAnalysis + resp, err := s.client.Do(ctx, req, &deleteAnalysis) if err != nil { return nil, resp, err } @@ -586,8 +586,8 @@ func (s *CodeScanningService) GetCodeQLDatabase(ctx context.Context, owner, repo return nil, nil, err } - codeqlDatabase := new(CodeQLDatabase) - resp, err := s.client.Do(ctx, req, codeqlDatabase) + var codeqlDatabase *CodeQLDatabase + resp, err := s.client.Do(ctx, req, &codeqlDatabase) if err != nil { return nil, resp, err } @@ -620,8 +620,8 @@ func (s *CodeScanningService) GetDefaultSetupConfiguration(ctx context.Context, return nil, nil, err } - cfg := new(DefaultSetupConfiguration) - resp, err := s.client.Do(ctx, req, cfg) + var cfg *DefaultSetupConfiguration + resp, err := s.client.Do(ctx, req, &cfg) if err != nil { return nil, resp, err } @@ -663,8 +663,8 @@ func (s *CodeScanningService) UpdateDefaultSetupConfiguration(ctx context.Contex return nil, nil, err } - a := new(UpdateDefaultSetupConfigurationResponse) - resp, err := s.client.Do(ctx, req, a) + var a *UpdateDefaultSetupConfigurationResponse + resp, err := s.client.Do(ctx, req, &a) if err != nil { return nil, resp, err } diff --git a/github/code_scanning_test.go b/github/code_scanning_test.go index 2befa22e2b5..c7aaf63b186 100644 --- a/github/code_scanning_test.go +++ b/github/code_scanning_test.go @@ -64,8 +64,8 @@ func TestCodeScanningService_UploadSarif(t *testing.T) { } mux.HandleFunc("/repos/o/r/code-scanning/sarifs", func(w http.ResponseWriter, r *http.Request) { - v := new(SarifAnalysis) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *SarifAnalysis + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") want := &SarifAnalysis{CommitSHA: Ptr("abc"), Ref: Ptr("ref/head/main"), Sarif: Ptr("abc"), CheckoutURI: Ptr("uri"), StartedAt: &Timestamp{time.Date(2006, time.January, 2, 15, 4, 5, 0, time.UTC)}, ToolName: Ptr("codeql-cli")} if !cmp.Equal(v, want) { diff --git a/github/codesofconduct.go b/github/codesofconduct.go index a514aac6b93..2e817eb426f 100644 --- a/github/codesofconduct.go +++ b/github/codesofconduct.go @@ -68,8 +68,8 @@ func (s *CodesOfConductService) Get(ctx context.Context, key string) (*CodeOfCon req.Header.Set("Accept", mediaTypeCodesOfConductPreview) - coc := new(CodeOfConduct) - resp, err := s.client.Do(ctx, req, coc) + var coc *CodeOfConduct + resp, err := s.client.Do(ctx, req, &coc) if err != nil { return nil, resp, err } diff --git a/github/copilot.go b/github/copilot.go index 445b6dda0fa..bca4f77c4da 100644 --- a/github/copilot.go +++ b/github/copilot.go @@ -238,20 +238,20 @@ func (cp *CopilotSeatDetails) UnmarshalJSON(data []byte) error { } if t, ok := v["type"].(string); ok && t == "User" { - user := &User{} - if err := json.Unmarshal(jsonData, user); err != nil { + var user *User + if err := json.Unmarshal(jsonData, &user); err != nil { return err } cp.Assignee = user } else if t, ok := v["type"].(string); ok && t == "Team" { - team := &Team{} - if err := json.Unmarshal(jsonData, team); err != nil { + var team *Team + if err := json.Unmarshal(jsonData, &team); err != nil { return err } cp.Assignee = team } else if t, ok := v["type"].(string); ok && t == "Organization" { - organization := &Organization{} - if err := json.Unmarshal(jsonData, organization); err != nil { + var organization *Organization + if err := json.Unmarshal(jsonData, &organization); err != nil { return err } cp.Assignee = organization diff --git a/github/copilot_test.go b/github/copilot_test.go index 1ee782bddad..eb87edef7cd 100644 --- a/github/copilot_test.go +++ b/github/copilot_test.go @@ -26,11 +26,9 @@ func TestCopilotSeatDetails_UnmarshalJSON(t *testing.T) { wantErr bool }{ { - name: "Invalid JSON", - data: `{`, - want: &CopilotSeatDetails{ - Assignee: nil, - }, + name: "Invalid JSON", + data: `{`, + want: nil, wantErr: true, }, { @@ -123,11 +121,11 @@ func TestCopilotSeatDetails_UnmarshalJSON(t *testing.T) { } for _, tc := range tests { - seatDetails := &CopilotSeatDetails{} + var seatDetails *CopilotSeatDetails t.Run(tc.name, func(t *testing.T) { t.Parallel() - err := json.Unmarshal([]byte(tc.data), seatDetails) + err := json.Unmarshal([]byte(tc.data), &seatDetails) if err == nil && tc.wantErr { t.Error("CopilotSeatDetails.UnmarshalJSON returned nil instead of an error") } @@ -150,9 +148,9 @@ func TestCopilotService_GetSeatDetailsUser(t *testing.T) { } }` - seatDetails := &CopilotSeatDetails{} + var seatDetails *CopilotSeatDetails - err := json.Unmarshal([]byte(data), seatDetails) + err := json.Unmarshal([]byte(data), &seatDetails) if err != nil { t.Errorf("CopilotSeatDetails.UnmarshalJSON returned an unexpected error: %v", err) } @@ -199,9 +197,9 @@ func TestCopilotService_GetSeatDetailsTeam(t *testing.T) { } }` - seatDetails := &CopilotSeatDetails{} + var seatDetails *CopilotSeatDetails - err := json.Unmarshal([]byte(data), seatDetails) + err := json.Unmarshal([]byte(data), &seatDetails) if err != nil { t.Errorf("CopilotSeatDetails.UnmarshalJSON returned an unexpected error: %v", err) } @@ -248,9 +246,9 @@ func TestCopilotService_GetSeatDetailsOrganization(t *testing.T) { } }` - seatDetails := &CopilotSeatDetails{} + var seatDetails *CopilotSeatDetails - err := json.Unmarshal([]byte(data), seatDetails) + err := json.Unmarshal([]byte(data), &seatDetails) if err != nil { t.Errorf("CopilotSeatDetails.UnmarshalJSON returned an unexpected error: %v", err) } diff --git a/github/dependabot_alerts.go b/github/dependabot_alerts.go index 67e624c9e88..ccc4b770329 100644 --- a/github/dependabot_alerts.go +++ b/github/dependabot_alerts.go @@ -155,8 +155,8 @@ func (s *DependabotService) GetRepoAlert(ctx context.Context, owner, repo string return nil, nil, err } - alert := new(DependabotAlert) - resp, err := s.client.Do(ctx, req, alert) + var alert *DependabotAlert + resp, err := s.client.Do(ctx, req, &alert) if err != nil { return nil, resp, err } @@ -176,8 +176,8 @@ func (s *DependabotService) UpdateAlert(ctx context.Context, owner, repo string, return nil, nil, err } - alert := new(DependabotAlert) - resp, err := s.client.Do(ctx, req, alert) + var alert *DependabotAlert + resp, err := s.client.Do(ctx, req, &alert) if err != nil { return nil, resp, err } diff --git a/github/dependabot_secrets.go b/github/dependabot_secrets.go index b4b3e0aa560..93dc83a5791 100644 --- a/github/dependabot_secrets.go +++ b/github/dependabot_secrets.go @@ -17,8 +17,8 @@ func (s *DependabotService) getPublicKey(ctx context.Context, url string) (*Publ return nil, nil, err } - pubKey := new(PublicKey) - resp, err := s.client.Do(ctx, req, pubKey) + var pubKey *PublicKey + resp, err := s.client.Do(ctx, req, &pubKey) if err != nil { return nil, resp, err } @@ -57,7 +57,7 @@ func (s *DependabotService) listSecrets(ctx context.Context, url string, opts *L return nil, nil, err } - secrets := new(Secrets) + var secrets *Secrets resp, err := s.client.Do(ctx, req, &secrets) if err != nil { return nil, resp, err @@ -94,8 +94,8 @@ func (s *DependabotService) getSecret(ctx context.Context, url string) (*Secret, return nil, nil, err } - secret := new(Secret) - resp, err := s.client.Do(ctx, req, secret) + var secret *Secret + resp, err := s.client.Do(ctx, req, &secret) if err != nil { return nil, resp, err } @@ -236,8 +236,8 @@ func (s *DependabotService) ListSelectedReposForOrgSecret(ctx context.Context, o return nil, nil, err } - result := new(SelectedReposList) - resp, err := s.client.Do(ctx, req, result) + var result *SelectedReposList + resp, err := s.client.Do(ctx, req, &result) if err != nil { return nil, resp, err } diff --git a/github/enterprise_actions_hosted_runners.go b/github/enterprise_actions_hosted_runners.go index 7465796445b..d6c8c8265a6 100644 --- a/github/enterprise_actions_hosted_runners.go +++ b/github/enterprise_actions_hosted_runners.go @@ -27,7 +27,7 @@ func (s *EnterpriseService) ListHostedRunners(ctx context.Context, enterprise st return nil, nil, err } - runners := &HostedRunners{} + var runners *HostedRunners resp, err := s.client.Do(ctx, req, &runners) if err != nil { return nil, resp, err @@ -52,8 +52,8 @@ func (s *EnterpriseService) CreateHostedRunner(ctx context.Context, enterprise s return nil, nil, err } - hostedRunner := new(HostedRunner) - resp, err := s.client.Do(ctx, req, hostedRunner) + var hostedRunner *HostedRunner + resp, err := s.client.Do(ctx, req, &hostedRunner) if err != nil { return nil, resp, err } @@ -73,8 +73,8 @@ func (s *EnterpriseService) GetHostedRunnerGitHubOwnedImages(ctx context.Context return nil, nil, err } - hostedRunnerImages := new(HostedRunnerImages) - resp, err := s.client.Do(ctx, req, hostedRunnerImages) + var hostedRunnerImages *HostedRunnerImages + resp, err := s.client.Do(ctx, req, &hostedRunnerImages) if err != nil { return nil, resp, err } @@ -94,8 +94,8 @@ func (s *EnterpriseService) GetHostedRunnerPartnerImages(ctx context.Context, en return nil, nil, err } - hostedRunnerImages := new(HostedRunnerImages) - resp, err := s.client.Do(ctx, req, hostedRunnerImages) + var hostedRunnerImages *HostedRunnerImages + resp, err := s.client.Do(ctx, req, &hostedRunnerImages) if err != nil { return nil, resp, err } @@ -115,8 +115,8 @@ func (s *EnterpriseService) GetHostedRunnerLimits(ctx context.Context, enterpris return nil, nil, err } - publicIPLimits := new(HostedRunnerPublicIPLimits) - resp, err := s.client.Do(ctx, req, publicIPLimits) + var publicIPLimits *HostedRunnerPublicIPLimits + resp, err := s.client.Do(ctx, req, &publicIPLimits) if err != nil { return nil, resp, err } @@ -136,8 +136,8 @@ func (s *EnterpriseService) GetHostedRunnerMachineSpecs(ctx context.Context, ent return nil, nil, err } - machineSpecs := new(HostedRunnerMachineSpecs) - resp, err := s.client.Do(ctx, req, machineSpecs) + var machineSpecs *HostedRunnerMachineSpecs + resp, err := s.client.Do(ctx, req, &machineSpecs) if err != nil { return nil, resp, err } @@ -157,8 +157,8 @@ func (s *EnterpriseService) GetHostedRunnerPlatforms(ctx context.Context, enterp return nil, nil, err } - platforms := new(HostedRunnerPlatforms) - resp, err := s.client.Do(ctx, req, platforms) + var platforms *HostedRunnerPlatforms + resp, err := s.client.Do(ctx, req, &platforms) if err != nil { return nil, resp, err } @@ -178,8 +178,8 @@ func (s *EnterpriseService) GetHostedRunner(ctx context.Context, enterprise stri return nil, nil, err } - hostedRunner := new(HostedRunner) - resp, err := s.client.Do(ctx, req, hostedRunner) + var hostedRunner *HostedRunner + resp, err := s.client.Do(ctx, req, &hostedRunner) if err != nil { return nil, resp, err } @@ -199,8 +199,8 @@ func (s *EnterpriseService) UpdateHostedRunner(ctx context.Context, enterprise s return nil, nil, err } - hostedRunner := new(HostedRunner) - resp, err := s.client.Do(ctx, req, hostedRunner) + var hostedRunner *HostedRunner + resp, err := s.client.Do(ctx, req, &hostedRunner) if err != nil { return nil, resp, err } @@ -220,8 +220,8 @@ func (s *EnterpriseService) DeleteHostedRunner(ctx context.Context, enterprise s return nil, nil, err } - hostedRunner := new(HostedRunner) - resp, err := s.client.Do(ctx, req, hostedRunner) + var hostedRunner *HostedRunner + resp, err := s.client.Do(ctx, req, &hostedRunner) if err != nil { return nil, resp, err } diff --git a/github/enterprise_actions_runner_groups.go b/github/enterprise_actions_runner_groups.go index f171df75734..c80d14cdc51 100644 --- a/github/enterprise_actions_runner_groups.go +++ b/github/enterprise_actions_runner_groups.go @@ -94,7 +94,7 @@ func (s *EnterpriseService) ListRunnerGroups(ctx context.Context, enterprise str return nil, nil, err } - groups := &EnterpriseRunnerGroups{} + var groups *EnterpriseRunnerGroups resp, err := s.client.Do(ctx, req, &groups) if err != nil { return nil, resp, err @@ -115,8 +115,8 @@ func (s *EnterpriseService) GetEnterpriseRunnerGroup(ctx context.Context, enterp return nil, nil, err } - runnerGroup := new(EnterpriseRunnerGroup) - resp, err := s.client.Do(ctx, req, runnerGroup) + var runnerGroup *EnterpriseRunnerGroup + resp, err := s.client.Do(ctx, req, &runnerGroup) if err != nil { return nil, resp, err } @@ -152,8 +152,8 @@ func (s *EnterpriseService) CreateEnterpriseRunnerGroup(ctx context.Context, ent return nil, nil, err } - runnerGroup := new(EnterpriseRunnerGroup) - resp, err := s.client.Do(ctx, req, runnerGroup) + var runnerGroup *EnterpriseRunnerGroup + resp, err := s.client.Do(ctx, req, &runnerGroup) if err != nil { return nil, resp, err } @@ -173,8 +173,8 @@ func (s *EnterpriseService) UpdateEnterpriseRunnerGroup(ctx context.Context, ent return nil, nil, err } - runnerGroup := new(EnterpriseRunnerGroup) - resp, err := s.client.Do(ctx, req, runnerGroup) + var runnerGroup *EnterpriseRunnerGroup + resp, err := s.client.Do(ctx, req, &runnerGroup) if err != nil { return nil, resp, err } @@ -199,7 +199,7 @@ func (s *EnterpriseService) ListOrganizationAccessRunnerGroup(ctx context.Contex return nil, nil, err } - orgs := &ListOrganizations{} + var orgs *ListOrganizations resp, err := s.client.Do(ctx, req, &orgs) if err != nil { return nil, resp, err @@ -276,7 +276,7 @@ func (s *EnterpriseService) ListRunnerGroupRunners(ctx context.Context, enterpri return nil, nil, err } - runners := &Runners{} + var runners *Runners resp, err := s.client.Do(ctx, req, &runners) if err != nil { return nil, resp, err diff --git a/github/enterprise_actions_runners.go b/github/enterprise_actions_runners.go index 408dcfd8493..0f519a082d4 100644 --- a/github/enterprise_actions_runners.go +++ b/github/enterprise_actions_runners.go @@ -44,8 +44,8 @@ func (s *EnterpriseService) GenerateEnterpriseJITConfig(ctx context.Context, ent return nil, nil, err } - jitConfig := new(JITRunnerConfig) - resp, err := s.client.Do(ctx, req, jitConfig) + var jitConfig *JITRunnerConfig + resp, err := s.client.Do(ctx, req, &jitConfig) if err != nil { return nil, resp, err } @@ -66,8 +66,8 @@ func (s *EnterpriseService) CreateRegistrationToken(ctx context.Context, enterpr return nil, nil, err } - registrationToken := new(RegistrationToken) - resp, err := s.client.Do(ctx, req, registrationToken) + var registrationToken *RegistrationToken + resp, err := s.client.Do(ctx, req, ®istrationToken) if err != nil { return nil, resp, err } @@ -92,7 +92,7 @@ func (s *EnterpriseService) ListRunners(ctx context.Context, enterprise string, return nil, nil, err } - runners := &Runners{} + var runners *Runners resp, err := s.client.Do(ctx, req, &runners) if err != nil { return nil, resp, err @@ -113,8 +113,8 @@ func (s *EnterpriseService) GetRunner(ctx context.Context, enterprise string, ru return nil, nil, err } - runner := new(Runner) - resp, err := s.client.Do(ctx, req, runner) + var runner *Runner + resp, err := s.client.Do(ctx, req, &runner) if err != nil { return nil, resp, err } diff --git a/github/enterprise_actions_runners_test.go b/github/enterprise_actions_runners_test.go index 53e5f30c2cb..a8016a4194f 100644 --- a/github/enterprise_actions_runners_test.go +++ b/github/enterprise_actions_runners_test.go @@ -22,8 +22,8 @@ func TestEnterpriseService_GenerateEnterpriseJITConfig(t *testing.T) { input := &GenerateJITConfigRequest{Name: "test", RunnerGroupID: 1, Labels: []string{"one", "two"}} mux.HandleFunc("/enterprises/o/actions/runners/generate-jitconfig", func(w http.ResponseWriter, r *http.Request) { - v := new(GenerateJITConfigRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *GenerateJITConfigRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { diff --git a/github/enterprise_billing_cost_centers.go b/github/enterprise_billing_cost_centers.go index 3cc3279da0f..bb41ea074d8 100644 --- a/github/enterprise_billing_cost_centers.go +++ b/github/enterprise_billing_cost_centers.go @@ -91,8 +91,8 @@ func (s *EnterpriseService) ListCostCenters(ctx context.Context, enterprise stri return nil, nil, err } - costCenters := &CostCenters{} - resp, err := s.client.Do(ctx, req, costCenters) + var costCenters *CostCenters + resp, err := s.client.Do(ctx, req, &costCenters) if err != nil { return nil, resp, err } @@ -113,8 +113,8 @@ func (s *EnterpriseService) CreateCostCenter(ctx context.Context, enterprise str return nil, nil, err } - result := &CostCenter{} - resp, err := s.client.Do(ctx, req, result) + var result *CostCenter + resp, err := s.client.Do(ctx, req, &result) if err != nil { return nil, resp, err } @@ -135,8 +135,8 @@ func (s *EnterpriseService) GetCostCenter(ctx context.Context, enterprise, costC return nil, nil, err } - costCenter := &CostCenter{} - resp, err := s.client.Do(ctx, req, costCenter) + var costCenter *CostCenter + resp, err := s.client.Do(ctx, req, &costCenter) if err != nil { return nil, resp, err } @@ -157,8 +157,8 @@ func (s *EnterpriseService) UpdateCostCenter(ctx context.Context, enterprise, co return nil, nil, err } - result := &CostCenter{} - resp, err := s.client.Do(ctx, req, result) + var result *CostCenter + resp, err := s.client.Do(ctx, req, &result) if err != nil { return nil, resp, err } @@ -179,8 +179,8 @@ func (s *EnterpriseService) DeleteCostCenter(ctx context.Context, enterprise, co return nil, nil, err } - result := &DeleteCostCenterResponse{} - resp, err := s.client.Do(ctx, req, result) + var result *DeleteCostCenterResponse + resp, err := s.client.Do(ctx, req, &result) if err != nil { return nil, resp, err } @@ -201,8 +201,8 @@ func (s *EnterpriseService) AddResourcesToCostCenter(ctx context.Context, enterp return nil, nil, err } - result := &AddResourcesToCostCenterResponse{} - resp, err := s.client.Do(ctx, req, result) + var result *AddResourcesToCostCenterResponse + resp, err := s.client.Do(ctx, req, &result) if err != nil { return nil, resp, err } @@ -223,8 +223,8 @@ func (s *EnterpriseService) RemoveResourcesFromCostCenter(ctx context.Context, e return nil, nil, err } - result := &RemoveResourcesFromCostCenterResponse{} - resp, err := s.client.Do(ctx, req, result) + var result *RemoveResourcesFromCostCenterResponse + resp, err := s.client.Do(ctx, req, &result) if err != nil { return nil, resp, err } diff --git a/github/enterprise_code_security_and_analysis.go b/github/enterprise_code_security_and_analysis.go index 159aeae4dca..bbd13877571 100644 --- a/github/enterprise_code_security_and_analysis.go +++ b/github/enterprise_code_security_and_analysis.go @@ -32,8 +32,8 @@ func (s *EnterpriseService) GetCodeSecurityAndAnalysis(ctx context.Context, ente return nil, nil, err } - settings := new(EnterpriseSecurityAnalysisSettings) - resp, err := s.client.Do(ctx, req, settings) + var settings *EnterpriseSecurityAnalysisSettings + resp, err := s.client.Do(ctx, req, &settings) if err != nil { return nil, resp, err } diff --git a/github/enterprise_code_security_and_analysis_test.go b/github/enterprise_code_security_and_analysis_test.go index 666563bee96..479c32aa91f 100644 --- a/github/enterprise_code_security_and_analysis_test.go +++ b/github/enterprise_code_security_and_analysis_test.go @@ -78,8 +78,8 @@ func TestEnterpriseService_UpdateCodeSecurityAndAnalysis(t *testing.T) { } mux.HandleFunc("/enterprises/e/code_security_and_analysis", func(_ http.ResponseWriter, r *http.Request) { - v := new(EnterpriseSecurityAnalysisSettings) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *EnterpriseSecurityAnalysisSettings + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { diff --git a/github/enterprise_codesecurity_configurations_test.go b/github/enterprise_codesecurity_configurations_test.go index 5a807f158d5..c805968fb36 100644 --- a/github/enterprise_codesecurity_configurations_test.go +++ b/github/enterprise_codesecurity_configurations_test.go @@ -307,8 +307,8 @@ func TestEnterpriseService_AttachCodeSecurityConfigurationToRepositories(t *test type request struct { Scope string `json:"scope"` } - v := new(request) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *request + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) if v.Scope != "all_without_configurations" { t.Errorf("Enterprise.AttachCodeSecurityConfigurationToRepositories request body scope = %v, want selected", v.Scope) } diff --git a/github/enterprise_licenses.go b/github/enterprise_licenses.go index e58fc07c640..59a83af02ab 100644 --- a/github/enterprise_licenses.go +++ b/github/enterprise_licenses.go @@ -106,7 +106,7 @@ func (s *EnterpriseService) GetConsumedLicenses(ctx context.Context, enterprise return nil, nil, err } - consumedLicenses := &EnterpriseConsumedLicenses{} + var consumedLicenses *EnterpriseConsumedLicenses resp, err := s.client.Do(ctx, req, &consumedLicenses) if err != nil { return nil, resp, err @@ -128,7 +128,7 @@ func (s *EnterpriseService) GetLicenseSyncStatus(ctx context.Context, enterprise return nil, nil, err } - syncStatus := &EnterpriseLicenseSyncStatus{} + var syncStatus *EnterpriseLicenseSyncStatus resp, err := s.client.Do(ctx, req, &syncStatus) if err != nil { return nil, resp, err diff --git a/github/enterprise_manage_ghes.go b/github/enterprise_manage_ghes.go index 023c119d152..7efb47f5250 100644 --- a/github/enterprise_manage_ghes.go +++ b/github/enterprise_manage_ghes.go @@ -84,8 +84,8 @@ func (s *EnterpriseService) CheckSystemRequirements(ctx context.Context) (*Syste return nil, nil, err } - systemRequirements := new(SystemRequirements) - resp, err := s.client.Do(ctx, req, systemRequirements) + var systemRequirements *SystemRequirements + resp, err := s.client.Do(ctx, req, &systemRequirements) if err != nil { return nil, resp, err } @@ -105,8 +105,8 @@ func (s *EnterpriseService) ClusterStatus(ctx context.Context) (*ClusterStatus, return nil, nil, err } - clusterStatus := new(ClusterStatus) - resp, err := s.client.Do(ctx, req, clusterStatus) + var clusterStatus *ClusterStatus + resp, err := s.client.Do(ctx, req, &clusterStatus) if err != nil { return nil, resp, err } @@ -129,8 +129,8 @@ func (s *EnterpriseService) ReplicationStatus(ctx context.Context, opts *NodeQue return nil, nil, err } - status := new(ClusterStatus) - resp, err := s.client.Do(ctx, req, status) + var status *ClusterStatus + resp, err := s.client.Do(ctx, req, &status) if err != nil { return nil, resp, err } diff --git a/github/enterprise_manage_ghes_config.go b/github/enterprise_manage_ghes_config.go index 92bf3d71ab9..a20bc1abd9b 100644 --- a/github/enterprise_manage_ghes_config.go +++ b/github/enterprise_manage_ghes_config.go @@ -318,8 +318,8 @@ func (s *EnterpriseService) ConfigApplyEvents(ctx context.Context, opts *ConfigA return nil, nil, err } - configApplyEvents := new(ConfigApplyEvents) - resp, err := s.client.Do(ctx, req, configApplyEvents) + var configApplyEvents *ConfigApplyEvents + resp, err := s.client.Do(ctx, req, &configApplyEvents) if err != nil { return nil, resp, err } @@ -425,8 +425,8 @@ func (s *EnterpriseService) NodeMetadata(ctx context.Context, opts *NodeQueryOpt return nil, nil, err } - status := new(NodeMetadataStatus) - resp, err := s.client.Do(ctx, req, status) + var status *NodeMetadataStatus + resp, err := s.client.Do(ctx, req, &status) if err != nil { return nil, resp, err } @@ -446,8 +446,8 @@ func (s *EnterpriseService) Settings(ctx context.Context) (*ConfigSettings, *Res return nil, nil, err } - configSettings := new(ConfigSettings) - resp, err := s.client.Do(ctx, req, configSettings) + var configSettings *ConfigSettings + resp, err := s.client.Do(ctx, req, &configSettings) if err != nil { return nil, resp, err } @@ -486,8 +486,8 @@ func (s *EnterpriseService) ConfigApply(ctx context.Context, opts *ConfigApplyOp return nil, nil, err } - configApplyOptions := new(ConfigApplyOptions) - resp, err := s.client.Do(ctx, req, configApplyOptions) + var configApplyOptions *ConfigApplyOptions + resp, err := s.client.Do(ctx, req, &configApplyOptions) if err != nil { return nil, resp, err } @@ -507,8 +507,8 @@ func (s *EnterpriseService) ConfigApplyStatus(ctx context.Context, opts *ConfigA return nil, nil, err } - status := new(ConfigApplyStatus) - resp, err := s.client.Do(ctx, req, status) + var status *ConfigApplyStatus + resp, err := s.client.Do(ctx, req, &status) if err != nil { return nil, resp, err } diff --git a/github/enterprise_manage_ghes_config_test.go b/github/enterprise_manage_ghes_config_test.go index 8f7f4e0a21c..faf9af4a2f5 100644 --- a/github/enterprise_manage_ghes_config_test.go +++ b/github/enterprise_manage_ghes_config_test.go @@ -603,8 +603,8 @@ func TestEnterpriseService_InitialConfig(t *testing.T) { } mux.HandleFunc("/manage/v1/config/init", func(_ http.ResponseWriter, r *http.Request) { - v := new(InitialConfigOptions) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *InitialConfigOptions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if diff := cmp.Diff(v, input); diff != "" { @@ -629,8 +629,8 @@ func TestEnterpriseService_ConfigApply(t *testing.T) { mux.HandleFunc("/manage/v1/config/apply", func(w http.ResponseWriter, r *http.Request) { testMethod(t, r, "POST") - got := new(ConfigApplyOptions) - assertNilError(t, json.NewDecoder(r.Body).Decode(got)) + var got *ConfigApplyOptions + assertNilError(t, json.NewDecoder(r.Body).Decode(&got)) want := &ConfigApplyOptions{ RunID: Ptr("1234"), @@ -673,8 +673,8 @@ func TestEnterpriseService_ConfigApplyStatus(t *testing.T) { mux.HandleFunc("/manage/v1/config/apply", func(w http.ResponseWriter, r *http.Request) { testMethod(t, r, "GET") - got := new(ConfigApplyOptions) - assertNilError(t, json.NewDecoder(r.Body).Decode(got)) + var got *ConfigApplyOptions + assertNilError(t, json.NewDecoder(r.Body).Decode(&got)) want := &ConfigApplyOptions{ RunID: Ptr("1234"), diff --git a/github/enterprise_manage_ghes_maintenance_test.go b/github/enterprise_manage_ghes_maintenance_test.go index 98e084724b5..73f100f47f3 100644 --- a/github/enterprise_manage_ghes_maintenance_test.go +++ b/github/enterprise_manage_ghes_maintenance_test.go @@ -95,8 +95,8 @@ func TestEnterpriseService_CreateMaintenance(t *testing.T) { } mux.HandleFunc("/manage/v1/maintenance", func(w http.ResponseWriter, r *http.Request) { - v := new(MaintenanceOptions) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *MaintenanceOptions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { diff --git a/github/enterprise_manage_ghes_ssh_test.go b/github/enterprise_manage_ghes_ssh_test.go index f8b9f725570..3262e0f8647 100644 --- a/github/enterprise_manage_ghes_ssh_test.go +++ b/github/enterprise_manage_ghes_ssh_test.go @@ -59,8 +59,8 @@ func TestEnterpriseService_DeleteSSHKey(t *testing.T) { } mux.HandleFunc("/manage/v1/access/ssh", func(w http.ResponseWriter, r *http.Request) { - v := new(SSHKeyOptions) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *SSHKeyOptions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "DELETE") if !cmp.Equal(v, input) { @@ -100,8 +100,8 @@ func TestEnterpriseService_CreateSSHKey(t *testing.T) { } mux.HandleFunc("/manage/v1/access/ssh", func(w http.ResponseWriter, r *http.Request) { - v := new(SSHKeyOptions) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *SSHKeyOptions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { diff --git a/github/enterprise_network_configurations.go b/github/enterprise_network_configurations.go index a6a690d786b..8b6ee1b75cf 100644 --- a/github/enterprise_network_configurations.go +++ b/github/enterprise_network_configurations.go @@ -27,11 +27,12 @@ func (s *EnterpriseService) ListEnterpriseNetworkConfigurations(ctx context.Cont return nil, nil, err } - networks := &NetworkConfigurations{} - resp, err := s.client.Do(ctx, req, networks) + var networks *NetworkConfigurations + resp, err := s.client.Do(ctx, req, &networks) if err != nil { return nil, resp, err } + return networks, resp, nil } @@ -51,8 +52,8 @@ func (s *EnterpriseService) CreateEnterpriseNetworkConfiguration(ctx context.Con return nil, nil, err } - network := &NetworkConfiguration{} - resp, err := s.client.Do(ctx, req, network) + var network *NetworkConfiguration + resp, err := s.client.Do(ctx, req, &network) if err != nil { return nil, resp, err } @@ -72,11 +73,12 @@ func (s *EnterpriseService) GetEnterpriseNetworkConfiguration(ctx context.Contex return nil, nil, err } - network := &NetworkConfiguration{} - resp, err := s.client.Do(ctx, req, network) + var network *NetworkConfiguration + resp, err := s.client.Do(ctx, req, &network) if err != nil { return nil, resp, err } + return network, resp, nil } @@ -96,11 +98,12 @@ func (s *EnterpriseService) UpdateEnterpriseNetworkConfiguration(ctx context.Con return nil, nil, err } - network := &NetworkConfiguration{} - resp, err := s.client.Do(ctx, req, network) + var network *NetworkConfiguration + resp, err := s.client.Do(ctx, req, &network) if err != nil { return nil, resp, err } + return network, resp, nil } @@ -115,6 +118,7 @@ func (s *EnterpriseService) DeleteEnterpriseNetworkConfiguration(ctx context.Con if err != nil { return nil, err } + return s.client.Do(ctx, req, nil) } @@ -130,10 +134,11 @@ func (s *EnterpriseService) GetEnterpriseNetworkSettingsResource(ctx context.Con return nil, nil, err } - resource := &NetworkSettingsResource{} - resp, err := s.client.Do(ctx, req, resource) + var resource *NetworkSettingsResource + resp, err := s.client.Do(ctx, req, &resource) if err != nil { return nil, resp, err } + return resource, resp, err } diff --git a/github/enterprise_scim.go b/github/enterprise_scim.go index 9f9e296944c..31d248f6c9f 100644 --- a/github/enterprise_scim.go +++ b/github/enterprise_scim.go @@ -190,8 +190,8 @@ func (s *EnterpriseService) ListProvisionedSCIMGroups(ctx context.Context, enter } req.Header.Set("Accept", mediaTypeSCIM) - groups := new(SCIMEnterpriseGroups) - resp, err := s.client.Do(ctx, req, groups) + var groups *SCIMEnterpriseGroups + resp, err := s.client.Do(ctx, req, &groups) if err != nil { return nil, resp, err } @@ -221,8 +221,8 @@ func (s *EnterpriseService) ListProvisionedSCIMUsers(ctx context.Context, enterp } req.Header.Set("Accept", mediaTypeSCIM) - users := new(SCIMEnterpriseUsers) - resp, err := s.client.Do(ctx, req, users) + var users *SCIMEnterpriseUsers + resp, err := s.client.Do(ctx, req, &users) if err != nil { return nil, resp, err } @@ -247,8 +247,8 @@ func (s *EnterpriseService) SetProvisionedSCIMGroup(ctx context.Context, enterpr } req.Header.Set("Accept", mediaTypeSCIM) - groupNew := new(SCIMEnterpriseGroupAttributes) - resp, err := s.client.Do(ctx, req, groupNew) + var groupNew *SCIMEnterpriseGroupAttributes + resp, err := s.client.Do(ctx, req, &groupNew) if err != nil { return nil, resp, err } @@ -275,8 +275,8 @@ func (s *EnterpriseService) SetProvisionedSCIMUser(ctx context.Context, enterpri } req.Header.Set("Accept", mediaTypeSCIM) - userNew := new(SCIMEnterpriseUserAttributes) - resp, err := s.client.Do(ctx, req, userNew) + var userNew *SCIMEnterpriseUserAttributes + resp, err := s.client.Do(ctx, req, &userNew) if err != nil { return nil, resp, err } @@ -305,8 +305,8 @@ func (s *EnterpriseService) UpdateSCIMGroupAttribute(ctx context.Context, enterp } req.Header.Set("Accept", mediaTypeSCIM) - group := new(SCIMEnterpriseGroupAttributes) - resp, err := s.client.Do(ctx, req, group) + var group *SCIMEnterpriseGroupAttributes + resp, err := s.client.Do(ctx, req, &group) if err != nil { return nil, resp, err } @@ -337,8 +337,8 @@ func (s *EnterpriseService) UpdateSCIMUserAttribute(ctx context.Context, enterpr } req.Header.Set("Accept", mediaTypeSCIM) - user := new(SCIMEnterpriseUserAttributes) - resp, err := s.client.Do(ctx, req, user) + var user *SCIMEnterpriseUserAttributes + resp, err := s.client.Do(ctx, req, &user) if err != nil { return nil, resp, err } @@ -359,8 +359,8 @@ func (s *EnterpriseService) ProvisionSCIMGroup(ctx context.Context, enterprise s } req.Header.Set("Accept", mediaTypeSCIM) - groupProvisioned := new(SCIMEnterpriseGroupAttributes) - resp, err := s.client.Do(ctx, req, groupProvisioned) + var groupProvisioned *SCIMEnterpriseGroupAttributes + resp, err := s.client.Do(ctx, req, &groupProvisioned) if err != nil { return nil, resp, err } @@ -381,8 +381,8 @@ func (s *EnterpriseService) ProvisionSCIMUser(ctx context.Context, enterprise st } req.Header.Set("Accept", mediaTypeSCIM) - userProvisioned := new(SCIMEnterpriseUserAttributes) - resp, err := s.client.Do(ctx, req, userProvisioned) + var userProvisioned *SCIMEnterpriseUserAttributes + resp, err := s.client.Do(ctx, req, &userProvisioned) if err != nil { return nil, resp, err } @@ -412,8 +412,8 @@ func (s *EnterpriseService) GetProvisionedSCIMGroup(ctx context.Context, enterpr } req.Header.Set("Accept", mediaTypeSCIM) - group := new(SCIMEnterpriseGroupAttributes) - resp, err := s.client.Do(ctx, req, group) + var group *SCIMEnterpriseGroupAttributes + resp, err := s.client.Do(ctx, req, &group) if err != nil { return nil, resp, err } @@ -435,8 +435,8 @@ func (s *EnterpriseService) GetProvisionedSCIMUser(ctx context.Context, enterpri } req.Header.Set("Accept", mediaTypeSCIM) - user := new(SCIMEnterpriseUserAttributes) - resp, err := s.client.Do(ctx, req, user) + var user *SCIMEnterpriseUserAttributes + resp, err := s.client.Do(ctx, req, &user) if err != nil { return nil, resp, err } diff --git a/github/event_types_test.go b/github/event_types_test.go index 74ca820a033..d11aa7c2834 100644 --- a/github/event_types_test.go +++ b/github/event_types_test.go @@ -8445,7 +8445,6 @@ func TestPingEvent_Marshal(t *testing.T) { l := make(map[string]any) l["key"] = "value" - hookConfig := new(HookConfig) u := &PingEvent{ Zen: Ptr("z"), @@ -8460,7 +8459,7 @@ func TestPingEvent_Marshal(t *testing.T) { TestURL: Ptr("tu"), PingURL: Ptr("pu"), LastResponse: l, - Config: hookConfig, + Config: &HookConfig{}, Events: []string{"a"}, Active: Ptr(true), }, diff --git a/github/examples_test.go b/github/examples_test.go index da4b300670d..5fc556b3337 100644 --- a/github/examples_test.go +++ b/github/examples_test.go @@ -95,9 +95,9 @@ func ExampleRepositoriesService_CreateFile() { func ExampleUsersService_ListAll() { client := github.NewClient(nil) + ctx := context.Background() opts := &github.UserListOptions{} for { - ctx := context.Background() users, _, err := client.Users.ListAll(ctx, opts) if err != nil { log.Fatalf("error listing users: %v", err) diff --git a/github/gists.go b/github/gists.go index 8b5dd47d8ec..6d9f86bf81c 100644 --- a/github/gists.go +++ b/github/gists.go @@ -190,8 +190,8 @@ func (s *GistsService) Get(ctx context.Context, id string) (*Gist, *Response, er return nil, nil, err } - gist := new(Gist) - resp, err := s.client.Do(ctx, req, gist) + var gist *Gist + resp, err := s.client.Do(ctx, req, &gist) if err != nil { return nil, resp, err } @@ -211,8 +211,8 @@ func (s *GistsService) GetRevision(ctx context.Context, id, sha string) (*Gist, return nil, nil, err } - gist := new(Gist) - resp, err := s.client.Do(ctx, req, gist) + var gist *Gist + resp, err := s.client.Do(ctx, req, &gist) if err != nil { return nil, resp, err } @@ -232,8 +232,8 @@ func (s *GistsService) Create(ctx context.Context, gist *Gist) (*Gist, *Response return nil, nil, err } - g := new(Gist) - resp, err := s.client.Do(ctx, req, g) + var g *Gist + resp, err := s.client.Do(ctx, req, &g) if err != nil { return nil, resp, err } @@ -253,8 +253,8 @@ func (s *GistsService) Edit(ctx context.Context, id string, gist *Gist) (*Gist, return nil, nil, err } - g := new(Gist) - resp, err := s.client.Do(ctx, req, g) + var g *Gist + resp, err := s.client.Do(ctx, req, &g) if err != nil { return nil, resp, err } @@ -362,8 +362,8 @@ func (s *GistsService) Fork(ctx context.Context, id string) (*Gist, *Response, e return nil, nil, err } - g := new(Gist) - resp, err := s.client.Do(ctx, req, g) + var g *Gist + resp, err := s.client.Do(ctx, req, &g) if err != nil { return nil, resp, err } diff --git a/github/gists_comments.go b/github/gists_comments.go index 5e0614231b8..a597a190ccf 100644 --- a/github/gists_comments.go +++ b/github/gists_comments.go @@ -61,8 +61,8 @@ func (s *GistsService) GetComment(ctx context.Context, gistID string, commentID return nil, nil, err } - c := new(GistComment) - resp, err := s.client.Do(ctx, req, c) + var c *GistComment + resp, err := s.client.Do(ctx, req, &c) if err != nil { return nil, resp, err } @@ -82,8 +82,8 @@ func (s *GistsService) CreateComment(ctx context.Context, gistID string, comment return nil, nil, err } - c := new(GistComment) - resp, err := s.client.Do(ctx, req, c) + var c *GistComment + resp, err := s.client.Do(ctx, req, &c) if err != nil { return nil, resp, err } @@ -103,8 +103,8 @@ func (s *GistsService) EditComment(ctx context.Context, gistID string, commentID return nil, nil, err } - c := new(GistComment) - resp, err := s.client.Do(ctx, req, c) + var c *GistComment + resp, err := s.client.Do(ctx, req, &c) if err != nil { return nil, resp, err } diff --git a/github/gists_comments_test.go b/github/gists_comments_test.go index cd3b58ffde8..63795ff9c20 100644 --- a/github/gists_comments_test.go +++ b/github/gists_comments_test.go @@ -169,8 +169,8 @@ func TestGistsService_CreateComment(t *testing.T) { input := &GistComment{ID: Ptr(int64(1)), Body: Ptr("b")} mux.HandleFunc("/gists/1/comments", func(w http.ResponseWriter, r *http.Request) { - v := new(GistComment) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *GistComment + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { @@ -222,8 +222,8 @@ func TestGistsService_EditComment(t *testing.T) { input := &GistComment{ID: Ptr(int64(1)), Body: Ptr("b")} mux.HandleFunc("/gists/1/comments/2", func(w http.ResponseWriter, r *http.Request) { - v := new(GistComment) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *GistComment + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { diff --git a/github/gists_test.go b/github/gists_test.go index 0748f23d0ba..cb47fecfae1 100644 --- a/github/gists_test.go +++ b/github/gists_test.go @@ -485,8 +485,8 @@ func TestGistsService_Create(t *testing.T) { } mux.HandleFunc("/gists", func(w http.ResponseWriter, r *http.Request) { - v := new(Gist) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *Gist + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { @@ -547,8 +547,8 @@ func TestGistsService_Edit(t *testing.T) { } mux.HandleFunc("/gists/1", func(w http.ResponseWriter, r *http.Request) { - v := new(Gist) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *Gist + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { diff --git a/github/git_blobs.go b/github/git_blobs.go index c734d595b30..bb46371f11a 100644 --- a/github/git_blobs.go +++ b/github/git_blobs.go @@ -33,8 +33,8 @@ func (s *GitService) GetBlob(ctx context.Context, owner, repo, sha string) (*Blo return nil, nil, err } - blob := new(Blob) - resp, err := s.client.Do(ctx, req, blob) + var blob *Blob + resp, err := s.client.Do(ctx, req, &blob) if err != nil { return nil, resp, err } @@ -78,11 +78,11 @@ func (s *GitService) CreateBlob(ctx context.Context, owner, repo string, blob Bl return nil, nil, err } - t := new(Blob) - resp, err := s.client.Do(ctx, req, t) + var v *Blob + resp, err := s.client.Do(ctx, req, &v) if err != nil { return nil, resp, err } - return t, resp, nil + return v, resp, nil } diff --git a/github/git_blobs_test.go b/github/git_blobs_test.go index b415bab442a..b1a35ac60dd 100644 --- a/github/git_blobs_test.go +++ b/github/git_blobs_test.go @@ -116,8 +116,8 @@ func TestGitService_CreateBlob(t *testing.T) { } mux.HandleFunc("/repos/o/r/git/blobs", func(w http.ResponseWriter, r *http.Request) { - v := new(Blob) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *Blob + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") diff --git a/github/git_commits.go b/github/git_commits.go index 5bf6cf7aa9b..529ce588279 100644 --- a/github/git_commits.go +++ b/github/git_commits.go @@ -92,8 +92,8 @@ func (s *GitService) GetCommit(ctx context.Context, owner, repo, sha string) (*C return nil, nil, err } - c := new(Commit) - resp, err := s.client.Do(ctx, req, c) + var c *Commit + resp, err := s.client.Do(ctx, req, &c) if err != nil { return nil, resp, err } @@ -166,8 +166,8 @@ func (s *GitService) CreateCommit(ctx context.Context, owner, repo string, commi return nil, nil, err } - c := new(Commit) - resp, err := s.client.Do(ctx, req, c) + var c *Commit + resp, err := s.client.Do(ctx, req, &c) if err != nil { return nil, resp, err } diff --git a/github/git_commits_test.go b/github/git_commits_test.go index cf8caf2798b..054c793268e 100644 --- a/github/git_commits_test.go +++ b/github/git_commits_test.go @@ -182,8 +182,8 @@ func TestGitService_CreateCommit(t *testing.T) { } mux.HandleFunc("/repos/o/r/git/commits", func(w http.ResponseWriter, r *http.Request) { - v := new(createCommit) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *createCommit + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") @@ -240,8 +240,8 @@ func TestGitService_CreateSignedCommit(t *testing.T) { } mux.HandleFunc("/repos/o/r/git/commits", func(w http.ResponseWriter, r *http.Request) { - v := new(createCommit) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *createCommit + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") diff --git a/github/git_refs.go b/github/git_refs.go index bca7741d936..9371e3e9851 100644 --- a/github/git_refs.go +++ b/github/git_refs.go @@ -63,8 +63,8 @@ func (s *GitService) GetRef(ctx context.Context, owner, repo, ref string) (*Refe return nil, nil, err } - r := new(Reference) - resp, err := s.client.Do(ctx, req, r) + var r *Reference + resp, err := s.client.Do(ctx, req, &r) if err != nil { return nil, resp, err } @@ -131,8 +131,8 @@ func (s *GitService) CreateRef(ctx context.Context, owner, repo string, ref Crea return nil, nil, err } - r := new(Reference) - resp, err := s.client.Do(ctx, req, r) + var r *Reference + resp, err := s.client.Do(ctx, req, &r) if err != nil { return nil, resp, err } @@ -161,8 +161,8 @@ func (s *GitService) UpdateRef(ctx context.Context, owner, repo, ref string, upd return nil, nil, err } - r := new(Reference) - resp, err := s.client.Do(ctx, req, r) + var r *Reference + resp, err := s.client.Do(ctx, req, &r) if err != nil { return nil, resp, err } diff --git a/github/git_refs_test.go b/github/git_refs_test.go index 76ed3e2f5bd..93be53c7b2c 100644 --- a/github/git_refs_test.go +++ b/github/git_refs_test.go @@ -345,8 +345,8 @@ func TestGitService_CreateRef(t *testing.T) { } mux.HandleFunc("/repos/o/r/git/refs", func(w http.ResponseWriter, r *http.Request) { - v := new(CreateRef) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *CreateRef + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(*v, args) { @@ -430,8 +430,8 @@ func TestGitService_UpdateRef(t *testing.T) { } mux.HandleFunc("/repos/o/r/git/refs/heads/b", func(w http.ResponseWriter, r *http.Request) { - v := new(UpdateRef) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *UpdateRef + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(*v, args) { @@ -591,8 +591,8 @@ func TestGitService_UpdateRef_pathEscape(t *testing.T) { } mux.HandleFunc("/repos/o/r/git/refs/heads/b#1", func(w http.ResponseWriter, r *http.Request) { - v := new(UpdateRef) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *UpdateRef + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(*v, args) { diff --git a/github/git_tags.go b/github/git_tags.go index 750b03760c0..26520d1b7cf 100644 --- a/github/git_tags.go +++ b/github/git_tags.go @@ -43,8 +43,8 @@ func (s *GitService) GetTag(ctx context.Context, owner, repo, sha string) (*Tag, return nil, nil, err } - tag := new(Tag) - resp, err := s.client.Do(ctx, req, tag) + var tag *Tag + resp, err := s.client.Do(ctx, req, &tag) if err != nil { return nil, resp, err } @@ -65,8 +65,8 @@ func (s *GitService) CreateTag(ctx context.Context, owner, repo string, tag Crea return nil, nil, err } - t := new(Tag) - resp, err := s.client.Do(ctx, req, t) + var t *Tag + resp, err := s.client.Do(ctx, req, &t) if err != nil { return nil, resp, err } diff --git a/github/git_tags_test.go b/github/git_tags_test.go index 36bb5ca0bbe..8cd1bae1b27 100644 --- a/github/git_tags_test.go +++ b/github/git_tags_test.go @@ -61,8 +61,8 @@ func TestGitService_CreateTag(t *testing.T) { } mux.HandleFunc("/repos/o/r/git/tags", func(w http.ResponseWriter, r *http.Request) { - v := new(CreateTag) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *CreateTag + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(*v, inputTag) { diff --git a/github/git_trees.go b/github/git_trees.go index 2ff0dc592d8..f9a6c12c145 100644 --- a/github/git_trees.go +++ b/github/git_trees.go @@ -115,8 +115,8 @@ func (s *GitService) GetTree(ctx context.Context, owner, repo, sha string, recur return nil, nil, err } - t := new(Tree) - resp, err := s.client.Do(ctx, req, t) + var t *Tree + resp, err := s.client.Do(ctx, req, &t) if err != nil { return nil, resp, err } @@ -170,8 +170,8 @@ func (s *GitService) CreateTree(ctx context.Context, owner, repo, baseTree strin return nil, nil, err } - t := new(Tree) - resp, err := s.client.Do(ctx, req, t) + var t *Tree + resp, err := s.client.Do(ctx, req, &t) if err != nil { return nil, resp, err } diff --git a/github/github.go b/github/github.go index 53b0c9003d1..bb9e9f3cd72 100644 --- a/github/github.go +++ b/github/github.go @@ -1627,15 +1627,14 @@ func setCredentialsAsHeaders(req *http.Request, id, secret string) *http.Request // // Since we are going to modify only req.Header here, we only need a deep copy // of req.Header. - convertedRequest := new(http.Request) - *convertedRequest = *req + convertedRequest := *req convertedRequest.Header = make(http.Header, len(req.Header)) for k, s := range req.Header { convertedRequest.Header[k] = append([]string(nil), s...) } convertedRequest.SetBasicAuth(id, secret) - return convertedRequest + return &convertedRequest } /* diff --git a/github/github_test.go b/github/github_test.go index bda84b3ac8a..b4efaecbabe 100644 --- a/github/github_test.go +++ b/github/github_test.go @@ -373,8 +373,7 @@ func testErrorResponseForStatusCode(t *testing.T, code int) { w.WriteHeader(code) }) - ctx := t.Context() - _, _, err := client.Repositories.ListHooks(ctx, "o", "r", nil) + _, _, err := client.Repositories.ListHooks(t.Context(), "o", "r", nil) var abuseErr *AbuseRateLimitError switch { @@ -1196,9 +1195,8 @@ func TestDo(t *testing.T) { }) req, _ := client.NewRequest("GET", ".", nil) - body := new(foo) - ctx := t.Context() - _, err := client.Do(ctx, req, body) + var body *foo + _, err := client.Do(t.Context(), req, &body) assertNilError(t, err) want := &foo{"a"} @@ -1228,8 +1226,7 @@ func TestDo_httpError(t *testing.T) { }) req, _ := client.NewRequest("GET", ".", nil) - ctx := t.Context() - resp, err := client.Do(ctx, req, nil) + resp, err := client.Do(t.Context(), req, nil) if err == nil { t.Fatal("Expected HTTP 400 error, got no error.") @@ -1251,8 +1248,7 @@ func TestDo_redirectLoop(t *testing.T) { }) req, _ := client.NewRequest("GET", ".", nil) - ctx := t.Context() - _, err := client.Do(ctx, req, nil) + _, err := client.Do(t.Context(), req, nil) if err == nil { t.Error("Expected error to be returned.") @@ -1321,8 +1317,7 @@ func TestDo_sanitizeURL(t *testing.T) { if err != nil { t.Fatalf("NewRequest returned unexpected error: %v", err) } - ctx := t.Context() - _, err = unauthedClient.Do(ctx, req, nil) + _, err = unauthedClient.Do(t.Context(), req, nil) if err == nil { t.Fatal("Expected error to be returned.") } @@ -1344,8 +1339,7 @@ func TestDo_rateLimit(t *testing.T) { }) req, _ := client.NewRequest("GET", ".", nil) - ctx := t.Context() - resp, err := client.Do(ctx, req, nil) + resp, err := client.Do(t.Context(), req, nil) if err != nil { t.Errorf("Do returned unexpected error: %v", err) } @@ -1464,8 +1458,7 @@ func TestDo_rateLimit_errorResponse(t *testing.T) { }) req, _ := client.NewRequest("GET", ".", nil) - ctx := t.Context() - resp, err := client.Do(ctx, req, nil) + resp, err := client.Do(t.Context(), req, nil) if err == nil { t.Error("Expected error to be returned.") } @@ -1510,8 +1503,7 @@ func TestDo_rateLimit_rateLimitError(t *testing.T) { }) req, _ := client.NewRequest("GET", ".", nil) - ctx := t.Context() - _, err := client.Do(ctx, req, nil) + _, err := client.Do(t.Context(), req, nil) if err == nil { t.Error("Expected error to be returned.") @@ -1686,8 +1678,7 @@ func TestDo_rateLimit_sleepUntilResponseResetLimit(t *testing.T) { }) req, _ := client.NewRequest("GET", ".", nil) - ctx := t.Context() - resp, err := client.Do(context.WithValue(ctx, SleepUntilPrimaryRateLimitResetWhenRateLimited, true), req, nil) + resp, err := client.Do(context.WithValue(t.Context(), SleepUntilPrimaryRateLimitResetWhenRateLimited, true), req, nil) if err != nil { t.Errorf("Do returned unexpected error: %v", err) } @@ -1720,8 +1711,7 @@ func TestDo_rateLimit_sleepUntilResponseResetLimitRetryOnce(t *testing.T) { }) req, _ := client.NewRequest("GET", ".", nil) - ctx := t.Context() - _, err := client.Do(context.WithValue(ctx, SleepUntilPrimaryRateLimitResetWhenRateLimited, true), req, nil) + _, err := client.Do(context.WithValue(t.Context(), SleepUntilPrimaryRateLimitResetWhenRateLimited, true), req, nil) if err == nil { t.Error("Expected error to be returned.") } @@ -1750,8 +1740,7 @@ func TestDo_rateLimit_sleepUntilClientResetLimit(t *testing.T) { fmt.Fprintln(w, `{}`) }) req, _ := client.NewRequest("GET", ".", nil) - ctx := t.Context() - resp, err := client.Do(context.WithValue(ctx, SleepUntilPrimaryRateLimitResetWhenRateLimited, true), req, nil) + resp, err := client.Do(context.WithValue(t.Context(), SleepUntilPrimaryRateLimitResetWhenRateLimited, true), req, nil) if err != nil { t.Errorf("Do returned unexpected error: %v", err) } @@ -1851,8 +1840,7 @@ func TestDo_rateLimit_abuseRateLimitError(t *testing.T) { }) req, _ := client.NewRequest("GET", ".", nil) - ctx := t.Context() - _, err := client.Do(ctx, req, nil) + _, err := client.Do(t.Context(), req, nil) if err == nil { t.Error("Expected error to be returned.") @@ -1886,8 +1874,7 @@ func TestDo_rateLimit_abuseRateLimitErrorEnterprise(t *testing.T) { }) req, _ := client.NewRequest("GET", ".", nil) - ctx := t.Context() - _, err := client.Do(ctx, req, nil) + _, err := client.Do(t.Context(), req, nil) if err == nil { t.Error("Expected error to be returned.") @@ -2034,8 +2021,7 @@ func TestDo_rateLimit_abuseRateLimitError_maxDuration(t *testing.T) { }) req, _ := client.NewRequest("GET", ".", nil) - ctx := t.Context() - _, err := client.Do(ctx, req, nil) + _, err := client.Do(t.Context(), req, nil) if err == nil { t.Error("Expected error to be returned.") @@ -2074,8 +2060,7 @@ func TestDo_rateLimit_disableRateLimitCheck(t *testing.T) { fmt.Fprintln(w, `{}`) }) req, _ := client.NewRequest("GET", ".", nil) - ctx := t.Context() - resp, err := client.Do(ctx, req, nil) + resp, err := client.Do(t.Context(), req, nil) if err != nil { t.Errorf("Do returned unexpected error: %v", err) } @@ -2110,8 +2095,7 @@ func TestDo_rateLimit_bypassRateLimitCheck(t *testing.T) { fmt.Fprintln(w, `{}`) }) req, _ := client.NewRequest("GET", ".", nil) - ctx := t.Context() - resp, err := client.Do(context.WithValue(ctx, BypassRateLimitCheck, true), req, nil) + resp, err := client.Do(context.WithValue(t.Context(), BypassRateLimitCheck, true), req, nil) if err != nil { t.Errorf("Do returned unexpected error: %v", err) } @@ -2137,8 +2121,7 @@ func TestDo_noContent(t *testing.T) { var body json.RawMessage req, _ := client.NewRequest("GET", ".", nil) - ctx := t.Context() - _, err := client.Do(ctx, req, &body) + _, err := client.Do(t.Context(), req, &body) if err != nil { t.Fatalf("Do returned unexpected error: %v", err) } @@ -2153,8 +2136,7 @@ func TestBareDoUntilFound_redirectLoop(t *testing.T) { }) req, _ := client.NewRequest("GET", ".", nil) - ctx := t.Context() - _, _, err := client.bareDoUntilFound(ctx, req, 1) + _, _, err := client.bareDoUntilFound(t.Context(), req, 1) if err == nil { t.Error("Expected error to be returned.") @@ -2173,8 +2155,7 @@ func TestBareDoUntilFound_UnexpectedRedirection(t *testing.T) { }) req, _ := client.NewRequest("GET", ".", nil) - ctx := t.Context() - _, _, err := client.bareDoUntilFound(ctx, req, 1) + _, _, err := client.bareDoUntilFound(t.Context(), req, 1) if err == nil { t.Error("Expected error to be returned.") @@ -2943,8 +2924,7 @@ func TestUnauthenticatedRateLimitedTransport(t *testing.T) { unauthedClient := NewClient(tp.Client()) unauthedClient.BaseURL = client.BaseURL req, _ := unauthedClient.NewRequest("GET", ".", nil) - ctx := t.Context() - _, err := unauthedClient.Do(ctx, req, nil) + _, err := unauthedClient.Do(t.Context(), req, nil) assertNilError(t, err) } @@ -3021,8 +3001,7 @@ func TestBasicAuthTransport(t *testing.T) { basicAuthClient := NewClient(tp.Client()) basicAuthClient.BaseURL = client.BaseURL req, _ := basicAuthClient.NewRequest("GET", ".", nil) - ctx := t.Context() - _, err := basicAuthClient.Do(ctx, req, nil) + _, err := basicAuthClient.Do(t.Context(), req, nil) assertNilError(t, err) } @@ -3167,13 +3146,12 @@ func TestBareDo_returnsOpenBody(t *testing.T) { fmt.Fprint(w, expectedBody) }) - ctx := t.Context() req, err := client.NewRequest("GET", "test-url", nil) if err != nil { t.Fatalf("client.NewRequest returned error: %v", err) } - resp, err := client.BareDo(ctx, req) + resp, err := client.BareDo(t.Context(), req) if err != nil { t.Fatalf("client.BareDo returned error: %v", err) } diff --git a/github/gitignore.go b/github/gitignore.go index 34cf285e146..82771a726e5 100644 --- a/github/gitignore.go +++ b/github/gitignore.go @@ -58,8 +58,8 @@ func (s *GitignoresService) Get(ctx context.Context, name string) (*Gitignore, * return nil, nil, err } - gitignore := new(Gitignore) - resp, err := s.client.Do(ctx, req, gitignore) + var gitignore *Gitignore + resp, err := s.client.Do(ctx, req, &gitignore) if err != nil { return nil, resp, err } diff --git a/github/interactions_orgs.go b/github/interactions_orgs.go index 55f2548179a..0fb9ca111fb 100644 --- a/github/interactions_orgs.go +++ b/github/interactions_orgs.go @@ -24,9 +24,8 @@ func (s *InteractionsService) GetRestrictionsForOrg(ctx context.Context, organiz req.Header.Set("Accept", mediaTypeInteractionRestrictionsPreview) - organizationInteractions := new(InteractionRestriction) - - resp, err := s.client.Do(ctx, req, organizationInteractions) + var organizationInteractions *InteractionRestriction + resp, err := s.client.Do(ctx, req, &organizationInteractions) if err != nil { return nil, resp, err } @@ -55,9 +54,8 @@ func (s *InteractionsService) UpdateRestrictionsForOrg(ctx context.Context, orga req.Header.Set("Accept", mediaTypeInteractionRestrictionsPreview) - organizationInteractions := new(InteractionRestriction) - - resp, err := s.client.Do(ctx, req, organizationInteractions) + var organizationInteractions *InteractionRestriction + resp, err := s.client.Do(ctx, req, &organizationInteractions) if err != nil { return nil, resp, err } diff --git a/github/interactions_orgs_test.go b/github/interactions_orgs_test.go index f177d6d17a3..973fdbcf31e 100644 --- a/github/interactions_orgs_test.go +++ b/github/interactions_orgs_test.go @@ -57,8 +57,8 @@ func TestInteractionsService_UpdateRestrictionsForOrg(t *testing.T) { input := &InteractionRestriction{Limit: Ptr("existing_users")} mux.HandleFunc("/orgs/o/interaction-limits", func(w http.ResponseWriter, r *http.Request) { - v := new(InteractionRestriction) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *InteractionRestriction + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") testHeader(t, r, "Accept", mediaTypeInteractionRestrictionsPreview) diff --git a/github/interactions_repos.go b/github/interactions_repos.go index d99de494a9a..1ee37dae8ad 100644 --- a/github/interactions_repos.go +++ b/github/interactions_repos.go @@ -24,9 +24,8 @@ func (s *InteractionsService) GetRestrictionsForRepo(ctx context.Context, owner, req.Header.Set("Accept", mediaTypeInteractionRestrictionsPreview) - repositoryInteractions := new(InteractionRestriction) - - resp, err := s.client.Do(ctx, req, repositoryInteractions) + var repositoryInteractions *InteractionRestriction + resp, err := s.client.Do(ctx, req, &repositoryInteractions) if err != nil { return nil, resp, err } @@ -55,9 +54,8 @@ func (s *InteractionsService) UpdateRestrictionsForRepo(ctx context.Context, own req.Header.Set("Accept", mediaTypeInteractionRestrictionsPreview) - repositoryInteractions := new(InteractionRestriction) - - resp, err := s.client.Do(ctx, req, repositoryInteractions) + var repositoryInteractions *InteractionRestriction + resp, err := s.client.Do(ctx, req, &repositoryInteractions) if err != nil { return nil, resp, err } diff --git a/github/interactions_repos_test.go b/github/interactions_repos_test.go index 07ce69532af..84ba45dffcb 100644 --- a/github/interactions_repos_test.go +++ b/github/interactions_repos_test.go @@ -57,8 +57,8 @@ func TestInteractionsService_UpdateRestrictionsForRepo(t *testing.T) { input := &InteractionRestriction{Limit: Ptr("existing_users")} mux.HandleFunc("/repos/o/r/interaction-limits", func(w http.ResponseWriter, r *http.Request) { - v := new(InteractionRestriction) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *InteractionRestriction + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") testHeader(t, r, "Accept", mediaTypeInteractionRestrictionsPreview) diff --git a/github/issue_import.go b/github/issue_import.go index ea42db1ba98..0feaac890a9 100644 --- a/github/issue_import.go +++ b/github/issue_import.go @@ -83,20 +83,20 @@ func (s *IssueImportService) Create(ctx context.Context, owner, repo string, iss req.Header.Set("Accept", mediaTypeIssueImportAPI) - i := new(IssueImportResponse) - resp, err := s.client.Do(ctx, req, i) + var i IssueImportResponse + resp, err := s.client.Do(ctx, req, &i) if err != nil { var aerr *AcceptedError if errors.As(err, &aerr) { - if err := json.Unmarshal(aerr.Raw, i); err != nil { - return i, resp, err + if err := json.Unmarshal(aerr.Raw, &i); err != nil { + return &i, resp, err } - return i, resp, err + return &i, resp, err } return nil, resp, err } - return i, resp, nil + return &i, resp, nil } // CheckStatus checks the status of an imported issue. @@ -113,8 +113,8 @@ func (s *IssueImportService) CheckStatus(ctx context.Context, owner, repo string req.Header.Set("Accept", mediaTypeIssueImportAPI) - i := new(IssueImportResponse) - resp, err := s.client.Do(ctx, req, i) + var i *IssueImportResponse + resp, err := s.client.Do(ctx, req, &i) if err != nil { return nil, resp, err } diff --git a/github/issue_import_test.go b/github/issue_import_test.go index d26d2013dd5..4c744a87794 100644 --- a/github/issue_import_test.go +++ b/github/issue_import_test.go @@ -37,8 +37,8 @@ func TestIssueImportService_Create(t *testing.T) { } mux.HandleFunc("/repos/o/r/import/issues", func(w http.ResponseWriter, r *http.Request) { - v := new(IssueImportRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *IssueImportRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") testHeader(t, r, "Accept", mediaTypeIssueImportAPI) if !cmp.Equal(v, input) { @@ -95,8 +95,8 @@ func TestIssueImportService_Create_deferred(t *testing.T) { } mux.HandleFunc("/repos/o/r/import/issues", func(w http.ResponseWriter, r *http.Request) { - v := new(IssueImportRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *IssueImportRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") testHeader(t, r, "Accept", mediaTypeIssueImportAPI) if !cmp.Equal(v, input) { @@ -141,8 +141,8 @@ func TestIssueImportService_Create_badResponse(t *testing.T) { } mux.HandleFunc("/repos/o/r/import/issues", func(w http.ResponseWriter, r *http.Request) { - v := new(IssueImportRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *IssueImportRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") testHeader(t, r, "Accept", mediaTypeIssueImportAPI) if !cmp.Equal(v, input) { diff --git a/github/issues.go b/github/issues.go index c31bebe459c..f4c2c7b244e 100644 --- a/github/issues.go +++ b/github/issues.go @@ -393,8 +393,8 @@ func (s *IssuesService) Get(ctx context.Context, owner, repo string, number int) req.Header.Set("Accept", mediaTypeReactionsPreview) - issue := new(Issue) - resp, err := s.client.Do(ctx, req, issue) + var issue *Issue + resp, err := s.client.Do(ctx, req, &issue) if err != nil { return nil, resp, err } @@ -414,8 +414,8 @@ func (s *IssuesService) Create(ctx context.Context, owner, repo string, issue *I return nil, nil, err } - i := new(Issue) - resp, err := s.client.Do(ctx, req, i) + var i *Issue + resp, err := s.client.Do(ctx, req, &i) if err != nil { return nil, resp, err } @@ -435,8 +435,8 @@ func (s *IssuesService) Edit(ctx context.Context, owner, repo string, number int return nil, nil, err } - i := new(Issue) - resp, err := s.client.Do(ctx, req, i) + var i *Issue + resp, err := s.client.Do(ctx, req, &i) if err != nil { return nil, resp, err } @@ -460,8 +460,8 @@ func (s *IssuesService) RemoveMilestone(ctx context.Context, owner, repo string, return nil, nil, err } - i := new(Issue) - resp, err := s.client.Do(ctx, req, i) + var i *Issue + resp, err := s.client.Do(ctx, req, &i) if err != nil { return nil, resp, err } diff --git a/github/issues_assignees.go b/github/issues_assignees.go index fd065771ed3..6e54b1f531e 100644 --- a/github/issues_assignees.go +++ b/github/issues_assignees.go @@ -69,8 +69,8 @@ func (s *IssuesService) AddAssignees(ctx context.Context, owner, repo string, nu return nil, nil, err } - issue := &Issue{} - resp, err := s.client.Do(ctx, req, issue) + var issue *Issue + resp, err := s.client.Do(ctx, req, &issue) if err != nil { return nil, resp, err } @@ -93,8 +93,8 @@ func (s *IssuesService) RemoveAssignees(ctx context.Context, owner, repo string, return nil, nil, err } - issue := &Issue{} - resp, err := s.client.Do(ctx, req, issue) + var issue *Issue + resp, err := s.client.Do(ctx, req, &issue) if err != nil { return nil, resp, err } diff --git a/github/issues_comments.go b/github/issues_comments.go index ef5314b188d..9347b677aaa 100644 --- a/github/issues_comments.go +++ b/github/issues_comments.go @@ -103,8 +103,8 @@ func (s *IssuesService) GetComment(ctx context.Context, owner, repo string, comm req.Header.Set("Accept", mediaTypeReactionsPreview) - comment := new(IssueComment) - resp, err := s.client.Do(ctx, req, comment) + var comment *IssueComment + resp, err := s.client.Do(ctx, req, &comment) if err != nil { return nil, resp, err } @@ -123,8 +123,8 @@ func (s *IssuesService) CreateComment(ctx context.Context, owner, repo string, n if err != nil { return nil, nil, err } - c := new(IssueComment) - resp, err := s.client.Do(ctx, req, c) + var c *IssueComment + resp, err := s.client.Do(ctx, req, &c) if err != nil { return nil, resp, err } @@ -144,8 +144,8 @@ func (s *IssuesService) EditComment(ctx context.Context, owner, repo string, com if err != nil { return nil, nil, err } - c := new(IssueComment) - resp, err := s.client.Do(ctx, req, c) + var c *IssueComment + resp, err := s.client.Do(ctx, req, &c) if err != nil { return nil, resp, err } diff --git a/github/issues_comments_test.go b/github/issues_comments_test.go index df50218d78a..befc7fc2f11 100644 --- a/github/issues_comments_test.go +++ b/github/issues_comments_test.go @@ -161,8 +161,8 @@ func TestIssuesService_CreateComment(t *testing.T) { input := &IssueComment{Body: Ptr("b")} mux.HandleFunc("/repos/o/r/issues/1/comments", func(w http.ResponseWriter, r *http.Request) { - v := new(IssueComment) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *IssueComment + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { @@ -214,8 +214,8 @@ func TestIssuesService_EditComment(t *testing.T) { input := &IssueComment{Body: Ptr("b")} mux.HandleFunc("/repos/o/r/issues/comments/1", func(w http.ResponseWriter, r *http.Request) { - v := new(IssueComment) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *IssueComment + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { diff --git a/github/issues_events.go b/github/issues_events.go index 8e234d7e020..93651f22c17 100644 --- a/github/issues_events.go +++ b/github/issues_events.go @@ -169,8 +169,8 @@ func (s *IssuesService) GetEvent(ctx context.Context, owner, repo string, id int return nil, nil, err } - event := new(IssueEvent) - resp, err := s.client.Do(ctx, req, event) + var event *IssueEvent + resp, err := s.client.Do(ctx, req, &event) if err != nil { return nil, resp, err } diff --git a/github/issues_labels.go b/github/issues_labels.go index 243670ec7eb..03b1f65a850 100644 --- a/github/issues_labels.go +++ b/github/issues_labels.go @@ -63,8 +63,8 @@ func (s *IssuesService) GetLabel(ctx context.Context, owner, repo, name string) return nil, nil, err } - label := new(Label) - resp, err := s.client.Do(ctx, req, label) + var label *Label + resp, err := s.client.Do(ctx, req, &label) if err != nil { return nil, resp, err } @@ -84,8 +84,8 @@ func (s *IssuesService) CreateLabel(ctx context.Context, owner, repo string, lab return nil, nil, err } - l := new(Label) - resp, err := s.client.Do(ctx, req, l) + var l *Label + resp, err := s.client.Do(ctx, req, &l) if err != nil { return nil, resp, err } @@ -105,8 +105,8 @@ func (s *IssuesService) EditLabel(ctx context.Context, owner, repo, name string, return nil, nil, err } - l := new(Label) - resp, err := s.client.Do(ctx, req, l) + var l *Label + resp, err := s.client.Do(ctx, req, &l) if err != nil { return nil, resp, err } diff --git a/github/issues_labels_test.go b/github/issues_labels_test.go index ae9eefe406d..37f583436fe 100644 --- a/github/issues_labels_test.go +++ b/github/issues_labels_test.go @@ -111,8 +111,8 @@ func TestIssuesService_CreateLabel(t *testing.T) { input := &Label{Name: Ptr("n")} mux.HandleFunc("/repos/o/r/labels", func(w http.ResponseWriter, r *http.Request) { - v := new(Label) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *Label + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { @@ -164,8 +164,8 @@ func TestIssuesService_EditLabel(t *testing.T) { input := &Label{Name: Ptr("z")} mux.HandleFunc("/repos/o/r/labels/n", func(w http.ResponseWriter, r *http.Request) { - v := new(Label) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *Label + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { diff --git a/github/issues_milestones.go b/github/issues_milestones.go index 74782902994..1557a02fb69 100644 --- a/github/issues_milestones.go +++ b/github/issues_milestones.go @@ -90,8 +90,8 @@ func (s *IssuesService) GetMilestone(ctx context.Context, owner, repo string, nu return nil, nil, err } - milestone := new(Milestone) - resp, err := s.client.Do(ctx, req, milestone) + var milestone *Milestone + resp, err := s.client.Do(ctx, req, &milestone) if err != nil { return nil, resp, err } @@ -111,8 +111,8 @@ func (s *IssuesService) CreateMilestone(ctx context.Context, owner, repo string, return nil, nil, err } - m := new(Milestone) - resp, err := s.client.Do(ctx, req, m) + var m *Milestone + resp, err := s.client.Do(ctx, req, &m) if err != nil { return nil, resp, err } @@ -132,8 +132,8 @@ func (s *IssuesService) EditMilestone(ctx context.Context, owner, repo string, n return nil, nil, err } - m := new(Milestone) - resp, err := s.client.Do(ctx, req, m) + var m *Milestone + resp, err := s.client.Do(ctx, req, &m) if err != nil { return nil, resp, err } diff --git a/github/issues_milestones_test.go b/github/issues_milestones_test.go index 4766cec327a..2ff7adbb35e 100644 --- a/github/issues_milestones_test.go +++ b/github/issues_milestones_test.go @@ -116,8 +116,8 @@ func TestIssuesService_CreateMilestone(t *testing.T) { input := &Milestone{Title: Ptr("t")} mux.HandleFunc("/repos/o/r/milestones", func(w http.ResponseWriter, r *http.Request) { - v := new(Milestone) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *Milestone + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { @@ -169,8 +169,8 @@ func TestIssuesService_EditMilestone(t *testing.T) { input := &Milestone{Title: Ptr("t")} mux.HandleFunc("/repos/o/r/milestones/1", func(w http.ResponseWriter, r *http.Request) { - v := new(Milestone) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *Milestone + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { diff --git a/github/issues_test.go b/github/issues_test.go index ff5b7377300..00052fc7ba1 100644 --- a/github/issues_test.go +++ b/github/issues_test.go @@ -307,8 +307,8 @@ func TestIssuesService_Create(t *testing.T) { } mux.HandleFunc("/repos/o/r/issues", func(w http.ResponseWriter, r *http.Request) { - v := new(IssueRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *IssueRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { @@ -360,8 +360,8 @@ func TestIssuesService_Edit(t *testing.T) { input := &IssueRequest{Title: Ptr("t"), Type: Ptr("bug")} mux.HandleFunc("/repos/o/r/issues/1", func(w http.ResponseWriter, r *http.Request) { - v := new(IssueRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *IssueRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { @@ -512,7 +512,7 @@ func TestIssuesService_Unlock(t *testing.T) { func TestIsPullRequest(t *testing.T) { t.Parallel() - i := new(Issue) + var i Issue if i.IsPullRequest() { t.Errorf("expected i.IsPullRequest (%v) to return false, got true", i) } diff --git a/github/licenses.go b/github/licenses.go index c589a8152d6..cc7df2be493 100644 --- a/github/licenses.go +++ b/github/licenses.go @@ -104,8 +104,8 @@ func (s *LicensesService) Get(ctx context.Context, licenseName string) (*License return nil, nil, err } - license := new(License) - resp, err := s.client.Do(ctx, req, license) + var license *License + resp, err := s.client.Do(ctx, req, &license) if err != nil { return nil, resp, err } diff --git a/github/markdown.go b/github/markdown.go index 0fd896c6c85..7879ab8a587 100644 --- a/github/markdown.go +++ b/github/markdown.go @@ -59,8 +59,8 @@ func (s *MarkdownService) Render(ctx context.Context, text string, opts *Markdow return "", nil, err } - buf := new(bytes.Buffer) - resp, err := s.client.Do(ctx, req, buf) + var buf bytes.Buffer + resp, err := s.client.Do(ctx, req, &buf) if err != nil { return "", resp, err } diff --git a/github/markdown_test.go b/github/markdown_test.go index a4b6d283f36..4b3be86599a 100644 --- a/github/markdown_test.go +++ b/github/markdown_test.go @@ -24,8 +24,8 @@ func TestMarkdownService_Markdown(t *testing.T) { Context: Ptr("google/go-github"), } mux.HandleFunc("/markdown", func(w http.ResponseWriter, r *http.Request) { - v := new(markdownRenderRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *markdownRenderRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { diff --git a/github/meta.go b/github/meta.go index 6dd104c8c30..b8b871146f2 100644 --- a/github/meta.go +++ b/github/meta.go @@ -123,8 +123,8 @@ func (s *MetaService) Get(ctx context.Context) (*APIMeta, *Response, error) { return nil, nil, err } - meta := new(APIMeta) - resp, err := s.client.Do(ctx, req, meta) + var meta *APIMeta + resp, err := s.client.Do(ctx, req, &meta) if err != nil { return nil, resp, err } @@ -156,8 +156,8 @@ func (s *MetaService) Octocat(ctx context.Context, message string) (string, *Res return "", nil, err } - buf := new(bytes.Buffer) - resp, err := s.client.Do(ctx, req, buf) + var buf bytes.Buffer + resp, err := s.client.Do(ctx, req, &buf) if err != nil { return "", resp, err } @@ -186,8 +186,8 @@ func (s *MetaService) Zen(ctx context.Context) (string, *Response, error) { return "", nil, err } - buf := new(bytes.Buffer) - resp, err := s.client.Do(ctx, req, buf) + var buf bytes.Buffer + resp, err := s.client.Do(ctx, req, &buf) if err != nil { return "", resp, err } diff --git a/github/migrations.go b/github/migrations.go index 14d014b6149..e68591f6459 100644 --- a/github/migrations.go +++ b/github/migrations.go @@ -111,8 +111,8 @@ func (s *MigrationService) StartMigration(ctx context.Context, org string, repos req.Header.Set("Accept", mediaTypeMigrationsPreview) - m := &Migration{} - resp, err := s.client.Do(ctx, req, m) + var m *Migration + resp, err := s.client.Do(ctx, req, &m) if err != nil { return nil, resp, err } @@ -164,8 +164,8 @@ func (s *MigrationService) MigrationStatus(ctx context.Context, org string, id i req.Header.Set("Accept", mediaTypeMigrationsPreview) - m := &Migration{} - resp, err := s.client.Do(ctx, req, m) + var m *Migration + resp, err := s.client.Do(ctx, req, &m) if err != nil { return nil, resp, err } diff --git a/github/migrations_source_import.go b/github/migrations_source_import.go index f484b77d474..276dfe7c87e 100644 --- a/github/migrations_source_import.go +++ b/github/migrations_source_import.go @@ -156,8 +156,8 @@ func (s *MigrationService) StartImport(ctx context.Context, owner, repo string, return nil, nil, err } - out := new(Import) - resp, err := s.client.Do(ctx, req, out) + var out *Import + resp, err := s.client.Do(ctx, req, &out) if err != nil { return nil, resp, err } @@ -177,8 +177,8 @@ func (s *MigrationService) ImportProgress(ctx context.Context, owner, repo strin return nil, nil, err } - out := new(Import) - resp, err := s.client.Do(ctx, req, out) + var out *Import + resp, err := s.client.Do(ctx, req, &out) if err != nil { return nil, resp, err } @@ -198,8 +198,8 @@ func (s *MigrationService) UpdateImport(ctx context.Context, owner, repo string, return nil, nil, err } - out := new(Import) - resp, err := s.client.Do(ctx, req, out) + var out *Import + resp, err := s.client.Do(ctx, req, &out) if err != nil { return nil, resp, err } @@ -252,8 +252,8 @@ func (s *MigrationService) MapCommitAuthor(ctx context.Context, owner, repo stri return nil, nil, err } - out := new(SourceImportAuthor) - resp, err := s.client.Do(ctx, req, out) + var out *SourceImportAuthor + resp, err := s.client.Do(ctx, req, &out) if err != nil { return nil, resp, err } @@ -275,8 +275,8 @@ func (s *MigrationService) SetLFSPreference(ctx context.Context, owner, repo str return nil, nil, err } - out := new(Import) - resp, err := s.client.Do(ctx, req, out) + var out *Import + resp, err := s.client.Do(ctx, req, &out) if err != nil { return nil, resp, err } diff --git a/github/migrations_source_import_test.go b/github/migrations_source_import_test.go index d31a3152cb4..b5b7270c238 100644 --- a/github/migrations_source_import_test.go +++ b/github/migrations_source_import_test.go @@ -26,8 +26,8 @@ func TestMigrationService_StartImport(t *testing.T) { } mux.HandleFunc("/repos/o/r/import", func(w http.ResponseWriter, r *http.Request) { - v := new(Import) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *Import + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { @@ -109,8 +109,8 @@ func TestMigrationService_UpdateImport(t *testing.T) { } mux.HandleFunc("/repos/o/r/import", func(w http.ResponseWriter, r *http.Request) { - v := new(Import) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *Import + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { @@ -190,8 +190,8 @@ func TestMigrationService_MapCommitAuthor(t *testing.T) { input := &SourceImportAuthor{Name: Ptr("n"), Email: Ptr("e")} mux.HandleFunc("/repos/o/r/import/authors/1", func(w http.ResponseWriter, r *http.Request) { - v := new(SourceImportAuthor) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *SourceImportAuthor + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { @@ -233,8 +233,8 @@ func TestMigrationService_SetLFSPreference(t *testing.T) { input := &Import{UseLFS: Ptr("opt_in")} mux.HandleFunc("/repos/o/r/import/lfs", func(w http.ResponseWriter, r *http.Request) { - v := new(Import) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *Import + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { diff --git a/github/migrations_user.go b/github/migrations_user.go index 49678fcc09f..b17abad8d31 100644 --- a/github/migrations_user.go +++ b/github/migrations_user.go @@ -86,8 +86,8 @@ func (s *MigrationService) StartUserMigration(ctx context.Context, repos []strin req.Header.Set("Accept", mediaTypeMigrationsPreview) - m := &UserMigration{} - resp, err := s.client.Do(ctx, req, m) + var m *UserMigration + resp, err := s.client.Do(ctx, req, &m) if err != nil { return nil, resp, err } @@ -139,8 +139,8 @@ func (s *MigrationService) UserMigrationStatus(ctx context.Context, id int64) (* req.Header.Set("Accept", mediaTypeMigrationsPreview) - m := &UserMigration{} - resp, err := s.client.Do(ctx, req, m) + var m *UserMigration + resp, err := s.client.Do(ctx, req, &m) if err != nil { return nil, resp, err } @@ -164,8 +164,6 @@ func (s *MigrationService) UserMigrationArchiveURL(ctx context.Context, id int64 req.Header.Set("Accept", mediaTypeMigrationsPreview) - m := &UserMigration{} - var loc string originalRedirect := s.client.client.CheckRedirect s.client.client.CheckRedirect = func(req *http.Request, _ []*http.Request) error { @@ -175,10 +173,13 @@ func (s *MigrationService) UserMigrationArchiveURL(ctx context.Context, id int64 defer func() { s.client.client.CheckRedirect = originalRedirect }() - resp, err := s.client.Do(ctx, req, m) + + var m *UserMigration + resp, err := s.client.Do(ctx, req, &m) if err == nil { return "", errors.New("expected redirect, none provided") } + loc = resp.Header.Get("Location") return loc, nil } diff --git a/github/orgs.go b/github/orgs.go index 2119f1d5620..bcb84f456fb 100644 --- a/github/orgs.go +++ b/github/orgs.go @@ -237,13 +237,13 @@ func (s *OrganizationsService) Get(ctx context.Context, org string) (*Organizati req.Header.Set("Accept", mediaTypeMemberAllowedRepoCreationTypePreview) - organization := new(Organization) - resp, err := s.client.Do(ctx, req, organization) + var o *Organization + resp, err := s.client.Do(ctx, req, &o) if err != nil { return nil, resp, err } - return organization, resp, nil + return o, resp, nil } // GetByID fetches an organization. @@ -258,13 +258,13 @@ func (s *OrganizationsService) GetByID(ctx context.Context, id int64) (*Organiza return nil, nil, err } - organization := new(Organization) - resp, err := s.client.Do(ctx, req, organization) + var org *Organization + resp, err := s.client.Do(ctx, req, &org) if err != nil { return nil, resp, err } - return organization, resp, nil + return org, resp, nil } // Edit an organization. @@ -281,8 +281,8 @@ func (s *OrganizationsService) Edit(ctx context.Context, name string, org *Organ req.Header.Set("Accept", mediaTypeMemberAllowedRepoCreationTypePreview) - o := new(Organization) - resp, err := s.client.Do(ctx, req, o) + var o *Organization + resp, err := s.client.Do(ctx, req, &o) if err != nil { return nil, resp, err } @@ -323,8 +323,8 @@ func (s *OrganizationsService) ListInstallations(ctx context.Context, org string return nil, nil, err } - result := new(OrganizationInstallations) - resp, err := s.client.Do(ctx, req, result) + var result *OrganizationInstallations + resp, err := s.client.Do(ctx, req, &result) if err != nil { return nil, resp, err } diff --git a/github/orgs_actions_allowed_test.go b/github/orgs_actions_allowed_test.go index 6c720a15915..7996b11afa2 100644 --- a/github/orgs_actions_allowed_test.go +++ b/github/orgs_actions_allowed_test.go @@ -55,8 +55,8 @@ func TestOrganizationsService_UpdateActionsAllowed(t *testing.T) { input := &ActionsAllowed{GithubOwnedAllowed: Ptr(true), VerifiedAllowed: Ptr(false), PatternsAllowed: []string{"a/b"}} mux.HandleFunc("/orgs/o/actions/permissions/selected-actions", func(w http.ResponseWriter, r *http.Request) { - v := new(ActionsAllowed) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *ActionsAllowed + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { diff --git a/github/orgs_actions_permissions_test.go b/github/orgs_actions_permissions_test.go index 897f6ee0853..d01adc75ac1 100644 --- a/github/orgs_actions_permissions_test.go +++ b/github/orgs_actions_permissions_test.go @@ -55,8 +55,8 @@ func TestOrganizationsService_UpdateActionsPermissions(t *testing.T) { input := &ActionsPermissions{EnabledRepositories: Ptr("all"), AllowedActions: Ptr("selected")} mux.HandleFunc("/orgs/o/actions/permissions", func(w http.ResponseWriter, r *http.Request) { - v := new(ActionsPermissions) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *ActionsPermissions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { diff --git a/github/orgs_artifacts.go b/github/orgs_artifacts.go index f17c078b1fa..70660adcd8e 100644 --- a/github/orgs_artifacts.go +++ b/github/orgs_artifacts.go @@ -118,11 +118,13 @@ func (s *OrganizationsService) CreateArtifactDeploymentRecord(ctx context.Contex if err != nil { return nil, nil, err } - v := new(ArtifactDeploymentResponse) - resp, err := s.client.Do(ctx, req, v) + + var v *ArtifactDeploymentResponse + resp, err := s.client.Do(ctx, req, &v) if err != nil { return nil, resp, err } + return v, resp, nil } @@ -137,11 +139,13 @@ func (s *OrganizationsService) SetClusterDeploymentRecords(ctx context.Context, if err != nil { return nil, nil, err } - v := new(ArtifactDeploymentResponse) - resp, err := s.client.Do(ctx, req, v) + + var v *ArtifactDeploymentResponse + resp, err := s.client.Do(ctx, req, &v) if err != nil { return nil, resp, err } + return v, resp, nil } @@ -156,11 +160,13 @@ func (s *OrganizationsService) CreateArtifactStorageRecord(ctx context.Context, if err != nil { return nil, nil, err } - v := new(ArtifactStorageResponse) - resp, err := s.client.Do(ctx, req, v) + + var v *ArtifactStorageResponse + resp, err := s.client.Do(ctx, req, &v) if err != nil { return nil, resp, err } + return v, resp, nil } @@ -179,11 +185,12 @@ func (s *OrganizationsService) ListArtifactDeploymentRecords(ctx context.Context return nil, nil, err } - v := new(ArtifactDeploymentResponse) - resp, err := s.client.Do(ctx, req, v) + var v *ArtifactDeploymentResponse + resp, err := s.client.Do(ctx, req, &v) if err != nil { return nil, resp, err } + return v, resp, nil } @@ -202,10 +209,11 @@ func (s *OrganizationsService) ListArtifactStorageRecords(ctx context.Context, o return nil, nil, err } - v := new(ArtifactStorageResponse) - resp, err := s.client.Do(ctx, req, v) + var v *ArtifactStorageResponse + resp, err := s.client.Do(ctx, req, &v) if err != nil { return nil, resp, err } + return v, resp, nil } diff --git a/github/orgs_codesecurity_configurations_test.go b/github/orgs_codesecurity_configurations_test.go index 708fe2a0c41..bfd7c833d87 100644 --- a/github/orgs_codesecurity_configurations_test.go +++ b/github/orgs_codesecurity_configurations_test.go @@ -446,8 +446,8 @@ func TestOrganizationsService_AttachCodeSecurityConfigurationToRepositories(t *t Scope string `json:"scope"` SelectedRepositoryIDs []int64 `json:"selected_repository_ids,omitempty"` } - v := new(request) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *request + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) if v.Scope != "selected" { t.Errorf("Organizations.AttachCodeSecurityConfigurationToRepositories request body scope = %v, want selected", v.Scope) } diff --git a/github/orgs_custom_repository_roles.go b/github/orgs_custom_repository_roles.go index 192ab63a6f7..e650f218b62 100644 --- a/github/orgs_custom_repository_roles.go +++ b/github/orgs_custom_repository_roles.go @@ -58,8 +58,8 @@ func (s *OrganizationsService) ListCustomRepoRoles(ctx context.Context, org stri return nil, nil, err } - customRepoRoles := new(OrganizationCustomRepoRoles) - resp, err := s.client.Do(ctx, req, customRepoRoles) + var customRepoRoles *OrganizationCustomRepoRoles + resp, err := s.client.Do(ctx, req, &customRepoRoles) if err != nil { return nil, resp, err } @@ -81,8 +81,8 @@ func (s *OrganizationsService) GetCustomRepoRole(ctx context.Context, org string return nil, nil, err } - resultingRole := new(CustomRepoRoles) - resp, err := s.client.Do(ctx, req, resultingRole) + var resultingRole *CustomRepoRoles + resp, err := s.client.Do(ctx, req, &resultingRole) if err != nil { return nil, resp, err } @@ -104,8 +104,8 @@ func (s *OrganizationsService) CreateCustomRepoRole(ctx context.Context, org str return nil, nil, err } - resultingRole := new(CustomRepoRoles) - resp, err := s.client.Do(ctx, req, resultingRole) + var resultingRole *CustomRepoRoles + resp, err := s.client.Do(ctx, req, &resultingRole) if err != nil { return nil, resp, err } @@ -127,8 +127,8 @@ func (s *OrganizationsService) UpdateCustomRepoRole(ctx context.Context, org str return nil, nil, err } - resultingRole := new(CustomRepoRoles) - resp, err := s.client.Do(ctx, req, resultingRole) + var resultingRole *CustomRepoRoles + resp, err := s.client.Do(ctx, req, &resultingRole) if err != nil { return nil, resp, err } @@ -150,8 +150,8 @@ func (s *OrganizationsService) DeleteCustomRepoRole(ctx context.Context, org str return nil, err } - resultingRole := new(CustomRepoRoles) - resp, err := s.client.Do(ctx, req, resultingRole) + var resultingRole *CustomRepoRoles + resp, err := s.client.Do(ctx, req, &resultingRole) if err != nil { return resp, err } diff --git a/github/orgs_hooks.go b/github/orgs_hooks.go index e3bb25e78f4..d957cecfeee 100644 --- a/github/orgs_hooks.go +++ b/github/orgs_hooks.go @@ -49,8 +49,8 @@ func (s *OrganizationsService) GetHook(ctx context.Context, org string, id int64 return nil, nil, err } - hook := new(Hook) - resp, err := s.client.Do(ctx, req, hook) + var hook *Hook + resp, err := s.client.Do(ctx, req, &hook) if err != nil { return nil, resp, err } @@ -86,8 +86,8 @@ func (s *OrganizationsService) CreateHook(ctx context.Context, org string, hook return nil, nil, err } - h := new(Hook) - resp, err := s.client.Do(ctx, req, h) + var h *Hook + resp, err := s.client.Do(ctx, req, &h) if err != nil { return nil, resp, err } @@ -107,8 +107,8 @@ func (s *OrganizationsService) EditHook(ctx context.Context, org string, id int6 return nil, nil, err } - h := new(Hook) - resp, err := s.client.Do(ctx, req, h) + var h *Hook + resp, err := s.client.Do(ctx, req, &h) if err != nil { return nil, resp, err } diff --git a/github/orgs_hooks_configuration.go b/github/orgs_hooks_configuration.go index aeb616fc4c7..9f95db253ff 100644 --- a/github/orgs_hooks_configuration.go +++ b/github/orgs_hooks_configuration.go @@ -22,8 +22,8 @@ func (s *OrganizationsService) GetHookConfiguration(ctx context.Context, org str return nil, nil, err } - config := new(HookConfig) - resp, err := s.client.Do(ctx, req, config) + var config *HookConfig + resp, err := s.client.Do(ctx, req, &config) if err != nil { return nil, resp, err } @@ -43,8 +43,8 @@ func (s *OrganizationsService) EditHookConfiguration(ctx context.Context, org st return nil, nil, err } - c := new(HookConfig) - resp, err := s.client.Do(ctx, req, c) + var c *HookConfig + resp, err := s.client.Do(ctx, req, &c) if err != nil { return nil, resp, err } diff --git a/github/orgs_hooks_configuration_test.go b/github/orgs_hooks_configuration_test.go index c57342afc21..7b154bbbbdf 100644 --- a/github/orgs_hooks_configuration_test.go +++ b/github/orgs_hooks_configuration_test.go @@ -70,8 +70,8 @@ func TestOrganizationsService_EditHookConfiguration(t *testing.T) { input := &HookConfig{} mux.HandleFunc("/orgs/o/hooks/1/config", func(w http.ResponseWriter, r *http.Request) { - v := new(HookConfig) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *HookConfig + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { diff --git a/github/orgs_hooks_deliveries.go b/github/orgs_hooks_deliveries.go index c1c30124028..e1e81839568 100644 --- a/github/orgs_hooks_deliveries.go +++ b/github/orgs_hooks_deliveries.go @@ -48,8 +48,8 @@ func (s *OrganizationsService) GetHookDelivery(ctx context.Context, owner string return nil, nil, err } - h := new(HookDelivery) - resp, err := s.client.Do(ctx, req, h) + var h *HookDelivery + resp, err := s.client.Do(ctx, req, &h) if err != nil { return nil, resp, err } @@ -69,8 +69,8 @@ func (s *OrganizationsService) RedeliverHookDelivery(ctx context.Context, owner return nil, nil, err } - h := new(HookDelivery) - resp, err := s.client.Do(ctx, req, h) + var h *HookDelivery + resp, err := s.client.Do(ctx, req, &h) if err != nil { return nil, resp, err } diff --git a/github/orgs_hooks_test.go b/github/orgs_hooks_test.go index f5eeda8a0a9..a0941aade8f 100644 --- a/github/orgs_hooks_test.go +++ b/github/orgs_hooks_test.go @@ -68,8 +68,8 @@ func TestOrganizationsService_CreateHook(t *testing.T) { input := &Hook{CreatedAt: &Timestamp{referenceTime}} mux.HandleFunc("/orgs/o/hooks", func(w http.ResponseWriter, r *http.Request) { - v := new(createHookRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *createHookRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") want := &createHookRequest{Name: "web"} @@ -161,8 +161,8 @@ func TestOrganizationsService_EditHook(t *testing.T) { input := &Hook{} mux.HandleFunc("/orgs/o/hooks/1", func(w http.ResponseWriter, r *http.Request) { - v := new(Hook) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *Hook + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { diff --git a/github/orgs_issue_types.go b/github/orgs_issue_types.go index 0819c218382..e03521d7de0 100644 --- a/github/orgs_issue_types.go +++ b/github/orgs_issue_types.go @@ -53,8 +53,8 @@ func (s *OrganizationsService) CreateIssueType(ctx context.Context, org string, return nil, nil, err } - issueType := new(IssueType) - resp, err := s.client.Do(ctx, req, issueType) + var issueType *IssueType + resp, err := s.client.Do(ctx, req, &issueType) if err != nil { return nil, resp, err } @@ -74,8 +74,8 @@ func (s *OrganizationsService) UpdateIssueType(ctx context.Context, org string, return nil, nil, err } - issueType := new(IssueType) - resp, err := s.client.Do(ctx, req, issueType) + var issueType *IssueType + resp, err := s.client.Do(ctx, req, &issueType) if err != nil { return nil, resp, err } diff --git a/github/orgs_issue_types_test.go b/github/orgs_issue_types_test.go index 10efc1d3047..30c9b4a2efa 100644 --- a/github/orgs_issue_types_test.go +++ b/github/orgs_issue_types_test.go @@ -97,8 +97,8 @@ func TestOrganizationsService_CreateIssueType(t *testing.T) { } mux.HandleFunc("/orgs/o/issue-types", func(w http.ResponseWriter, r *http.Request) { - v := new(CreateOrUpdateIssueTypesOptions) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *CreateOrUpdateIssueTypesOptions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { @@ -161,8 +161,8 @@ func TestOrganizationsService_UpdateIssueType(t *testing.T) { } mux.HandleFunc("/orgs/o/issue-types/410", func(w http.ResponseWriter, r *http.Request) { - v := new(CreateOrUpdateIssueTypesOptions) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *CreateOrUpdateIssueTypesOptions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { diff --git a/github/orgs_members.go b/github/orgs_members.go index 837a8f44677..2300f595015 100644 --- a/github/orgs_members.go +++ b/github/orgs_members.go @@ -256,8 +256,8 @@ func (s *OrganizationsService) GetOrgMembership(ctx context.Context, user, org s return nil, nil, err } - membership := new(Membership) - resp, err := s.client.Do(ctx, req, membership) + var membership *Membership + resp, err := s.client.Do(ctx, req, &membership) if err != nil { return nil, resp, err } @@ -290,8 +290,8 @@ func (s *OrganizationsService) EditOrgMembership(ctx context.Context, user, org return nil, nil, err } - m := new(Membership) - resp, err := s.client.Do(ctx, req, m) + var m *Membership + resp, err := s.client.Do(ctx, req, &m) if err != nil { return nil, resp, err } diff --git a/github/orgs_members_test.go b/github/orgs_members_test.go index b696bb621aa..1738f401351 100644 --- a/github/orgs_members_test.go +++ b/github/orgs_members_test.go @@ -469,8 +469,8 @@ func TestOrganizationsService_EditOrgMembership_AuthenticatedUser(t *testing.T) input := &Membership{State: Ptr("active")} mux.HandleFunc("/user/memberships/orgs/o", func(w http.ResponseWriter, r *http.Request) { - v := new(Membership) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *Membership + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { @@ -513,8 +513,8 @@ func TestOrganizationsService_EditOrgMembership_SpecifiedUser(t *testing.T) { input := &Membership{State: Ptr("active")} mux.HandleFunc("/orgs/o/memberships/u", func(w http.ResponseWriter, r *http.Request) { - v := new(Membership) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *Membership + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { @@ -673,8 +673,8 @@ func TestOrganizationsService_CreateOrgInvitation(t *testing.T) { } mux.HandleFunc("/orgs/o/invitations", func(w http.ResponseWriter, r *http.Request) { - v := new(CreateOrgInvitationOptions) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *CreateOrgInvitationOptions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { diff --git a/github/orgs_network_configurations.go b/github/orgs_network_configurations.go index 89437f76c88..62eccc2c7da 100644 --- a/github/orgs_network_configurations.go +++ b/github/orgs_network_configurations.go @@ -116,11 +116,12 @@ func (s *OrganizationsService) ListNetworkConfigurations(ctx context.Context, or return nil, nil, err } - configurations := &NetworkConfigurations{} - resp, err := s.client.Do(ctx, req, configurations) + var configurations *NetworkConfigurations + resp, err := s.client.Do(ctx, req, &configurations) if err != nil { return nil, resp, err } + return configurations, resp, nil } @@ -140,11 +141,12 @@ func (s *OrganizationsService) CreateNetworkConfiguration(ctx context.Context, o return nil, nil, err } - configuration := &NetworkConfiguration{} - resp, err := s.client.Do(ctx, req, configuration) + var configuration *NetworkConfiguration + resp, err := s.client.Do(ctx, req, &configuration) if err != nil { return nil, resp, err } + return configuration, resp, nil } @@ -160,11 +162,12 @@ func (s *OrganizationsService) GetNetworkConfiguration(ctx context.Context, org, return nil, nil, err } - configuration := &NetworkConfiguration{} - resp, err := s.client.Do(ctx, req, configuration) + var configuration *NetworkConfiguration + resp, err := s.client.Do(ctx, req, &configuration) if err != nil { return nil, resp, err } + return configuration, resp, nil } @@ -184,11 +187,12 @@ func (s *OrganizationsService) UpdateNetworkConfiguration(ctx context.Context, o return nil, nil, err } - configuration := &NetworkConfiguration{} - resp, err := s.client.Do(ctx, req, configuration) + var configuration *NetworkConfiguration + resp, err := s.client.Do(ctx, req, &configuration) if err != nil { return nil, resp, err } + return configuration, resp, nil } @@ -204,11 +208,12 @@ func (s *OrganizationsService) DeleteNetworkConfigurations(ctx context.Context, return nil, err } - configuration := &NetworkConfiguration{} - resp, err := s.client.Do(ctx, req, configuration) + var configuration *NetworkConfiguration + resp, err := s.client.Do(ctx, req, &configuration) if err != nil { return resp, err } + return resp, nil } @@ -224,10 +229,11 @@ func (s *OrganizationsService) GetNetworkConfigurationResource(ctx context.Conte return nil, nil, err } - resource := &NetworkSettingsResource{} - resp, err := s.client.Do(ctx, req, resource) + var resource *NetworkSettingsResource + resp, err := s.client.Do(ctx, req, &resource) if err != nil { return nil, resp, err } + return resource, resp, nil } diff --git a/github/orgs_organization_roles.go b/github/orgs_organization_roles.go index 7feb016f068..cb4a638fd2b 100644 --- a/github/orgs_organization_roles.go +++ b/github/orgs_organization_roles.go @@ -65,8 +65,8 @@ func (s *OrganizationsService) ListRoles(ctx context.Context, org string) (*Orga return nil, nil, err } - customRepoRoles := new(OrganizationCustomRoles) - resp, err := s.client.Do(ctx, req, customRepoRoles) + var customRepoRoles *OrganizationCustomRoles + resp, err := s.client.Do(ctx, req, &customRepoRoles) if err != nil { return nil, resp, err } @@ -88,8 +88,8 @@ func (s *OrganizationsService) GetOrgRole(ctx context.Context, org string, roleI return nil, nil, err } - resultingRole := new(CustomOrgRole) - resp, err := s.client.Do(ctx, req, resultingRole) + var resultingRole *CustomOrgRole + resp, err := s.client.Do(ctx, req, &resultingRole) if err != nil { return nil, resp, err } @@ -111,8 +111,8 @@ func (s *OrganizationsService) CreateCustomOrgRole(ctx context.Context, org stri return nil, nil, err } - resultingRole := new(CustomOrgRole) - resp, err := s.client.Do(ctx, req, resultingRole) + var resultingRole *CustomOrgRole + resp, err := s.client.Do(ctx, req, &resultingRole) if err != nil { return nil, resp, err } @@ -134,8 +134,8 @@ func (s *OrganizationsService) UpdateCustomOrgRole(ctx context.Context, org stri return nil, nil, err } - resultingRole := new(CustomOrgRole) - resp, err := s.client.Do(ctx, req, resultingRole) + var resultingRole *CustomOrgRole + resp, err := s.client.Do(ctx, req, &resultingRole) if err != nil { return nil, resp, err } @@ -157,8 +157,8 @@ func (s *OrganizationsService) DeleteCustomOrgRole(ctx context.Context, org stri return nil, err } - resultingRole := new(CustomOrgRole) - resp, err := s.client.Do(ctx, req, resultingRole) + var resultingRole *CustomOrgRole + resp, err := s.client.Do(ctx, req, &resultingRole) if err != nil { return resp, err } diff --git a/github/orgs_personal_access_tokens_test.go b/github/orgs_personal_access_tokens_test.go index 3ad495f71d6..868132c7e92 100644 --- a/github/orgs_personal_access_tokens_test.go +++ b/github/orgs_personal_access_tokens_test.go @@ -344,8 +344,8 @@ func TestOrganizationsService_ReviewPersonalAccessTokenRequest(t *testing.T) { } mux.HandleFunc("/orgs/o/personal-access-token-requests/1", func(w http.ResponseWriter, r *http.Request) { - v := new(ReviewPersonalAccessTokenRequestOptions) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *ReviewPersonalAccessTokenRequestOptions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, &input) { diff --git a/github/orgs_test.go b/github/orgs_test.go index 9b062bc0347..15b7414cc36 100644 --- a/github/orgs_test.go +++ b/github/orgs_test.go @@ -267,8 +267,8 @@ func TestOrganizationsService_Edit(t *testing.T) { input := &Organization{Login: Ptr("l")} mux.HandleFunc("/orgs/o", func(w http.ResponseWriter, r *http.Request) { - v := new(Organization) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *Organization + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testHeader(t, r, "Accept", mediaTypeMemberAllowedRepoCreationTypePreview) testMethod(t, r, "PATCH") diff --git a/github/private_registries_test.go b/github/private_registries_test.go index c214fd486bc..fd9531416a4 100644 --- a/github/private_registries_test.go +++ b/github/private_registries_test.go @@ -100,8 +100,8 @@ func TestPrivateRegistriesService_CreateOrganizationPrivateRegistry(t *testing.T } mux.HandleFunc("/orgs/o/private-registries", func(w http.ResponseWriter, r *http.Request) { - v := new(CreateOrganizationPrivateRegistry) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *CreateOrganizationPrivateRegistry + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { @@ -250,8 +250,8 @@ func TestPrivateRegistries_UpdateOrganizationPrivateRegistry(t *testing.T) { } mux.HandleFunc("/orgs/o/private-registries/MAVEN_REPOSITORY_SECRET", func(w http.ResponseWriter, r *http.Request) { - v := new(UpdateOrganizationPrivateRegistry) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *UpdateOrganizationPrivateRegistry + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { diff --git a/github/projects.go b/github/projects.go index 8d6cbf8dae0..96b9e0a3816 100644 --- a/github/projects.go +++ b/github/projects.go @@ -295,6 +295,7 @@ func (s *ProjectsService) ListOrganizationProjects(ctx context.Context, org stri if err != nil { return nil, resp, err } + return projects, resp, nil } @@ -310,11 +311,12 @@ func (s *ProjectsService) GetOrganizationProject(ctx context.Context, org string return nil, nil, err } - project := new(ProjectV2) - resp, err := s.client.Do(ctx, req, project) + var project *ProjectV2 + resp, err := s.client.Do(ctx, req, &project) if err != nil { return nil, resp, err } + return project, resp, nil } @@ -339,6 +341,7 @@ func (s *ProjectsService) ListUserProjects(ctx context.Context, username string, if err != nil { return nil, resp, err } + return projects, resp, nil } @@ -354,11 +357,12 @@ func (s *ProjectsService) GetUserProject(ctx context.Context, username string, p return nil, nil, err } - project := new(ProjectV2) - resp, err := s.client.Do(ctx, req, project) + var project *ProjectV2 + resp, err := s.client.Do(ctx, req, &project) if err != nil { return nil, resp, err } + return project, resp, nil } @@ -384,6 +388,7 @@ func (s *ProjectsService) ListOrganizationProjectFields(ctx context.Context, org if err != nil { return nil, resp, err } + return fields, resp, nil } @@ -409,6 +414,7 @@ func (s *ProjectsService) ListUserProjectFields(ctx context.Context, user string if err != nil { return nil, resp, err } + return fields, resp, nil } @@ -424,11 +430,12 @@ func (s *ProjectsService) GetOrganizationProjectField(ctx context.Context, org s return nil, nil, err } - field := new(ProjectV2Field) - resp, err := s.client.Do(ctx, req, field) + var field *ProjectV2Field + resp, err := s.client.Do(ctx, req, &field) if err != nil { return nil, resp, err } + return field, resp, nil } @@ -444,11 +451,12 @@ func (s *ProjectsService) GetUserProjectField(ctx context.Context, user string, return nil, nil, err } - field := new(ProjectV2Field) - resp, err := s.client.Do(ctx, req, field) + var field *ProjectV2Field + resp, err := s.client.Do(ctx, req, &field) if err != nil { return nil, resp, err } + return field, resp, nil } @@ -525,6 +533,7 @@ func (s *ProjectsService) ListOrganizationProjectItems(ctx context.Context, org if err != nil { return nil, resp, err } + return items, resp, nil } @@ -540,11 +549,12 @@ func (s *ProjectsService) AddOrganizationProjectItem(ctx context.Context, org st return nil, nil, err } - item := new(ProjectV2Item) - resp, err := s.client.Do(ctx, req, item) + var item *ProjectV2Item + resp, err := s.client.Do(ctx, req, &item) if err != nil { return nil, resp, err } + return item, resp, nil } @@ -559,15 +569,18 @@ func (s *ProjectsService) GetOrganizationProjectItem(ctx context.Context, org st if err != nil { return nil, nil, err } + req, err := s.client.NewRequest("GET", u, nil) if err != nil { return nil, nil, err } - item := new(ProjectV2Item) - resp, err := s.client.Do(ctx, req, item) + + var item *ProjectV2Item + resp, err := s.client.Do(ctx, req, &item) if err != nil { return nil, resp, err } + return item, resp, nil } @@ -582,11 +595,13 @@ func (s *ProjectsService) UpdateOrganizationProjectItem(ctx context.Context, org if err != nil { return nil, nil, err } - item := new(ProjectV2Item) - resp, err := s.client.Do(ctx, req, item) + + var item *ProjectV2Item + resp, err := s.client.Do(ctx, req, &item) if err != nil { return nil, resp, err } + return item, resp, nil } @@ -601,6 +616,7 @@ func (s *ProjectsService) DeleteOrganizationProjectItem(ctx context.Context, org if err != nil { return nil, err } + return s.client.Do(ctx, req, nil) } @@ -615,15 +631,18 @@ func (s *ProjectsService) ListUserProjectItems(ctx context.Context, username str if err != nil { return nil, nil, err } + req, err := s.client.NewRequest("GET", u, nil) if err != nil { return nil, nil, err } + var items []*ProjectV2Item resp, err := s.client.Do(ctx, req, &items) if err != nil { return nil, resp, err } + return items, resp, nil } @@ -638,11 +657,13 @@ func (s *ProjectsService) AddUserProjectItem(ctx context.Context, username strin if err != nil { return nil, nil, err } - item := new(ProjectV2Item) - resp, err := s.client.Do(ctx, req, item) + + var item *ProjectV2Item + resp, err := s.client.Do(ctx, req, &item) if err != nil { return nil, resp, err } + return item, resp, nil } @@ -657,15 +678,18 @@ func (s *ProjectsService) GetUserProjectItem(ctx context.Context, username strin if err != nil { return nil, nil, err } + req, err := s.client.NewRequest("GET", u, nil) if err != nil { return nil, nil, err } - item := new(ProjectV2Item) - resp, err := s.client.Do(ctx, req, item) + + var item *ProjectV2Item + resp, err := s.client.Do(ctx, req, &item) if err != nil { return nil, resp, err } + return item, resp, nil } @@ -680,11 +704,13 @@ func (s *ProjectsService) UpdateUserProjectItem(ctx context.Context, username st if err != nil { return nil, nil, err } - item := new(ProjectV2Item) - resp, err := s.client.Do(ctx, req, item) + + var item *ProjectV2Item + resp, err := s.client.Do(ctx, req, &item) if err != nil { return nil, resp, err } + return item, resp, nil } @@ -699,5 +725,6 @@ func (s *ProjectsService) DeleteUserProjectItem(ctx context.Context, username st if err != nil { return nil, err } + return s.client.Do(ctx, req, nil) } diff --git a/github/pulls.go b/github/pulls.go index aefd08a6dde..20c8879a36d 100644 --- a/github/pulls.go +++ b/github/pulls.go @@ -219,8 +219,8 @@ func (s *PullRequestsService) Get(ctx context.Context, owner, repo string, numbe return nil, nil, err } - pull := new(PullRequest) - resp, err := s.client.Do(ctx, req, pull) + var pull *PullRequest + resp, err := s.client.Do(ctx, req, &pull) if err != nil { return nil, resp, err } @@ -289,8 +289,8 @@ func (s *PullRequestsService) Create(ctx context.Context, owner, repo string, pu return nil, nil, err } - p := new(PullRequest) - resp, err := s.client.Do(ctx, req, p) + var p *PullRequest + resp, err := s.client.Do(ctx, req, &p) if err != nil { return nil, resp, err } @@ -333,8 +333,8 @@ func (s *PullRequestsService) UpdateBranch(ctx context.Context, owner, repo stri req.Header.Set("Accept", mediaTypeUpdatePullRequestBranchPreview) - p := new(PullRequestBranchUpdateResponse) - resp, err := s.client.Do(ctx, req, p) + var p *PullRequestBranchUpdateResponse + resp, err := s.client.Do(ctx, req, &p) if err != nil { return nil, resp, err } @@ -384,8 +384,8 @@ func (s *PullRequestsService) Edit(ctx context.Context, owner, repo string, numb return nil, nil, err } - p := new(PullRequest) - resp, err := s.client.Do(ctx, req, p) + var p *PullRequest + resp, err := s.client.Do(ctx, req, &p) if err != nil { return nil, resp, err } @@ -497,7 +497,7 @@ type pullRequestMergeRequest struct { func (s *PullRequestsService) Merge(ctx context.Context, owner, repo string, number int, commitMessage string, options *PullRequestOptions) (*PullRequestMergeResult, *Response, error) { u := fmt.Sprintf("repos/%v/%v/pulls/%v/merge", owner, repo, number) - pullRequestBody := &pullRequestMergeRequest{} + var pullRequestBody pullRequestMergeRequest if commitMessage != "" { pullRequestBody.CommitMessage = &commitMessage } @@ -509,13 +509,13 @@ func (s *PullRequestsService) Merge(ctx context.Context, owner, repo string, num pullRequestBody.CommitMessage = &commitMessage } } - req, err := s.client.NewRequest("PUT", u, pullRequestBody) + req, err := s.client.NewRequest("PUT", u, &pullRequestBody) if err != nil { return nil, nil, err } - mergeResult := new(PullRequestMergeResult) - resp, err := s.client.Do(ctx, req, mergeResult) + var mergeResult *PullRequestMergeResult + resp, err := s.client.Do(ctx, req, &mergeResult) if err != nil { return nil, resp, err } diff --git a/github/pulls_comments.go b/github/pulls_comments.go index 4d601730b48..69de53c712e 100644 --- a/github/pulls_comments.go +++ b/github/pulls_comments.go @@ -122,8 +122,8 @@ func (s *PullRequestsService) GetComment(ctx context.Context, owner, repo string acceptHeaders := []string{mediaTypeReactionsPreview, mediaTypeMultiLineCommentsPreview} req.Header.Set("Accept", strings.Join(acceptHeaders, ", ")) - comment := new(PullRequestComment) - resp, err := s.client.Do(ctx, req, comment) + var comment *PullRequestComment + resp, err := s.client.Do(ctx, req, &comment) if err != nil { return nil, resp, err } @@ -145,8 +145,8 @@ func (s *PullRequestsService) CreateComment(ctx context.Context, owner, repo str acceptHeaders := []string{mediaTypeReactionsPreview, mediaTypeMultiLineCommentsPreview} req.Header.Set("Accept", strings.Join(acceptHeaders, ", ")) - c := new(PullRequestComment) - resp, err := s.client.Do(ctx, req, c) + var c *PullRequestComment + resp, err := s.client.Do(ctx, req, &c) if err != nil { return nil, resp, err } @@ -173,8 +173,8 @@ func (s *PullRequestsService) CreateCommentInReplyTo(ctx context.Context, owner, return nil, nil, err } - c := new(PullRequestComment) - resp, err := s.client.Do(ctx, req, c) + var c *PullRequestComment + resp, err := s.client.Do(ctx, req, &c) if err != nil { return nil, resp, err } @@ -195,8 +195,8 @@ func (s *PullRequestsService) EditComment(ctx context.Context, owner, repo strin return nil, nil, err } - c := new(PullRequestComment) - resp, err := s.client.Do(ctx, req, c) + var c *PullRequestComment + resp, err := s.client.Do(ctx, req, &c) if err != nil { return nil, resp, err } @@ -215,5 +215,6 @@ func (s *PullRequestsService) DeleteComment(ctx context.Context, owner, repo str if err != nil { return nil, err } + return s.client.Do(ctx, req, nil) } diff --git a/github/pulls_comments_test.go b/github/pulls_comments_test.go index e6e2d048930..0c77bb24a87 100644 --- a/github/pulls_comments_test.go +++ b/github/pulls_comments_test.go @@ -268,8 +268,8 @@ func TestPullRequestsService_CreateComment(t *testing.T) { wantAcceptHeaders := []string{mediaTypeReactionsPreview, mediaTypeMultiLineCommentsPreview} mux.HandleFunc("/repos/o/r/pulls/1/comments", func(w http.ResponseWriter, r *http.Request) { - v := new(PullRequestComment) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *PullRequestComment + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testHeader(t, r, "Accept", strings.Join(wantAcceptHeaders, ", ")) testMethod(t, r, "POST") @@ -322,8 +322,8 @@ func TestPullRequestsService_CreateCommentInReplyTo(t *testing.T) { input := &PullRequestComment{Body: Ptr("b")} mux.HandleFunc("/repos/o/r/pulls/1/comments", func(w http.ResponseWriter, r *http.Request) { - v := new(PullRequestComment) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *PullRequestComment + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { @@ -366,8 +366,8 @@ func TestPullRequestsService_EditComment(t *testing.T) { input := &PullRequestComment{Body: Ptr("b")} mux.HandleFunc("/repos/o/r/pulls/comments/1", func(w http.ResponseWriter, r *http.Request) { - v := new(PullRequestComment) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *PullRequestComment + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { diff --git a/github/pulls_reviewers.go b/github/pulls_reviewers.go index daa171faeb9..297634c9621 100644 --- a/github/pulls_reviewers.go +++ b/github/pulls_reviewers.go @@ -42,8 +42,8 @@ func (s *PullRequestsService) RequestReviewers(ctx context.Context, owner, repo return nil, nil, err } - r := new(PullRequest) - resp, err := s.client.Do(ctx, req, r) + var r *PullRequest + resp, err := s.client.Do(ctx, req, &r) if err != nil { return nil, resp, err } @@ -64,8 +64,8 @@ func (s *PullRequestsService) ListReviewers(ctx context.Context, owner, repo str return nil, nil, err } - reviewers := new(Reviewers) - resp, err := s.client.Do(ctx, req, reviewers) + var reviewers *Reviewers + resp, err := s.client.Do(ctx, req, &reviewers) if err != nil { return nil, resp, err } diff --git a/github/pulls_reviews.go b/github/pulls_reviews.go index e8cf7a75b0c..9f55ab533cf 100644 --- a/github/pulls_reviews.go +++ b/github/pulls_reviews.go @@ -141,8 +141,8 @@ func (s *PullRequestsService) GetReview(ctx context.Context, owner, repo string, return nil, nil, err } - review := new(PullRequestReview) - resp, err := s.client.Do(ctx, req, review) + var review *PullRequestReview + resp, err := s.client.Do(ctx, req, &review) if err != nil { return nil, resp, err } @@ -163,8 +163,8 @@ func (s *PullRequestsService) DeletePendingReview(ctx context.Context, owner, re return nil, nil, err } - review := new(PullRequestReview) - resp, err := s.client.Do(ctx, req, review) + var review *PullRequestReview + resp, err := s.client.Do(ctx, req, &review) if err != nil { return nil, resp, err } @@ -254,8 +254,8 @@ func (s *PullRequestsService) CreateReview(ctx context.Context, owner, repo stri req.Header.Set("Accept", mediaTypeMultiLineCommentsPreview) } - r := new(PullRequestReview) - resp, err := s.client.Do(ctx, req, r) + var r *PullRequestReview + resp, err := s.client.Do(ctx, req, &r) if err != nil { return nil, resp, err } @@ -301,8 +301,8 @@ func (s *PullRequestsService) SubmitReview(ctx context.Context, owner, repo stri return nil, nil, err } - r := new(PullRequestReview) - resp, err := s.client.Do(ctx, req, r) + var r *PullRequestReview + resp, err := s.client.Do(ctx, req, &r) if err != nil { return nil, resp, err } @@ -323,8 +323,8 @@ func (s *PullRequestsService) DismissReview(ctx context.Context, owner, repo str return nil, nil, err } - r := new(PullRequestReview) - resp, err := s.client.Do(ctx, req, r) + var r *PullRequestReview + resp, err := s.client.Do(ctx, req, &r) if err != nil { return nil, resp, err } diff --git a/github/pulls_reviews_test.go b/github/pulls_reviews_test.go index b0ed4f41661..02ee6084b03 100644 --- a/github/pulls_reviews_test.go +++ b/github/pulls_reviews_test.go @@ -366,8 +366,8 @@ func TestPullRequestsService_CreateReview(t *testing.T) { } mux.HandleFunc("/repos/o/r/pulls/1/reviews", func(w http.ResponseWriter, r *http.Request) { - v := new(PullRequestReviewRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *PullRequestReviewRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { @@ -470,8 +470,8 @@ func TestPullRequestsService_CreateReview_addHeader(t *testing.T) { } mux.HandleFunc("/repos/o/r/pulls/1/reviews", func(w http.ResponseWriter, r *http.Request) { - v := new(PullRequestReviewRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *PullRequestReviewRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { @@ -534,8 +534,8 @@ func TestPullRequestsService_SubmitReview(t *testing.T) { } mux.HandleFunc("/repos/o/r/pulls/1/reviews/1/events", func(w http.ResponseWriter, r *http.Request) { - v := new(PullRequestReviewRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *PullRequestReviewRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { @@ -587,8 +587,8 @@ func TestPullRequestsService_DismissReview(t *testing.T) { input := &PullRequestReviewDismissalRequest{Message: Ptr("m")} mux.HandleFunc("/repos/o/r/pulls/1/reviews/1/dismissals", func(w http.ResponseWriter, r *http.Request) { - v := new(PullRequestReviewDismissalRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *PullRequestReviewDismissalRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { diff --git a/github/pulls_test.go b/github/pulls_test.go index b34140f8c71..b98188758ee 100644 --- a/github/pulls_test.go +++ b/github/pulls_test.go @@ -359,8 +359,8 @@ func TestPullRequestsService_Create(t *testing.T) { input := &NewPullRequest{Title: Ptr("t")} mux.HandleFunc("/repos/o/r/pulls", func(w http.ResponseWriter, r *http.Request) { - v := new(NewPullRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *NewPullRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { diff --git a/github/reactions.go b/github/reactions.go index f8b4023c239..9097a5d6902 100644 --- a/github/reactions.go +++ b/github/reactions.go @@ -104,8 +104,8 @@ func (s *ReactionsService) CreateCommentReaction(ctx context.Context, owner, rep req.Header.Set("Accept", mediaTypeReactionsPreview) - m := &Reaction{} - resp, err := s.client.Do(ctx, req, m) + var m *Reaction + resp, err := s.client.Do(ctx, req, &m) if err != nil { return nil, resp, err } @@ -182,8 +182,8 @@ func (s *ReactionsService) CreateIssueReaction(ctx context.Context, owner, repo req.Header.Set("Accept", mediaTypeReactionsPreview) - m := &Reaction{} - resp, err := s.client.Do(ctx, req, m) + var m *Reaction + resp, err := s.client.Do(ctx, req, &m) if err != nil { return nil, resp, err } @@ -260,8 +260,8 @@ func (s *ReactionsService) CreateIssueCommentReaction(ctx context.Context, owner req.Header.Set("Accept", mediaTypeReactionsPreview) - m := &Reaction{} - resp, err := s.client.Do(ctx, req, m) + var m *Reaction + resp, err := s.client.Do(ctx, req, &m) if err != nil { return nil, resp, err } @@ -338,8 +338,8 @@ func (s *ReactionsService) CreatePullRequestCommentReaction(ctx context.Context, req.Header.Set("Accept", mediaTypeReactionsPreview) - m := &Reaction{} - resp, err := s.client.Do(ctx, req, m) + var m *Reaction + resp, err := s.client.Do(ctx, req, &m) if err != nil { return nil, resp, err } @@ -414,8 +414,8 @@ func (s *ReactionsService) CreateTeamDiscussionReaction(ctx context.Context, tea req.Header.Set("Accept", mediaTypeReactionsPreview) - m := &Reaction{} - resp, err := s.client.Do(ctx, req, m) + var m *Reaction + resp, err := s.client.Do(ctx, req, &m) if err != nil { return nil, resp, err } @@ -489,8 +489,8 @@ func (s *ReactionsService) CreateTeamDiscussionCommentReaction(ctx context.Conte req.Header.Set("Accept", mediaTypeReactionsPreview) - m := &Reaction{} - resp, err := s.client.Do(ctx, req, m) + var m *Reaction + resp, err := s.client.Do(ctx, req, &m) if err != nil { return nil, resp, err } @@ -550,8 +550,8 @@ func (s *ReactionsService) CreateReleaseReaction(ctx context.Context, owner, rep req.Header.Set("Accept", mediaTypeReactionsPreview) - m := &Reaction{} - resp, err := s.client.Do(ctx, req, m) + var m *Reaction + resp, err := s.client.Do(ctx, req, &m) if err != nil { return nil, resp, err } diff --git a/github/repos.go b/github/repos.go index ac76f1f3f80..293b20b6b45 100644 --- a/github/repos.go +++ b/github/repos.go @@ -595,8 +595,8 @@ func (s *RepositoriesService) Create(ctx context.Context, org string, repo *Repo acceptHeaders := []string{mediaTypeRepositoryTemplatePreview, mediaTypeRepositoryVisibilityPreview} req.Header.Set("Accept", strings.Join(acceptHeaders, ", ")) - r := new(Repository) - resp, err := s.client.Do(ctx, req, r) + var r *Repository + resp, err := s.client.Do(ctx, req, &r) if err != nil { return nil, resp, err } @@ -629,8 +629,8 @@ func (s *RepositoriesService) CreateFromTemplate(ctx context.Context, templateOw } req.Header.Set("Accept", mediaTypeRepositoryTemplatePreview) - r := new(Repository) - resp, err := s.client.Do(ctx, req, r) + var r *Repository + resp, err := s.client.Do(ctx, req, &r) if err != nil { return nil, resp, err } @@ -659,8 +659,8 @@ func (s *RepositoriesService) Get(ctx context.Context, owner, repo string) (*Rep } req.Header.Set("Accept", strings.Join(acceptHeaders, ", ")) - repository := new(Repository) - resp, err := s.client.Do(ctx, req, repository) + var repository *Repository + resp, err := s.client.Do(ctx, req, &repository) if err != nil { return nil, resp, err } @@ -684,8 +684,8 @@ func (s *RepositoriesService) GetCodeOfConduct(ctx context.Context, owner, repo req.Header.Set("Accept", mediaTypeCodesOfConductPreview) - r := new(Repository) - resp, err := s.client.Do(ctx, req, r) + var r *Repository + resp, err := s.client.Do(ctx, req, &r) if err != nil { return nil, resp, err } @@ -705,8 +705,8 @@ func (s *RepositoriesService) GetByID(ctx context.Context, id int64) (*Repositor return nil, nil, err } - repository := new(Repository) - resp, err := s.client.Do(ctx, req, repository) + var repository *Repository + resp, err := s.client.Do(ctx, req, &repository) if err != nil { return nil, resp, err } @@ -728,8 +728,8 @@ func (s *RepositoriesService) Edit(ctx context.Context, owner, repo string, repo acceptHeaders := []string{mediaTypeRepositoryTemplatePreview, mediaTypeRepositoryVisibilityPreview} req.Header.Set("Accept", strings.Join(acceptHeaders, ", ")) - r := new(Repository) - resp, err := s.client.Do(ctx, req, r) + var r *Repository + resp, err := s.client.Do(ctx, req, &r) if err != nil { return nil, resp, err } @@ -855,8 +855,8 @@ func (s *RepositoriesService) GetAutomatedSecurityFixes(ctx context.Context, own return nil, nil, err } - p := new(AutomatedSecurityFixes) - resp, err := s.client.Do(ctx, req, p) + var p *AutomatedSecurityFixes + resp, err := s.client.Do(ctx, req, &p) if err != nil { return nil, resp, err } @@ -1463,8 +1463,8 @@ func (s *RepositoriesService) GetBranch(ctx context.Context, owner, repo, branch return nil, newResponse(resp), fmt.Errorf("unexpected status code: %v", resp.Status) } - b := new(Branch) - err = json.NewDecoder(resp.Body).Decode(b) + var b *Branch + err = json.NewDecoder(resp.Body).Decode(&b) return b, newResponse(resp), err } @@ -1491,8 +1491,8 @@ func (s *RepositoriesService) RenameBranch(ctx context.Context, owner, repo, bra return nil, nil, err } - b := new(Branch) - resp, err := s.client.Do(ctx, req, b) + var b *Branch + resp, err := s.client.Do(ctx, req, &b) if err != nil { return nil, resp, err } @@ -1516,8 +1516,8 @@ func (s *RepositoriesService) GetBranchProtection(ctx context.Context, owner, re req.Header.Set("Accept", mediaTypeRequiredApprovingReviewsPreview) - p := new(Protection) - resp, err := s.client.Do(ctx, req, p) + var p *Protection + resp, err := s.client.Do(ctx, req, &p) if err != nil { if isBranchNotProtected(err) { err = ErrBranchNotProtected @@ -1542,8 +1542,8 @@ func (s *RepositoriesService) GetRequiredStatusChecks(ctx context.Context, owner return nil, nil, err } - p := new(RequiredStatusChecks) - resp, err := s.client.Do(ctx, req, p) + var p *RequiredStatusChecks + resp, err := s.client.Do(ctx, req, &p) if err != nil { if isBranchNotProtected(err) { err = ErrBranchNotProtected @@ -1595,8 +1595,8 @@ func (s *RepositoriesService) UpdateBranchProtection(ctx context.Context, owner, req.Header.Set("Accept", mediaTypeRequiredApprovingReviewsPreview) - p := new(Protection) - resp, err := s.client.Do(ctx, req, p) + var p *Protection + resp, err := s.client.Do(ctx, req, &p) if err != nil { return nil, resp, err } @@ -1637,8 +1637,8 @@ func (s *RepositoriesService) GetSignaturesProtectedBranch(ctx context.Context, req.Header.Set("Accept", mediaTypeSignaturePreview) - p := new(SignaturesProtectedBranch) - resp, err := s.client.Do(ctx, req, p) + var p *SignaturesProtectedBranch + resp, err := s.client.Do(ctx, req, &p) if err != nil { if isBranchNotProtected(err) { err = ErrBranchNotProtected @@ -1666,8 +1666,8 @@ func (s *RepositoriesService) RequireSignaturesOnProtectedBranch(ctx context.Con req.Header.Set("Accept", mediaTypeSignaturePreview) - r := new(SignaturesProtectedBranch) - resp, err := s.client.Do(ctx, req, r) + var r *SignaturesProtectedBranch + resp, err := s.client.Do(ctx, req, &r) if err != nil { return nil, resp, err } @@ -1708,8 +1708,8 @@ func (s *RepositoriesService) UpdateRequiredStatusChecks(ctx context.Context, ow return nil, nil, err } - sc := new(RequiredStatusChecks) - resp, err := s.client.Do(ctx, req, sc) + var sc *RequiredStatusChecks + resp, err := s.client.Do(ctx, req, &sc) if err != nil { return nil, resp, err } @@ -1746,8 +1746,8 @@ func (s *RepositoriesService) License(ctx context.Context, owner, repo string) ( return nil, nil, err } - r := &RepositoryLicense{} - resp, err := s.client.Do(ctx, req, r) + var r *RepositoryLicense + resp, err := s.client.Do(ctx, req, &r) if err != nil { return nil, resp, err } @@ -1771,8 +1771,8 @@ func (s *RepositoriesService) GetPullRequestReviewEnforcement(ctx context.Contex req.Header.Set("Accept", mediaTypeRequiredApprovingReviewsPreview) - r := new(PullRequestReviewsEnforcement) - resp, err := s.client.Do(ctx, req, r) + var r *PullRequestReviewsEnforcement + resp, err := s.client.Do(ctx, req, &r) if err != nil { return nil, resp, err } @@ -1797,8 +1797,8 @@ func (s *RepositoriesService) UpdatePullRequestReviewEnforcement(ctx context.Con req.Header.Set("Accept", mediaTypeRequiredApprovingReviewsPreview) - r := new(PullRequestReviewsEnforcement) - resp, err := s.client.Do(ctx, req, r) + var r *PullRequestReviewsEnforcement + resp, err := s.client.Do(ctx, req, &r) if err != nil { return nil, resp, err } @@ -1828,8 +1828,8 @@ func (s *RepositoriesService) DisableDismissalRestrictions(ctx context.Context, req.Header.Set("Accept", mediaTypeRequiredApprovingReviewsPreview) - r := new(PullRequestReviewsEnforcement) - resp, err := s.client.Do(ctx, req, r) + var r *PullRequestReviewsEnforcement + resp, err := s.client.Do(ctx, req, &r) if err != nil { return nil, resp, err } @@ -1868,8 +1868,8 @@ func (s *RepositoriesService) GetAdminEnforcement(ctx context.Context, owner, re return nil, nil, err } - r := new(AdminEnforcement) - resp, err := s.client.Do(ctx, req, r) + var r *AdminEnforcement + resp, err := s.client.Do(ctx, req, &r) if err != nil { return nil, resp, err } @@ -1892,8 +1892,8 @@ func (s *RepositoriesService) AddAdminEnforcement(ctx context.Context, owner, re return nil, nil, err } - r := new(AdminEnforcement) - resp, err := s.client.Do(ctx, req, r) + var r *AdminEnforcement + resp, err := s.client.Do(ctx, req, &r) if err != nil { return nil, resp, err } @@ -1942,8 +1942,8 @@ func (s *RepositoriesService) ListAllTopics(ctx context.Context, owner, repo str req.Header.Set("Accept", mediaTypeTopicsPreview) - topics := new(repositoryTopics) - resp, err := s.client.Do(ctx, req, topics) + var topics *repositoryTopics + resp, err := s.client.Do(ctx, req, &topics) if err != nil { return nil, resp, err } @@ -2329,8 +2329,8 @@ func (s *RepositoriesService) Transfer(ctx context.Context, owner, repo string, return nil, nil, err } - r := new(Repository) - resp, err := s.client.Do(ctx, req, r) + var r *Repository + resp, err := s.client.Do(ctx, req, &r) if err != nil { return nil, resp, err } @@ -2360,8 +2360,8 @@ func (s *RepositoriesService) Dispatch(ctx context.Context, owner, repo string, return nil, nil, err } - r := new(Repository) - resp, err := s.client.Do(ctx, req, r) + var r *Repository + resp, err := s.client.Do(ctx, req, &r) if err != nil { return nil, resp, err } @@ -2439,8 +2439,8 @@ func (s *RepositoriesService) IsPrivateReportingEnabled(ctx context.Context, own return false, nil, err } - privateReporting := new(checkPrivateReporting) - resp, err := s.client.Do(ctx, req, privateReporting) + var privateReporting checkPrivateReporting + resp, err := s.client.Do(ctx, req, &privateReporting) return privateReporting.Enabled, resp, err } diff --git a/github/repos_actions_access.go b/github/repos_actions_access.go index 2da1f01cc26..c69887b3549 100644 --- a/github/repos_actions_access.go +++ b/github/repos_actions_access.go @@ -33,8 +33,8 @@ func (s *RepositoriesService) GetActionsAccessLevel(ctx context.Context, owner, return nil, nil, err } - raal := new(RepositoryActionsAccessLevel) - resp, err := s.client.Do(ctx, req, raal) + var raal *RepositoryActionsAccessLevel + resp, err := s.client.Do(ctx, req, &raal) if err != nil { return nil, resp, err } diff --git a/github/repos_actions_access_test.go b/github/repos_actions_access_test.go index d79daa35282..715c091ac50 100644 --- a/github/repos_actions_access_test.go +++ b/github/repos_actions_access_test.go @@ -55,8 +55,8 @@ func TestRepositoriesService_EditActionsAccessLevel(t *testing.T) { input := &RepositoryActionsAccessLevel{AccessLevel: Ptr("organization")} mux.HandleFunc("/repos/o/r/actions/permissions/access", func(_ http.ResponseWriter, r *http.Request) { - v := new(RepositoryActionsAccessLevel) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *RepositoryActionsAccessLevel + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { diff --git a/github/repos_actions_allowed.go b/github/repos_actions_allowed.go index e9ebff1d328..45128db401d 100644 --- a/github/repos_actions_allowed.go +++ b/github/repos_actions_allowed.go @@ -22,8 +22,8 @@ func (s *RepositoriesService) GetActionsAllowed(ctx context.Context, org, repo s return nil, nil, err } - actionsAllowed := new(ActionsAllowed) - resp, err := s.client.Do(ctx, req, actionsAllowed) + var actionsAllowed *ActionsAllowed + resp, err := s.client.Do(ctx, req, &actionsAllowed) if err != nil { return nil, resp, err } @@ -43,8 +43,8 @@ func (s *RepositoriesService) EditActionsAllowed(ctx context.Context, org, repo return nil, nil, err } - p := new(ActionsAllowed) - resp, err := s.client.Do(ctx, req, p) + var p *ActionsAllowed + resp, err := s.client.Do(ctx, req, &p) if err != nil { return nil, resp, err } diff --git a/github/repos_actions_allowed_test.go b/github/repos_actions_allowed_test.go index a604ee15679..226ee1ee074 100644 --- a/github/repos_actions_allowed_test.go +++ b/github/repos_actions_allowed_test.go @@ -55,8 +55,8 @@ func TestRepositoriesService_UpdateActionsAllowed(t *testing.T) { input := &ActionsAllowed{GithubOwnedAllowed: Ptr(true), VerifiedAllowed: Ptr(false), PatternsAllowed: []string{"a/b"}} mux.HandleFunc("/repos/o/r/actions/permissions/selected-actions", func(w http.ResponseWriter, r *http.Request) { - v := new(ActionsAllowed) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *ActionsAllowed + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { diff --git a/github/repos_actions_permissions.go b/github/repos_actions_permissions.go index 7e56c3f3965..91374050dfe 100644 --- a/github/repos_actions_permissions.go +++ b/github/repos_actions_permissions.go @@ -45,8 +45,8 @@ func (s *RepositoriesService) GetActionsPermissions(ctx context.Context, owner, return nil, nil, err } - permissions := new(ActionsPermissionsRepository) - resp, err := s.client.Do(ctx, req, permissions) + var permissions *ActionsPermissionsRepository + resp, err := s.client.Do(ctx, req, &permissions) if err != nil { return nil, resp, err } @@ -66,8 +66,8 @@ func (s *RepositoriesService) UpdateActionsPermissions(ctx context.Context, owne return nil, nil, err } - permissions := new(ActionsPermissionsRepository) - resp, err := s.client.Do(ctx, req, permissions) + var permissions *ActionsPermissionsRepository + resp, err := s.client.Do(ctx, req, &permissions) if err != nil { return nil, resp, err } @@ -88,8 +88,8 @@ func (s *RepositoriesService) GetDefaultWorkflowPermissions(ctx context.Context, return nil, nil, err } - permissions := new(DefaultWorkflowPermissionRepository) - resp, err := s.client.Do(ctx, req, permissions) + var permissions *DefaultWorkflowPermissionRepository + resp, err := s.client.Do(ctx, req, &permissions) if err != nil { return nil, resp, err } @@ -109,8 +109,8 @@ func (s *RepositoriesService) UpdateDefaultWorkflowPermissions(ctx context.Conte return nil, nil, err } - p := new(DefaultWorkflowPermissionRepository) - resp, err := s.client.Do(ctx, req, p) + var p *DefaultWorkflowPermissionRepository + resp, err := s.client.Do(ctx, req, &p) if err != nil { return nil, resp, err } @@ -131,8 +131,8 @@ func (s *RepositoriesService) GetArtifactAndLogRetentionPeriod(ctx context.Conte return nil, nil, err } - arp := new(ArtifactPeriod) - resp, err := s.client.Do(ctx, req, arp) + var arp *ArtifactPeriod + resp, err := s.client.Do(ctx, req, &arp) if err != nil { return nil, resp, err } @@ -168,8 +168,8 @@ func (s *RepositoriesService) GetPrivateRepoForkPRWorkflowSettings(ctx context.C return nil, nil, err } - permissions := new(WorkflowsPermissions) - resp, err := s.client.Do(ctx, req, permissions) + var permissions *WorkflowsPermissions + resp, err := s.client.Do(ctx, req, &permissions) if err != nil { return nil, resp, err } @@ -205,8 +205,8 @@ func (s *ActionsService) GetForkPRContributorApprovalPermissions(ctx context.Con return nil, nil, err } - policy := new(ContributorApprovalPermissions) - resp, err := s.client.Do(ctx, req, policy) + var policy *ContributorApprovalPermissions + resp, err := s.client.Do(ctx, req, &policy) if err != nil { return nil, resp, err } diff --git a/github/repos_actions_permissions_test.go b/github/repos_actions_permissions_test.go index aad947f9dc7..cb39b0ed43c 100644 --- a/github/repos_actions_permissions_test.go +++ b/github/repos_actions_permissions_test.go @@ -55,8 +55,8 @@ func TestRepositoriesService_UpdateActionsPermissions(t *testing.T) { input := &ActionsPermissionsRepository{Enabled: Ptr(true), AllowedActions: Ptr("selected"), SHAPinningRequired: Ptr(true)} mux.HandleFunc("/repos/o/r/actions/permissions", func(w http.ResponseWriter, r *http.Request) { - v := new(ActionsPermissionsRepository) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *ActionsPermissionsRepository + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { @@ -154,8 +154,8 @@ func TestRepositoriesService_UpdateDefaultWorkflowPermissions(t *testing.T) { input := &DefaultWorkflowPermissionRepository{DefaultWorkflowPermissions: Ptr("read"), CanApprovePullRequestReviews: Ptr(true)} mux.HandleFunc("/repos/o/r/actions/permissions/workflow", func(w http.ResponseWriter, r *http.Request) { - v := new(DefaultWorkflowPermissionRepository) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *DefaultWorkflowPermissionRepository + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { @@ -236,8 +236,8 @@ func TestRepositoriesService_UpdateArtifactAndLogRetentionPeriod(t *testing.T) { input := &ArtifactPeriodOpt{Days: Ptr(90)} mux.HandleFunc("/repos/o/r/actions/permissions/artifact-and-log-retention", func(w http.ResponseWriter, r *http.Request) { - v := new(ArtifactPeriodOpt) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *ArtifactPeriodOpt + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { @@ -317,8 +317,8 @@ func TestRepositoriesService_UpdatePrivateRepoForkPRWorkflowSettings(t *testing. } mux.HandleFunc("/repos/o/r/actions/permissions/fork-pr-workflows-private-repos", func(w http.ResponseWriter, r *http.Request) { - v := new(WorkflowsPermissionsOpt) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *WorkflowsPermissionsOpt + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { @@ -389,8 +389,8 @@ func TestActionsService_UpdateForkPRContributorApprovalPermissions(t *testing.T) input := ContributorApprovalPermissions{ApprovalPolicy: "require_approval"} mux.HandleFunc("/repos/o/r/actions/permissions/fork-pr-contributor-approval", func(w http.ResponseWriter, r *http.Request) { - v := new(ContributorApprovalPermissions) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *ContributorApprovalPermissions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, &input) { diff --git a/github/repos_autolinks.go b/github/repos_autolinks.go index 2deb9f5a67a..bcba050a743 100644 --- a/github/repos_autolinks.go +++ b/github/repos_autolinks.go @@ -61,8 +61,8 @@ func (s *RepositoriesService) AddAutolink(ctx context.Context, owner, repo strin return nil, nil, err } - al := new(Autolink) - resp, err := s.client.Do(ctx, req, al) + var al *Autolink + resp, err := s.client.Do(ctx, req, &al) if err != nil { return nil, resp, err } diff --git a/github/repos_autolinks_test.go b/github/repos_autolinks_test.go index ba607f5986a..411063fef45 100644 --- a/github/repos_autolinks_test.go +++ b/github/repos_autolinks_test.go @@ -63,8 +63,8 @@ func TestRepositoriesService_AddAutolink(t *testing.T) { IsAlphanumeric: Ptr(true), } mux.HandleFunc("/repos/o/r/autolinks", func(w http.ResponseWriter, r *http.Request) { - v := new(AutolinkOptions) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *AutolinkOptions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, opt) { t.Errorf("Request body = %+v, want %+v", v, opt) diff --git a/github/repos_codeowners.go b/github/repos_codeowners.go index 93eeae09b17..6a9ada8c1a6 100644 --- a/github/repos_codeowners.go +++ b/github/repos_codeowners.go @@ -51,8 +51,8 @@ func (s *RepositoriesService) GetCodeownersErrors(ctx context.Context, owner, re return nil, nil, err } - codeownersErrors := &CodeownersErrors{} - resp, err := s.client.Do(ctx, req, codeownersErrors) + var codeownersErrors *CodeownersErrors + resp, err := s.client.Do(ctx, req, &codeownersErrors) if err != nil { return nil, resp, err } diff --git a/github/repos_collaborators.go b/github/repos_collaborators.go index a46f452942a..1df56feeefa 100644 --- a/github/repos_collaborators.go +++ b/github/repos_collaborators.go @@ -115,8 +115,8 @@ func (s *RepositoriesService) GetPermissionLevel(ctx context.Context, owner, rep return nil, nil, err } - rpl := new(RepositoryPermissionLevel) - resp, err := s.client.Do(ctx, req, rpl) + var rpl *RepositoryPermissionLevel + resp, err := s.client.Do(ctx, req, &rpl) if err != nil { return nil, resp, err } @@ -152,8 +152,8 @@ func (s *RepositoriesService) AddCollaborator(ctx context.Context, owner, repo, return nil, nil, err } - acr := new(CollaboratorInvitation) - resp, err := s.client.Do(ctx, req, acr) + var acr *CollaboratorInvitation + resp, err := s.client.Do(ctx, req, &acr) if err != nil { return nil, resp, err } diff --git a/github/repos_collaborators_test.go b/github/repos_collaborators_test.go index f93c415bcc8..12ef0b4d635 100644 --- a/github/repos_collaborators_test.go +++ b/github/repos_collaborators_test.go @@ -266,8 +266,8 @@ func TestRepositoriesService_AddCollaborator(t *testing.T) { opt := &RepositoryAddCollaboratorOptions{Permission: "admin"} mux.HandleFunc("/repos/o/r/collaborators/u", func(w http.ResponseWriter, r *http.Request) { - v := new(RepositoryAddCollaboratorOptions) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *RepositoryAddCollaboratorOptions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, opt) { t.Errorf("Request body = %+v, want %+v", v, opt) diff --git a/github/repos_comments.go b/github/repos_comments.go index 3d02a1999e8..4675936ba53 100644 --- a/github/repos_comments.go +++ b/github/repos_comments.go @@ -102,8 +102,8 @@ func (s *RepositoriesService) CreateComment(ctx context.Context, owner, repo, sh return nil, nil, err } - c := new(RepositoryComment) - resp, err := s.client.Do(ctx, req, c) + var c *RepositoryComment + resp, err := s.client.Do(ctx, req, &c) if err != nil { return nil, resp, err } @@ -125,8 +125,8 @@ func (s *RepositoriesService) GetComment(ctx context.Context, owner, repo string req.Header.Set("Accept", mediaTypeReactionsPreview) - c := new(RepositoryComment) - resp, err := s.client.Do(ctx, req, c) + var c *RepositoryComment + resp, err := s.client.Do(ctx, req, &c) if err != nil { return nil, resp, err } @@ -146,8 +146,8 @@ func (s *RepositoriesService) UpdateComment(ctx context.Context, owner, repo str return nil, nil, err } - c := new(RepositoryComment) - resp, err := s.client.Do(ctx, req, c) + var c *RepositoryComment + resp, err := s.client.Do(ctx, req, &c) if err != nil { return nil, resp, err } @@ -166,5 +166,6 @@ func (s *RepositoriesService) DeleteComment(ctx context.Context, owner, repo str if err != nil { return nil, err } + return s.client.Do(ctx, req, nil) } diff --git a/github/repos_comments_test.go b/github/repos_comments_test.go index 09e531c5c71..3328b00722c 100644 --- a/github/repos_comments_test.go +++ b/github/repos_comments_test.go @@ -115,8 +115,8 @@ func TestRepositoriesService_CreateComment(t *testing.T) { input := &RepositoryComment{Body: Ptr("b")} mux.HandleFunc("/repos/o/r/commits/s/comments", func(w http.ResponseWriter, r *http.Request) { - v := new(RepositoryComment) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *RepositoryComment + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { @@ -213,8 +213,8 @@ func TestRepositoriesService_UpdateComment(t *testing.T) { input := &RepositoryComment{Body: Ptr("b")} mux.HandleFunc("/repos/o/r/comments/1", func(w http.ResponseWriter, r *http.Request) { - v := new(RepositoryComment) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *RepositoryComment + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { diff --git a/github/repos_commits.go b/github/repos_commits.go index 36192cd3ed1..95ae695c159 100644 --- a/github/repos_commits.go +++ b/github/repos_commits.go @@ -165,8 +165,8 @@ func (s *RepositoriesService) GetCommit(ctx context.Context, owner, repo, sha st return nil, nil, err } - commit := new(RepositoryCommit) - resp, err := s.client.Do(ctx, req, commit) + var commit *RepositoryCommit + resp, err := s.client.Do(ctx, req, &commit) if err != nil { return nil, resp, err } @@ -252,8 +252,8 @@ func (s *RepositoriesService) CompareCommits(ctx context.Context, owner, repo, b return nil, nil, err } - comp := new(CommitsComparison) - resp, err := s.client.Do(ctx, req, comp) + var comp *CommitsComparison + resp, err := s.client.Do(ctx, req, &comp) if err != nil { return nil, resp, err } diff --git a/github/repos_community_health.go b/github/repos_community_health.go index 54d1b414ec9..1f5f0aa470c 100644 --- a/github/repos_community_health.go +++ b/github/repos_community_health.go @@ -53,8 +53,8 @@ func (s *RepositoriesService) GetCommunityHealthMetrics(ctx context.Context, own return nil, nil, err } - metrics := &CommunityHealthMetrics{} - resp, err := s.client.Do(ctx, req, metrics) + var metrics *CommunityHealthMetrics + resp, err := s.client.Do(ctx, req, &metrics) if err != nil { return nil, resp, err } diff --git a/github/repos_contents.go b/github/repos_contents.go index 73321e260d9..f03bfa78b3e 100644 --- a/github/repos_contents.go +++ b/github/repos_contents.go @@ -115,8 +115,8 @@ func (s *RepositoriesService) GetReadme(ctx context.Context, owner, repo string, return nil, nil, err } - readme := new(RepositoryContent) - resp, err := s.client.Do(ctx, req, readme) + var readme *RepositoryContent + resp, err := s.client.Do(ctx, req, &readme) if err != nil { return nil, resp, err } @@ -284,8 +284,8 @@ func (s *RepositoriesService) CreateFile(ctx context.Context, owner, repo, path return nil, nil, err } - createResponse := new(RepositoryContentResponse) - resp, err := s.client.Do(ctx, req, createResponse) + var createResponse *RepositoryContentResponse + resp, err := s.client.Do(ctx, req, &createResponse) if err != nil { return nil, resp, err } @@ -306,8 +306,8 @@ func (s *RepositoriesService) UpdateFile(ctx context.Context, owner, repo, path return nil, nil, err } - updateResponse := new(RepositoryContentResponse) - resp, err := s.client.Do(ctx, req, updateResponse) + var updateResponse *RepositoryContentResponse + resp, err := s.client.Do(ctx, req, &updateResponse) if err != nil { return nil, resp, err } @@ -328,8 +328,8 @@ func (s *RepositoriesService) DeleteFile(ctx context.Context, owner, repo, path return nil, nil, err } - deleteResponse := new(RepositoryContentResponse) - resp, err := s.client.Do(ctx, req, deleteResponse) + var deleteResponse *RepositoryContentResponse + resp, err := s.client.Do(ctx, req, &deleteResponse) if err != nil { return nil, resp, err } diff --git a/github/repos_deployment_protection_rules.go b/github/repos_deployment_protection_rules.go index 3454f1f28cf..9b33eb32755 100644 --- a/github/repos_deployment_protection_rules.go +++ b/github/repos_deployment_protection_rules.go @@ -78,8 +78,8 @@ func (s *RepositoriesService) CreateCustomDeploymentProtectionRule(ctx context.C return nil, nil, err } - protectionRule := new(CustomDeploymentProtectionRule) - resp, err := s.client.Do(ctx, req, protectionRule) + var protectionRule *CustomDeploymentProtectionRule + resp, err := s.client.Do(ctx, req, &protectionRule) if err != nil { return nil, resp, err } diff --git a/github/repos_deployment_protection_rules_test.go b/github/repos_deployment_protection_rules_test.go index 7abb4cb27ab..0ab490665b9 100644 --- a/github/repos_deployment_protection_rules_test.go +++ b/github/repos_deployment_protection_rules_test.go @@ -59,8 +59,8 @@ func TestRepositoriesService_CreateCustomDeploymentProtectionRule(t *testing.T) } mux.HandleFunc("/repos/o/r/environments/e/deployment_protection_rules", func(w http.ResponseWriter, r *http.Request) { - v := new(CustomDeploymentProtectionRuleRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *CustomDeploymentProtectionRuleRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") want := input diff --git a/github/repos_deployments.go b/github/repos_deployments.go index 637067491b0..6890b1ffe84 100644 --- a/github/repos_deployments.go +++ b/github/repos_deployments.go @@ -100,8 +100,8 @@ func (s *RepositoriesService) GetDeployment(ctx context.Context, owner, repo str return nil, nil, err } - deployment := new(Deployment) - resp, err := s.client.Do(ctx, req, deployment) + var deployment *Deployment + resp, err := s.client.Do(ctx, req, &deployment) if err != nil { return nil, resp, err } @@ -125,8 +125,8 @@ func (s *RepositoriesService) CreateDeployment(ctx context.Context, owner, repo acceptHeaders := []string{mediaTypeDeploymentStatusPreview, mediaTypeExpandDeploymentStatusPreview} req.Header.Set("Accept", strings.Join(acceptHeaders, ", ")) - d := new(Deployment) - resp, err := s.client.Do(ctx, req, d) + var d *Deployment + resp, err := s.client.Do(ctx, req, &d) if err != nil { return nil, resp, err } @@ -225,8 +225,8 @@ func (s *RepositoriesService) GetDeploymentStatus(ctx context.Context, owner, re acceptHeaders := []string{mediaTypeDeploymentStatusPreview, mediaTypeExpandDeploymentStatusPreview} req.Header.Set("Accept", strings.Join(acceptHeaders, ", ")) - d := new(DeploymentStatus) - resp, err := s.client.Do(ctx, req, d) + var d *DeploymentStatus + resp, err := s.client.Do(ctx, req, &d) if err != nil { return nil, resp, err } @@ -250,8 +250,8 @@ func (s *RepositoriesService) CreateDeploymentStatus(ctx context.Context, owner, acceptHeaders := []string{mediaTypeDeploymentStatusPreview, mediaTypeExpandDeploymentStatusPreview} req.Header.Set("Accept", strings.Join(acceptHeaders, ", ")) - d := new(DeploymentStatus) - resp, err := s.client.Do(ctx, req, d) + var d *DeploymentStatus + resp, err := s.client.Do(ctx, req, &d) if err != nil { return nil, resp, err } diff --git a/github/repos_deployments_test.go b/github/repos_deployments_test.go index aea37246819..b1294929350 100644 --- a/github/repos_deployments_test.go +++ b/github/repos_deployments_test.go @@ -95,8 +95,8 @@ func TestRepositoriesService_CreateDeployment(t *testing.T) { input := &DeploymentRequest{Ref: Ptr("1111"), Task: Ptr("deploy"), TransientEnvironment: Ptr(true)} mux.HandleFunc("/repos/o/r/deployments", func(w http.ResponseWriter, r *http.Request) { - v := new(DeploymentRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *DeploymentRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") wantAcceptHeaders := []string{mediaTypeDeploymentStatusPreview, mediaTypeExpandDeploymentStatusPreview} @@ -254,8 +254,8 @@ func TestRepositoriesService_CreateDeploymentStatus(t *testing.T) { input := &DeploymentStatusRequest{State: Ptr("inactive"), Description: Ptr("deploy"), AutoInactive: Ptr(false)} mux.HandleFunc("/repos/o/r/deployments/1/statuses", func(w http.ResponseWriter, r *http.Request) { - v := new(DeploymentStatusRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *DeploymentStatusRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") wantAcceptHeaders := []string{mediaTypeDeploymentStatusPreview, mediaTypeExpandDeploymentStatusPreview} diff --git a/github/repos_environments.go b/github/repos_environments.go index 7bc8394ac38..55d518cebdd 100644 --- a/github/repos_environments.go +++ b/github/repos_environments.go @@ -137,7 +137,6 @@ func (s *RepositoriesService) ListEnvironments(ctx context.Context, owner, repo //meta:operation GET /repos/{owner}/{repo}/environments/{environment_name} func (s *RepositoriesService) GetEnvironment(ctx context.Context, owner, repo, name string) (*Environment, *Response, error) { u := fmt.Sprintf("repos/%v/%v/environments/%v", owner, repo, name) - req, err := s.client.NewRequest("GET", u, nil) if err != nil { return nil, nil, err @@ -195,14 +194,13 @@ type createUpdateEnvironmentNoEnterprise struct { //meta:operation PUT /repos/{owner}/{repo}/environments/{environment_name} func (s *RepositoriesService) CreateUpdateEnvironment(ctx context.Context, owner, repo, name string, environment *CreateUpdateEnvironment) (*Environment, *Response, error) { u := fmt.Sprintf("repos/%v/%v/environments/%v", owner, repo, name) - req, err := s.client.NewRequest("PUT", u, environment) if err != nil { return nil, nil, err } - e := new(Environment) - resp, err := s.client.Do(ctx, req, e) + var e *Environment + resp, err := s.client.Do(ctx, req, &e) if err != nil { // The API returns 422 when the pricing plan doesn't support all the fields sent. // This path will be executed for Pro/Teams private repos. @@ -215,6 +213,7 @@ func (s *RepositoriesService) CreateUpdateEnvironment(ctx context.Context, owner } return nil, resp, err } + return e, resp, nil } @@ -228,11 +227,12 @@ func (s *RepositoriesService) createNewEnvNoEnterprise(ctx context.Context, u st return nil, nil, err } - e := new(Environment) - resp, err := s.client.Do(ctx, req, e) + var e *Environment + resp, err := s.client.Do(ctx, req, &e) if err != nil { return nil, resp, err } + return e, resp, nil } @@ -243,10 +243,10 @@ func (s *RepositoriesService) createNewEnvNoEnterprise(ctx context.Context, u st //meta:operation DELETE /repos/{owner}/{repo}/environments/{environment_name} func (s *RepositoriesService) DeleteEnvironment(ctx context.Context, owner, repo, name string) (*Response, error) { u := fmt.Sprintf("repos/%v/%v/environments/%v", owner, repo, name) - req, err := s.client.NewRequest("DELETE", u, nil) if err != nil { return nil, err } + return s.client.Do(ctx, req, nil) } diff --git a/github/repos_environments_test.go b/github/repos_environments_test.go index 3c55d3a04da..75642a2cc92 100644 --- a/github/repos_environments_test.go +++ b/github/repos_environments_test.go @@ -185,8 +185,8 @@ func TestRepositoriesService_CreateEnvironment(t *testing.T) { } mux.HandleFunc("/repos/o/r/environments/e", func(w http.ResponseWriter, r *http.Request) { - v := new(CreateUpdateEnvironment) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *CreateUpdateEnvironment + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") want := &CreateUpdateEnvironment{WaitTimer: Ptr(30), CanAdminsBypass: Ptr(true)} @@ -230,8 +230,8 @@ func TestRepositoriesService_CreateEnvironment_noEnterprise(t *testing.T) { callCount := 0 mux.HandleFunc("/repos/o/r/environments/e", func(w http.ResponseWriter, r *http.Request) { - v := new(CreateUpdateEnvironment) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *CreateUpdateEnvironment + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if callCount == 0 { @@ -270,8 +270,8 @@ func TestRepositoriesService_createNewEnvNoEnterprise(t *testing.T) { } mux.HandleFunc("/repos/o/r/environments/e", func(w http.ResponseWriter, r *http.Request) { - v := new(createUpdateEnvironmentNoEnterprise) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *createUpdateEnvironmentNoEnterprise + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") want := &createUpdateEnvironmentNoEnterprise{ diff --git a/github/repos_forks.go b/github/repos_forks.go index cffc87e9b0b..fe1f6284d30 100644 --- a/github/repos_forks.go +++ b/github/repos_forks.go @@ -79,20 +79,20 @@ func (s *RepositoriesService) CreateFork(ctx context.Context, owner, repo string return nil, nil, err } - fork := new(Repository) - resp, err := s.client.Do(ctx, req, fork) + var fork Repository + resp, err := s.client.Do(ctx, req, &fork) if err != nil { // Persist AcceptedError's metadata to the Repository object. var aerr *AcceptedError if errors.As(err, &aerr) { - if err := json.Unmarshal(aerr.Raw, fork); err != nil { - return fork, resp, err + if err := json.Unmarshal(aerr.Raw, &fork); err != nil { + return &fork, resp, err } - return fork, resp, err + return &fork, resp, err } return nil, resp, err } - return fork, resp, nil + return &fork, resp, nil } diff --git a/github/repos_hooks.go b/github/repos_hooks.go index bbadab80094..cd9ecc3f83a 100644 --- a/github/repos_hooks.go +++ b/github/repos_hooks.go @@ -102,8 +102,8 @@ func (s *RepositoriesService) CreateHook(ctx context.Context, owner, repo string return nil, nil, err } - h := new(Hook) - resp, err := s.client.Do(ctx, req, h) + var h *Hook + resp, err := s.client.Do(ctx, req, &h) if err != nil { return nil, resp, err } @@ -148,8 +148,9 @@ func (s *RepositoriesService) GetHook(ctx context.Context, owner, repo string, i if err != nil { return nil, nil, err } - h := new(Hook) - resp, err := s.client.Do(ctx, req, h) + + var h *Hook + resp, err := s.client.Do(ctx, req, &h) if err != nil { return nil, resp, err } @@ -168,8 +169,9 @@ func (s *RepositoriesService) EditHook(ctx context.Context, owner, repo string, if err != nil { return nil, nil, err } - h := new(Hook) - resp, err := s.client.Do(ctx, req, h) + + var h *Hook + resp, err := s.client.Do(ctx, req, &h) if err != nil { return nil, resp, err } @@ -188,6 +190,7 @@ func (s *RepositoriesService) DeleteHook(ctx context.Context, owner, repo string if err != nil { return nil, err } + return s.client.Do(ctx, req, nil) } diff --git a/github/repos_hooks_configuration.go b/github/repos_hooks_configuration.go index 69d1f4060ba..46fff057fc5 100644 --- a/github/repos_hooks_configuration.go +++ b/github/repos_hooks_configuration.go @@ -37,8 +37,8 @@ func (s *RepositoriesService) GetHookConfiguration(ctx context.Context, owner, r return nil, nil, err } - config := new(HookConfig) - resp, err := s.client.Do(ctx, req, config) + var config *HookConfig + resp, err := s.client.Do(ctx, req, &config) if err != nil { return nil, resp, err } @@ -58,8 +58,8 @@ func (s *RepositoriesService) EditHookConfiguration(ctx context.Context, owner, return nil, nil, err } - c := new(HookConfig) - resp, err := s.client.Do(ctx, req, c) + var c *HookConfig + resp, err := s.client.Do(ctx, req, &c) if err != nil { return nil, resp, err } diff --git a/github/repos_hooks_configuration_test.go b/github/repos_hooks_configuration_test.go index 10eb3eaf497..620265a6d05 100644 --- a/github/repos_hooks_configuration_test.go +++ b/github/repos_hooks_configuration_test.go @@ -70,8 +70,8 @@ func TestRepositoriesService_EditHookConfiguration(t *testing.T) { input := &HookConfig{} mux.HandleFunc("/repos/o/r/hooks/1/config", func(w http.ResponseWriter, r *http.Request) { - v := new(HookConfig) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *HookConfig + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { diff --git a/github/repos_hooks_deliveries.go b/github/repos_hooks_deliveries.go index 526d82c6f7c..3db13755acf 100644 --- a/github/repos_hooks_deliveries.go +++ b/github/repos_hooks_deliveries.go @@ -120,8 +120,8 @@ func (s *RepositoriesService) GetHookDelivery(ctx context.Context, owner, repo s return nil, nil, err } - h := new(HookDelivery) - resp, err := s.client.Do(ctx, req, h) + var h *HookDelivery + resp, err := s.client.Do(ctx, req, &h) if err != nil { return nil, resp, err } @@ -141,8 +141,8 @@ func (s *RepositoriesService) RedeliverHookDelivery(ctx context.Context, owner, return nil, nil, err } - h := new(HookDelivery) - resp, err := s.client.Do(ctx, req, h) + var h *HookDelivery + resp, err := s.client.Do(ctx, req, &h) if err != nil { return nil, resp, err } diff --git a/github/repos_hooks_test.go b/github/repos_hooks_test.go index ca8603a8889..2e9ea17978f 100644 --- a/github/repos_hooks_test.go +++ b/github/repos_hooks_test.go @@ -21,8 +21,8 @@ func TestRepositoriesService_CreateHook(t *testing.T) { input := &Hook{CreatedAt: &Timestamp{referenceTime}} mux.HandleFunc("/repos/o/r/hooks", func(w http.ResponseWriter, r *http.Request) { - v := new(createHookRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *createHookRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") want := &createHookRequest{Name: "web"} @@ -171,8 +171,8 @@ func TestRepositoriesService_EditHook(t *testing.T) { input := &Hook{} mux.HandleFunc("/repos/o/r/hooks/1", func(w http.ResponseWriter, r *http.Request) { - v := new(Hook) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *Hook + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { diff --git a/github/repos_invitations.go b/github/repos_invitations.go index 98fe01d1c9a..0a6d5a9917f 100644 --- a/github/repos_invitations.go +++ b/github/repos_invitations.go @@ -86,8 +86,8 @@ func (s *RepositoriesService) UpdateInvitation(ctx context.Context, owner, repo return nil, nil, err } - invite := &RepositoryInvitation{} - resp, err := s.client.Do(ctx, req, invite) + var invite *RepositoryInvitation + resp, err := s.client.Do(ctx, req, &invite) if err != nil { return nil, resp, err } diff --git a/github/repos_keys.go b/github/repos_keys.go index 0d050c8030b..b48018094c4 100644 --- a/github/repos_keys.go +++ b/github/repos_keys.go @@ -51,8 +51,8 @@ func (s *RepositoriesService) GetKey(ctx context.Context, owner, repo string, id return nil, nil, err } - key := new(Key) - resp, err := s.client.Do(ctx, req, key) + var key *Key + resp, err := s.client.Do(ctx, req, &key) if err != nil { return nil, resp, err } @@ -73,8 +73,8 @@ func (s *RepositoriesService) CreateKey(ctx context.Context, owner, repo string, return nil, nil, err } - k := new(Key) - resp, err := s.client.Do(ctx, req, k) + var k *Key + resp, err := s.client.Do(ctx, req, &k) if err != nil { return nil, resp, err } diff --git a/github/repos_keys_test.go b/github/repos_keys_test.go index 899a1212bfe..5f7bfd265d2 100644 --- a/github/repos_keys_test.go +++ b/github/repos_keys_test.go @@ -111,8 +111,8 @@ func TestRepositoriesService_CreateKey(t *testing.T) { input := &Key{Key: Ptr("k"), Title: Ptr("t")} mux.HandleFunc("/repos/o/r/keys", func(w http.ResponseWriter, r *http.Request) { - v := new(Key) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *Key + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { diff --git a/github/repos_merging.go b/github/repos_merging.go index b26e5da1af6..caf73cacad3 100644 --- a/github/repos_merging.go +++ b/github/repos_merging.go @@ -44,8 +44,8 @@ func (s *RepositoriesService) Merge(ctx context.Context, owner, repo string, req return nil, nil, err } - commit := new(RepositoryCommit) - resp, err := s.client.Do(ctx, req, commit) + var commit *RepositoryCommit + resp, err := s.client.Do(ctx, req, &commit) if err != nil { return nil, resp, err } @@ -66,8 +66,8 @@ func (s *RepositoriesService) MergeUpstream(ctx context.Context, owner, repo str return nil, nil, err } - result := new(RepoMergeUpstreamResult) - resp, err := s.client.Do(ctx, req, result) + var result *RepoMergeUpstreamResult + resp, err := s.client.Do(ctx, req, &result) if err != nil { return nil, resp, err } diff --git a/github/repos_merging_test.go b/github/repos_merging_test.go index 006c988fb22..f54ef4d087b 100644 --- a/github/repos_merging_test.go +++ b/github/repos_merging_test.go @@ -25,8 +25,8 @@ func TestRepositoriesService_Merge(t *testing.T) { } mux.HandleFunc("/repos/o/r/merges", func(w http.ResponseWriter, r *http.Request) { - v := new(RepositoryMergeRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *RepositoryMergeRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { @@ -90,8 +90,8 @@ func TestRepositoriesService_MergeUpstream(t *testing.T) { } mux.HandleFunc("/repos/o/r/merge-upstream", func(w http.ResponseWriter, r *http.Request) { - v := new(RepoMergeUpstreamRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *RepoMergeUpstreamRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { diff --git a/github/repos_pages.go b/github/repos_pages.go index 92110f59831..c3969a08fec 100644 --- a/github/repos_pages.go +++ b/github/repos_pages.go @@ -126,8 +126,8 @@ func (s *RepositoriesService) EnablePages(ctx context.Context, owner, repo strin req.Header.Set("Accept", mediaTypeEnablePagesAPIPreview) - enable := new(Pages) - resp, err := s.client.Do(ctx, req, enable) + var enable *Pages + resp, err := s.client.Do(ctx, req, &enable) if err != nil { return nil, resp, err } @@ -236,8 +236,8 @@ func (s *RepositoriesService) GetPagesInfo(ctx context.Context, owner, repo stri return nil, nil, err } - site := new(Pages) - resp, err := s.client.Do(ctx, req, site) + var site *Pages + resp, err := s.client.Do(ctx, req, &site) if err != nil { return nil, resp, err } @@ -283,8 +283,8 @@ func (s *RepositoriesService) GetLatestPagesBuild(ctx context.Context, owner, re return nil, nil, err } - build := new(PagesBuild) - resp, err := s.client.Do(ctx, req, build) + var build *PagesBuild + resp, err := s.client.Do(ctx, req, &build) if err != nil { return nil, resp, err } @@ -304,8 +304,8 @@ func (s *RepositoriesService) GetPageBuild(ctx context.Context, owner, repo stri return nil, nil, err } - build := new(PagesBuild) - resp, err := s.client.Do(ctx, req, build) + var build *PagesBuild + resp, err := s.client.Do(ctx, req, &build) if err != nil { return nil, resp, err } @@ -325,8 +325,8 @@ func (s *RepositoriesService) RequestPageBuild(ctx context.Context, owner, repo return nil, nil, err } - build := new(PagesBuild) - resp, err := s.client.Do(ctx, req, build) + var build *PagesBuild + resp, err := s.client.Do(ctx, req, &build) if err != nil { return nil, resp, err } @@ -346,8 +346,8 @@ func (s *RepositoriesService) GetPageHealthCheck(ctx context.Context, owner, rep return nil, nil, err } - healthCheckResponse := new(PagesHealthCheckResponse) - resp, err := s.client.Do(ctx, req, healthCheckResponse) + var healthCheckResponse *PagesHealthCheckResponse + resp, err := s.client.Do(ctx, req, &healthCheckResponse) if err != nil { return nil, resp, err } diff --git a/github/repos_pages_test.go b/github/repos_pages_test.go index d0942fdd6cd..0b1d9a486dd 100644 --- a/github/repos_pages_test.go +++ b/github/repos_pages_test.go @@ -30,8 +30,8 @@ func TestRepositoriesService_EnablePagesLegacy(t *testing.T) { } mux.HandleFunc("/repos/o/r/pages", func(w http.ResponseWriter, r *http.Request) { - v := new(createPagesRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *createPagesRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") testHeader(t, r, "Accept", mediaTypeEnablePagesAPIPreview) @@ -84,8 +84,8 @@ func TestRepositoriesService_EnablePagesWorkflow(t *testing.T) { } mux.HandleFunc("/repos/o/r/pages", func(w http.ResponseWriter, r *http.Request) { - v := new(createPagesRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *createPagesRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") testHeader(t, r, "Accept", mediaTypeEnablePagesAPIPreview) @@ -135,8 +135,8 @@ func TestRepositoriesService_UpdatePagesLegacy(t *testing.T) { } mux.HandleFunc("/repos/o/r/pages", func(w http.ResponseWriter, r *http.Request) { - v := new(PagesUpdate) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *PagesUpdate + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") want := &PagesUpdate{CNAME: Ptr("www.example.com"), BuildType: Ptr("legacy"), Source: &PagesSource{Branch: Ptr("gh-pages")}} @@ -174,8 +174,8 @@ func TestRepositoriesService_UpdatePagesWorkflow(t *testing.T) { } mux.HandleFunc("/repos/o/r/pages", func(w http.ResponseWriter, r *http.Request) { - v := new(PagesUpdate) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *PagesUpdate + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") want := &PagesUpdate{CNAME: Ptr("www.example.com"), BuildType: Ptr("workflow")} @@ -212,8 +212,8 @@ func TestRepositoriesService_UpdatePagesGHES(t *testing.T) { } mux.HandleFunc("/repos/o/r/pages", func(w http.ResponseWriter, r *http.Request) { - v := new(PagesUpdate) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *PagesUpdate + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") want := &PagesUpdate{BuildType: Ptr("workflow")} diff --git a/github/repos_prereceive_hooks.go b/github/repos_prereceive_hooks.go index eec1360c896..3025c0f4bc7 100644 --- a/github/repos_prereceive_hooks.go +++ b/github/repos_prereceive_hooks.go @@ -64,8 +64,8 @@ func (s *RepositoriesService) GetPreReceiveHook(ctx context.Context, owner, repo req.Header.Set("Accept", mediaTypePreReceiveHooksPreview) - h := new(PreReceiveHook) - resp, err := s.client.Do(ctx, req, h) + var h *PreReceiveHook + resp, err := s.client.Do(ctx, req, &h) if err != nil { return nil, resp, err } @@ -87,8 +87,8 @@ func (s *RepositoriesService) UpdatePreReceiveHook(ctx context.Context, owner, r req.Header.Set("Accept", mediaTypePreReceiveHooksPreview) - h := new(PreReceiveHook) - resp, err := s.client.Do(ctx, req, h) + var h *PreReceiveHook + resp, err := s.client.Do(ctx, req, &h) if err != nil { return nil, resp, err } diff --git a/github/repos_prereceive_hooks_test.go b/github/repos_prereceive_hooks_test.go index 707553e574b..daac60beeca 100644 --- a/github/repos_prereceive_hooks_test.go +++ b/github/repos_prereceive_hooks_test.go @@ -114,8 +114,8 @@ func TestRepositoriesService_UpdatePreReceiveHook(t *testing.T) { input := &PreReceiveHook{} mux.HandleFunc("/repos/o/r/pre-receive-hooks/1", func(w http.ResponseWriter, r *http.Request) { - v := new(PreReceiveHook) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *PreReceiveHook + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { diff --git a/github/repos_releases.go b/github/repos_releases.go index ba35d804128..f7a449b0e62 100644 --- a/github/repos_releases.go +++ b/github/repos_releases.go @@ -155,8 +155,8 @@ func (s *RepositoriesService) GenerateReleaseNotes(ctx context.Context, owner, r return nil, nil, err } - r := new(RepositoryReleaseNotes) - resp, err := s.client.Do(ctx, req, r) + var r *RepositoryReleaseNotes + resp, err := s.client.Do(ctx, req, &r) if err != nil { return nil, resp, err } @@ -170,11 +170,12 @@ func (s *RepositoriesService) getSingleRelease(ctx context.Context, url string) return nil, nil, err } - release := new(RepositoryRelease) - resp, err := s.client.Do(ctx, req, release) + var release *RepositoryRelease + resp, err := s.client.Do(ctx, req, &release) if err != nil { return nil, resp, err } + return release, resp, nil } @@ -228,11 +229,12 @@ func (s *RepositoriesService) CreateRelease(ctx context.Context, owner, repo str return nil, nil, err } - r := new(RepositoryRelease) - resp, err := s.client.Do(ctx, req, r) + var r *RepositoryRelease + resp, err := s.client.Do(ctx, req, &r) if err != nil { return nil, resp, err } + return r, resp, nil } @@ -267,11 +269,12 @@ func (s *RepositoriesService) EditRelease(ctx context.Context, owner, repo strin return nil, nil, err } - r := new(RepositoryRelease) - resp, err := s.client.Do(ctx, req, r) + var r *RepositoryRelease + resp, err := s.client.Do(ctx, req, &r) if err != nil { return nil, resp, err } + return r, resp, nil } @@ -328,11 +331,12 @@ func (s *RepositoriesService) GetReleaseAsset(ctx context.Context, owner, repo s return nil, nil, err } - asset := new(ReleaseAsset) - resp, err := s.client.Do(ctx, req, asset) + var asset *ReleaseAsset + resp, err := s.client.Do(ctx, req, &asset) if err != nil { return nil, resp, err } + return asset, resp, nil } @@ -424,11 +428,12 @@ func (s *RepositoriesService) EditReleaseAsset(ctx context.Context, owner, repo return nil, nil, err } - asset := new(ReleaseAsset) - resp, err := s.client.Do(ctx, req, asset) + var asset *ReleaseAsset + resp, err := s.client.Do(ctx, req, &asset) if err != nil { return nil, resp, err } + return asset, resp, nil } @@ -482,11 +487,12 @@ func (s *RepositoriesService) UploadReleaseAsset(ctx context.Context, owner, rep return nil, nil, err } - asset := new(ReleaseAsset) - resp, err := s.client.Do(ctx, req, asset) + var asset *ReleaseAsset + resp, err := s.client.Do(ctx, req, &asset) if err != nil { return nil, resp, err } + return asset, resp, nil } @@ -555,10 +561,11 @@ func (s *RepositoriesService) UploadReleaseAssetFromRelease( return nil, nil, err } - asset := new(ReleaseAsset) - resp, err := s.client.Do(ctx, req, asset) + var asset *ReleaseAsset + resp, err := s.client.Do(ctx, req, &asset) if err != nil { return nil, resp, err } + return asset, resp, nil } diff --git a/github/repos_releases_test.go b/github/repos_releases_test.go index 92dc045ebb1..18fd41bab9e 100644 --- a/github/repos_releases_test.go +++ b/github/repos_releases_test.go @@ -224,8 +224,8 @@ func TestRepositoriesService_CreateRelease(t *testing.T) { } mux.HandleFunc("/repos/o/r/releases", func(w http.ResponseWriter, r *http.Request) { - v := new(repositoryReleaseRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *repositoryReleaseRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") want := &repositoryReleaseRequest{ @@ -294,8 +294,8 @@ func TestRepositoriesService_EditRelease(t *testing.T) { } mux.HandleFunc("/repos/o/r/releases/1", func(w http.ResponseWriter, r *http.Request) { - v := new(repositoryReleaseRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *repositoryReleaseRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") want := &repositoryReleaseRequest{ @@ -626,8 +626,8 @@ func TestRepositoriesService_EditReleaseAsset(t *testing.T) { input := &ReleaseAsset{Name: Ptr("n")} mux.HandleFunc("/repos/o/r/releases/assets/1", func(w http.ResponseWriter, r *http.Request) { - v := new(ReleaseAsset) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *ReleaseAsset + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { diff --git a/github/repos_stats.go b/github/repos_stats.go index b05bae6daef..0e8a6a7f101 100644 --- a/github/repos_stats.go +++ b/github/repos_stats.go @@ -183,8 +183,8 @@ func (s *RepositoriesService) ListParticipation(ctx context.Context, owner, repo return nil, nil, err } - participation := new(RepositoryParticipation) - resp, err := s.client.Do(ctx, req, participation) + var participation *RepositoryParticipation + resp, err := s.client.Do(ctx, req, &participation) if err != nil { return nil, resp, err } diff --git a/github/repos_statuses.go b/github/repos_statuses.go index 547cc1f12cf..aaebf4b8b27 100644 --- a/github/repos_statuses.go +++ b/github/repos_statuses.go @@ -82,8 +82,8 @@ func (s *RepositoriesService) CreateStatus(ctx context.Context, owner, repo, ref return nil, nil, err } - repoStatus := new(RepoStatus) - resp, err := s.client.Do(ctx, req, repoStatus) + var repoStatus *RepoStatus + resp, err := s.client.Do(ctx, req, &repoStatus) if err != nil { return nil, resp, err } @@ -128,8 +128,8 @@ func (s *RepositoriesService) GetCombinedStatus(ctx context.Context, owner, repo return nil, nil, err } - status := new(CombinedStatus) - resp, err := s.client.Do(ctx, req, status) + var status *CombinedStatus + resp, err := s.client.Do(ctx, req, &status) if err != nil { return nil, resp, err } diff --git a/github/repos_statuses_test.go b/github/repos_statuses_test.go index ec9b94d9640..33d960d1c22 100644 --- a/github/repos_statuses_test.go +++ b/github/repos_statuses_test.go @@ -67,8 +67,8 @@ func TestRepositoriesService_CreateStatus(t *testing.T) { input := RepoStatus{State: Ptr("s"), TargetURL: Ptr("t"), Description: Ptr("d")} mux.HandleFunc("/repos/o/r/statuses/r", func(w http.ResponseWriter, r *http.Request) { - v := new(RepoStatus) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *RepoStatus + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, &input) { diff --git a/github/repos_tags.go b/github/repos_tags.go index 07f9e3aa934..1cbdde60424 100644 --- a/github/repos_tags.go +++ b/github/repos_tags.go @@ -61,8 +61,8 @@ func (s *RepositoriesService) CreateTagProtection(ctx context.Context, owner, re return nil, nil, err } - tagProtection := new(TagProtection) - resp, err := s.client.Do(ctx, req, tagProtection) + var tagProtection *TagProtection + resp, err := s.client.Do(ctx, req, &tagProtection) if err != nil { return nil, resp, err } diff --git a/github/repos_tags_test.go b/github/repos_tags_test.go index ea1e9a2bb7f..f9bd618ff1c 100644 --- a/github/repos_tags_test.go +++ b/github/repos_tags_test.go @@ -66,8 +66,8 @@ func TestRepositoriesService_CreateTagProtection(t *testing.T) { pattern := "tag*" mux.HandleFunc("/repos/o/r/tags/protection", func(w http.ResponseWriter, r *http.Request) { - v := new(tagProtectionRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *tagProtectionRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") want := &tagProtectionRequest{Pattern: "tag*"} diff --git a/github/repos_test.go b/github/repos_test.go index 722317a64be..495bdc83f74 100644 --- a/github/repos_test.go +++ b/github/repos_test.go @@ -229,8 +229,8 @@ func TestRepositoriesService_Create_user(t *testing.T) { wantAcceptHeaders := []string{mediaTypeRepositoryTemplatePreview, mediaTypeRepositoryVisibilityPreview} mux.HandleFunc("/user/repos", func(w http.ResponseWriter, r *http.Request) { - v := new(createRepoRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *createRepoRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") testHeader(t, r, "Accept", strings.Join(wantAcceptHeaders, ", ")) @@ -283,8 +283,8 @@ func TestRepositoriesService_Create_org(t *testing.T) { wantAcceptHeaders := []string{mediaTypeRepositoryTemplatePreview, mediaTypeRepositoryVisibilityPreview} mux.HandleFunc("/orgs/o/repos", func(w http.ResponseWriter, r *http.Request) { - v := new(createRepoRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *createRepoRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") testHeader(t, r, "Accept", strings.Join(wantAcceptHeaders, ", ")) @@ -323,8 +323,8 @@ func TestRepositoriesService_Create_withCustomProperties(t *testing.T) { wantAcceptHeaders := []string{mediaTypeRepositoryTemplatePreview, mediaTypeRepositoryVisibilityPreview} mux.HandleFunc("/orgs/o/repos", func(w http.ResponseWriter, r *http.Request) { - v := new(createRepoRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *createRepoRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") testHeader(t, r, "Accept", strings.Join(wantAcceptHeaders, ", ")) @@ -364,8 +364,8 @@ func TestRepositoriesService_CreateFromTemplate(t *testing.T) { } mux.HandleFunc("/repos/to/tr/generate", func(w http.ResponseWriter, r *http.Request) { - v := new(TemplateRepoRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *TemplateRepoRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") testHeader(t, r, "Accept", mediaTypeRepositoryTemplatePreview) @@ -528,8 +528,8 @@ func TestRepositoriesService_Edit(t *testing.T) { wantAcceptHeaders := []string{mediaTypeRepositoryTemplatePreview, mediaTypeRepositoryVisibilityPreview} mux.HandleFunc("/repos/o/r", func(w http.ResponseWriter, r *http.Request) { - v := new(Repository) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *Repository + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") testHeader(t, r, "Accept", strings.Join(wantAcceptHeaders, ", ")) @@ -1148,8 +1148,8 @@ func TestRepositoriesService_RenameBranch(t *testing.T) { renameBranchReq := "nn" mux.HandleFunc(test.urlPath, func(w http.ResponseWriter, r *http.Request) { - v := new(renameBranchRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *renameBranchRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") want := &renameBranchRequest{NewName: renameBranchReq} @@ -1512,8 +1512,8 @@ func TestRepositoriesService_UpdateBranchProtection_Contexts(t *testing.T) { } mux.HandleFunc(test.urlPath, func(w http.ResponseWriter, r *http.Request) { - v := new(ProtectionRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *ProtectionRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { @@ -1700,8 +1700,8 @@ func TestRepositoriesService_UpdateBranchProtection_EmptyContexts(t *testing.T) } mux.HandleFunc(test.urlPath, func(w http.ResponseWriter, r *http.Request) { - v := new(ProtectionRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *ProtectionRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { @@ -1879,8 +1879,8 @@ func TestRepositoriesService_UpdateBranchProtection_Checks(t *testing.T) { } mux.HandleFunc(test.urlPath, func(w http.ResponseWriter, r *http.Request) { - v := new(ProtectionRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *ProtectionRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { @@ -2032,8 +2032,8 @@ func TestRepositoriesService_UpdateBranchProtection_EmptyChecks(t *testing.T) { } mux.HandleFunc(test.urlPath, func(w http.ResponseWriter, r *http.Request) { - v := new(ProtectionRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *ProtectionRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { @@ -2174,8 +2174,8 @@ func TestRepositoriesService_UpdateBranchProtection_StrictNoChecks(t *testing.T) } mux.HandleFunc(test.urlPath, func(w http.ResponseWriter, r *http.Request) { - v := new(ProtectionRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *ProtectionRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { @@ -2298,8 +2298,8 @@ func TestRepositoriesService_UpdateBranchProtection_RequireLastPushApproval(t *t } mux.HandleFunc(test.urlPath, func(w http.ResponseWriter, r *http.Request) { - v := new(ProtectionRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *ProtectionRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { @@ -2564,8 +2564,8 @@ func TestRepositoriesService_UpdateRequiredStatusChecks_Contexts(t *testing.T) { } mux.HandleFunc(test.urlPath, func(w http.ResponseWriter, r *http.Request) { - v := new(RequiredStatusChecksRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *RequiredStatusChecksRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { @@ -2655,8 +2655,8 @@ func TestRepositoriesService_UpdateRequiredStatusChecks_Checks(t *testing.T) { } mux.HandleFunc(test.urlPath, func(w http.ResponseWriter, r *http.Request) { - v := new(RequiredStatusChecksRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *RequiredStatusChecksRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { @@ -2937,8 +2937,8 @@ func TestRepositoriesService_UpdatePullRequestReviewEnforcement(t *testing.T) { } mux.HandleFunc(test.urlPath, func(w http.ResponseWriter, r *http.Request) { - v := new(PullRequestReviewsEnforcementUpdate) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *PullRequestReviewsEnforcementUpdate + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { diff --git a/github/repos_traffic.go b/github/repos_traffic.go index ae2f1a86bd7..dddd1b97eb4 100644 --- a/github/repos_traffic.go +++ b/github/repos_traffic.go @@ -113,7 +113,7 @@ func (s *RepositoriesService) ListTrafficViews(ctx context.Context, owner, repo return nil, nil, err } - trafficViews := new(TrafficViews) + var trafficViews *TrafficViews resp, err := s.client.Do(ctx, req, &trafficViews) if err != nil { return nil, resp, err @@ -139,7 +139,7 @@ func (s *RepositoriesService) ListTrafficClones(ctx context.Context, owner, repo return nil, nil, err } - trafficClones := new(TrafficClones) + var trafficClones *TrafficClones resp, err := s.client.Do(ctx, req, &trafficClones) if err != nil { return nil, resp, err diff --git a/github/scim.go b/github/scim.go index 8e89796a489..96c05e81d62 100644 --- a/github/scim.go +++ b/github/scim.go @@ -110,8 +110,8 @@ func (s *SCIMService) ListSCIMProvisionedIdentities(ctx context.Context, org str return nil, nil, err } - identities := new(SCIMProvisionedIdentities) - resp, err := s.client.Do(ctx, req, identities) + var identities *SCIMProvisionedIdentities + resp, err := s.client.Do(ctx, req, &identities) if err != nil { return nil, resp, err } @@ -132,8 +132,8 @@ func (s *SCIMService) ProvisionAndInviteSCIMUser(ctx context.Context, org string return nil, nil, err } - user := new(SCIMUserAttributes) - resp, err := s.client.Do(ctx, req, user) + var user *SCIMUserAttributes + resp, err := s.client.Do(ctx, req, &user) if err != nil { return nil, resp, err } @@ -153,7 +153,7 @@ func (s *SCIMService) GetSCIMProvisioningInfoForUser(ctx context.Context, org, s return nil, nil, err } - user := new(SCIMUserAttributes) + var user *SCIMUserAttributes resp, err := s.client.Do(ctx, req, &user) if err != nil { return nil, resp, err diff --git a/github/search.go b/github/search.go index eb8ea223649..59a91bddaa1 100644 --- a/github/search.go +++ b/github/search.go @@ -79,8 +79,8 @@ type RepositoriesSearchResult struct { // //meta:operation GET /search/repositories func (s *SearchService) Repositories(ctx context.Context, query string, opts *SearchOptions) (*RepositoriesSearchResult, *Response, error) { - result := new(RepositoriesSearchResult) - resp, err := s.search(ctx, "repositories", &searchParameters{Query: query}, opts, result) + var result *RepositoriesSearchResult + resp, err := s.search(ctx, "repositories", &searchParameters{Query: query}, opts, &result) if err != nil { return nil, resp, err } @@ -117,8 +117,8 @@ type TopicResult struct { // //meta:operation GET /search/topics func (s *SearchService) Topics(ctx context.Context, query string, opts *SearchOptions) (*TopicsSearchResult, *Response, error) { - result := new(TopicsSearchResult) - resp, err := s.search(ctx, "topics", &searchParameters{Query: query}, opts, result) + var result *TopicsSearchResult + resp, err := s.search(ctx, "topics", &searchParameters{Query: query}, opts, &result) if err != nil { return nil, resp, err } @@ -154,8 +154,8 @@ type CommitResult struct { // //meta:operation GET /search/commits func (s *SearchService) Commits(ctx context.Context, query string, opts *SearchOptions) (*CommitsSearchResult, *Response, error) { - result := new(CommitsSearchResult) - resp, err := s.search(ctx, "commits", &searchParameters{Query: query}, opts, result) + var result *CommitsSearchResult + resp, err := s.search(ctx, "commits", &searchParameters{Query: query}, opts, &result) if err != nil { return nil, resp, err } @@ -176,8 +176,8 @@ type IssuesSearchResult struct { // //meta:operation GET /search/issues func (s *SearchService) Issues(ctx context.Context, query string, opts *SearchOptions) (*IssuesSearchResult, *Response, error) { - result := new(IssuesSearchResult) - resp, err := s.search(ctx, "issues", &searchParameters{Query: query}, opts, result) + var result *IssuesSearchResult + resp, err := s.search(ctx, "issues", &searchParameters{Query: query}, opts, &result) if err != nil { return nil, resp, err } @@ -198,8 +198,8 @@ type UsersSearchResult struct { // //meta:operation GET /search/users func (s *SearchService) Users(ctx context.Context, query string, opts *SearchOptions) (*UsersSearchResult, *Response, error) { - result := new(UsersSearchResult) - resp, err := s.search(ctx, "users", &searchParameters{Query: query}, opts, result) + var result *UsersSearchResult + resp, err := s.search(ctx, "users", &searchParameters{Query: query}, opts, &result) if err != nil { return nil, resp, err } @@ -253,8 +253,8 @@ func (c CodeResult) String() string { // //meta:operation GET /search/code func (s *SearchService) Code(ctx context.Context, query string, opts *SearchOptions) (*CodeSearchResult, *Response, error) { - result := new(CodeSearchResult) - resp, err := s.search(ctx, "code", &searchParameters{Query: query}, opts, result) + var result *CodeSearchResult + resp, err := s.search(ctx, "code", &searchParameters{Query: query}, opts, &result) if err != nil { return nil, resp, err } @@ -290,8 +290,8 @@ func (l LabelResult) String() string { // //meta:operation GET /search/labels func (s *SearchService) Labels(ctx context.Context, repoID int64, query string, opts *SearchOptions) (*LabelsSearchResult, *Response, error) { - result := new(LabelsSearchResult) - resp, err := s.search(ctx, "labels", &searchParameters{RepositoryID: &repoID, Query: query}, opts, result) + var result *LabelsSearchResult + resp, err := s.search(ctx, "labels", &searchParameters{RepositoryID: &repoID, Query: query}, opts, &result) if err != nil { return nil, resp, err } diff --git a/github/secret_scanning_test.go b/github/secret_scanning_test.go index 97ee161f001..c2c672f09a8 100644 --- a/github/secret_scanning_test.go +++ b/github/secret_scanning_test.go @@ -355,8 +355,8 @@ func TestSecretScanningService_UpdateAlert(t *testing.T) { mux.HandleFunc("/repos/o/r/secret-scanning/alerts/1", func(w http.ResponseWriter, r *http.Request) { testMethod(t, r, "PATCH") - v := new(SecretScanningAlertUpdateOptions) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *SecretScanningAlertUpdateOptions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) want := &SecretScanningAlertUpdateOptions{State: "resolved", Resolution: Ptr("used_in_tests")} diff --git a/github/security_advisories.go b/github/security_advisories.go index 5c7b8fd4e3c..43d8b9a03c4 100644 --- a/github/security_advisories.go +++ b/github/security_advisories.go @@ -168,21 +168,21 @@ func (s *SecurityAdvisoriesService) CreateTemporaryPrivateFork(ctx context.Conte return nil, nil, err } - fork := new(Repository) - resp, err := s.client.Do(ctx, req, fork) + var fork Repository + resp, err := s.client.Do(ctx, req, &fork) if err != nil { var aerr *AcceptedError if errors.As(err, &aerr) { - if err := json.Unmarshal(aerr.Raw, fork); err != nil { - return fork, resp, err + if err := json.Unmarshal(aerr.Raw, &fork); err != nil { + return &fork, resp, err } - return fork, resp, err + return &fork, resp, err } return nil, resp, err } - return fork, resp, nil + return &fork, resp, nil } // ListRepositorySecurityAdvisoriesForOrg lists the repository security advisories for an organization. diff --git a/github/sub_issue.go b/github/sub_issue.go index 02f7f505c2e..091f67368a0 100644 --- a/github/sub_issue.go +++ b/github/sub_issue.go @@ -57,8 +57,8 @@ func (s *SubIssueService) Remove(ctx context.Context, owner, repo string, issueN return nil, nil, err } - si := new(SubIssue) - resp, err := s.client.Do(ctx, req, si) + var si *SubIssue + resp, err := s.client.Do(ctx, req, &si) if err != nil { return nil, resp, err } @@ -107,8 +107,8 @@ func (s *SubIssueService) Add(ctx context.Context, owner, repo string, issueNumb return nil, nil, err } - si := new(SubIssue) - resp, err := s.client.Do(ctx, req, si) + var si *SubIssue + resp, err := s.client.Do(ctx, req, &si) if err != nil { return nil, resp, err } @@ -130,8 +130,8 @@ func (s *SubIssueService) Reprioritize(ctx context.Context, owner, repo string, return nil, nil, err } - si := new(SubIssue) - resp, err := s.client.Do(ctx, req, si) + var si *SubIssue + resp, err := s.client.Do(ctx, req, &si) if err != nil { return nil, resp, err } diff --git a/github/sub_issue_test.go b/github/sub_issue_test.go index 9c9eff482ae..6c898b7e147 100644 --- a/github/sub_issue_test.go +++ b/github/sub_issue_test.go @@ -21,8 +21,8 @@ func TestSubIssuesService_Add(t *testing.T) { input := &SubIssueRequest{SubIssueID: 42} mux.HandleFunc("/repos/o/r/issues/1/sub_issues", func(w http.ResponseWriter, r *http.Request) { - v := new(SubIssueRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *SubIssueRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { @@ -104,8 +104,8 @@ func TestSubIssuesService_Remove(t *testing.T) { input := &SubIssueRequest{SubIssueID: 42} mux.HandleFunc("/repos/o/r/issues/1/sub_issue", func(w http.ResponseWriter, r *http.Request) { - v := new(SubIssueRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *SubIssueRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "DELETE") if !cmp.Equal(v, input) { @@ -145,8 +145,8 @@ func TestSubIssuesService_Reprioritize(t *testing.T) { mux.HandleFunc("/repos/o/r/issues/1/sub_issues/priority", func(w http.ResponseWriter, r *http.Request) { testMethod(t, r, "PATCH") - v := new(SubIssueRequest) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *SubIssueRequest + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { diff --git a/github/teams.go b/github/teams.go index cf9a616d3fd..2fd7bc2ce8d 100644 --- a/github/teams.go +++ b/github/teams.go @@ -130,8 +130,8 @@ func (s *TeamsService) GetTeamByID(ctx context.Context, orgID, teamID int64) (*T return nil, nil, err } - t := new(Team) - resp, err := s.client.Do(ctx, req, t) + var t *Team + resp, err := s.client.Do(ctx, req, &t) if err != nil { return nil, resp, err } @@ -151,8 +151,8 @@ func (s *TeamsService) GetTeamBySlug(ctx context.Context, org, slug string) (*Te return nil, nil, err } - t := new(Team) - resp, err := s.client.Do(ctx, req, t) + var t *Team + resp, err := s.client.Do(ctx, req, &t) if err != nil { return nil, resp, err } @@ -206,8 +206,8 @@ func (s *TeamsService) CreateTeam(ctx context.Context, org string, team NewTeam) return nil, nil, err } - t := new(Team) - resp, err := s.client.Do(ctx, req, t) + var t *Team + resp, err := s.client.Do(ctx, req, &t) if err != nil { return nil, resp, err } @@ -266,8 +266,8 @@ func (s *TeamsService) EditTeamByID(ctx context.Context, orgID, teamID int64, te return nil, nil, err } - t := new(Team) - resp, err := s.client.Do(ctx, req, t) + var t *Team + resp, err := s.client.Do(ctx, req, &t) if err != nil { return nil, resp, err } @@ -295,8 +295,8 @@ func (s *TeamsService) EditTeamBySlug(ctx context.Context, org, slug string, tea return nil, nil, err } - t := new(Team) - resp, err := s.client.Do(ctx, req, t) + var t *Team + resp, err := s.client.Do(ctx, req, &t) if err != nil { return nil, resp, err } @@ -466,8 +466,8 @@ func (s *TeamsService) IsTeamRepoByID(ctx context.Context, orgID, teamID int64, req.Header.Set("Accept", mediaTypeOrgPermissionRepo) - repository := new(Repository) - resp, err := s.client.Do(ctx, req, repository) + var repository *Repository + resp, err := s.client.Do(ctx, req, &repository) if err != nil { return nil, resp, err } @@ -491,8 +491,8 @@ func (s *TeamsService) IsTeamRepoBySlug(ctx context.Context, org, slug, owner, r req.Header.Set("Accept", mediaTypeOrgPermissionRepo) - repository := new(Repository) - resp, err := s.client.Do(ctx, req, repository) + var repository *Repository + resp, err := s.client.Do(ctx, req, &repository) if err != nil { return nil, resp, err } @@ -680,7 +680,7 @@ func (s *TeamsService) ReviewTeamProjectsByID(ctx context.Context, orgID, teamID req.Header.Set("Accept", mediaTypeProjectsPreview) - projects := &ProjectV2{} + var projects *ProjectV2 resp, err := s.client.Do(ctx, req, &projects) if err != nil { return nil, resp, err @@ -704,7 +704,7 @@ func (s *TeamsService) ReviewTeamProjectsBySlug(ctx context.Context, org, slug s req.Header.Set("Accept", mediaTypeProjectsPreview) - projects := &ProjectV2{} + var projects *ProjectV2 resp, err := s.client.Do(ctx, req, &projects) if err != nil { return nil, resp, err @@ -848,8 +848,8 @@ func (s *TeamsService) ListIDPGroupsInOrganization(ctx context.Context, org stri return nil, nil, err } - groups := new(IDPGroupList) - resp, err := s.client.Do(ctx, req, groups) + var groups *IDPGroupList + resp, err := s.client.Do(ctx, req, &groups) if err != nil { return nil, resp, err } @@ -873,8 +873,8 @@ func (s *TeamsService) ListIDPGroupsForTeamByID(ctx context.Context, orgID, team return nil, nil, err } - groups := new(IDPGroupList) - resp, err := s.client.Do(ctx, req, groups) + var groups *IDPGroupList + resp, err := s.client.Do(ctx, req, &groups) if err != nil { return nil, resp, err } @@ -896,8 +896,8 @@ func (s *TeamsService) ListIDPGroupsForTeamBySlug(ctx context.Context, org, slug return nil, nil, err } - groups := new(IDPGroupList) - resp, err := s.client.Do(ctx, req, groups) + var groups *IDPGroupList + resp, err := s.client.Do(ctx, req, &groups) if err != nil { return nil, resp, err } @@ -921,8 +921,8 @@ func (s *TeamsService) CreateOrUpdateIDPGroupConnectionsByID(ctx context.Context return nil, nil, err } - groups := new(IDPGroupList) - resp, err := s.client.Do(ctx, req, groups) + var groups *IDPGroupList + resp, err := s.client.Do(ctx, req, &groups) if err != nil { return nil, resp, err } @@ -944,8 +944,8 @@ func (s *TeamsService) CreateOrUpdateIDPGroupConnectionsBySlug(ctx context.Conte return nil, nil, err } - groups := new(IDPGroupList) - resp, err := s.client.Do(ctx, req, groups) + var groups *IDPGroupList + resp, err := s.client.Do(ctx, req, &groups) if err != nil { return nil, resp, err } @@ -993,8 +993,8 @@ func (s *TeamsService) GetExternalGroup(ctx context.Context, org string, groupID return nil, nil, err } - externalGroup := new(ExternalGroup) - resp, err := s.client.Do(ctx, req, externalGroup) + var externalGroup *ExternalGroup + resp, err := s.client.Do(ctx, req, &externalGroup) if err != nil { return nil, resp, err } @@ -1027,8 +1027,8 @@ func (s *TeamsService) ListExternalGroups(ctx context.Context, org string, opts return nil, nil, err } - externalGroups := new(ExternalGroupList) - resp, err := s.client.Do(ctx, req, externalGroups) + var externalGroups *ExternalGroupList + resp, err := s.client.Do(ctx, req, &externalGroups) if err != nil { return nil, resp, err } @@ -1049,8 +1049,8 @@ func (s *TeamsService) ListExternalGroupsForTeamBySlug(ctx context.Context, org, return nil, nil, err } - externalGroups := new(ExternalGroupList) - resp, err := s.client.Do(ctx, req, externalGroups) + var externalGroups *ExternalGroupList + resp, err := s.client.Do(ctx, req, &externalGroups) if err != nil { return nil, resp, err } @@ -1071,8 +1071,8 @@ func (s *TeamsService) UpdateConnectedExternalGroup(ctx context.Context, org, sl return nil, nil, err } - externalGroup := new(ExternalGroup) - resp, err := s.client.Do(ctx, req, externalGroup) + var externalGroup *ExternalGroup + resp, err := s.client.Do(ctx, req, &externalGroup) if err != nil { return nil, resp, err } diff --git a/github/teams_discussion_comments.go b/github/teams_discussion_comments.go index 0080dac1831..ae478142078 100644 --- a/github/teams_discussion_comments.go +++ b/github/teams_discussion_comments.go @@ -107,8 +107,8 @@ func (s *TeamsService) GetCommentByID(ctx context.Context, orgID, teamID int64, return nil, nil, err } - discussionComment := &DiscussionComment{} - resp, err := s.client.Do(ctx, req, discussionComment) + var discussionComment *DiscussionComment + resp, err := s.client.Do(ctx, req, &discussionComment) if err != nil { return nil, resp, err } @@ -130,8 +130,8 @@ func (s *TeamsService) GetCommentBySlug(ctx context.Context, org, slug string, d return nil, nil, err } - discussionComment := &DiscussionComment{} - resp, err := s.client.Do(ctx, req, discussionComment) + var discussionComment *DiscussionComment + resp, err := s.client.Do(ctx, req, &discussionComment) if err != nil { return nil, resp, err } @@ -152,8 +152,8 @@ func (s *TeamsService) CreateCommentByID(ctx context.Context, orgID, teamID int6 return nil, nil, err } - discussionComment := &DiscussionComment{} - resp, err := s.client.Do(ctx, req, discussionComment) + var discussionComment *DiscussionComment + resp, err := s.client.Do(ctx, req, &discussionComment) if err != nil { return nil, resp, err } @@ -174,8 +174,8 @@ func (s *TeamsService) CreateCommentBySlug(ctx context.Context, org, slug string return nil, nil, err } - discussionComment := &DiscussionComment{} - resp, err := s.client.Do(ctx, req, discussionComment) + var discussionComment *DiscussionComment + resp, err := s.client.Do(ctx, req, &discussionComment) if err != nil { return nil, resp, err } @@ -197,8 +197,8 @@ func (s *TeamsService) EditCommentByID(ctx context.Context, orgID, teamID int64, return nil, nil, err } - discussionComment := &DiscussionComment{} - resp, err := s.client.Do(ctx, req, discussionComment) + var discussionComment *DiscussionComment + resp, err := s.client.Do(ctx, req, &discussionComment) if err != nil { return nil, resp, err } @@ -220,8 +220,8 @@ func (s *TeamsService) EditCommentBySlug(ctx context.Context, org, slug string, return nil, nil, err } - discussionComment := &DiscussionComment{} - resp, err := s.client.Do(ctx, req, discussionComment) + var discussionComment *DiscussionComment + resp, err := s.client.Do(ctx, req, &discussionComment) if err != nil { return nil, resp, err } diff --git a/github/teams_discussion_comments_test.go b/github/teams_discussion_comments_test.go index 38c45b10c33..a451ed92639 100644 --- a/github/teams_discussion_comments_test.go +++ b/github/teams_discussion_comments_test.go @@ -245,8 +245,8 @@ func TestTeamsService_CreateComment(t *testing.T) { input := DiscussionComment{Body: Ptr("c")} handlerFunc := func(w http.ResponseWriter, r *http.Request) { - v := new(DiscussionComment) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *DiscussionComment + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, &input) { @@ -317,8 +317,8 @@ func TestTeamsService_EditComment(t *testing.T) { input := DiscussionComment{Body: Ptr("e")} handlerFunc := func(w http.ResponseWriter, r *http.Request) { - v := new(DiscussionComment) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *DiscussionComment + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, &input) { diff --git a/github/teams_discussions.go b/github/teams_discussions.go index a06adecf5b9..f1fb51f0032 100644 --- a/github/teams_discussions.go +++ b/github/teams_discussions.go @@ -113,8 +113,8 @@ func (s *TeamsService) GetDiscussionByID(ctx context.Context, orgID, teamID int6 return nil, nil, err } - teamDiscussion := &TeamDiscussion{} - resp, err := s.client.Do(ctx, req, teamDiscussion) + var teamDiscussion *TeamDiscussion + resp, err := s.client.Do(ctx, req, &teamDiscussion) if err != nil { return nil, resp, err } @@ -135,8 +135,8 @@ func (s *TeamsService) GetDiscussionBySlug(ctx context.Context, org, slug string return nil, nil, err } - teamDiscussion := &TeamDiscussion{} - resp, err := s.client.Do(ctx, req, teamDiscussion) + var teamDiscussion *TeamDiscussion + resp, err := s.client.Do(ctx, req, &teamDiscussion) if err != nil { return nil, resp, err } @@ -157,8 +157,8 @@ func (s *TeamsService) CreateDiscussionByID(ctx context.Context, orgID, teamID i return nil, nil, err } - teamDiscussion := &TeamDiscussion{} - resp, err := s.client.Do(ctx, req, teamDiscussion) + var teamDiscussion *TeamDiscussion + resp, err := s.client.Do(ctx, req, &teamDiscussion) if err != nil { return nil, resp, err } @@ -179,8 +179,8 @@ func (s *TeamsService) CreateDiscussionBySlug(ctx context.Context, org, slug str return nil, nil, err } - teamDiscussion := &TeamDiscussion{} - resp, err := s.client.Do(ctx, req, teamDiscussion) + var teamDiscussion *TeamDiscussion + resp, err := s.client.Do(ctx, req, &teamDiscussion) if err != nil { return nil, resp, err } @@ -202,8 +202,8 @@ func (s *TeamsService) EditDiscussionByID(ctx context.Context, orgID, teamID int return nil, nil, err } - teamDiscussion := &TeamDiscussion{} - resp, err := s.client.Do(ctx, req, teamDiscussion) + var teamDiscussion *TeamDiscussion + resp, err := s.client.Do(ctx, req, &teamDiscussion) if err != nil { return nil, resp, err } @@ -225,8 +225,8 @@ func (s *TeamsService) EditDiscussionBySlug(ctx context.Context, org, slug strin return nil, nil, err } - teamDiscussion := &TeamDiscussion{} - resp, err := s.client.Do(ctx, req, teamDiscussion) + var teamDiscussion *TeamDiscussion + resp, err := s.client.Do(ctx, req, &teamDiscussion) if err != nil { return nil, resp, err } diff --git a/github/teams_discussions_test.go b/github/teams_discussions_test.go index 1ac6cf850c5..8e924fad55c 100644 --- a/github/teams_discussions_test.go +++ b/github/teams_discussions_test.go @@ -322,8 +322,8 @@ func TestTeamsService_CreateDiscussionByID(t *testing.T) { input := TeamDiscussion{Title: Ptr("c_t"), Body: Ptr("c_b")} mux.HandleFunc("/organizations/1/team/2/discussions", func(w http.ResponseWriter, r *http.Request) { - v := new(TeamDiscussion) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *TeamDiscussion + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, &input) { @@ -366,8 +366,8 @@ func TestTeamsService_CreateDiscussionBySlug(t *testing.T) { input := TeamDiscussion{Title: Ptr("c_t"), Body: Ptr("c_b")} mux.HandleFunc("/orgs/o/teams/s/discussions", func(w http.ResponseWriter, r *http.Request) { - v := new(TeamDiscussion) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *TeamDiscussion + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, &input) { @@ -410,8 +410,8 @@ func TestTeamsService_EditDiscussionByID(t *testing.T) { input := TeamDiscussion{Title: Ptr("e_t"), Body: Ptr("e_b")} mux.HandleFunc("/organizations/1/team/2/discussions/3", func(w http.ResponseWriter, r *http.Request) { - v := new(TeamDiscussion) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *TeamDiscussion + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, &input) { @@ -454,8 +454,8 @@ func TestTeamsService_EditDiscussionBySlug(t *testing.T) { input := TeamDiscussion{Title: Ptr("e_t"), Body: Ptr("e_b")} mux.HandleFunc("/orgs/o/teams/s/discussions/3", func(w http.ResponseWriter, r *http.Request) { - v := new(TeamDiscussion) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *TeamDiscussion + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, &input) { diff --git a/github/teams_members.go b/github/teams_members.go index 059d993a3e6..315a5c78578 100644 --- a/github/teams_members.go +++ b/github/teams_members.go @@ -87,8 +87,8 @@ func (s *TeamsService) GetTeamMembershipByID(ctx context.Context, orgID, teamID return nil, nil, err } - t := new(Membership) - resp, err := s.client.Do(ctx, req, t) + var t *Membership + resp, err := s.client.Do(ctx, req, &t) if err != nil { return nil, resp, err } @@ -109,8 +109,8 @@ func (s *TeamsService) GetTeamMembershipBySlug(ctx context.Context, org, slug, u return nil, nil, err } - t := new(Membership) - resp, err := s.client.Do(ctx, req, t) + var t *Membership + resp, err := s.client.Do(ctx, req, &t) if err != nil { return nil, resp, err } @@ -145,8 +145,8 @@ func (s *TeamsService) AddTeamMembershipByID(ctx context.Context, orgID, teamID return nil, nil, err } - t := new(Membership) - resp, err := s.client.Do(ctx, req, t) + var t *Membership + resp, err := s.client.Do(ctx, req, &t) if err != nil { return nil, resp, err } @@ -167,8 +167,8 @@ func (s *TeamsService) AddTeamMembershipBySlug(ctx context.Context, org, slug, u return nil, nil, err } - t := new(Membership) - resp, err := s.client.Do(ctx, req, t) + var t *Membership + resp, err := s.client.Do(ctx, req, &t) if err != nil { return nil, resp, err } diff --git a/github/teams_members_test.go b/github/teams_members_test.go index b549dd2b6b4..5234e9dbce8 100644 --- a/github/teams_members_test.go +++ b/github/teams_members_test.go @@ -331,8 +331,8 @@ func TestTeamsService__AddTeamMembershipByID(t *testing.T) { opt := &TeamAddTeamMembershipOptions{Role: "maintainer"} mux.HandleFunc("/organizations/1/team/2/memberships/u", func(w http.ResponseWriter, r *http.Request) { - v := new(TeamAddTeamMembershipOptions) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *TeamAddTeamMembershipOptions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, opt) { @@ -375,8 +375,8 @@ func TestTeamsService__AddTeamMembershipByID_notFound(t *testing.T) { opt := &TeamAddTeamMembershipOptions{Role: "maintainer"} mux.HandleFunc("/organizations/1/team/2/memberships/u", func(w http.ResponseWriter, r *http.Request) { - v := new(TeamAddTeamMembershipOptions) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *TeamAddTeamMembershipOptions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, opt) { @@ -420,8 +420,8 @@ func TestTeamsService__AddTeamMembershipBySlug(t *testing.T) { opt := &TeamAddTeamMembershipOptions{Role: "maintainer"} mux.HandleFunc("/orgs/o/teams/s/memberships/u", func(w http.ResponseWriter, r *http.Request) { - v := new(TeamAddTeamMembershipOptions) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *TeamAddTeamMembershipOptions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, opt) { @@ -464,8 +464,8 @@ func TestTeamsService__AddTeamMembershipBySlug_notFound(t *testing.T) { opt := &TeamAddTeamMembershipOptions{Role: "maintainer"} mux.HandleFunc("/orgs/o/teams/s/memberships/u", func(w http.ResponseWriter, r *http.Request) { - v := new(TeamAddTeamMembershipOptions) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *TeamAddTeamMembershipOptions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, opt) { diff --git a/github/teams_test.go b/github/teams_test.go index 2efc1cd4f9a..9cef55710db 100644 --- a/github/teams_test.go +++ b/github/teams_test.go @@ -192,8 +192,8 @@ func TestTeamsService_CreateTeam(t *testing.T) { input := NewTeam{Name: "n", Privacy: Ptr("closed"), RepoNames: []string{"r"}} mux.HandleFunc("/orgs/o/teams", func(w http.ResponseWriter, r *http.Request) { - v := new(NewTeam) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *NewTeam + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, &input) { @@ -245,8 +245,8 @@ func TestTeamsService_EditTeamByID(t *testing.T) { input := NewTeam{Name: "n", Privacy: Ptr("closed")} mux.HandleFunc("/organizations/1/team/1", func(w http.ResponseWriter, r *http.Request) { - v := new(NewTeam) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *NewTeam + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, &input) { @@ -290,13 +290,13 @@ func TestTeamsService_EditTeamByID_RemoveParent(t *testing.T) { var body string mux.HandleFunc("/organizations/1/team/1", func(w http.ResponseWriter, r *http.Request) { - v := new(NewTeam) buf, err := io.ReadAll(r.Body) if err != nil { t.Errorf("Unable to read body: %v", err) } body = string(buf) - assertNilError(t, json.NewDecoder(bytes.NewBuffer(buf)).Decode(v)) + var v *NewTeam + assertNilError(t, json.NewDecoder(bytes.NewBuffer(buf)).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, &input) { @@ -329,8 +329,8 @@ func TestTeamsService_EditTeamBySlug(t *testing.T) { input := NewTeam{Name: "n", Privacy: Ptr("closed")} mux.HandleFunc("/orgs/o/teams/s", func(w http.ResponseWriter, r *http.Request) { - v := new(NewTeam) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *NewTeam + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, &input) { @@ -374,13 +374,13 @@ func TestTeamsService_EditTeamBySlug_RemoveParent(t *testing.T) { var body string mux.HandleFunc("/orgs/o/teams/s", func(w http.ResponseWriter, r *http.Request) { - v := new(NewTeam) buf, err := io.ReadAll(r.Body) if err != nil { t.Errorf("Unable to read body: %v", err) } body = string(buf) - assertNilError(t, json.NewDecoder(bytes.NewBuffer(buf)).Decode(v)) + var v *NewTeam + assertNilError(t, json.NewDecoder(bytes.NewBuffer(buf)).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, &input) { @@ -791,8 +791,8 @@ func TestTeamsService_AddTeamRepoByID(t *testing.T) { opt := &TeamAddTeamRepoOptions{Permission: "admin"} mux.HandleFunc("/organizations/1/team/1/repos/owner/repo", func(w http.ResponseWriter, r *http.Request) { - v := new(TeamAddTeamRepoOptions) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *TeamAddTeamRepoOptions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, opt) { @@ -826,8 +826,8 @@ func TestTeamsService_AddTeamRepoBySlug(t *testing.T) { opt := &TeamAddTeamRepoOptions{Permission: "admin"} mux.HandleFunc("/orgs/org/teams/slug/repos/owner/repo", func(w http.ResponseWriter, r *http.Request) { - v := new(TeamAddTeamRepoOptions) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *TeamAddTeamRepoOptions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, opt) { @@ -1162,8 +1162,8 @@ func TestTeamsService_AddTeamProjectByID(t *testing.T) { testMethod(t, r, "PUT") testHeader(t, r, "Accept", mediaTypeProjectsPreview) - v := &TeamProjectOptions{} - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *TeamProjectOptions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) if !cmp.Equal(v, opt) { t.Errorf("Request body = %+v, want %+v", v, opt) } @@ -1200,8 +1200,8 @@ func TestTeamsService_AddTeamProjectBySlug(t *testing.T) { testMethod(t, r, "PUT") testHeader(t, r, "Accept", mediaTypeProjectsPreview) - v := &TeamProjectOptions{} - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *TeamProjectOptions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) if !cmp.Equal(v, opt) { t.Errorf("Request body = %+v, want %+v", v, opt) } diff --git a/github/users.go b/github/users.go index ae5027d3155..0799395987d 100644 --- a/github/users.go +++ b/github/users.go @@ -105,8 +105,8 @@ func (s *UsersService) Get(ctx context.Context, user string) (*User, *Response, return nil, nil, err } - uResp := new(User) - resp, err := s.client.Do(ctx, req, uResp) + var uResp *User + resp, err := s.client.Do(ctx, req, &uResp) if err != nil { return nil, resp, err } @@ -126,8 +126,8 @@ func (s *UsersService) GetByID(ctx context.Context, id int64) (*User, *Response, return nil, nil, err } - user := new(User) - resp, err := s.client.Do(ctx, req, user) + var user *User + resp, err := s.client.Do(ctx, req, &user) if err != nil { return nil, resp, err } @@ -147,8 +147,8 @@ func (s *UsersService) Edit(ctx context.Context, user *User) (*User, *Response, return nil, nil, err } - uResp := new(User) - resp, err := s.client.Do(ctx, req, uResp) + var uResp *User + resp, err := s.client.Do(ctx, req, &uResp) if err != nil { return nil, resp, err } @@ -196,8 +196,8 @@ func (s *UsersService) GetHovercard(ctx context.Context, user string, opts *Hove return nil, nil, err } - hc := new(Hovercard) - resp, err := s.client.Do(ctx, req, hc) + var hc *Hovercard + resp, err := s.client.Do(ctx, req, &hc) if err != nil { return nil, resp, err } diff --git a/github/users_administration_test.go b/github/users_administration_test.go index 56b48d8c276..084a7826cbf 100644 --- a/github/users_administration_test.go +++ b/github/users_administration_test.go @@ -98,8 +98,8 @@ func TestUsersServiceReason_Suspend(t *testing.T) { input := &UserSuspendOptions{Reason: Ptr("test")} mux.HandleFunc("/users/u/suspended", func(w http.ResponseWriter, r *http.Request) { - v := new(UserSuspendOptions) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *UserSuspendOptions + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PUT") if !cmp.Equal(v, input) { diff --git a/github/users_emails_test.go b/github/users_emails_test.go index 84d94dc5a10..27664047fd6 100644 --- a/github/users_emails_test.go +++ b/github/users_emails_test.go @@ -148,7 +148,7 @@ func TestUsersService_SetEmailVisibility(t *testing.T) { input := &UserEmail{Visibility: Ptr("private")} mux.HandleFunc("/user/email/visibility", func(w http.ResponseWriter, r *http.Request) { - v := new(UserEmail) + var v *UserEmail assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") diff --git a/github/users_gpg_keys.go b/github/users_gpg_keys.go index d33564cab7c..f27768c7753 100644 --- a/github/users_gpg_keys.go +++ b/github/users_gpg_keys.go @@ -89,8 +89,8 @@ func (s *UsersService) GetGPGKey(ctx context.Context, id int64) (*GPGKey, *Respo return nil, nil, err } - key := &GPGKey{} - resp, err := s.client.Do(ctx, req, key) + var key *GPGKey + resp, err := s.client.Do(ctx, req, &key) if err != nil { return nil, resp, err } @@ -113,8 +113,8 @@ func (s *UsersService) CreateGPGKey(ctx context.Context, armoredPublicKey string return nil, nil, err } - key := &GPGKey{} - resp, err := s.client.Do(ctx, req, key) + var key *GPGKey + resp, err := s.client.Do(ctx, req, &key) if err != nil { return nil, resp, err } diff --git a/github/users_keys.go b/github/users_keys.go index 350a684b797..47e4226a768 100644 --- a/github/users_keys.go +++ b/github/users_keys.go @@ -75,8 +75,8 @@ func (s *UsersService) GetKey(ctx context.Context, id int64) (*Key, *Response, e return nil, nil, err } - key := new(Key) - resp, err := s.client.Do(ctx, req, key) + var key *Key + resp, err := s.client.Do(ctx, req, &key) if err != nil { return nil, resp, err } @@ -97,8 +97,8 @@ func (s *UsersService) CreateKey(ctx context.Context, key *Key) (*Key, *Response return nil, nil, err } - k := new(Key) - resp, err := s.client.Do(ctx, req, k) + var k *Key + resp, err := s.client.Do(ctx, req, &k) if err != nil { return nil, resp, err } diff --git a/github/users_keys_test.go b/github/users_keys_test.go index 35385c21d9f..efb089bb6b3 100644 --- a/github/users_keys_test.go +++ b/github/users_keys_test.go @@ -123,8 +123,8 @@ func TestUsersService_CreateKey(t *testing.T) { input := &Key{Key: Ptr("k"), Title: Ptr("t")} mux.HandleFunc("/user/keys", func(w http.ResponseWriter, r *http.Request) { - v := new(Key) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *Key + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { diff --git a/github/users_ssh_signing_keys.go b/github/users_ssh_signing_keys.go index 968401f028c..440d98510ce 100644 --- a/github/users_ssh_signing_keys.go +++ b/github/users_ssh_signing_keys.go @@ -70,8 +70,8 @@ func (s *UsersService) GetSSHSigningKey(ctx context.Context, id int64) (*SSHSign return nil, nil, err } - key := new(SSHSigningKey) - resp, err := s.client.Do(ctx, req, key) + var key *SSHSigningKey + resp, err := s.client.Do(ctx, req, &key) if err != nil { return nil, resp, err } @@ -92,8 +92,8 @@ func (s *UsersService) CreateSSHSigningKey(ctx context.Context, key *Key) (*SSHS return nil, nil, err } - k := new(SSHSigningKey) - resp, err := s.client.Do(ctx, req, k) + var k *SSHSigningKey + resp, err := s.client.Do(ctx, req, &k) if err != nil { return nil, resp, err } diff --git a/github/users_ssh_signing_keys_test.go b/github/users_ssh_signing_keys_test.go index 8c77dff0368..f5fdd2d28f9 100644 --- a/github/users_ssh_signing_keys_test.go +++ b/github/users_ssh_signing_keys_test.go @@ -123,8 +123,8 @@ func TestUsersService_CreateSSHSigningKey(t *testing.T) { input := &Key{Key: Ptr("k"), Title: Ptr("t")} mux.HandleFunc("/user/ssh_signing_keys", func(w http.ResponseWriter, r *http.Request) { - v := new(Key) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *Key + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "POST") if !cmp.Equal(v, input) { diff --git a/github/users_test.go b/github/users_test.go index 7a2784744f3..17901935c1b 100644 --- a/github/users_test.go +++ b/github/users_test.go @@ -251,8 +251,8 @@ func TestUsersService_Edit(t *testing.T) { input := &User{Name: Ptr("n")} mux.HandleFunc("/user", func(w http.ResponseWriter, r *http.Request) { - v := new(User) - assertNilError(t, json.NewDecoder(r.Body).Decode(v)) + var v *User + assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) testMethod(t, r, "PATCH") if !cmp.Equal(v, input) { diff --git a/tools/gen-release-notes/main.go b/tools/gen-release-notes/main.go index e819724e9dc..5930c740b49 100644 --- a/tools/gen-release-notes/main.go +++ b/tools/gen-release-notes/main.go @@ -122,8 +122,8 @@ func genRefLines(breaking, nonBreaking []string) (ref, refNon []string) { func runCommand(cmdArgs []string) string { cmd := exec.Command(cmdArgs[0], cmdArgs[1:]...) //nolint:gosec - out := &bytes.Buffer{} - cmd.Stdout = out + var out bytes.Buffer + cmd.Stdout = &out cmd.Stderr = os.Stderr log.Printf("Running command: %v", strings.Join(cmdArgs, " ")) From e089733efa17c2f7c0aac1a97fbf320c3a641180 Mon Sep 17 00:00:00 2001 From: Glenn Lewis <6598971+gmlewis@users.noreply.github.com> Date: Wed, 18 Mar 2026 12:25:28 -0400 Subject: [PATCH 2/2] Implement and use new custom extraneousnew linter Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com> --- .custom-gcl.yml | 2 + .golangci.yml | 9 + github/pulls_reviews.go | 4 +- tools/extraneous-new/extraneous_new.go | 308 ++++++++++++++++++ tools/extraneous-new/extraneous_new_test.go | 24 ++ tools/extraneous-new/go.mod | 13 + tools/extraneous-new/go.sum | 10 + .../testdata/src/has-warnings/main.go | 77 +++++ .../testdata/src/no-warnings/main.go | 55 ++++ 9 files changed, 500 insertions(+), 2 deletions(-) create mode 100644 tools/extraneous-new/extraneous_new.go create mode 100644 tools/extraneous-new/extraneous_new_test.go create mode 100644 tools/extraneous-new/go.mod create mode 100644 tools/extraneous-new/go.sum create mode 100644 tools/extraneous-new/testdata/src/has-warnings/main.go create mode 100644 tools/extraneous-new/testdata/src/no-warnings/main.go diff --git a/.custom-gcl.yml b/.custom-gcl.yml index 4c5716e008a..bfbf6ad0f5b 100644 --- a/.custom-gcl.yml +++ b/.custom-gcl.yml @@ -1,5 +1,7 @@ version: v2.10.1 # should be in sync with script/setup-custom-gcl.sh plugins: + - module: "github.com/google/go-github/v84/tools/extraneousnew" + path: ./tools/extraneous-new - module: "github.com/google/go-github/v84/tools/fmtpercentv" path: ./tools/fmtpercentv - module: "github.com/google/go-github/v84/tools/sliceofpointers" diff --git a/.golangci.yml b/.golangci.yml index 2914085f6de..9bc14152b66 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -11,6 +11,7 @@ linters: - dupl - errcheck - errorlint + - extraneousnew - fmtpercentv - forbidigo - gocritic @@ -180,6 +181,14 @@ linters: os-create-temp: true os-temp-dir: true custom: + extraneousnew: + type: module + description: Reports problematic usage of 'new' or '&SomeStruct{}' when a more idiomatic 'var' pointer would be more appropriate. + original-url: github.com/google/go-github/v84/tools/extraneousnew + settings: + ignored-methods: + - RateLimitService.Get + - RepositoriesService.ReplaceAllTopics fmtpercentv: type: module description: Reports usage of %d or %s in format strings. diff --git a/github/pulls_reviews.go b/github/pulls_reviews.go index 9f55ab533cf..d41820891eb 100644 --- a/github/pulls_reviews.go +++ b/github/pulls_reviews.go @@ -279,8 +279,8 @@ func (s *PullRequestsService) UpdateReview(ctx context.Context, owner, repo stri return nil, nil, err } - review := &PullRequestReview{} - resp, err := s.client.Do(ctx, req, review) + var review *PullRequestReview + resp, err := s.client.Do(ctx, req, &review) if err != nil { return nil, resp, err } diff --git a/tools/extraneous-new/extraneous_new.go b/tools/extraneous-new/extraneous_new.go new file mode 100644 index 00000000000..ad7ac6cd9e4 --- /dev/null +++ b/tools/extraneous-new/extraneous_new.go @@ -0,0 +1,308 @@ +// Copyright 2026 The go-github AUTHORS. All rights reserved. +// +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +// Package extraneousnew is a custom linter to be used by +// golangci-lint to find instances where the Go code could +// replace extraneous and problematic usage of `new` or `&SomeStruct{}` +// with an initialized pointer in very specific instances. +// It promotes the idiomatic Go concept that the zero-value is useful. +package extraneousnew + +import ( + "go/ast" + "go/token" + + "github.com/golangci/plugin-module-register/register" + "golang.org/x/tools/go/analysis" +) + +func init() { + register.Plugin("extraneousnew", New) +} + +// ExtraneousNewPlugin is a custom linter plugin for golangci-lint. +type ExtraneousNewPlugin struct { + ignoredMethods map[string]bool +} + +// Settings is the configuration for the extraneousnew linter. +type Settings struct { + // IgnoredMethods causes the linter to skip linting individual `Receiver.Methods`. + IgnoredMethods []string `json:"ignored-methods" yaml:"ignored-methods"` +} + +// New returns an analysis.Analyzer to use with golangci-lint. +func New(cfg any) (register.LinterPlugin, error) { + settings := Settings{} + if cfg != nil { + if data, ok := cfg.(map[string]any); ok { + if ignored, ok := data["ignored-methods"].([]any); ok { + for _, m := range ignored { + if s, ok := m.(string); ok { + settings.IgnoredMethods = append(settings.IgnoredMethods, s) + } + } + } + } + } + + ignoredMethods := map[string]bool{} + for _, m := range settings.IgnoredMethods { + ignoredMethods[m] = true + } + + return &ExtraneousNewPlugin{ + ignoredMethods: ignoredMethods, + }, nil +} + +// BuildAnalyzers builds the analyzers for the ExtraneousNewPlugin. +func (f *ExtraneousNewPlugin) BuildAnalyzers() ([]*analysis.Analyzer, error) { + return []*analysis.Analyzer{ + { + Name: "extraneousnew", + Doc: `Reports problematic usage of 'new' or '&SomeStruct{}' when a +more idiomatic 'var' pointer would be more appropriate. +It encourages use of the idiomatic Go concept that the zero-value is useful.`, + Run: func(pass *analysis.Pass) (any, error) { + return run(pass, f.ignoredMethods) + }, + }, + }, nil +} + +// GetLoadMode returns the load mode for the ExtraneousNewPlugin. +func (f *ExtraneousNewPlugin) GetLoadMode() string { + return register.LoadModeSyntax +} + +func run(pass *analysis.Pass, ignoredMethods map[string]bool) (any, error) { + for _, file := range pass.Files { + ast.Inspect(file, func(n ast.Node) bool { + fn, ok := n.(*ast.FuncDecl) + if !ok { + return true + } + + if !fn.Name.IsExported() { + return false + } + + // Check if method should be ignored. + if fn.Recv != nil && len(fn.Recv.List) > 0 { + var recvName string + recvType := fn.Recv.List[0].Type + if star, ok := recvType.(*ast.StarExpr); ok { + recvType = star.X + } + if ident, ok := recvType.(*ast.Ident); ok { + recvName = ident.Name + } + + if recvName != "" { + fullName := recvName + "." + fn.Name.Name + if ignoredMethods[fullName] { + return false + } + } + } + + if fn.Body != nil { + inspectAllBlocks(pass, fn.Body) + } + return true + }) + } + return nil, nil +} + +func inspectAllBlocks(pass *analysis.Pass, root ast.Node) { + ast.Inspect(root, func(n ast.Node) bool { + block, ok := n.(*ast.BlockStmt) + if !ok { + return true + } + inspectBlock(pass, block) + return true + }) +} + +func inspectBlock(pass *analysis.Pass, block *ast.BlockStmt) { + // Track pointers that are currently nil. + nilPointers := make(map[string]*ast.Ident) + + for i, stmt := range block.List { + // 1. Check for `var v *T` or `var v *struct{...}` + if decl, ok := stmt.(*ast.DeclStmt); ok { + if gen, ok := decl.Decl.(*ast.GenDecl); ok && gen.Tok == token.VAR { + for _, spec := range gen.Specs { + if vSpec, ok := spec.(*ast.ValueSpec); ok { + if _, ok := vSpec.Type.(*ast.StarExpr); ok && len(vSpec.Values) == 0 { + for _, name := range vSpec.Names { + nilPointers[name.Name] = name + } + } + } + } + } + } + + // 2. Check for `v = new(T)` or `v := new(T)` + var assignLHS *ast.Ident + var isNewT bool + var typeName string + + if assign, ok := stmt.(*ast.AssignStmt); ok && len(assign.Lhs) == 1 && len(assign.Rhs) == 1 { + if lhs, ok := assign.Lhs[0].(*ast.Ident); ok { + assignLHS = lhs + // Any assignment to v means it's no longer a "nil pointer" for our simple tracking. + delete(nilPointers, lhs.Name) + + // Check for v := new(T) or v := &T{} + if call, ok := assign.Rhs[0].(*ast.CallExpr); ok { + if fun, ok := call.Fun.(*ast.Ident); ok && fun.Name == "new" && len(call.Args) == 1 { + isNewT = true + if typeIdent, ok := call.Args[0].(*ast.Ident); ok { + typeName = typeIdent.Name + } + } + } + if unary, ok := assign.Rhs[0].(*ast.UnaryExpr); ok && unary.Op == token.AND { + if composite, ok := unary.X.(*ast.CompositeLit); ok && len(composite.Elts) == 0 { + isNewT = true + if typeIdent, ok := composite.Type.(*ast.Ident); ok { + typeName = typeIdent.Name + } + } + } + } + } + + if isNewT && assignLHS != nil { + lookAhead(pass, block, i, assignLHS, typeName) + continue + } + + // If it's a regular assignment (possibly with multiple variables), it might initialize a nil pointer. + if assign, ok := stmt.(*ast.AssignStmt); ok { + for _, lhs := range assign.Lhs { + if ident, ok := lhs.(*ast.Ident); ok { + delete(nilPointers, ident.Name) + } + } + } + + // 3. Check if a nil pointer is passed to Do/Decode. + ast.Inspect(stmt, func(n ast.Node) bool { + call, ok := n.(*ast.CallExpr) + if !ok { + return true + } + + fnName := getFunctionName(call.Fun) + if fnName == "" { + return true + } + + var targetArg ast.Expr + if fnName == "Do" && len(call.Args) == 3 { + targetArg = call.Args[2] + } else if fnName == "Decode" && len(call.Args) == 1 { + targetArg = call.Args[0] + } + + if targetArg != nil { + if ident, ok := targetArg.(*ast.Ident); ok { + if _, isNil := nilPointers[ident.Name]; isNil { + pass.Reportf(ident.Pos(), "pass '&%v' instead", ident.Name) + } + } + } + return true + }) + } +} + +func getFunctionName(expr ast.Expr) string { + switch f := expr.(type) { + case *ast.SelectorExpr: + return f.Sel.Name + case *ast.Ident: + return f.Name + } + return "" +} + +func lookAhead(pass *analysis.Pass, block *ast.BlockStmt, startIndex int, lhsIdent *ast.Ident, typeName string) { + var foundProperUse bool + var foundOtherUse bool + + for j := startIndex + 1; j < len(block.List); j++ { + nextStmt := block.List[j] + ast.Inspect(nextStmt, func(un ast.Node) bool { + if foundProperUse || foundOtherUse { + return false + } + + // Check if lhsIdent is used here. + ident, ok := un.(*ast.Ident) + if !ok || ident.Name != lhsIdent.Name { + return true + } + + // Found a use of lhsIdent. Is it the target argument in a call to Do or Decode? + isSafe := false + ast.Inspect(nextStmt, func(n ast.Node) bool { + call, ok := n.(*ast.CallExpr) + if !ok { + return true + } + + fnName := getFunctionName(call.Fun) + var targetArg ast.Expr + if fnName == "Do" && len(call.Args) == 3 { + targetArg = call.Args[2] + } else if fnName == "Decode" && len(call.Args) == 1 { + targetArg = call.Args[0] + } + + if targetArg != nil { + if isIdentOrAddressOfIdent(targetArg, lhsIdent.Name) { + isSafe = true + return false + } + } + return true + }) + + if isSafe { + if typeName != "" { + pass.Reportf(ident.Pos(), "use 'var %v *%v' and pass '&%v' instead", lhsIdent.Name, typeName, lhsIdent.Name) + } else { + pass.Reportf(ident.Pos(), "use 'var %v *T' and pass '&%v' instead", lhsIdent.Name, lhsIdent.Name) + } + foundProperUse = true + } else { + foundOtherUse = true + } + return false + }) + if foundProperUse || foundOtherUse { + break + } + } +} + +func isIdentOrAddressOfIdent(expr ast.Expr, name string) bool { + if ident, ok := expr.(*ast.Ident); ok { + return ident.Name == name + } + if unary, ok := expr.(*ast.UnaryExpr); ok && unary.Op == token.AND { + if ident, ok := unary.X.(*ast.Ident); ok { + return ident.Name == name + } + } + return false +} diff --git a/tools/extraneous-new/extraneous_new_test.go b/tools/extraneous-new/extraneous_new_test.go new file mode 100644 index 00000000000..b0058781f63 --- /dev/null +++ b/tools/extraneous-new/extraneous_new_test.go @@ -0,0 +1,24 @@ +// Copyright 2026 The go-github AUTHORS. All rights reserved. +// +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +package extraneousnew + +import ( + "testing" + + "golang.org/x/tools/go/analysis/analysistest" +) + +func TestRun(t *testing.T) { + t.Parallel() + testdata := analysistest.TestData() + plugin, _ := New(map[string]any{ + "ignored-methods": []any{ + "Receiver.MethodNameToIgnore", + }, + }) + analyzers, _ := plugin.BuildAnalyzers() + analysistest.Run(t, testdata, analyzers[0], "has-warnings", "no-warnings") +} diff --git a/tools/extraneous-new/go.mod b/tools/extraneous-new/go.mod new file mode 100644 index 00000000000..20bb99588ec --- /dev/null +++ b/tools/extraneous-new/go.mod @@ -0,0 +1,13 @@ +module github.com/google/go-github/v84/tools/extraneousnew + +go 1.25.0 + +require ( + github.com/golangci/plugin-module-register v0.1.1 + golang.org/x/tools v0.29.0 +) + +require ( + golang.org/x/mod v0.22.0 // indirect + golang.org/x/sync v0.10.0 // indirect +) diff --git a/tools/extraneous-new/go.sum b/tools/extraneous-new/go.sum new file mode 100644 index 00000000000..c2f7392bb23 --- /dev/null +++ b/tools/extraneous-new/go.sum @@ -0,0 +1,10 @@ +github.com/golangci/plugin-module-register v0.1.1 h1:TCmesur25LnyJkpsVrupv1Cdzo+2f7zX0H6Jkw1Ol6c= +github.com/golangci/plugin-module-register v0.1.1/go.mod h1:TTpqoB6KkwOJMV8u7+NyXMrkwwESJLOkfl9TxR1DGFc= +github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI= +github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY= +golang.org/x/mod v0.22.0 h1:D4nJWe9zXqHOmWqj4VMOJhvzj7bEZg4wEYa759z1pH4= +golang.org/x/mod v0.22.0/go.mod h1:6SkKJ3Xj0I0BrPOZoBy3bdMptDDU9oJrpohJ3eWZ1fY= +golang.org/x/sync v0.10.0 h1:3NQrjDixjgGwUOCaF8w2+VYHv0Ve/vGYSbdkTa98gmQ= +golang.org/x/sync v0.10.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk= +golang.org/x/tools v0.29.0 h1:Xx0h3TtM9rzQpQuR4dKLrdglAmCEN5Oi+P74JdhdzXE= +golang.org/x/tools v0.29.0/go.mod h1:KMQVMRsVxU6nHCFXrBPhDB8XncLNLM0lIy/F14RP588= diff --git a/tools/extraneous-new/testdata/src/has-warnings/main.go b/tools/extraneous-new/testdata/src/has-warnings/main.go new file mode 100644 index 00000000000..2dddce91693 --- /dev/null +++ b/tools/extraneous-new/testdata/src/has-warnings/main.go @@ -0,0 +1,77 @@ +// Copyright 2026 The go-github AUTHORS. All rights reserved. +// +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +package main + +import ( + "context" + "encoding/json" + "net/http" + "testing" +) + +type T struct { + Field string +} + +type Client struct{} + +func (c *Client) Do(ctx context.Context, req any, v any) (any, error) { + return nil, nil +} + +type Service struct { + client *Client +} + +func assertNilError(t *testing.T, err error) {} + +func (s *Service) TestMethod(ctx context.Context, req any, r *http.Request, t *testing.T) { + v1 := new(T) + s.client.Do(ctx, req, v1) // want "use 'var v1 [*]T' and pass '&v1' instead" + + v2 := &T{} + s.client.Do(ctx, req, v2) // want "use 'var v2 [*]T' and pass '&v2' instead" + + v3 := new(T) + json.NewDecoder(r.Body).Decode(v3) // want "use 'var v3 [*]T' and pass '&v3' instead" + + v4 := &T{} + json.NewDecoder(r.Body).Decode(v4) // want "use 'var v4 [*]T' and pass '&v4' instead" + + v5 := &T{} + s.client.Do(ctx, req, &v5) // want "use 'var v5 [*]T' and pass '&v5' instead" + + v6 := new(T) + assertNilError(t, json.NewDecoder(r.Body).Decode(v6)) // want "use 'var v6 [*]T' and pass '&v6' instead" + + v7 := &T{Field: "something"} + s.client.Do(ctx, req, v7) // No warning + + var v8 *T + v8 = new(T) + s.client.Do(ctx, req, v8) // want "use 'var v8 [*]T' and pass '&v8' instead" + + // Multiple assignments in same block + v9 := new(T) + v10 := new(T) + s.client.Do(ctx, req, v9) // want "use 'var v9 [*]T' and pass '&v9' instead" + s.client.Do(ctx, req, v10) // want "use 'var v10 [*]T' and pass '&v10' instead" + + // Anonymous struct + v11 := new(struct { + F string + }) + s.client.Do(ctx, req, v11) // want "use 'var v11 [*]T' and pass '&v11' instead" + + // Anonymous struct + var v12 *struct { + F string + } + s.client.Do(ctx, req, v12) // want "pass '&v12' instead" + + var v13 *T + s.client.Do(ctx, req, v13) // want "pass '&v13' instead" +} diff --git a/tools/extraneous-new/testdata/src/no-warnings/main.go b/tools/extraneous-new/testdata/src/no-warnings/main.go new file mode 100644 index 00000000000..7b8cb18c70d --- /dev/null +++ b/tools/extraneous-new/testdata/src/no-warnings/main.go @@ -0,0 +1,55 @@ +// Copyright 2026 The go-github AUTHORS. All rights reserved. +// +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +package main + +import ( + "context" +) + +type T struct { + Field string +} + +type Client struct{} + +func (c *Client) Do(ctx context.Context, req any, v any) (any, error) { + return nil, nil +} + +type Receiver struct { + client *Client +} + +func (s *Receiver) TestMethod(ctx context.Context, req any) { + // Proper usage: var pointer and pass &v + var v1 *T + s.client.Do(ctx, req, &v1) + + // Literal with fields + v2 := &T{Field: "something"} + s.client.Do(ctx, req, v2) + + // new(T) but used for something else first + v3 := new(T) + v3.Field = "set" + s.client.Do(ctx, req, v3) + + // Anonymous struct + var v11 *struct { + F string + } + s.client.Do(ctx, req, &v11) +} + +func (s *Receiver) MethodNameToIgnore(ctx context.Context, req any) { + v := new(T) + s.client.Do(ctx, req, v) +} + +func (s *Receiver) unexportedMethod(ctx context.Context, req any) { + v := new(T) + s.client.Do(ctx, req, v) // Should be ignored because unexported. +}