Delete concurrent camera quick setting#512
Conversation
Migrates the concurrent camera toggle from the Quick Settings bottom
sheet
to the main Settings screen.
Changes:
- Added ConcurrentCameraMode to JcaSettings proto and SettingsRepository.
- Updated CameraSystem to apply concurrent camera setting changes.
- Added ConcurrentCameraSetting UI and state to feature/settings.
- Removed concurrent camera toggle from QuickSettingsScreen.
- Updated ConcurrentCameraTest to toggle the setting via Settings screen.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the Concurrent Camera setting from the Quick Settings menu to the main Settings screen. The changes include updating the proto datastore for persistence, implementing the setting toggle in the UI, and refactoring instrumented tests to verify the setting via the Settings screen. Reviewer feedback suggests using more idiomatic Compose testing matchers like assertIsOn(), removing redundant support checks in tests, and applying the internal visibility modifier to new functions and composables. Additionally, the reviewer noted a potentially missing file (CameraAppSettings) and emphasized the requirement to synchronize default values across the datastore and the app's default settings.
| maxVideoDurationMillis = it.maxVideoDurationMillis, | ||
| videoQuality = VideoQuality.fromProto(it.videoQuality), | ||
| audioEnabled = it.audioEnabledStatus, | ||
| concurrentCameraMode = when (it.concurrentCameraModeStatus) { |
There was a problem hiding this comment.
The CameraAppSettings data class appears to have been modified to include the concurrentCameraMode property, but the file itself is missing from this pull request. Please ensure all modified files are included. Additionally, verify that the default value for this new setting is synchronized in both JcaSettingsSerializer and the CameraAppSettings default instance.
References
- When a new setting is added to the proto datastore, its default value must be defined and synchronized in JcaSettingsSerializer and CameraAppSettings. (link)
There was a problem hiding this comment.
what do you mean by file is missing? the concurrentCameraModeStatus is an auto generated file
Kimblebee
changed the title
Kimblebee
force-pushed
the
kim/feature/concurrent-camera-settings
branch
from
1079495 to
42d1f7a
Compare
1 participant
Deletes the concurrent camera quick setting in anticipation of a quick settings UI refactor wherein it is removed. The concurrent camerea setting has been made available in the main settings screen.