Condition that always returns true

[lifove]

Hi
I've also found a code smell (possibly a bug).

Path: com.windowtester.swt.runtime/src/com/windowtester/runtime/swt/condition/eclipse/ActiveEditorCondition.java

 61                 public boolean test() {
 62                         IFile file = getActiveFile();
 63                         if (file == null)
 64                                 return false;
 65                         actualPath = file.getLocation();
 66                         return actualPath.equals(actualPath) == isActive;
 67                 }

In Line 66, "actualPath.equals(actualPath)" will always return true. It should be like this?

66                         return this.actualPath.equals(actualPath) == isActive;

Thanks!

[fredg02]

Thanks for reporting this issue. I will take a look.