chore: re-enable noImplicitAny (#107)

Author: DominicKramer

package-lock.json

@@ -61,16 +61,29 @@
     "@google-cloud/nodejs-repo-tools": "^2.0.11",
     "@types/express": "^4.11.0",
     "@types/express-serve-static-core": "^4.11.1",
+    "@types/extend": "^3.0.0",
     "@types/glob": "^5.0.35",
     "@types/hapi": "^16.1.11",
     "@types/is": "0.0.19",
     "@types/koa": "^2.0.43",
+    "@types/lodash.assign": "^4.2.3",
+    "@types/lodash.foreach": "^4.5.3",
     "@types/lodash.has": "^4.5.3",
+    "@types/lodash.indexof": "^4.0.3",
+    "@types/lodash.maxby": "^4.6.3",
+    "@types/lodash.merge": "^4.6.3",
+    "@types/lodash.omit": "^4.5.3",
+    "@types/lodash.omitby": "^4.6.3",
+    "@types/lodash.pick": "^4.4.3",
+    "@types/lodash.random": "^3.2.3",
+    "@types/lodash.without": "^4.4.3",
     "@types/mocha": "^5.0.0",
     "@types/ncp": "^2.0.1",
+    "@types/nock": "^9.1.2",
     "@types/node": "^9.4.0",
     "@types/once": "^1.4.0",
     "@types/pify": "^3.0.1",
+    "@types/proxyquire": "^1.3.28",
     "@types/request": "^2.0.9",
     "@types/restify": "^5.0.6",
     "@types/rimraf": "^2.0.2",

package.json

@@ -123,8 +123,8 @@ export class ErrorMessage {
    *  error was reported
    * @returns {this} - returns the instance for chaining
    */
-  setServiceContext(service: string, version?: string) {
-    this.serviceContext.service = isString(service) ? service : 'node';
+  setServiceContext(service?: string, version?: string) {
+    this.serviceContext.service = (isString(service) ? service : 'node')!;
     this.serviceContext.version = isString(version) ? version : undefined;
 
     return this;
@@ -136,8 +136,8 @@ export class ErrorMessage {
    * @param {String} message - the error message
    * @returns {this} - returns the instance for chaining
    */
-  setMessage(message: string) {
-    this.message = isString(message) ? message : '';
+  setMessage(message?: string) {
+    this.message = (isString(message) ? message : '')!;
 
     return this;
   }
@@ -149,8 +149,8 @@ export class ErrorMessage {
    *  errors instantiation
    * @returns {this} - returns the instance for chaining
    */
-  setHttpMethod(method: string) {
-    this.context.httpRequest.method = isString(method) ? method : '';
+  setHttpMethod(method?: string) {
+    this.context.httpRequest.method = (isString(method) ? method : '')!;
 
     return this;
   }
@@ -161,8 +161,8 @@ export class ErrorMessage {
    * @param {String} url - the requests target url
    * @returns {this} - returns the instance for chaining
    */
-  setUrl(url: string) {
-    this.context.httpRequest.url = isString(url) ? url : '';
+  setUrl(url?: string) {
+    this.context.httpRequest.url = (isString(url) ? url : '')!;
 
     return this;
   }
@@ -173,8 +173,9 @@ export class ErrorMessage {
    * @param {String} userAgent - the requests user-agent
    * @returns {this} - returns the instance for chaining
    */
-  setUserAgent(userAgent: string) {
-    this.context.httpRequest.userAgent = isString(userAgent) ? userAgent : '';
+  setUserAgent(userAgent?: string) {
+    this.context.httpRequest.userAgent =
+        (isString(userAgent) ? userAgent : '')!;
 
     return this;
   }
@@ -185,8 +186,8 @@ export class ErrorMessage {
    * @param {String} referrer - the requests referrer
    * @returns {this} - returns the instance for chaining
    */
-  setReferrer(referrer: string) {
-    this.context.httpRequest.referrer = isString(referrer) ? referrer : '';
+  setReferrer(referrer?: string) {
+    this.context.httpRequest.referrer = (isString(referrer) ? referrer : '')!;
 
     return this;
   }
@@ -197,9 +198,9 @@ export class ErrorMessage {
    * @param {Number} responseStatusCode - the response status code
    * @returns {this} - returns the instance for chaining
    */
-  setResponseStatusCode(responseStatusCode: number) {
+  setResponseStatusCode(responseStatusCode?: number) {
     this.context.httpRequest.responseStatusCode =
-        isNumber(responseStatusCode) ? responseStatusCode : 0;
+        (isNumber(responseStatusCode) ? responseStatusCode : 0)!;
 
     return this;
   }
@@ -210,8 +211,8 @@ export class ErrorMessage {
    * @param {String} remoteIp - the requesters remote IP
    * @returns {this} - returns the instance for chaining
    */
-  setRemoteIp(remoteIp: string) {
-    this.context.httpRequest.remoteIp = isString(remoteIp) ? remoteIp : '';
+  setRemoteIp(remoteIp?: string) {
+    this.context.httpRequest.remoteIp = (isString(remoteIp) ? remoteIp : '')!;
 
     return this;
   }
@@ -222,8 +223,8 @@ export class ErrorMessage {
    * @param {String} user - the vm instances user
    * @returns {this} - returns the instance for chaining
    */
-  setUser(user: string) {
-    this.context.user = isString(user) ? user : '';
+  setUser(user?: string) {
+    this.context.user = (isString(user) ? user : '')!;
 
     return this;
   }
@@ -234,8 +235,9 @@ export class ErrorMessage {
    * @param {String} filePath - the vm instances filePath
    * @returns {this} - returns the instance for chaining
    */
-  setFilePath(filePath: string) {
-    this.context.reportLocation.filePath = isString(filePath) ? filePath : '';
+  setFilePath(filePath?: string) {
+    this.context.reportLocation.filePath =
+        (isString(filePath) ? filePath : '')!;
 
     return this;
   }
@@ -246,9 +248,9 @@ export class ErrorMessage {
    * @param {Number} lineNumber - the line number of the report context
    * @returns {this} - returns the instance for chaining
    */
-  setLineNumber(lineNumber: number) {
+  setLineNumber(lineNumber?: number) {
     this.context.reportLocation.lineNumber =
-        isNumber(lineNumber) ? lineNumber : 0;
+        (isNumber(lineNumber) ? lineNumber : 0)!;
 
     return this;
   }
@@ -259,9 +261,9 @@ export class ErrorMessage {
    * @param {String} functionName - the function name of the report context
    * @returns {this} - returns the instance for chaining
    */
-  setFunctionName(functionName: string) {
+  setFunctionName(functionName?: string) {
     this.context.reportLocation.functionName =
-        isString(functionName) ? functionName : '';
+        (isString(functionName) ? functionName : '')!;
 
     return this;
   }

src/classes/error-message.ts

@@ -99,9 +99,10 @@ export class ErrorReporting {
   private _logger: types.Logger;
   private _config: Configuration;
   private _client: AuthClient;
+  // the `err` argument can be anything, including `null` and `undefined`
   report:
-      (err: {}, request?: manualRequestExtractor.Request,
-       additionalMessage?: string|{},
+      (err: any,  // tslint:disable-line:no-any
+       request?: manualRequestExtractor.Request, additionalMessage?: string|{},
        callback?: manualInterface.Callback|{}|string) => ErrorMessage;
   event: () => ErrorMessage;
   hapi: {register: (server: {}, options: {}, next: Function) => void};

src/index.ts

@@ -64,9 +64,11 @@ export function handlerSetup(
    * @returns {ErrorMessage} - returns the error message created through with
    * the parameters given.
    */
+  // the `err` argument can be anything, including `null` and `undefined`
   function reportManualError(
-      err: {}, request?: Request|Callback|string,
-      additionalMessage?: Callback|string|{}, callback?: Callback|{}|string) {
+      err: any,  // tslint:disable-line:no-any
+      request?: Request|Callback|string, additionalMessage?: Callback|string|{},
+      callback?: Callback|{}|string) {
     let em;
     if (isString(request)) {
       // no request given

src/interfaces/manual.ts

@@ -17,10 +17,13 @@
 
 import has = require('lodash.has');
 import * as is from 'is';
+import * as types from './types';
+
 const isObject = is.object;
 const isString = is.string;
 const isNumber = is.number;
-import {logger} from '@google-cloud/common';
+const logger: types.logger = require('@google-cloud/common').logger;
+
 const packageJson = require('../../package.json');
 
 import {ConfigurationOptions} from './configuration';

src/logger.ts

@@ -40,7 +40,9 @@ export interface PopulatedObject {
  *  information into
  * @returns {Undefined} - does not return a value
  */
-export function populateErrorMessage(ob: {}, em: ErrorMessage) {
+// the `ob` argument can be anything, including `null` and `undefined`
+// tslint:disable-next-line:no-any
+export function populateErrorMessage(ob: any, em: ErrorMessage) {
   if (ob === null || ob === undefined) {
     em.setMessage(buildStackTrace('' + ob));
   } else if ((ob as {stack: {}}).stack) {

src/populate-error-message.ts

@@ -39,7 +39,7 @@ export interface LoggerOptions {
 
 export interface logger {
   (options?: LoggerOptions | string): Logger;
-  LEVELS: string[];
+  LEVELS: string[] & { [key: string]: string; };
 }
 
 export interface Options {