Skip to content

Commit 1ad8365

Browse files
build: only check --engine-strict for production deps (#520)
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/02b30105-142c-418e-95f6-025914ce48a3/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@5451633
1 parent 36b2e4a commit 1ad8365

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

.github/workflows/ci.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,11 @@ jobs:
1616
with:
1717
node-version: ${{ matrix.node }}
1818
- run: node --version
19-
- run: npm install --engine-strict
19+
# The first installation step ensures that all of our production
20+
# dependencies work on the given Node.js version, this helps us find
21+
# dependencies that don't match our engines field:
22+
- run: npm install --production --engine-strict
23+
- run: npm install
2024
- run: npm test
2125
- name: coverage
2226
uses: codecov/codecov-action@v1

synth.metadata

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@
44
"git": {
55
"name": ".",
66
"remote": "https://github.com/googleapis/nodejs-error-reporting.git",
7-
"sha": "062e004d79066ae57bc27a1519a43fad70efa1f3"
7+
"sha": "36b2e4aa4ed0135cdd19e740e6ed8ff4133ce99d"
88
}
99
},
1010
{
1111
"git": {
1212
"name": "synthtool",
1313
"remote": "https://github.com/googleapis/synthtool.git",
14-
"sha": "0c868d49b8e05bc1f299bc773df9eb4ef9ed96e9"
14+
"sha": "5451633881133e5573cc271a18e73b18caca8b1b"
1515
}
1616
}
1717
],

0 commit comments

Comments
 (0)